[SOLR-4051] DIH Delta updates do not work for all locales

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.0
• Component/s: contrib - DataImportHandler
• Assignee: James Dyer
• Reporter: James Dyer
• Created: 08/Nov/12 20:35
• Updated: 22/Mar/13 16:17
• Resolved: 13/Nov/12 18:58

Description

DIH Writes the last modified date to a Properties file using the default locale. This gets sent in plaintext to the database at the next delta update. DIH does not use prepared statements but just puts the date in an SQL Statement in yyyy-mm-dd hh:mm:ss format. It would probably be best to always format this date in JDBC escape syntax (http://docs.oracle.com/javase/1.4.2/docs/guide/jdbc/getstart/statement.html#999472) and java.sql.Timestamp#toString(). To do this, we'd need to parse the user's query and remove the single quotes likely there (and now the quotes would be optional and undesired).

It might just be simpler to change the SimpleDateFormat to use the root locale as this appears to be the original intent here anyhow. Affected locales include ja_JP_JP , hi_IN , th_TH

Issue Links

• incorporates: SOLR-1970 need to customize location of dataimport.properties
• incorporates: SOLR-2658 dataimport.properties : change datetime format
• relates to: SOLR-3365 Data import using local time to mark last_index_time
• relates to: SOLR-3856 DIH: Better tests for SqlEntityProcessor
• relates to: SOLR-1916 investigate DIH use of default locale