Solr
  1. Solr
  2. SOLR-3856

DIH: Better tests for SqlEntityProcessor

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.6, 4.0
    • Fix Version/s: 4.1, 6.0
    • Labels:
      None

      Description

      The current tests for SqlEntityProcessor (& CachedSqlEntityProcessor), while many, do not reliably fail when bugs are introduced! They are also difficult to look at and understand. As we move Jenkins onto new environments, we have found several of them fail regularly leading to "@Ignore".

      My aim here is to write all new tests for (Cached)SqlEntityProcessor, and to document (hopefully fix) any bugs this reveals.

      1. SOLR-3856_20121109_fixes.patch
        7 kB
        James Dyer
      2. SOLR-3856.patch
        109 kB
        James Dyer
      3. SOLR-3856.patch
        109 kB
        James Dyer
      4. SOLR-3856.patch
        33 kB
        James Dyer
      5. SOLR-3856-3.5.patch
        26 kB
        James Dyer

        Issue Links

          Activity

          Hide
          James Dyer added a comment -

          Here is a patch for trunk and also for Solr 3.5. (3.5 is the latest version prior to SOLR-2382 and other changes that may have caused undetected bugs, so its a good "control case")

          This first patch only replaces the "full-import" tests. I am working on "delta" tests now.

          Show
          James Dyer added a comment - Here is a patch for trunk and also for Solr 3.5. (3.5 is the latest version prior to SOLR-2382 and other changes that may have caused undetected bugs, so its a good "control case") This first patch only replaces the "full-import" tests. I am working on "delta" tests now.
          Hide
          James Dyer added a comment -

          This patch tests both full-import and delta-import with a fair amount of random variation between runs.

          These new tests are intended to be a replacement for all of the existing (Cached)SqlEntityProcessor tests, most of which were failing intermittently and subsequently had been disabled.

          I plan to commit this in a few days.

          Show
          James Dyer added a comment - This patch tests both full-import and delta-import with a fair amount of random variation between runs. These new tests are intended to be a replacement for all of the existing (Cached)SqlEntityProcessor tests, most of which were failing intermittently and subsequently had been disabled. I plan to commit this in a few days.
          Hide
          James Dyer added a comment -

          updated patch with slightly less-verbosity.

          Show
          James Dyer added a comment - updated patch with slightly less-verbosity.
          Hide
          James Dyer added a comment -

          committed.

          Trunk: r1406231 (CHANGES.txt: r1406245)
          4x: r1406246

          Show
          James Dyer added a comment - committed. Trunk: r1406231 (CHANGES.txt: r1406245) 4x: r1406246
          Hide
          James Dyer added a comment -

          re-open to deal with recent test failures.

          Show
          James Dyer added a comment - re-open to deal with recent test failures.
          Hide
          James Dyer added a comment -

          This adds better messages on failure to help figuring these out. Also added an assume when the locale breaks the test, until SOLR-4051/SOLR-1916 can be fixed

          Show
          James Dyer added a comment - This adds better messages on failure to help figuring these out. Also added an assume when the locale breaks the test, until SOLR-4051 / SOLR-1916 can be fixed
          Hide
          James Dyer added a comment -

          committed fixes.

          Trunk: r1407547
          branch_4x: r1407549

          Show
          James Dyer added a comment - committed fixes. Trunk: r1407547 branch_4x: r1407549
          Hide
          Commit Tag Bot added a comment -

          [branch_4x commit] James Dyer
          http://svn.apache.org/viewvc?view=revision&revision=1407549

          SOLR-3856: Improve tests for SqlEntityProcessor

          Show
          Commit Tag Bot added a comment - [branch_4x commit] James Dyer http://svn.apache.org/viewvc?view=revision&revision=1407549 SOLR-3856 : Improve tests for SqlEntityProcessor
          Hide
          Commit Tag Bot added a comment -

          [branch_4x commit] James Dyer
          http://svn.apache.org/viewvc?view=revision&revision=1407144

          SOLR-3856: @Ignore Delta test while investigating Linux failures

          Show
          Commit Tag Bot added a comment - [branch_4x commit] James Dyer http://svn.apache.org/viewvc?view=revision&revision=1407144 SOLR-3856 : @Ignore Delta test while investigating Linux failures
          Hide
          Commit Tag Bot added a comment -

          [branch_4x commit] James Dyer
          http://svn.apache.org/viewvc?view=revision&revision=1406706

          SOLR-3856: Better test failure output

          Show
          Commit Tag Bot added a comment - [branch_4x commit] James Dyer http://svn.apache.org/viewvc?view=revision&revision=1406706 SOLR-3856 : Better test failure output
          Hide
          Commit Tag Bot added a comment -

          [branch_4x commit] James Dyer
          http://svn.apache.org/viewvc?view=revision&revision=1406246

          SOLR-3856: Improve tests for SqlEntityProcessor

          Show
          Commit Tag Bot added a comment - [branch_4x commit] James Dyer http://svn.apache.org/viewvc?view=revision&revision=1406246 SOLR-3856 : Improve tests for SqlEntityProcessor

            People

            • Assignee:
              James Dyer
              Reporter:
              James Dyer
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development