Uploaded image for project: 'REEF (Retired)'
  1. REEF (Retired)
  2. REEF-332

Pass checkstyle

    XMLWordPrintableJSON

Details

    • Task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 0.12
    • All
    • None

    Description

      REEF-331 added checkstyle. Depending on how you look at it, either some of the checks don't match our codebase, or some of our codebase doesn't match the checks.

      The goal is to fix this situation before the next release. For each checkstyle, here's the proposed workflow: (1) create a sub-issue, and how to fix it (either fix the rule or the codebase) (2) discuss (3) create a PR

      Attachments

        Issue Links

          1.
          Fix instances of "first sentence period" checkstyle Sub-task Resolved Mariia Mykhailova
          2.
          Remove `More than 7 parameters` Checkstyle check for constructors Sub-task Resolved Mariia Mykhailova
          3.
          Fix violations / reconfigure checkstyle checks in "Whitespace" category Sub-task Resolved Mariia Mykhailova
          4.
          Fix violations / reconfigure check for UnusedImports check Sub-task Resolved Mariia Mykhailova
          5.
          Fix violations / reconfigure checkstyle checks in "Blocks" category Sub-task Closed Mariia Mykhailova
          6.
          Fix violations of EmptyStatement, SimplifyBooleanExpression and SimplifyBooleanReturn checks (Coding category) Sub-task Resolved Mariia Mykhailova
          7.
          Fix violations of MissingSwitchDefault checkstyle Sub-task Resolved Mariia Mykhailova
          8.
          Fix violations of EqualsHashCode checkstyle Sub-task Resolved Mariia Mykhailova
          9.
          Fix violations of RedundantModifier checkstyle Sub-task Resolved Mariia Mykhailova
          10.
          Fix violations of ModifierOrder checkstyle Sub-task Resolved Mariia Mykhailova
          11.
          Fix violations of FinalClass and HideUtilityClassConstructor checkstyles Sub-task Resolved Mariia Mykhailova
          12.
          Fix violations of ArrayTypeStyle checkstyle Sub-task Resolved Mariia Mykhailova
          13.
          Triage TODO comments in Java code Sub-task Resolved Mariia Mykhailova
          14.
          Convert checkstyle violations to build breaks Sub-task Resolved Mariia Mykhailova
          15.
          Fix violations of Indentation checkstyle Sub-task Resolved Mariia Mykhailova
          16.
          Fix violations of LineLength checkstyle Sub-task Resolved Mariia Mykhailova
          17.
          Fix violations of checks in "Naming" category for private variables/methods Sub-task Resolved Mariia Mykhailova
          18.
          Fix violations of JavadocStyle checkstyle Sub-task Resolved Mariia Mykhailova
          19.
          Fix violations of JavadocPackage checkstyle Sub-task Resolved Mariia Mykhailova
          20.
          Fix violations of HiddenField checkstyle Sub-task Resolved Mariia Mykhailova
          21.
          Enforce checkstyle checks in "Naming" category Sub-task Resolved Mariia Mykhailova
          22.
          Fix violations of VisibilityModifier checkstyle Sub-task Resolved Mariia Mykhailova
          23.
          Switch to Checkstyle 6.6 Sub-task Resolved Mariia Mykhailova
          24.
          Enable checkstyle for test source directories Sub-task Resolved Mariia Mykhailova

          Activity

            People

              MariiaMykhailova Mariia Mykhailova
              chobrian Brian Cho
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: