Uploaded image for project: 'REEF (Retired)'
  1. REEF (Retired)
  2. REEF-332 Pass checkstyle
  3. REEF-397

Fix violations of FinalClass and HideUtilityClassConstructor checkstyles

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 0.12
    • All
    • None

    Description

      • FinalClass (if a class only has private constructors, it should be declared as final so that the intention for it to not be overridden is clear) has 11 violations, plan to add final declaration
      • HideUtilityClassConstructor (if a class has only static methods/fields, it's utility and doesn't need to be instantiated) has 51 violations, plan to add private constructors / declare existing constructors private and see whether this breaks something in our code (i.e. whether we have instances of any utility classes).

      Attachments

        Activity

          People

            MariiaMykhailova Mariia Mykhailova
            MariiaMykhailova Mariia Mykhailova
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: