[REEF-441] Fix violations of VisibilityModifier checkstyle

• Type: Sub-task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.12
• Component/s: All
• Assignee: Mariia Mykhailova
• Reporter: Mariia Mykhailova
• Created: 01/Jul/15 23:53
• Updated: 31/Jul/15 17:44
• Resolved: 31/Jul/15 17:44

Description

http://checkstyle.sourceforge.net/config_design.html#VisibilityModifier
"Only static final, immutable or annotated by specified annotation members may be public; other class members must be private unless the property protectedAllowed or packageAllowed is set. "

We have around 100 violations of various nature:

• Some, like endIndicators and startIndicators in org/apache/reef/util/logging/LogParser.java, are static but not final and look like they should be final
• Some, like in org/apache/reef/common/AbstractFailure.java, already have getters but are protected or default visibility instead of private
• Some, like handler and message in org/apache/reef/runtime/common/utils/DispatchingEStage.java, have no getters and are public

Fixing public members requires two-stage change with deprecation.