Uploaded image for project: 'REEF (Retired)'
  1. REEF (Retired)
  2. REEF-332 Pass checkstyle
  3. REEF-371

Fix violations of EqualsHashCode checkstyle

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 0.12
    • 0.12
    • All
    • None

    Description

      http://checkstyle.sourceforge.net/config_coding.html#EqualsHashCode requires that classes that override equals() must also override hashCode(). We have 6 violations

      org/apache/reef/client/LauncherStatus.java
      org/apache/reef/io/network/group/impl/GroupCommunicationMessage.java
      org/apache/reef/io/network/group/impl/task/NodeStructImpl.java
      org/apache/reef/tang/implementation/types/AbstractNode.java
      org/apache/reef/tang/implementation/types/ConstructorArgImpl.java
      org/apache/reef/tang/implementation/types/ConstructorDefImpl.java

      I plan to add hashCode() to these classes.

      Attachments

        Activity

          People

            MariiaMykhailova Mariia Mykhailova
            MariiaMykhailova Mariia Mykhailova
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: