Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9184

Logging HDFS operation's caller context into audit logs

    Details

    • Type: New Feature
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Release Note:
      The feature needs to enabled by setting "hadoop.caller.context.enabled" to true. When the feature is used, additional fields are written into namenode audit log records.

      Description

      For a given HDFS operation (e.g. delete file), it's very helpful to track which upper level job issues it. The upper level callers may be specific Oozie tasks, MR jobs, and hive queries. One scenario is that the namenode (NN) is abused/spammed, the operator may want to know immediately which MR job should be blamed so that she can kill it. To this end, the caller context contains at least the application-dependent "tracking id".

      There are several existing techniques that may be related to this problem.
      1. Currently the HDFS audit log tracks the users of the the operation which is obviously not enough. It's common that the same user issues multiple jobs at the same time. Even for a single top level task, tracking back to a specific caller in a chain of operations of the whole workflow (e.g.Oozie -> Hive -> Yarn) is hard, if not impossible.
      2. HDFS integrated htrace support for providing tracing information across multiple layers. The span is created in many places interconnected like a tree structure which relies on offline analysis across RPC boundary. For this use case, htrace has to be enabled at 100% sampling rate which introduces significant overhead. Moreover, passing additional information (via annotations) other than span id from root of the tree to leaf is a significant additional work.
      3. In HDFS-4680 , there are some related discussion on this topic. The final patch implemented the tracking id as a part of delegation token. This protects the tracking information from being changed or impersonated. However, kerberos authenticated connections or insecure connections don't have tokens. HADOOP-8779 proposes to use tokens in all the scenarios, but that might mean changes to several upstream projects and is a major change in their security implementation.

      We propose another approach to address this problem. We also treat HDFS audit log as a good place for after-the-fact root cause analysis. We propose to put the caller id (e.g. Hive query id) in threadlocals. Specially, on client side the threadlocal object is passed to NN as a part of RPC header (optional), while on sever side NN retrieves it from header and put it to Handler's threadlocals. Finally in FSNamesystem, HDFS audit logger will record the caller context for each operation. In this way, the existing code is not affected.

      It is still challenging to keep "lying" client from abusing the caller context. Our proposal is to add a signature field to the caller context. The client choose to provide its signature along with the caller id. The operator may need to validate the signature at the time of offline analysis. The NN is not responsible for validating the signature online.

      1. HDFS-9184.000.patch
        21 kB
        Mingliang Liu
      2. HDFS-9184.001.patch
        24 kB
        Mingliang Liu
      3. HDFS-9184.002.patch
        23 kB
        Mingliang Liu
      4. HDFS-9184.003.patch
        23 kB
        Mingliang Liu
      5. HDFS-9184.004.patch
        23 kB
        Mingliang Liu
      6. HDFS-9184.005.patch
        25 kB
        Mingliang Liu
      7. HDFS-9184.006.patch
        24 kB
        Mingliang Liu
      8. HDFS-9184.007.patch
        26 kB
        Mingliang Liu
      9. HDFS-9184.008.patch
        29 kB
        Mingliang Liu
      10. HDFS-9184.009.patch
        29 kB
        Mingliang Liu

        Issue Links

          Activity

          Hide
          liuml07 Mingliang Liu added a comment -

          The v0 patch implements this idea as early effort.

          Show
          liuml07 Mingliang Liu added a comment - The v0 patch implements this idea as early effort.
          Hide
          cmccabe Colin P. McCabe added a comment -

          HTrace doesn't need to be enabled at 100% sampling to detect abuse or spamming of requests. If the spamming is significant enough to cause a problem, it will also show up in the sampled traces.

          Moreover, passing additional information (via annotations) other than span id from root of the tree to leaf is a significant additional work

          Annotations aren't passed from root to leaf. Annotations are properties of spans, and are sent to the span receiver.

          We propose another approach to address this problem. We also treat HDFS audit log as a good place for after-the-fact root cause analysis. We propose to put the caller id (e.g. Hive query id) in threadlocals. Specially, on client side the threadlocal object is passed to NN as a part of RPC header (optional), while on sever side NN retrieves it from header and put it to Handler's threadlocals. Finally in FSNamesystem, HDFS audit logger will record the caller context for each operation. In this way, the existing code is not affected.

          I think this kind of full-system analysis should be handled by HTrace, not by ad-hoc solutions like this. There are a lot of use-cases for Hive that don't involve HDFS at all, such as using Hive over HBase, or using Hive to access local filesystem resources. We cannot use the HDFS audit log for that, because HDFS is not involved (or is involved only as the backend for another storage system). And that's ignoring the significant compatibility, performance, and complexity problems of adding this to the NameNode.

          Show
          cmccabe Colin P. McCabe added a comment - HTrace doesn't need to be enabled at 100% sampling to detect abuse or spamming of requests. If the spamming is significant enough to cause a problem, it will also show up in the sampled traces. Moreover, passing additional information (via annotations) other than span id from root of the tree to leaf is a significant additional work Annotations aren't passed from root to leaf. Annotations are properties of spans, and are sent to the span receiver. We propose another approach to address this problem. We also treat HDFS audit log as a good place for after-the-fact root cause analysis. We propose to put the caller id (e.g. Hive query id) in threadlocals. Specially, on client side the threadlocal object is passed to NN as a part of RPC header (optional), while on sever side NN retrieves it from header and put it to Handler's threadlocals. Finally in FSNamesystem, HDFS audit logger will record the caller context for each operation. In this way, the existing code is not affected. I think this kind of full-system analysis should be handled by HTrace, not by ad-hoc solutions like this. There are a lot of use-cases for Hive that don't involve HDFS at all, such as using Hive over HBase, or using Hive to access local filesystem resources. We cannot use the HDFS audit log for that, because HDFS is not involved (or is involved only as the backend for another storage system). And that's ignoring the significant compatibility, performance, and complexity problems of adding this to the NameNode.
          Hide
          aw Allen Wittenauer added a comment -

          significant compatibility ... problems

          I'm pretty much a big -1 (esp in branch-2) just because of that. This will break users in a major ways, so the earliest any thing like this could happen is in trunk.

          Show
          aw Allen Wittenauer added a comment - significant compatibility ... problems I'm pretty much a big -1 (esp in branch-2) just because of that. This will break users in a major ways, so the earliest any thing like this could happen is in trunk.
          Hide
          jnp Jitendra Nath Pandey added a comment -

          I think the purpose is not only to detect abusive clients, but also the ability to audit where the requests are coming from. Users often wonder, what is running in the cluster, and how hdfs is being used. This feature will allow us to analyze how upstream components are using hdfs and their load distribution. Sampling will not work for this kind of analysis.
          Htrace is more of a profiling tool and is useful to analyze for performance of various spans which are a pretty low level. But, it is an overkill and doesn't really fit for audit purpose that needs to capture high level contexts all the time.

          Show
          jnp Jitendra Nath Pandey added a comment - I think the purpose is not only to detect abusive clients, but also the ability to audit where the requests are coming from. Users often wonder, what is running in the cluster, and how hdfs is being used. This feature will allow us to analyze how upstream components are using hdfs and their load distribution. Sampling will not work for this kind of analysis. Htrace is more of a profiling tool and is useful to analyze for performance of various spans which are a pretty low level. But, it is an overkill and doesn't really fit for audit purpose that needs to capture high level contexts all the time.
          Hide
          aw Allen Wittenauer added a comment -

          Let me clarify a bit:

          The HDFS audit log is probably the single most widely machine parsed log in the entirety of the Hadoop. It was specifically made a fixed field log to make it easy even for beginner admins to use, in a format that doesn't require a lot of heavy machinery to actually make useful. As a result, changing the format of this file has an extreme impact on pretty much every Hadoop operations team in existence. So while the functionality may be useful, there is no way in good conscious should we be modifying the current layout in branch-2.

          So I still stand at:

          -1 for branch-2
          0 for trunk

          Show
          aw Allen Wittenauer added a comment - Let me clarify a bit: The HDFS audit log is probably the single most widely machine parsed log in the entirety of the Hadoop. It was specifically made a fixed field log to make it easy even for beginner admins to use, in a format that doesn't require a lot of heavy machinery to actually make useful. As a result, changing the format of this file has an extreme impact on pretty much every Hadoop operations team in existence. So while the functionality may be useful, there is no way in good conscious should we be modifying the current layout in branch-2. So I still stand at: -1 for branch-2 0 for trunk
          Hide
          daryn Daryn Sharp added a comment -

          Adding another kvp to the audit log is not an incompatible change, and isn't IMHO grounds for a -1. I'm pretty sure the previous proto=(rpc|webhdfs) key was added mid-2.x with no fanfare.

          The goal of this jira is sorely needed. The crux is how can we do it with minimal performance impact and no incompatibility. My concern is the overhead with a per-call context. I'd rather see it in the connection context. I thought we could leverage the dfsclient id, but alas it's not part of the connection context like I thought. But, adding an optional & arbitrary string to the connection context might work. I can envision a conceptually simple api to append a delimited value.

          Show
          daryn Daryn Sharp added a comment - Adding another kvp to the audit log is not an incompatible change, and isn't IMHO grounds for a -1. I'm pretty sure the previous proto=(rpc|webhdfs) key was added mid-2.x with no fanfare. The goal of this jira is sorely needed. The crux is how can we do it with minimal performance impact and no incompatibility. My concern is the overhead with a per-call context. I'd rather see it in the connection context. I thought we could leverage the dfsclient id, but alas it's not part of the connection context like I thought. But, adding an optional & arbitrary string to the connection context might work. I can envision a conceptually simple api to append a delimited value.
          Hide
          aw Allen Wittenauer added a comment -

          I'm pretty sure the previous proto=(rpc|webhdfs) key was added mid-2.x with no fanfare.

          Believe me, it broke stuff. I would have -1'd that one too.

          Show
          aw Allen Wittenauer added a comment - I'm pretty sure the previous proto=(rpc|webhdfs) key was added mid-2.x with no fanfare. Believe me, it broke stuff. I would have -1'd that one too.
          Hide
          daryn Daryn Sharp added a comment -

          It's a simple and extensible kvp file. If something doesn't parse it as such, it's the parser's fault, not an incompatibility that should hinder progress.

          Food for thought: by this incompatibility logic, we can't add any new fields to protobufs

          Show
          daryn Daryn Sharp added a comment - It's a simple and extensible kvp file. If something doesn't parse it as such, it's the parser's fault, not an incompatibility that should hinder progress. Food for thought: by this incompatibility logic, we can't add any new fields to protobufs
          Hide
          jnp Jitendra Nath Pandey added a comment -

          Audit log format is designed to be a key value format so that it can be extensible. Addition of a new key optional value pair is not an incompatible change.
          However, we can also consider making this feature configurable which is off by default, so that there is no change at all.

          Show
          jnp Jitendra Nath Pandey added a comment - Audit log format is designed to be a key value format so that it can be extensible. Addition of a new key optional value pair is not an incompatible change. However, we can also consider making this feature configurable which is off by default, so that there is no change at all.
          Hide
          jnp Jitendra Nath Pandey added a comment -

          bq ...connection context
          Many applications heavily rely on filesystem cache and connection cache for performance. A string in connection context would need to be updated for different calls. It may not work in multi-threaded applications.

          I think if we restrict the length of this additional string these costs can be kept to minimal. For example, a default length of 128 bytes will be a small increment to current audit log record sizes.

          Show
          jnp Jitendra Nath Pandey added a comment - bq ...connection context Many applications heavily rely on filesystem cache and connection cache for performance. A string in connection context would need to be updated for different calls. It may not work in multi-threaded applications. I think if we restrict the length of this additional string these costs can be kept to minimal. For example, a default length of 128 bytes will be a small increment to current audit log record sizes.
          Hide
          cmccabe Colin P. McCabe added a comment -

          Is it documented anywhere that the audit log is key/value? I didn't see any specification for the format... did I miss some docs somewhere? I don't think this is similar to protobuf because there is a clearly defined and documented way to extend PB.

          Many modern Hadoop systems access HDFS through a proxy. For example, some people use Tachyon to get read and write caching. RecordService provides row-level security and deserialization services. Hive itself usually does its work on behalf of some other process like Tableau, or Spark. How will this solution work in those cases?

          For me, a lot of this discussion gets back to the reasons why htrace is a separate system rather than just part of HDFS or HBase. You need something that can span multiple projects and create a coherent narrative about what's going on. I agree that HTrace should not be run at 100% sampling, but I am not convinced by the arguments that we need 100% sampling.

          If this is to diagnose performance issues, then 1% or so sampling should be fine. If this is about security issues, then it seems flawed, since it doesn't actually stop anyone from accessing anything. Can you be a little clearer about the specific use-cases for this?

          Show
          cmccabe Colin P. McCabe added a comment - Is it documented anywhere that the audit log is key/value? I didn't see any specification for the format... did I miss some docs somewhere? I don't think this is similar to protobuf because there is a clearly defined and documented way to extend PB. Many modern Hadoop systems access HDFS through a proxy. For example, some people use Tachyon to get read and write caching. RecordService provides row-level security and deserialization services. Hive itself usually does its work on behalf of some other process like Tableau, or Spark. How will this solution work in those cases? For me, a lot of this discussion gets back to the reasons why htrace is a separate system rather than just part of HDFS or HBase. You need something that can span multiple projects and create a coherent narrative about what's going on. I agree that HTrace should not be run at 100% sampling, but I am not convinced by the arguments that we need 100% sampling. If this is to diagnose performance issues, then 1% or so sampling should be fine. If this is about security issues, then it seems flawed, since it doesn't actually stop anyone from accessing anything. Can you be a little clearer about the specific use-cases for this?
          Hide
          aw Allen Wittenauer added a comment -

          Is it documented anywhere that the audit log is key/value? I didn't see any specification for the format...

          It's a) not documented and b) not a kvp.

          Story time. This is going to be the shorter version.

          I have few regrets about things I helped design in Hadoop, but this does happen to be one of them especially due to all of the misunderstanding around what it's purpose in life is and how people actually use it. When Chris Douglas and I did the design work on the audit log back in 2008 (IIRC), I specifically wanted a fixed field log file format. We were going to be writing ops tools to answer questions that we the ops team simply could not. It was important that the format stay fixed for a variety of reasons:

          • The ops team at Y! was tiny with a mix of junior and senior folks. The junior folks were likely going to be the ones writing the code since the senior folks were busy dealing with the continual fallout from the weekly Hadoop upgrades and just getting a working infrastructure in place while we moved away from YST. (... and getting ops-specific tooling out of dev was regularly blocked by management ...)
          • We needed to make sure that no matter what the devs added to Hadoop, the log file wouldn't change. At that point in time, the logs for things like the NN were wildly fluctuating and were pretty much impossible to use for any sort of metrics or monitoring. We needed a safespace that was away from the turmoil happening in the rest of the system. If the system would have been open ended, it would have been absolute hell to work with. Forcing a format that at that point covered 100% of the foreseeable use cases solved that problem.
          • The content was modeled after Solaris BSM with a few key differences. BSM wrote in binary which just wasn't a real option without us pulling out more advanced techniques. It would fail the 'quick and dirty' tests that the ops team had to have in order to fulfill user needs. BSM also supported a heck of a lot more than Hadoop did. So a straight logfile it was.

          Now one of the things I wanted to avoid was the "tab problem". e.g., fields that are empty end up looking like field<tab><tab>field. So we settled on a <column label>=<value> format where every label would always be present so that we could then use spaces to break up the columns. [Thus why I say it is *not* kvp. In most key-value stores that I've worked with, it's rare to see key=(null)].

          I've also heard that the file is a "weird form of JSON". No, it's not. In fact, I vetoed JSON because of the extra parsing overhead with very little gain to be seen by doing that vs. just fixing all the fields.

          Now, what would I do differently? #1 would be documentation with a clear explanation of this history, covering the whys and the hows. #2 would probably be to make it officially key value with some fields being required. But that's a different problem altogether....

          Show
          aw Allen Wittenauer added a comment - Is it documented anywhere that the audit log is key/value? I didn't see any specification for the format... It's a) not documented and b) not a kvp. Story time. This is going to be the shorter version. I have few regrets about things I helped design in Hadoop, but this does happen to be one of them especially due to all of the misunderstanding around what it's purpose in life is and how people actually use it. When Chris Douglas and I did the design work on the audit log back in 2008 (IIRC), I specifically wanted a fixed field log file format. We were going to be writing ops tools to answer questions that we the ops team simply could not. It was important that the format stay fixed for a variety of reasons: The ops team at Y! was tiny with a mix of junior and senior folks. The junior folks were likely going to be the ones writing the code since the senior folks were busy dealing with the continual fallout from the weekly Hadoop upgrades and just getting a working infrastructure in place while we moved away from YST. (... and getting ops-specific tooling out of dev was regularly blocked by management ...) We needed to make sure that no matter what the devs added to Hadoop, the log file wouldn't change. At that point in time, the logs for things like the NN were wildly fluctuating and were pretty much impossible to use for any sort of metrics or monitoring. We needed a safespace that was away from the turmoil happening in the rest of the system. If the system would have been open ended, it would have been absolute hell to work with. Forcing a format that at that point covered 100% of the foreseeable use cases solved that problem. The content was modeled after Solaris BSM with a few key differences. BSM wrote in binary which just wasn't a real option without us pulling out more advanced techniques. It would fail the 'quick and dirty' tests that the ops team had to have in order to fulfill user needs. BSM also supported a heck of a lot more than Hadoop did. So a straight logfile it was. Now one of the things I wanted to avoid was the "tab problem". e.g., fields that are empty end up looking like field<tab><tab>field. So we settled on a <column label>=<value> format where every label would always be present so that we could then use spaces to break up the columns. [Thus why I say it is *not* kvp. In most key-value stores that I've worked with, it's rare to see key=(null)] . I've also heard that the file is a "weird form of JSON". No, it's not. In fact, I vetoed JSON because of the extra parsing overhead with very little gain to be seen by doing that vs. just fixing all the fields. Now, what would I do differently? #1 would be documentation with a clear explanation of this history, covering the whys and the hows. #2 would probably be to make it officially key value with some fields being required. But that's a different problem altogether....
          Hide
          daryn Daryn Sharp added a comment -

          (I'll rest my case, sans history, with the format is "label=val <tab> label=val ...". A rather self-documenting format. If a parser can't handle another label, esp. one tacked on to the end, that's just bad programming)

          Anyway, the most basic use-case is: Production user X is pounding the NN. I wonder what job it is? Let me look at oozie, arg, 20 jobs. Hey, user X, stop abusing the NN, kill your bad job. You don't know which job? Can you tell from these paths? You can't? Fine, I'll login to one of the hosts in the audit log and look for the tasks. Arg, 5 different jobs running tasks as user X on this node. I guess I'll try to intersect the jobs across multiple nodes... Boy, I wish the audit log could tell me which job it is...

          I'd love to see a keep-it-simple approach for this most basic issue we've all faced.

          Show
          daryn Daryn Sharp added a comment - (I'll rest my case, sans history, with the format is "label=val <tab> label=val ...". A rather self-documenting format. If a parser can't handle another label, esp. one tacked on to the end, that's just bad programming) Anyway, the most basic use-case is: Production user X is pounding the NN. I wonder what job it is? Let me look at oozie, arg, 20 jobs. Hey, user X, stop abusing the NN, kill your bad job. You don't know which job? Can you tell from these paths? You can't? Fine, I'll login to one of the hosts in the audit log and look for the tasks. Arg, 5 different jobs running tasks as user X on this node. I guess I'll try to intersect the jobs across multiple nodes... Boy, I wish the audit log could tell me which job it is... I'd love to see a keep-it-simple approach for this most basic issue we've all faced.
          Hide
          aw Allen Wittenauer added a comment -

          If a parser can't handle another label, esp. one tacked on to the end, that's just bad programming

          You've missed several key points in that story.

          Show
          aw Allen Wittenauer added a comment - If a parser can't handle another label, esp. one tacked on to the end, that's just bad programming You've missed several key points in that story.
          Hide
          cmccabe Colin P. McCabe added a comment -

          Allen Wittenauer: I feel like this is a good example of why the audit log format should have been JSON. We wouldn't be having this discussion if the format had been one JSON record per line, since it would be obvious how to parse it. It's also relatively easy to find libraries for JSON in every language you might want to use (although perhaps it wasn't so easy back when the audit log was first added to HDFS?) I'm not sure I understand the desire for COBOL-style fixed fields (party like it's 1975?). But I do agree that compatibility is a concern here since there is basically no spec that we can point to when people are writing their parsers. They could easily just be doing scanf("%s %s %s", foo, bar, baz) and then we would break them.

          Daryn Sharp: thanks for giving an example of how this would be used. I agree this has been a pain point for a while. This is possibly a dumb question, but couldn't clientId be used for this purpose?

          This solution also presupposes some kind of daemon or service to gather context IDs in Hive. This service hasn't been written yet, but if it were, it seems like it might start looking a lot like HTrace. Like I said earlier, I also feel like this solution wouldn't work in the case where HBase was in use, or RecordService, or Tachyon. We are definitely planning some YARN and MR integration for HTrace. I would really like to get more people excited about this project and work out what we'd need to do to get it to cover all these use-cases.

          Show
          cmccabe Colin P. McCabe added a comment - Allen Wittenauer : I feel like this is a good example of why the audit log format should have been JSON. We wouldn't be having this discussion if the format had been one JSON record per line, since it would be obvious how to parse it. It's also relatively easy to find libraries for JSON in every language you might want to use (although perhaps it wasn't so easy back when the audit log was first added to HDFS?) I'm not sure I understand the desire for COBOL-style fixed fields (party like it's 1975?). But I do agree that compatibility is a concern here since there is basically no spec that we can point to when people are writing their parsers. They could easily just be doing scanf("%s %s %s", foo, bar, baz) and then we would break them. Daryn Sharp : thanks for giving an example of how this would be used. I agree this has been a pain point for a while. This is possibly a dumb question, but couldn't clientId be used for this purpose? This solution also presupposes some kind of daemon or service to gather context IDs in Hive. This service hasn't been written yet, but if it were, it seems like it might start looking a lot like HTrace. Like I said earlier, I also feel like this solution wouldn't work in the case where HBase was in use, or RecordService, or Tachyon. We are definitely planning some YARN and MR integration for HTrace. I would really like to get more people excited about this project and work out what we'd need to do to get it to cover all these use-cases.
          Hide
          daryn Daryn Sharp added a comment -

          This is possibly a dumb question, but couldn't clientId be used for this purpose?

          Colin P. McCabe, if you are thinking the dfs clientid like I did, it's only passed in file writing operations. It won't help in storms of opens, listStatus, getFileInfo, etc. If you are referring to the IPC client id then I'm not sure how we provide any traceability?

          Show
          daryn Daryn Sharp added a comment - This is possibly a dumb question, but couldn't clientId be used for this purpose? Colin P. McCabe , if you are thinking the dfs clientid like I did, it's only passed in file writing operations. It won't help in storms of opens, listStatus, getFileInfo, etc. If you are referring to the IPC client id then I'm not sure how we provide any traceability?
          Hide
          liuml07 Mingliang Liu added a comment -

          Thanks all for the input.

          Before we have a perfect solution, we consider this approach a feasible option for the heavily needed goal. In terms of security, it seems flawed. There is a signature field when building the caller context which may be useful for the offline analysis and validation.

          The v1 patch aims to address the incompatible concern. We don't think there is "significant compatibility" issue here. Specially,

          • We won't record the caller context unless its config key is explicitly turned on by users
          • NO existing API is changed to implement this feature
          • The current layout of the audit log is not changed as there will be an optional kvp in the end of the line.
            Just for the record: it's good to make audit log itself have well-defined structure and format in the future.

          As using htrace, which depends on 100% sampling across many spans, is totally different from this approach, this patch does not adopt it. If performance problem is really a concern, I don't expect htrace can do better.

          Show
          liuml07 Mingliang Liu added a comment - Thanks all for the input. Before we have a perfect solution, we consider this approach a feasible option for the heavily needed goal. In terms of security, it seems flawed. There is a signature field when building the caller context which may be useful for the offline analysis and validation. The v1 patch aims to address the incompatible concern. We don't think there is "significant compatibility" issue here. Specially, We won't record the caller context unless its config key is explicitly turned on by users NO existing API is changed to implement this feature The current layout of the audit log is not changed as there will be an optional kvp in the end of the line. Just for the record: it's good to make audit log itself have well-defined structure and format in the future. As using htrace , which depends on 100% sampling across many spans, is totally different from this approach, this patch does not adopt it. If performance problem is really a concern, I don't expect htrace can do better.
          Hide
          jnp Jitendra Nath Pandey added a comment -

          Mingliang Liu, I would suggest to make the length of the context and signature configurable, defaults are ok.

          Show
          jnp Jitendra Nath Pandey added a comment - Mingliang Liu , I would suggest to make the length of the context and signature configurable, defaults are ok.
          Hide
          liuml07 Mingliang Liu added a comment -

          To address some offline comments, the v2 patch makes the caller context's length limit configurable. The default size is 128 bytes. Any comment is welcome.

          Show
          liuml07 Mingliang Liu added a comment - To address some offline comments, the v2 patch makes the caller context's length limit configurable. The default size is 128 bytes. Any comment is welcome.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 26m 16s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 12m 17s There were no new javac warning messages.
          +1 javadoc 12m 56s There were no new javadoc warning messages.
          -1 release audit 0m 23s The applied patch generated 1 release audit warnings.
          -1 checkstyle 2m 39s The applied patch generated 9 new checkstyle issues (total was 229, now 237).
          +1 whitespace 0m 1s The patch has no lines that end in whitespace.
          +1 install 2m 3s mvn install still works.
          +1 eclipse:eclipse 0m 45s The patch built with eclipse:eclipse.
          -1 findbugs 6m 33s The patch appears to introduce 2 new Findbugs (version 3.0.0) warnings.
          -1 common tests 10m 28s Tests failed in hadoop-common.
          -1 hdfs tests 149m 16s Tests failed in hadoop-hdfs.
              224m 4s  



          Reason Tests
          FindBugs module:hadoop-hdfs
          Failed unit tests hadoop.fs.shell.find.TestName
            hadoop.fs.shell.find.TestIname
            hadoop.fs.TestLocalFsFCStatistics
            hadoop.fs.shell.find.TestFind
            hadoop.ipc.TestIPC
            hadoop.ha.TestZKFailoverController
            hadoop.security.ssl.TestReloadingX509TrustManager
            hadoop.test.TestTimedOutTestsListener
            hadoop.fs.shell.find.TestPrint
            hadoop.hdfs.TestWriteRead
            hadoop.hdfs.server.namenode.snapshot.TestCheckpointsWithSnapshots
            hadoop.hdfs.server.namenode.ha.TestDNFencing
            hadoop.hdfs.server.namenode.ha.TestStandbyIsHot
            hadoop.hdfs.TestRollingUpgrade
            hadoop.hdfs.TestHFlush
            hadoop.hdfs.TestParallelRead
            hadoop.hdfs.TestBlockReaderLocalLegacy
            hadoop.hdfs.server.namenode.TestAuditLogger
            hadoop.hdfs.server.namenode.TestXAttrConfigFlag
            hadoop.hdfs.TestPread
            hadoop.hdfs.TestDFSStripedOutputStream
            hadoop.hdfs.TestWriteConfigurationToDFS
            hadoop.hdfs.TestDFSRollback
            hadoop.hdfs.TestDataTransferKeepalive
            hadoop.hdfs.TestDFSFinalize
            hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication
            hadoop.hdfs.server.namenode.metrics.TestNNMetricFilesInGetListingOps
            hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots
            hadoop.hdfs.server.namenode.ha.TestHASafeMode
            hadoop.hdfs.TestDFSShell
            hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA
            hadoop.hdfs.TestSeekBug
            hadoop.hdfs.TestCrcCorruption
            hadoop.hdfs.server.namenode.TestStorageRestore
            hadoop.hdfs.TestAbandonBlock
            hadoop.hdfs.TestGetFileChecksum
            hadoop.hdfs.server.namenode.TestBlockUnderConstruction
            hadoop.hdfs.TestSafeModeWithStripedFile
            hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForContentSummary
            hadoop.hdfs.TestFileCreationDelete
            hadoop.hdfs.TestReadWhileWriting
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010
            hadoop.hdfs.security.TestDelegationToken
            hadoop.hdfs.server.namenode.ha.TestHAAppend
            hadoop.hdfs.TestMissingBlocksAlert
            hadoop.hdfs.TestBlocksScheduledCounter
            hadoop.hdfs.TestSmallBlock
            hadoop.hdfs.TestDFSClientRetries
            hadoop.hdfs.TestDFSMkdirs
            hadoop.hdfs.server.namenode.TestFavoredNodesEndToEnd
            hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits
            hadoop.hdfs.server.namenode.TestNameNodeMXBean
            hadoop.hdfs.server.namenode.TestLargeDirectoryDelete
            hadoop.hdfs.server.namenode.TestDeleteRace
            hadoop.hdfs.TestFSInputChecker
            hadoop.hdfs.server.namenode.ha.TestXAttrsWithHA
            hadoop.hdfs.server.namenode.ha.TestHAMetrics
            hadoop.hdfs.TestRollingUpgradeRollback
            hadoop.hdfs.TestRemoteBlockReader
            hadoop.hdfs.TestBlockStoragePolicy
            hadoop.hdfs.TestLeaseRecovery
            hadoop.hdfs.server.namenode.TestBackupNode
            hadoop.hdfs.TestBlockReaderLocal
            hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForXAttr
            hadoop.hdfs.tools.TestDebugAdmin
            hadoop.hdfs.TestReadStripedFileWithDecoding
            hadoop.hdfs.TestLargeBlock
            hadoop.hdfs.server.namenode.TestFSNamesystemMBean
            hadoop.hdfs.tools.TestDFSZKFailoverController
            hadoop.hdfs.TestDistributedFileSystem
            hadoop.hdfs.TestListFilesInFileContext
            hadoop.hdfs.server.namenode.TestNameNodeRecovery
            hadoop.hdfs.TestFileAppend2
            hadoop.hdfs.TestFsShellPermission
            hadoop.hdfs.server.namenode.ha.TestHAFsck
            hadoop.hdfs.TestRollingUpgradeDowngrade
            hadoop.hdfs.TestFileLengthOnClusterRestart
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.TestWriteReadStripedFile
            hadoop.hdfs.TestParallelUnixDomainRead
            hadoop.hdfs.server.namenode.TestQuotaWithStripedBlocks
            hadoop.hdfs.TestGetBlocks
            hadoop.hdfs.security.token.block.TestBlockToken
            hadoop.hdfs.web.TestWebHdfsTokens
            hadoop.hdfs.TestErasureCodingPolicies
            hadoop.hdfs.TestEncryptionZonesWithKMS
            hadoop.hdfs.TestClientReportBadBlock
            hadoop.hdfs.TestDFSStorageStateRecovery
            hadoop.hdfs.TestRestartDFS
            hadoop.hdfs.TestFileAppend4
            hadoop.hdfs.server.namenode.ha.TestFailoverWithBlockTokensEnabled
            hadoop.hdfs.TestSetTimes
            hadoop.hdfs.server.namenode.TestAclConfigFlag
            hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
            hadoop.hdfs.server.namenode.TestNameNodeAcl
            hadoop.hdfs.TestSetrepIncreasing
            hadoop.hdfs.TestLease
            hadoop.hdfs.TestSafeMode
            hadoop.hdfs.server.namenode.TestEditLogAutoroll
            hadoop.hdfs.TestDFSUpgrade
            hadoop.hdfs.TestDecommission
            hadoop.hdfs.TestFileStatusWithECPolicy
            hadoop.hdfs.protocol.datatransfer.sasl.TestSaslDataTransfer
            hadoop.hdfs.server.namenode.ha.TestQuotasWithHA
            hadoop.hdfs.TestFileCorruption
            hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs
            hadoop.hdfs.TestQuota
            hadoop.hdfs.server.namenode.ha.TestHarFileSystemWithHA
            hadoop.hdfs.TestFileStatus
            hadoop.hdfs.TestEncryptionZonesWithHA
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure000
            hadoop.hdfs.server.namenode.TestProcessCorruptBlocks
            hadoop.hdfs.TestClose
            hadoop.hdfs.TestMultiThreadedHflush
            hadoop.hdfs.TestDFSClientExcludedNodes
            hadoop.hdfs.server.namenode.TestAddOverReplicatedStripedBlocks
            hadoop.hdfs.TestFileConcurrentReader
            hadoop.hdfs.server.namenode.snapshot.TestUpdatePipelineWithSnapshots
            hadoop.hdfs.TestDataTransferProtocol
            hadoop.hdfs.TestBlockReaderFactory
            hadoop.hdfs.server.namenode.TestParallelImageWrite
            hadoop.hdfs.server.namenode.TestCheckpoint
            hadoop.hdfs.server.namenode.web.resources.TestWebHdfsDataLocality
            hadoop.hdfs.TestDatanodeDeath
            hadoop.hdfs.TestPipelines
            hadoop.hdfs.web.TestWebHDFSAcl
            hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerWithStripedBlocks
            hadoop.hdfs.server.namenode.TestFSImage
            hadoop.hdfs.web.TestWebHdfsWithMultipleNameNodes
            hadoop.hdfs.server.namenode.ha.TestBootstrapStandbyWithQJM
            hadoop.hdfs.server.namenode.TestFsckWithMultipleNameNodes
            hadoop.hdfs.server.namenode.ha.TestFailureOfSharedDir
            hadoop.hdfs.TestRenameWhileOpen
            hadoop.hdfs.server.namenode.TestNameNodeXAttr
            hadoop.hdfs.server.namenode.TestEditLogJournalFailures
            hadoop.hdfs.server.namenode.ha.TestPendingCorruptDnMessages
            hadoop.hdfs.TestWriteBlockGetsBlockLengthHint
            hadoop.hdfs.server.namenode.TestFSEditLogLoader
            hadoop.hdfs.tools.TestStoragePolicyCommands
            hadoop.hdfs.server.namenode.TestNamenodeRetryCache
            hadoop.hdfs.server.namenode.TestDecommissioningStatus
            hadoop.hdfs.TestDFSStartupVersions
            hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForAcl
            hadoop.hdfs.server.namenode.ha.TestHAStateTransitions
            hadoop.hdfs.TestAppendSnapshotTruncate
            hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate
            hadoop.hdfs.TestParallelShortCircuitReadUnCached
            hadoop.hdfs.TestDFSClientFailover
            hadoop.hdfs.TestFSOutputSummer
            hadoop.hdfs.server.namenode.TestHDFSConcat
            hadoop.hdfs.server.namenode.ha.TestInitializeSharedEdits
            hadoop.hdfs.server.namenode.TestFSImageWithAcl
            hadoop.hdfs.server.namenode.snapshot.TestINodeFileUnderConstructionWithSnapshot
            hadoop.hdfs.web.TestFSMainOperationsWebHdfs
            hadoop.hdfs.TestDFSInotifyEventInputStream
            hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
            hadoop.hdfs.server.namenode.ha.TestStandbyBlockManagement
            hadoop.hdfs.server.namenode.TestSaveNamespace
            hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics
            hadoop.hdfs.TestDFSPermission
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotStatsMXBean
            hadoop.hdfs.TestListFilesInDFS
            hadoop.hdfs.TestModTime
            hadoop.hdfs.TestReservedRawPaths
            hadoop.hdfs.TestHDFSFileSystemContract
            hadoop.hdfs.server.namenode.TestHostsFiles
            hadoop.hdfs.TestFileCreation
            hadoop.hdfs.server.namenode.TestINodeAttributeProvider
            hadoop.hdfs.TestParallelShortCircuitRead
            hadoop.hdfs.server.namenode.TestFSImageWithXAttr
            hadoop.hdfs.TestParallelShortCircuitLegacyRead
            hadoop.hdfs.server.namenode.TestFileJournalManager
            hadoop.hdfs.TestFileCreationEmpty
            hadoop.hdfs.TestRead
            hadoop.hdfs.server.namenode.TestAuditLogAtDebug
            hadoop.hdfs.TestFileAppend
            hadoop.hdfs.web.TestWebHdfsFileSystemContract
            hadoop.hdfs.server.namenode.TestSecureNameNode
            hadoop.hdfs.web.TestWebHDFS
            hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer
            hadoop.hdfs.TestReplaceDatanodeOnFailure
            hadoop.hdfs.server.namenode.TestAddBlock
            hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
            hadoop.hdfs.TestFetchImage
            hadoop.hdfs.TestInjectionForSimulatedStorage
            hadoop.hdfs.TestFileCreationClient
            hadoop.hdfs.server.namenode.TestAddStripedBlocks
            hadoop.hdfs.server.namenode.TestNameEditsConfigs
            hadoop.hdfs.server.namenode.TestCacheDirectives
            hadoop.hdfs.TestClientProtocolForPipelineRecovery
            hadoop.hdfs.TestDFSRemove
            hadoop.hdfs.TestFileAppendRestart
            hadoop.hdfs.TestDFSOutputStream
            hadoop.hdfs.TestDisableConnCache
            hadoop.hdfs.TestParallelShortCircuitReadNoChecksum
            hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
            hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer
            hadoop.hdfs.server.namenode.snapshot.TestFileContextSnapshot
            hadoop.hdfs.server.namenode.TestStartup
            hadoop.hdfs.server.namenode.snapshot.TestSetQuotaWithSnapshot
            hadoop.hdfs.TestBlockMissingException
            hadoop.hdfs.server.namenode.TestProtectedDirectories
          Timed out tests org.apache.hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
            org.apache.hadoop.hdfs.web.TestWebHDFSForHA



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12765950/HDFS-9184.002.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / def374e
          Release Audit https://builds.apache.org/job/PreCommit-HDFS-Build/12910/artifact/patchprocess/patchReleaseAuditProblems.txt
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12910/artifact/patchprocess/diffcheckstylehadoop-common.txt
          Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12910/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
          hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/12910/artifact/patchprocess/testrun_hadoop-common.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12910/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12910/testReport/
          Java 1.7.0_55
          uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12910/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 26m 16s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 12m 17s There were no new javac warning messages. +1 javadoc 12m 56s There were no new javadoc warning messages. -1 release audit 0m 23s The applied patch generated 1 release audit warnings. -1 checkstyle 2m 39s The applied patch generated 9 new checkstyle issues (total was 229, now 237). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 2m 3s mvn install still works. +1 eclipse:eclipse 0m 45s The patch built with eclipse:eclipse. -1 findbugs 6m 33s The patch appears to introduce 2 new Findbugs (version 3.0.0) warnings. -1 common tests 10m 28s Tests failed in hadoop-common. -1 hdfs tests 149m 16s Tests failed in hadoop-hdfs.     224m 4s   Reason Tests FindBugs module:hadoop-hdfs Failed unit tests hadoop.fs.shell.find.TestName   hadoop.fs.shell.find.TestIname   hadoop.fs.TestLocalFsFCStatistics   hadoop.fs.shell.find.TestFind   hadoop.ipc.TestIPC   hadoop.ha.TestZKFailoverController   hadoop.security.ssl.TestReloadingX509TrustManager   hadoop.test.TestTimedOutTestsListener   hadoop.fs.shell.find.TestPrint   hadoop.hdfs.TestWriteRead   hadoop.hdfs.server.namenode.snapshot.TestCheckpointsWithSnapshots   hadoop.hdfs.server.namenode.ha.TestDNFencing   hadoop.hdfs.server.namenode.ha.TestStandbyIsHot   hadoop.hdfs.TestRollingUpgrade   hadoop.hdfs.TestHFlush   hadoop.hdfs.TestParallelRead   hadoop.hdfs.TestBlockReaderLocalLegacy   hadoop.hdfs.server.namenode.TestAuditLogger   hadoop.hdfs.server.namenode.TestXAttrConfigFlag   hadoop.hdfs.TestPread   hadoop.hdfs.TestDFSStripedOutputStream   hadoop.hdfs.TestWriteConfigurationToDFS   hadoop.hdfs.TestDFSRollback   hadoop.hdfs.TestDataTransferKeepalive   hadoop.hdfs.TestDFSFinalize   hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication   hadoop.hdfs.server.namenode.metrics.TestNNMetricFilesInGetListingOps   hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots   hadoop.hdfs.server.namenode.ha.TestHASafeMode   hadoop.hdfs.TestDFSShell   hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA   hadoop.hdfs.TestSeekBug   hadoop.hdfs.TestCrcCorruption   hadoop.hdfs.server.namenode.TestStorageRestore   hadoop.hdfs.TestAbandonBlock   hadoop.hdfs.TestGetFileChecksum   hadoop.hdfs.server.namenode.TestBlockUnderConstruction   hadoop.hdfs.TestSafeModeWithStripedFile   hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForContentSummary   hadoop.hdfs.TestFileCreationDelete   hadoop.hdfs.TestReadWhileWriting   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010   hadoop.hdfs.security.TestDelegationToken   hadoop.hdfs.server.namenode.ha.TestHAAppend   hadoop.hdfs.TestMissingBlocksAlert   hadoop.hdfs.TestBlocksScheduledCounter   hadoop.hdfs.TestSmallBlock   hadoop.hdfs.TestDFSClientRetries   hadoop.hdfs.TestDFSMkdirs   hadoop.hdfs.server.namenode.TestFavoredNodesEndToEnd   hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits   hadoop.hdfs.server.namenode.TestNameNodeMXBean   hadoop.hdfs.server.namenode.TestLargeDirectoryDelete   hadoop.hdfs.server.namenode.TestDeleteRace   hadoop.hdfs.TestFSInputChecker   hadoop.hdfs.server.namenode.ha.TestXAttrsWithHA   hadoop.hdfs.server.namenode.ha.TestHAMetrics   hadoop.hdfs.TestRollingUpgradeRollback   hadoop.hdfs.TestRemoteBlockReader   hadoop.hdfs.TestBlockStoragePolicy   hadoop.hdfs.TestLeaseRecovery   hadoop.hdfs.server.namenode.TestBackupNode   hadoop.hdfs.TestBlockReaderLocal   hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForXAttr   hadoop.hdfs.tools.TestDebugAdmin   hadoop.hdfs.TestReadStripedFileWithDecoding   hadoop.hdfs.TestLargeBlock   hadoop.hdfs.server.namenode.TestFSNamesystemMBean   hadoop.hdfs.tools.TestDFSZKFailoverController   hadoop.hdfs.TestDistributedFileSystem   hadoop.hdfs.TestListFilesInFileContext   hadoop.hdfs.server.namenode.TestNameNodeRecovery   hadoop.hdfs.TestFileAppend2   hadoop.hdfs.TestFsShellPermission   hadoop.hdfs.server.namenode.ha.TestHAFsck   hadoop.hdfs.TestRollingUpgradeDowngrade   hadoop.hdfs.TestFileLengthOnClusterRestart   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.TestWriteReadStripedFile   hadoop.hdfs.TestParallelUnixDomainRead   hadoop.hdfs.server.namenode.TestQuotaWithStripedBlocks   hadoop.hdfs.TestGetBlocks   hadoop.hdfs.security.token.block.TestBlockToken   hadoop.hdfs.web.TestWebHdfsTokens   hadoop.hdfs.TestErasureCodingPolicies   hadoop.hdfs.TestEncryptionZonesWithKMS   hadoop.hdfs.TestClientReportBadBlock   hadoop.hdfs.TestDFSStorageStateRecovery   hadoop.hdfs.TestRestartDFS   hadoop.hdfs.TestFileAppend4   hadoop.hdfs.server.namenode.ha.TestFailoverWithBlockTokensEnabled   hadoop.hdfs.TestSetTimes   hadoop.hdfs.server.namenode.TestAclConfigFlag   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.server.namenode.TestNameNodeAcl   hadoop.hdfs.TestSetrepIncreasing   hadoop.hdfs.TestLease   hadoop.hdfs.TestSafeMode   hadoop.hdfs.server.namenode.TestEditLogAutoroll   hadoop.hdfs.TestDFSUpgrade   hadoop.hdfs.TestDecommission   hadoop.hdfs.TestFileStatusWithECPolicy   hadoop.hdfs.protocol.datatransfer.sasl.TestSaslDataTransfer   hadoop.hdfs.server.namenode.ha.TestQuotasWithHA   hadoop.hdfs.TestFileCorruption   hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs   hadoop.hdfs.TestQuota   hadoop.hdfs.server.namenode.ha.TestHarFileSystemWithHA   hadoop.hdfs.TestFileStatus   hadoop.hdfs.TestEncryptionZonesWithHA   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure000   hadoop.hdfs.server.namenode.TestProcessCorruptBlocks   hadoop.hdfs.TestClose   hadoop.hdfs.TestMultiThreadedHflush   hadoop.hdfs.TestDFSClientExcludedNodes   hadoop.hdfs.server.namenode.TestAddOverReplicatedStripedBlocks   hadoop.hdfs.TestFileConcurrentReader   hadoop.hdfs.server.namenode.snapshot.TestUpdatePipelineWithSnapshots   hadoop.hdfs.TestDataTransferProtocol   hadoop.hdfs.TestBlockReaderFactory   hadoop.hdfs.server.namenode.TestParallelImageWrite   hadoop.hdfs.server.namenode.TestCheckpoint   hadoop.hdfs.server.namenode.web.resources.TestWebHdfsDataLocality   hadoop.hdfs.TestDatanodeDeath   hadoop.hdfs.TestPipelines   hadoop.hdfs.web.TestWebHDFSAcl   hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerWithStripedBlocks   hadoop.hdfs.server.namenode.TestFSImage   hadoop.hdfs.web.TestWebHdfsWithMultipleNameNodes   hadoop.hdfs.server.namenode.ha.TestBootstrapStandbyWithQJM   hadoop.hdfs.server.namenode.TestFsckWithMultipleNameNodes   hadoop.hdfs.server.namenode.ha.TestFailureOfSharedDir   hadoop.hdfs.TestRenameWhileOpen   hadoop.hdfs.server.namenode.TestNameNodeXAttr   hadoop.hdfs.server.namenode.TestEditLogJournalFailures   hadoop.hdfs.server.namenode.ha.TestPendingCorruptDnMessages   hadoop.hdfs.TestWriteBlockGetsBlockLengthHint   hadoop.hdfs.server.namenode.TestFSEditLogLoader   hadoop.hdfs.tools.TestStoragePolicyCommands   hadoop.hdfs.server.namenode.TestNamenodeRetryCache   hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.hdfs.TestDFSStartupVersions   hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForAcl   hadoop.hdfs.server.namenode.ha.TestHAStateTransitions   hadoop.hdfs.TestAppendSnapshotTruncate   hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate   hadoop.hdfs.TestParallelShortCircuitReadUnCached   hadoop.hdfs.TestDFSClientFailover   hadoop.hdfs.TestFSOutputSummer   hadoop.hdfs.server.namenode.TestHDFSConcat   hadoop.hdfs.server.namenode.ha.TestInitializeSharedEdits   hadoop.hdfs.server.namenode.TestFSImageWithAcl   hadoop.hdfs.server.namenode.snapshot.TestINodeFileUnderConstructionWithSnapshot   hadoop.hdfs.web.TestFSMainOperationsWebHdfs   hadoop.hdfs.TestDFSInotifyEventInputStream   hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA   hadoop.hdfs.server.namenode.ha.TestStandbyBlockManagement   hadoop.hdfs.server.namenode.TestSaveNamespace   hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics   hadoop.hdfs.TestDFSPermission   hadoop.hdfs.server.namenode.snapshot.TestSnapshotStatsMXBean   hadoop.hdfs.TestListFilesInDFS   hadoop.hdfs.TestModTime   hadoop.hdfs.TestReservedRawPaths   hadoop.hdfs.TestHDFSFileSystemContract   hadoop.hdfs.server.namenode.TestHostsFiles   hadoop.hdfs.TestFileCreation   hadoop.hdfs.server.namenode.TestINodeAttributeProvider   hadoop.hdfs.TestParallelShortCircuitRead   hadoop.hdfs.server.namenode.TestFSImageWithXAttr   hadoop.hdfs.TestParallelShortCircuitLegacyRead   hadoop.hdfs.server.namenode.TestFileJournalManager   hadoop.hdfs.TestFileCreationEmpty   hadoop.hdfs.TestRead   hadoop.hdfs.server.namenode.TestAuditLogAtDebug   hadoop.hdfs.TestFileAppend   hadoop.hdfs.web.TestWebHdfsFileSystemContract   hadoop.hdfs.server.namenode.TestSecureNameNode   hadoop.hdfs.web.TestWebHDFS   hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer   hadoop.hdfs.TestReplaceDatanodeOnFailure   hadoop.hdfs.server.namenode.TestAddBlock   hadoop.hdfs.server.namenode.ha.TestPipelinesFailover   hadoop.hdfs.TestFetchImage   hadoop.hdfs.TestInjectionForSimulatedStorage   hadoop.hdfs.TestFileCreationClient   hadoop.hdfs.server.namenode.TestAddStripedBlocks   hadoop.hdfs.server.namenode.TestNameEditsConfigs   hadoop.hdfs.server.namenode.TestCacheDirectives   hadoop.hdfs.TestClientProtocolForPipelineRecovery   hadoop.hdfs.TestDFSRemove   hadoop.hdfs.TestFileAppendRestart   hadoop.hdfs.TestDFSOutputStream   hadoop.hdfs.TestDisableConnCache   hadoop.hdfs.TestParallelShortCircuitReadNoChecksum   hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints   hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer   hadoop.hdfs.server.namenode.snapshot.TestFileContextSnapshot   hadoop.hdfs.server.namenode.TestStartup   hadoop.hdfs.server.namenode.snapshot.TestSetQuotaWithSnapshot   hadoop.hdfs.TestBlockMissingException   hadoop.hdfs.server.namenode.TestProtectedDirectories Timed out tests org.apache.hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots   org.apache.hadoop.hdfs.web.TestWebHDFSForHA Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12765950/HDFS-9184.002.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / def374e Release Audit https://builds.apache.org/job/PreCommit-HDFS-Build/12910/artifact/patchprocess/patchReleaseAuditProblems.txt checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12910/artifact/patchprocess/diffcheckstylehadoop-common.txt Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12910/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/12910/artifact/patchprocess/testrun_hadoop-common.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12910/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12910/testReport/ Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12910/console This message was automatically generated.
          Hide
          liuml07 Mingliang Liu added a comment -

          The failing tests seem unrelated. While the "cancel patch" and "submit patch" trick did not trigger the Jenkins again, I simply rebase the v2 patch from trunk branch and submit again, which is called v3.

          Thanks Jitendra Nath Pandey for reviewing the code.

          Show
          liuml07 Mingliang Liu added a comment - The failing tests seem unrelated. While the "cancel patch" and "submit patch" trick did not trigger the Jenkins again, I simply rebase the v2 patch from trunk branch and submit again, which is called v3. Thanks Jitendra Nath Pandey for reviewing the code.
          Hide
          liuml07 Mingliang Liu added a comment -

          The v4 patch fixes the audit log format, separating the caller context and signature with colon :

          Show
          liuml07 Mingliang Liu added a comment - The v4 patch fixes the audit log format, separating the caller context and signature with colon :
          Hide
          leftnoteasy Wangda Tan added a comment -

          Thanks Mingliang Liu, instead of static final ThreadLocal<CallerContext> context = new ThreadLocal<>();, could you use InheritableThreadLocal instead? With the InheritableThreadLocal, we don't need to set the context at every thread. For example, MR can set the Context at main thread so all threads will have this value automatically.

          Show
          leftnoteasy Wangda Tan added a comment - Thanks Mingliang Liu , instead of static final ThreadLocal<CallerContext> context = new ThreadLocal<>(); , could you use InheritableThreadLocal instead? With the InheritableThreadLocal , we don't need to set the context at every thread. For example, MR can set the Context at main thread so all threads will have this value automatically.
          Hide
          liuml07 Mingliang Liu added a comment -

          Thanks for your comment Wangda Tan. it makes perfect sense to me that the caller context is inherited in the child thread, as we don't support caller context hierarchy (which was by-design). Please note that the child thread is free to override its own current caller context.

          The v5 patch addresses this with updated unit test.

          Show
          liuml07 Mingliang Liu added a comment - Thanks for your comment Wangda Tan . it makes perfect sense to me that the caller context is inherited in the child thread, as we don't support caller context hierarchy (which was by-design). Please note that the child thread is free to override its own current caller context. The v5 patch addresses this with updated unit test.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 20m 33s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 8m 18s There were no new javac warning messages.
          +1 javadoc 10m 40s There were no new javadoc warning messages.
          -1 release audit 0m 18s The applied patch generated 1 release audit warnings.
          -1 checkstyle 1m 59s The applied patch generated 9 new checkstyle issues (total was 225, now 233).
          +1 whitespace 0m 1s The patch has no lines that end in whitespace.
          +1 install 1m 37s mvn install still works.
          +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse.
          -1 findbugs 4m 31s The patch appears to introduce 2 new Findbugs (version 3.0.0) warnings.
          +1 common tests 7m 0s Tests passed in hadoop-common.
          -1 hdfs tests 96m 36s Tests failed in hadoop-hdfs.
              152m 26s  



          Reason Tests
          FindBugs module:hadoop-hdfs
          Failed unit tests hadoop.hdfs.TestReservedRawPaths
            hadoop.hdfs.server.namenode.snapshot.TestUpdatePipelineWithSnapshots
            hadoop.hdfs.TestModTime
            hadoop.fs.TestUrlStreamHandler
            hadoop.hdfs.security.TestDelegationToken
            hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead
            hadoop.hdfs.server.namenode.TestFileLimit
            hadoop.hdfs.TestParallelShortCircuitRead
            hadoop.hdfs.server.namenode.snapshot.TestFileContextSnapshot
            hadoop.hdfs.TestDisableConnCache
            hadoop.hdfs.server.namenode.TestEditLogAutoroll
            hadoop.TestRefreshCallQueue
            hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
            hadoop.cli.TestCryptoAdminCLI
            hadoop.hdfs.TestDFSClientRetries
            hadoop.hdfs.TestSetrepDecreasing
            hadoop.hdfs.server.datanode.TestDiskError
            hadoop.fs.viewfs.TestViewFsWithAcls
            hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes
            hadoop.hdfs.server.namenode.TestAddStripedBlocks
            hadoop.hdfs.server.namenode.TestFSEditLogLoader
            hadoop.hdfs.server.namenode.TestHostsFiles
            hadoop.hdfs.server.datanode.TestTransferRbw
            hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistPolicy
            hadoop.fs.contract.hdfs.TestHDFSContractDelete
            hadoop.hdfs.server.namenode.TestFileContextAcl
            hadoop.hdfs.TestSafeModeWithStripedFile
            hadoop.fs.TestFcHdfsSetUMask
            hadoop.fs.TestUnbuffer
            hadoop.hdfs.server.namenode.TestDeleteRace
            hadoop.hdfs.TestPread
            hadoop.hdfs.server.namenode.TestFSDirectory
            hadoop.fs.contract.hdfs.TestHDFSContractOpen
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotListing
            hadoop.hdfs.server.datanode.TestBlockRecovery
            hadoop.hdfs.server.namenode.TestFileTruncate
            hadoop.hdfs.TestReadWhileWriting
            hadoop.fs.contract.hdfs.TestHDFSContractMkdir
            hadoop.fs.contract.hdfs.TestHDFSContractAppend
            hadoop.hdfs.server.datanode.TestFsDatasetCache
            hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock
            hadoop.hdfs.server.namenode.ha.TestQuotasWithHA
            hadoop.hdfs.TestReadStripedFileWithMissingBlocks
            hadoop.hdfs.server.namenode.TestAuditLogger
            hadoop.hdfs.server.namenode.TestRecoverStripedBlocks
            hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFS
            hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistFiles
            hadoop.hdfs.TestWriteBlockGetsBlockLengthHint
            hadoop.hdfs.TestDatanodeLayoutUpgrade
            hadoop.hdfs.server.namenode.TestHDFSConcat
            hadoop.hdfs.protocol.datatransfer.sasl.TestSaslDataTransfer
            hadoop.hdfs.server.datanode.TestCachingStrategy
            hadoop.fs.TestSymlinkHdfsFileSystem
            hadoop.fs.viewfs.TestViewFsDefaultValue
            hadoop.fs.TestSymlinkHdfsFileContext
            hadoop.hdfs.TestClientProtocolForPipelineRecovery
            hadoop.hdfs.TestFSInputChecker
            hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
            hadoop.hdfs.server.mover.TestStorageMover
            hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistLockedMemory
            hadoop.hdfs.server.datanode.TestBlockReplacement
            hadoop.hdfs.server.datanode.fsdataset.impl.TestInterDatanodeProtocol
            hadoop.cli.TestAclCLI
            hadoop.hdfs.security.token.block.TestBlockToken
            hadoop.hdfs.server.namenode.ha.TestHAMetrics
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotBlocksMap
            hadoop.hdfs.server.blockmanagement.TestNodeCount
            hadoop.hdfs.TestFileAppend
            hadoop.hdfs.server.datanode.TestReadOnlySharedStorage
            hadoop.hdfs.TestEncryptedTransfer
            hadoop.hdfs.tools.TestStoragePolicyCommands
            hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks
            hadoop.hdfs.TestParallelShortCircuitReadUnCached
            hadoop.hdfs.server.datanode.TestHSync
            hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyWriter
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.fs.contract.hdfs.TestHDFSContractSeek
            hadoop.hdfs.server.namenode.TestFileContextXAttr
            hadoop.hdfs.TestAbandonBlock
            hadoop.hdfs.server.namenode.TestAclConfigFlag
            hadoop.hdfs.TestFileCreationClient
            hadoop.hdfs.TestRemoteBlockReader2
            hadoop.hdfs.server.namenode.TestFSImageWithXAttr
            hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics
            hadoop.hdfs.TestFileAppendRestart
            hadoop.hdfs.server.namenode.snapshot.TestXAttrWithSnapshot
            hadoop.hdfs.server.namenode.TestFSImageWithAcl
            hadoop.hdfs.server.namenode.TestQuotaWithStripedBlocks
            hadoop.hdfs.server.namenode.ha.TestStandbyBlockManagement
            hadoop.tracing.TestTracing
            hadoop.hdfs.tools.TestDFSZKFailoverController
            hadoop.hdfs.server.namenode.TestListCorruptFileBlocks
            hadoop.hdfs.server.namenode.ha.TestFailureOfSharedDir
            hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
            hadoop.hdfs.TestBlockReaderLocalLegacy
            hadoop.hdfs.TestWriteConfigurationToDFS
            hadoop.hdfs.TestExternalBlockReader
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure000
            hadoop.hdfs.qjournal.TestSecureNNWithQJM
            hadoop.hdfs.server.namenode.TestParallelImageWrite
            hadoop.hdfs.TestReplication
            hadoop.hdfs.server.namenode.snapshot.TestAclWithSnapshot
            hadoop.hdfs.TestFileConcurrentReader
            hadoop.fs.viewfs.TestViewFsWithXAttrs
            hadoop.cli.TestErasureCodingCLI
            hadoop.hdfs.qjournal.TestNNWithQJM
            hadoop.hdfs.TestClose
            hadoop.hdfs.server.namenode.snapshot.TestGetContentSummaryWithSnapshot
            hadoop.hdfs.TestDFSUpgradeFromImage
            hadoop.hdfs.server.namenode.TestEditLogJournalFailures
            hadoop.hdfs.TestPersistBlocks
            hadoop.hdfs.TestDFSRollback
            hadoop.tools.TestJMXGet
            hadoop.hdfs.server.namenode.TestNameNodeMXBean
            hadoop.hdfs.server.datanode.TestBlockHasMultipleReplicasOnSameDN
            hadoop.hdfs.TestFileAppend4
            hadoop.hdfs.tools.TestDebugAdmin
            hadoop.hdfs.server.blockmanagement.TestSequentialBlockGroupId
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotDiffReport
            hadoop.fs.contract.hdfs.TestHDFSContractCreate
            hadoop.hdfs.server.datanode.fsdataset.impl.TestDatanodeRestart
            hadoop.hdfs.server.namenode.TestFSNamesystemMBean
            hadoop.hdfs.TestWriteRead
            hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
            hadoop.hdfs.TestHdfsAdmin
            hadoop.hdfs.server.datanode.TestFsDatasetCacheRevocation
            hadoop.hdfs.TestDFSPermission
            hadoop.fs.TestEnhancedByteBufferAccess
            hadoop.fs.TestFcHdfsPermission
            hadoop.hdfs.TestSafeMode
            hadoop.fs.viewfs.TestViewFsHdfs
            hadoop.hdfs.TestDFSRename
            hadoop.fs.TestResolveHdfsSymlink
            hadoop.hdfs.server.namenode.metrics.TestNNMetricFilesInGetListingOps
            hadoop.hdfs.server.namenode.web.resources.TestWebHdfsDataLocality
            hadoop.tracing.TestTracingShortCircuitLocalRead
            hadoop.hdfs.server.blockmanagement.TestNameNodePrunesMissingStorages
            hadoop.hdfs.server.namenode.TestDecommissioningStatus
            hadoop.fs.contract.hdfs.TestHDFSContractGetFileStatus
            hadoop.hdfs.server.namenode.snapshot.TestCheckpointsWithSnapshots
            hadoop.hdfs.server.namenode.TestProtectedDirectories
            hadoop.hdfs.TestDFSUpgrade
            hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForContentSummary
            hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation
            hadoop.hdfs.TestParallelShortCircuitReadNoChecksum
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureToleration
            hadoop.hdfs.TestDFSStorageStateRecovery
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotMetrics
            hadoop.hdfs.TestDecommission
            hadoop.hdfs.TestEncryptionZonesWithKMS
            hadoop.hdfs.server.datanode.TestTriggerBlockReport
            hadoop.hdfs.server.namenode.TestAuditLogAtDebug
            hadoop.hdfs.server.namenode.TestINodeFile
            hadoop.hdfs.TestFSOutputSummer
            hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
            hadoop.hdfs.TestFileLengthOnClusterRestart
            hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs
            hadoop.hdfs.TestSetTimes
            hadoop.hdfs.server.namenode.TestQuotaByStorageType
            hadoop.hdfs.server.balancer.TestBalancerWithEncryptedTransfer
            hadoop.hdfs.server.namenode.TestNamenodeRetryCache
            hadoop.fs.TestWebHdfsFileContextMainOperations
            hadoop.hdfs.server.balancer.TestBalancer
            hadoop.hdfs.TestDFSRemove
            hadoop.fs.TestFcHdfsCreateMkdir
            hadoop.hdfs.TestEncryptionZones
            hadoop.hdfs.TestAppendDifferentChecksum
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotReplication
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotNameWithInvalidCharacters
            hadoop.hdfs.server.namenode.ha.TestBootstrapStandbyWithQJM
            hadoop.hdfs.server.namenode.TestBlockUnderConstruction
            hadoop.hdfs.server.mover.TestMover
            hadoop.hdfs.server.blockmanagement.TestComputeInvalidateWork
            hadoop.hdfs.TestDFSFinalize
            hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaPlacement
            hadoop.hdfs.server.namenode.TestCacheDirectives
            hadoop.hdfs.TestFileAppend2
            hadoop.hdfs.server.namenode.ha.TestInitializeSharedEdits
            hadoop.hdfs.server.namenode.ha.TestFailoverWithBlockTokensEnabled
            hadoop.hdfs.server.datanode.TestBlockScanner
            hadoop.hdfs.server.namenode.TestStorageRestore
            hadoop.hdfs.server.namenode.TestEditLog
            hadoop.fs.viewfs.TestViewFileSystemWithXAttrs
            hadoop.hdfs.server.namenode.ha.TestHAFsck
            hadoop.fs.viewfs.TestViewFileSystemWithAcls
            hadoop.hdfs.server.namenode.TestXAttrConfigFlag
            hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer
            hadoop.hdfs.TestFsShellPermission
            hadoop.hdfs.TestFileStatusWithECPolicy
            hadoop.hdfs.TestFileAppend3
            hadoop.hdfs.TestDFSInputStream
            hadoop.hdfs.server.namenode.snapshot.TestINodeFileUnderConstructionWithSnapshot
            hadoop.hdfs.TestWriteReadStripedFile
            hadoop.hdfs.TestQuota
            hadoop.hdfs.server.namenode.snapshot.TestDisallowModifyROSnapshot
            hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes
            hadoop.hdfs.TestClientBlockVerification
            hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer
            hadoop.hdfs.server.blockmanagement.TestBlockManager
            hadoop.hdfs.server.datanode.TestDataNodeMetrics
            hadoop.hdfs.server.namenode.TestFsckWithMultipleNameNodes
            hadoop.hdfs.TestDFSClientFailover
            hadoop.hdfs.TestDFSStripedOutputStream
            hadoop.hdfs.server.namenode.TestSnapshotPathINodes
            hadoop.hdfs.TestRollingUpgrade
            hadoop.hdfs.server.namenode.ha.TestStandbyIsHot
            hadoop.security.TestPermission
            hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure
            hadoop.fs.contract.hdfs.TestHDFSContractConcat
            hadoop.hdfs.TestGetBlocks
            hadoop.hdfs.server.namenode.TestLargeDirectoryDelete
            hadoop.hdfs.server.blockmanagement.TestOverReplicatedBlocks
            hadoop.hdfs.server.namenode.TestFsck
            hadoop.hdfs.server.namenode.TestAuditLogs
            hadoop.hdfs.TestListFilesInFileContext
            hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots
            hadoop.hdfs.TestMultiThreadedHflush
            hadoop.hdfs.server.namenode.TestSecondaryNameNodeUpgrade
            hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
            hadoop.security.TestPermissionSymlinks
            hadoop.hdfs.TestDataTransferKeepalive
            hadoop.hdfs.TestRenameWhileOpen
            hadoop.hdfs.TestClientReportBadBlock
            hadoop.hdfs.server.blockmanagement.TestSequentialBlockId
            hadoop.fs.contract.hdfs.TestHDFSContractRootDirectory
            hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot
            hadoop.hdfs.server.namenode.TestAddOverReplicatedStripedBlocks
            hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerWithStripedBlocks
            hadoop.hdfs.TestParallelUnixDomainRead
            hadoop.cli.TestXAttrCLI
            hadoop.hdfs.server.namenode.TestNameEditsConfigs
            hadoop.hdfs.TestEncryptionZonesWithHA
            hadoop.hdfs.TestFileCreationEmpty
            hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA
            hadoop.hdfs.shortcircuit.TestShortCircuitCache
            hadoop.fs.contract.hdfs.TestHDFSContractRename
            hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotFileLength
            hadoop.hdfs.server.datanode.fsdataset.impl.TestScrLazyPersistFiles
            hadoop.hdfs.server.datanode.TestNNHandlesBlockReportPerStorage
            hadoop.fs.permission.TestStickyBit
            hadoop.hdfs.server.namenode.ha.TestPendingCorruptDnMessages
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotDeletion
            hadoop.hdfs.TestDFSStartupVersions
            hadoop.hdfs.TestFileCreation
            hadoop.hdfs.server.namenode.ha.TestHASafeMode
            hadoop.hdfs.TestMissingBlocksAlert
            hadoop.hdfs.server.namenode.TestSecureNameNode
            hadoop.hdfs.server.namenode.snapshot.TestSnapshot
            hadoop.fs.viewfs.TestViewFileSystemAtHdfsRoot
            hadoop.hdfs.server.namenode.TestStartup
            hadoop.hdfs.server.namenode.TestNameNodeRecovery
            hadoop.hdfs.TestRead
            hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate
            hadoop.fs.contract.hdfs.TestHDFSContractSetTimes
            hadoop.hdfs.TestLocalDFS
            hadoop.hdfs.TestDatanodeDeath
            hadoop.hdfs.server.datanode.TestDeleteBlockPool
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
            hadoop.hdfs.server.datanode.TestNNHandlesCombinedBlockReport
            hadoop.hdfs.server.namenode.ha.TestXAttrsWithHA
            hadoop.hdfs.TestBlockReaderFactory
            hadoop.hdfs.server.namenode.TestINodeAttributeProvider
            hadoop.hdfs.server.namenode.TestFSImageWithSnapshot
            hadoop.hdfs.TestPipelines
            hadoop.hdfs.TestReadStripedFileWithDecoding
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010
            hadoop.fs.loadGenerator.TestLoadGenerator
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotRename
            hadoop.hdfs.server.namenode.TestStripedINodeFile
            hadoop.hdfs.TestListFilesInDFS
            hadoop.cli.TestCacheAdminCLI
            hadoop.fs.TestSWebHdfsFileContextMainOperations
            hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForXAttr
            hadoop.hdfs.server.namenode.TestProcessCorruptBlocks
            hadoop.hdfs.TestFileCorruption
            hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
            hadoop.hdfs.server.datanode.fsdataset.impl.TestSpaceReservation
            hadoop.fs.TestHDFSFileContextMainOperations
            hadoop.hdfs.server.namenode.TestSaveNamespace
            hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped
            hadoop.fs.TestGlobPaths
            hadoop.fs.viewfs.TestViewFsFileStatusHdfs
            hadoop.hdfs.server.namenode.TestMetaSave
            hadoop.hdfs.server.blockmanagement.TestPendingReplication
            hadoop.hdfs.server.namenode.ha.TestHarFileSystemWithHA
            hadoop.fs.viewfs.TestViewFsAtHdfsRoot
            hadoop.hdfs.server.datanode.TestIncrementalBrVariations
            hadoop.hdfs.server.balancer.TestBalancerWithSaslDataTransfer
            hadoop.hdfs.server.namenode.ha.TestHAAppend
            hadoop.hdfs.server.namenode.TestBackupNode
            hadoop.hdfs.server.namenode.TestNameNodeAcl
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
            hadoop.fs.shell.TestHdfsTextCommand
            hadoop.hdfs.TestLargeBlock
            hadoop.cli.TestDeleteCLI
            hadoop.cli.TestHDFSCLI
            hadoop.hdfs.TestReplaceDatanodeOnFailure
            hadoop.hdfs.server.namenode.TestFavoredNodesEndToEnd
            hadoop.fs.TestSymlinkHdfsDisable
            hadoop.hdfs.server.namenode.ha.TestHAStateTransitions
            hadoop.hdfs.server.namenode.TestFSImage
            hadoop.fs.viewfs.TestViewFileSystemHdfs
            hadoop.hdfs.server.namenode.TestAddBlock
            hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication
            hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits
            hadoop.hdfs.TestDFSInotifyEventInputStream
            hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
            hadoop.hdfs.server.namenode.snapshot.TestSnapshottableDirListing
            hadoop.hdfs.TestLease
            hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery
            hadoop.hdfs.server.namenode.snapshot.TestSetQuotaWithSnapshot
            hadoop.hdfs.server.namenode.TestNameNodeXAttr
            hadoop.hdfs.server.datanode.TestDnRespectsBlockReportSplitThreshold
            hadoop.hdfs.server.namenode.TestCheckpoint
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotStatsMXBean
            hadoop.hdfs.server.namenode.ha.TestDNFencing
            hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade
            hadoop.hdfs.TestLeaseRecovery
            hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForAcl



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12766184/HDFS-9184.003.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 9849c8b
          Release Audit https://builds.apache.org/job/PreCommit-HDFS-Build/12941/artifact/patchprocess/patchReleaseAuditProblems.txt
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12941/artifact/patchprocess/diffcheckstylehadoop-common.txt
          Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12941/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
          hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/12941/artifact/patchprocess/testrun_hadoop-common.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12941/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12941/testReport/
          Java 1.7.0_55
          uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12941/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 20m 33s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 8m 18s There were no new javac warning messages. +1 javadoc 10m 40s There were no new javadoc warning messages. -1 release audit 0m 18s The applied patch generated 1 release audit warnings. -1 checkstyle 1m 59s The applied patch generated 9 new checkstyle issues (total was 225, now 233). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 37s mvn install still works. +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse. -1 findbugs 4m 31s The patch appears to introduce 2 new Findbugs (version 3.0.0) warnings. +1 common tests 7m 0s Tests passed in hadoop-common. -1 hdfs tests 96m 36s Tests failed in hadoop-hdfs.     152m 26s   Reason Tests FindBugs module:hadoop-hdfs Failed unit tests hadoop.hdfs.TestReservedRawPaths   hadoop.hdfs.server.namenode.snapshot.TestUpdatePipelineWithSnapshots   hadoop.hdfs.TestModTime   hadoop.fs.TestUrlStreamHandler   hadoop.hdfs.security.TestDelegationToken   hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead   hadoop.hdfs.server.namenode.TestFileLimit   hadoop.hdfs.TestParallelShortCircuitRead   hadoop.hdfs.server.namenode.snapshot.TestFileContextSnapshot   hadoop.hdfs.TestDisableConnCache   hadoop.hdfs.server.namenode.TestEditLogAutoroll   hadoop.TestRefreshCallQueue   hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints   hadoop.cli.TestCryptoAdminCLI   hadoop.hdfs.TestDFSClientRetries   hadoop.hdfs.TestSetrepDecreasing   hadoop.hdfs.server.datanode.TestDiskError   hadoop.fs.viewfs.TestViewFsWithAcls   hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes   hadoop.hdfs.server.namenode.TestAddStripedBlocks   hadoop.hdfs.server.namenode.TestFSEditLogLoader   hadoop.hdfs.server.namenode.TestHostsFiles   hadoop.hdfs.server.datanode.TestTransferRbw   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistPolicy   hadoop.fs.contract.hdfs.TestHDFSContractDelete   hadoop.hdfs.server.namenode.TestFileContextAcl   hadoop.hdfs.TestSafeModeWithStripedFile   hadoop.fs.TestFcHdfsSetUMask   hadoop.fs.TestUnbuffer   hadoop.hdfs.server.namenode.TestDeleteRace   hadoop.hdfs.TestPread   hadoop.hdfs.server.namenode.TestFSDirectory   hadoop.fs.contract.hdfs.TestHDFSContractOpen   hadoop.hdfs.server.namenode.snapshot.TestSnapshotListing   hadoop.hdfs.server.datanode.TestBlockRecovery   hadoop.hdfs.server.namenode.TestFileTruncate   hadoop.hdfs.TestReadWhileWriting   hadoop.fs.contract.hdfs.TestHDFSContractMkdir   hadoop.fs.contract.hdfs.TestHDFSContractAppend   hadoop.hdfs.server.datanode.TestFsDatasetCache   hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock   hadoop.hdfs.server.namenode.ha.TestQuotasWithHA   hadoop.hdfs.TestReadStripedFileWithMissingBlocks   hadoop.hdfs.server.namenode.TestAuditLogger   hadoop.hdfs.server.namenode.TestRecoverStripedBlocks   hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFS   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistFiles   hadoop.hdfs.TestWriteBlockGetsBlockLengthHint   hadoop.hdfs.TestDatanodeLayoutUpgrade   hadoop.hdfs.server.namenode.TestHDFSConcat   hadoop.hdfs.protocol.datatransfer.sasl.TestSaslDataTransfer   hadoop.hdfs.server.datanode.TestCachingStrategy   hadoop.fs.TestSymlinkHdfsFileSystem   hadoop.fs.viewfs.TestViewFsDefaultValue   hadoop.fs.TestSymlinkHdfsFileContext   hadoop.hdfs.TestClientProtocolForPipelineRecovery   hadoop.hdfs.TestFSInputChecker   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.server.mover.TestStorageMover   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistLockedMemory   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.datanode.fsdataset.impl.TestInterDatanodeProtocol   hadoop.cli.TestAclCLI   hadoop.hdfs.security.token.block.TestBlockToken   hadoop.hdfs.server.namenode.ha.TestHAMetrics   hadoop.hdfs.server.namenode.snapshot.TestSnapshotBlocksMap   hadoop.hdfs.server.blockmanagement.TestNodeCount   hadoop.hdfs.TestFileAppend   hadoop.hdfs.server.datanode.TestReadOnlySharedStorage   hadoop.hdfs.TestEncryptedTransfer   hadoop.hdfs.tools.TestStoragePolicyCommands   hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks   hadoop.hdfs.TestParallelShortCircuitReadUnCached   hadoop.hdfs.server.datanode.TestHSync   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyWriter   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.fs.contract.hdfs.TestHDFSContractSeek   hadoop.hdfs.server.namenode.TestFileContextXAttr   hadoop.hdfs.TestAbandonBlock   hadoop.hdfs.server.namenode.TestAclConfigFlag   hadoop.hdfs.TestFileCreationClient   hadoop.hdfs.TestRemoteBlockReader2   hadoop.hdfs.server.namenode.TestFSImageWithXAttr   hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics   hadoop.hdfs.TestFileAppendRestart   hadoop.hdfs.server.namenode.snapshot.TestXAttrWithSnapshot   hadoop.hdfs.server.namenode.TestFSImageWithAcl   hadoop.hdfs.server.namenode.TestQuotaWithStripedBlocks   hadoop.hdfs.server.namenode.ha.TestStandbyBlockManagement   hadoop.tracing.TestTracing   hadoop.hdfs.tools.TestDFSZKFailoverController   hadoop.hdfs.server.namenode.TestListCorruptFileBlocks   hadoop.hdfs.server.namenode.ha.TestFailureOfSharedDir   hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA   hadoop.hdfs.TestBlockReaderLocalLegacy   hadoop.hdfs.TestWriteConfigurationToDFS   hadoop.hdfs.TestExternalBlockReader   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure000   hadoop.hdfs.qjournal.TestSecureNNWithQJM   hadoop.hdfs.server.namenode.TestParallelImageWrite   hadoop.hdfs.TestReplication   hadoop.hdfs.server.namenode.snapshot.TestAclWithSnapshot   hadoop.hdfs.TestFileConcurrentReader   hadoop.fs.viewfs.TestViewFsWithXAttrs   hadoop.cli.TestErasureCodingCLI   hadoop.hdfs.qjournal.TestNNWithQJM   hadoop.hdfs.TestClose   hadoop.hdfs.server.namenode.snapshot.TestGetContentSummaryWithSnapshot   hadoop.hdfs.TestDFSUpgradeFromImage   hadoop.hdfs.server.namenode.TestEditLogJournalFailures   hadoop.hdfs.TestPersistBlocks   hadoop.hdfs.TestDFSRollback   hadoop.tools.TestJMXGet   hadoop.hdfs.server.namenode.TestNameNodeMXBean   hadoop.hdfs.server.datanode.TestBlockHasMultipleReplicasOnSameDN   hadoop.hdfs.TestFileAppend4   hadoop.hdfs.tools.TestDebugAdmin   hadoop.hdfs.server.blockmanagement.TestSequentialBlockGroupId   hadoop.hdfs.server.namenode.snapshot.TestSnapshotDiffReport   hadoop.fs.contract.hdfs.TestHDFSContractCreate   hadoop.hdfs.server.datanode.fsdataset.impl.TestDatanodeRestart   hadoop.hdfs.server.namenode.TestFSNamesystemMBean   hadoop.hdfs.TestWriteRead   hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes   hadoop.hdfs.TestHdfsAdmin   hadoop.hdfs.server.datanode.TestFsDatasetCacheRevocation   hadoop.hdfs.TestDFSPermission   hadoop.fs.TestEnhancedByteBufferAccess   hadoop.fs.TestFcHdfsPermission   hadoop.hdfs.TestSafeMode   hadoop.fs.viewfs.TestViewFsHdfs   hadoop.hdfs.TestDFSRename   hadoop.fs.TestResolveHdfsSymlink   hadoop.hdfs.server.namenode.metrics.TestNNMetricFilesInGetListingOps   hadoop.hdfs.server.namenode.web.resources.TestWebHdfsDataLocality   hadoop.tracing.TestTracingShortCircuitLocalRead   hadoop.hdfs.server.blockmanagement.TestNameNodePrunesMissingStorages   hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.fs.contract.hdfs.TestHDFSContractGetFileStatus   hadoop.hdfs.server.namenode.snapshot.TestCheckpointsWithSnapshots   hadoop.hdfs.server.namenode.TestProtectedDirectories   hadoop.hdfs.TestDFSUpgrade   hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForContentSummary   hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation   hadoop.hdfs.TestParallelShortCircuitReadNoChecksum   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureToleration   hadoop.hdfs.TestDFSStorageStateRecovery   hadoop.hdfs.server.namenode.snapshot.TestSnapshotMetrics   hadoop.hdfs.TestDecommission   hadoop.hdfs.TestEncryptionZonesWithKMS   hadoop.hdfs.server.datanode.TestTriggerBlockReport   hadoop.hdfs.server.namenode.TestAuditLogAtDebug   hadoop.hdfs.server.namenode.TestINodeFile   hadoop.hdfs.TestFSOutputSummer   hadoop.hdfs.server.namenode.ha.TestPipelinesFailover   hadoop.hdfs.TestFileLengthOnClusterRestart   hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs   hadoop.hdfs.TestSetTimes   hadoop.hdfs.server.namenode.TestQuotaByStorageType   hadoop.hdfs.server.balancer.TestBalancerWithEncryptedTransfer   hadoop.hdfs.server.namenode.TestNamenodeRetryCache   hadoop.fs.TestWebHdfsFileContextMainOperations   hadoop.hdfs.server.balancer.TestBalancer   hadoop.hdfs.TestDFSRemove   hadoop.fs.TestFcHdfsCreateMkdir   hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.TestAppendDifferentChecksum   hadoop.hdfs.server.namenode.snapshot.TestSnapshotReplication   hadoop.hdfs.server.namenode.snapshot.TestSnapshotNameWithInvalidCharacters   hadoop.hdfs.server.namenode.ha.TestBootstrapStandbyWithQJM   hadoop.hdfs.server.namenode.TestBlockUnderConstruction   hadoop.hdfs.server.mover.TestMover   hadoop.hdfs.server.blockmanagement.TestComputeInvalidateWork   hadoop.hdfs.TestDFSFinalize   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaPlacement   hadoop.hdfs.server.namenode.TestCacheDirectives   hadoop.hdfs.TestFileAppend2   hadoop.hdfs.server.namenode.ha.TestInitializeSharedEdits   hadoop.hdfs.server.namenode.ha.TestFailoverWithBlockTokensEnabled   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.namenode.TestStorageRestore   hadoop.hdfs.server.namenode.TestEditLog   hadoop.fs.viewfs.TestViewFileSystemWithXAttrs   hadoop.hdfs.server.namenode.ha.TestHAFsck   hadoop.fs.viewfs.TestViewFileSystemWithAcls   hadoop.hdfs.server.namenode.TestXAttrConfigFlag   hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer   hadoop.hdfs.TestFsShellPermission   hadoop.hdfs.TestFileStatusWithECPolicy   hadoop.hdfs.TestFileAppend3   hadoop.hdfs.TestDFSInputStream   hadoop.hdfs.server.namenode.snapshot.TestINodeFileUnderConstructionWithSnapshot   hadoop.hdfs.TestWriteReadStripedFile   hadoop.hdfs.TestQuota   hadoop.hdfs.server.namenode.snapshot.TestDisallowModifyROSnapshot   hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes   hadoop.hdfs.TestClientBlockVerification   hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer   hadoop.hdfs.server.blockmanagement.TestBlockManager   hadoop.hdfs.server.datanode.TestDataNodeMetrics   hadoop.hdfs.server.namenode.TestFsckWithMultipleNameNodes   hadoop.hdfs.TestDFSClientFailover   hadoop.hdfs.TestDFSStripedOutputStream   hadoop.hdfs.server.namenode.TestSnapshotPathINodes   hadoop.hdfs.TestRollingUpgrade   hadoop.hdfs.server.namenode.ha.TestStandbyIsHot   hadoop.security.TestPermission   hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure   hadoop.fs.contract.hdfs.TestHDFSContractConcat   hadoop.hdfs.TestGetBlocks   hadoop.hdfs.server.namenode.TestLargeDirectoryDelete   hadoop.hdfs.server.blockmanagement.TestOverReplicatedBlocks   hadoop.hdfs.server.namenode.TestFsck   hadoop.hdfs.server.namenode.TestAuditLogs   hadoop.hdfs.TestListFilesInFileContext   hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots   hadoop.hdfs.TestMultiThreadedHflush   hadoop.hdfs.server.namenode.TestSecondaryNameNodeUpgrade   hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks   hadoop.security.TestPermissionSymlinks   hadoop.hdfs.TestDataTransferKeepalive   hadoop.hdfs.TestRenameWhileOpen   hadoop.hdfs.TestClientReportBadBlock   hadoop.hdfs.server.blockmanagement.TestSequentialBlockId   hadoop.fs.contract.hdfs.TestHDFSContractRootDirectory   hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot   hadoop.hdfs.server.namenode.TestAddOverReplicatedStripedBlocks   hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerWithStripedBlocks   hadoop.hdfs.TestParallelUnixDomainRead   hadoop.cli.TestXAttrCLI   hadoop.hdfs.server.namenode.TestNameEditsConfigs   hadoop.hdfs.TestEncryptionZonesWithHA   hadoop.hdfs.TestFileCreationEmpty   hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA   hadoop.hdfs.shortcircuit.TestShortCircuitCache   hadoop.fs.contract.hdfs.TestHDFSContractRename   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.server.namenode.snapshot.TestSnapshotFileLength   hadoop.hdfs.server.datanode.fsdataset.impl.TestScrLazyPersistFiles   hadoop.hdfs.server.datanode.TestNNHandlesBlockReportPerStorage   hadoop.fs.permission.TestStickyBit   hadoop.hdfs.server.namenode.ha.TestPendingCorruptDnMessages   hadoop.hdfs.server.namenode.snapshot.TestSnapshotDeletion   hadoop.hdfs.TestDFSStartupVersions   hadoop.hdfs.TestFileCreation   hadoop.hdfs.server.namenode.ha.TestHASafeMode   hadoop.hdfs.TestMissingBlocksAlert   hadoop.hdfs.server.namenode.TestSecureNameNode   hadoop.hdfs.server.namenode.snapshot.TestSnapshot   hadoop.fs.viewfs.TestViewFileSystemAtHdfsRoot   hadoop.hdfs.server.namenode.TestStartup   hadoop.hdfs.server.namenode.TestNameNodeRecovery   hadoop.hdfs.TestRead   hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate   hadoop.fs.contract.hdfs.TestHDFSContractSetTimes   hadoop.hdfs.TestLocalDFS   hadoop.hdfs.TestDatanodeDeath   hadoop.hdfs.server.datanode.TestDeleteBlockPool   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting   hadoop.hdfs.server.datanode.TestNNHandlesCombinedBlockReport   hadoop.hdfs.server.namenode.ha.TestXAttrsWithHA   hadoop.hdfs.TestBlockReaderFactory   hadoop.hdfs.server.namenode.TestINodeAttributeProvider   hadoop.hdfs.server.namenode.TestFSImageWithSnapshot   hadoop.hdfs.TestPipelines   hadoop.hdfs.TestReadStripedFileWithDecoding   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010   hadoop.fs.loadGenerator.TestLoadGenerator   hadoop.hdfs.server.namenode.snapshot.TestSnapshotRename   hadoop.hdfs.server.namenode.TestStripedINodeFile   hadoop.hdfs.TestListFilesInDFS   hadoop.cli.TestCacheAdminCLI   hadoop.fs.TestSWebHdfsFileContextMainOperations   hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForXAttr   hadoop.hdfs.server.namenode.TestProcessCorruptBlocks   hadoop.hdfs.TestFileCorruption   hadoop.hdfs.server.namenode.TestNamenodeCapacityReport   hadoop.hdfs.server.datanode.fsdataset.impl.TestSpaceReservation   hadoop.fs.TestHDFSFileContextMainOperations   hadoop.hdfs.server.namenode.TestSaveNamespace   hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped   hadoop.fs.TestGlobPaths   hadoop.fs.viewfs.TestViewFsFileStatusHdfs   hadoop.hdfs.server.namenode.TestMetaSave   hadoop.hdfs.server.blockmanagement.TestPendingReplication   hadoop.hdfs.server.namenode.ha.TestHarFileSystemWithHA   hadoop.fs.viewfs.TestViewFsAtHdfsRoot   hadoop.hdfs.server.datanode.TestIncrementalBrVariations   hadoop.hdfs.server.balancer.TestBalancerWithSaslDataTransfer   hadoop.hdfs.server.namenode.ha.TestHAAppend   hadoop.hdfs.server.namenode.TestBackupNode   hadoop.hdfs.server.namenode.TestNameNodeAcl   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.fs.shell.TestHdfsTextCommand   hadoop.hdfs.TestLargeBlock   hadoop.cli.TestDeleteCLI   hadoop.cli.TestHDFSCLI   hadoop.hdfs.TestReplaceDatanodeOnFailure   hadoop.hdfs.server.namenode.TestFavoredNodesEndToEnd   hadoop.fs.TestSymlinkHdfsDisable   hadoop.hdfs.server.namenode.ha.TestHAStateTransitions   hadoop.hdfs.server.namenode.TestFSImage   hadoop.fs.viewfs.TestViewFileSystemHdfs   hadoop.hdfs.server.namenode.TestAddBlock   hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication   hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits   hadoop.hdfs.TestDFSInotifyEventInputStream   hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots   hadoop.hdfs.server.namenode.snapshot.TestSnapshottableDirListing   hadoop.hdfs.TestLease   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery   hadoop.hdfs.server.namenode.snapshot.TestSetQuotaWithSnapshot   hadoop.hdfs.server.namenode.TestNameNodeXAttr   hadoop.hdfs.server.datanode.TestDnRespectsBlockReportSplitThreshold   hadoop.hdfs.server.namenode.TestCheckpoint   hadoop.hdfs.server.namenode.snapshot.TestSnapshotStatsMXBean   hadoop.hdfs.server.namenode.ha.TestDNFencing   hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade   hadoop.hdfs.TestLeaseRecovery   hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForAcl Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12766184/HDFS-9184.003.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 9849c8b Release Audit https://builds.apache.org/job/PreCommit-HDFS-Build/12941/artifact/patchprocess/patchReleaseAuditProblems.txt checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12941/artifact/patchprocess/diffcheckstylehadoop-common.txt Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12941/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/12941/artifact/patchprocess/testrun_hadoop-common.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12941/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12941/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12941/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 19m 59s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 8m 6s There were no new javac warning messages.
          +1 javadoc 10m 29s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 51s The applied patch generated 9 new checkstyle issues (total was 225, now 233).
          +1 whitespace 0m 1s The patch has no lines that end in whitespace.
          +1 install 1m 41s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          -1 findbugs 4m 31s The patch appears to introduce 2 new Findbugs (version 3.0.0) warnings.
          -1 common tests 6m 40s Tests failed in hadoop-common.
          -1 hdfs tests 62m 49s Tests failed in hadoop-hdfs.
              117m 23s  



          Reason Tests
          FindBugs module:hadoop-hdfs
          Failed unit tests hadoop.ipc.TestRPC
            hadoop.net.TestDNS
            hadoop.hdfs.web.TestWebHDFSOAuth2
          Timed out tests org.apache.hadoop.hdfs.TestDatanodeDeath
            org.apache.hadoop.hdfs.TestSafeMode
            org.apache.hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits
            org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure000



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12766202/HDFS-9184.004.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / c60a16f
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12943/artifact/patchprocess/diffcheckstylehadoop-common.txt
          Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12943/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
          hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/12943/artifact/patchprocess/testrun_hadoop-common.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12943/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12943/testReport/
          Java 1.7.0_55
          uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12943/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 19m 59s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 8m 6s There were no new javac warning messages. +1 javadoc 10m 29s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 51s The applied patch generated 9 new checkstyle issues (total was 225, now 233). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 41s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. -1 findbugs 4m 31s The patch appears to introduce 2 new Findbugs (version 3.0.0) warnings. -1 common tests 6m 40s Tests failed in hadoop-common. -1 hdfs tests 62m 49s Tests failed in hadoop-hdfs.     117m 23s   Reason Tests FindBugs module:hadoop-hdfs Failed unit tests hadoop.ipc.TestRPC   hadoop.net.TestDNS   hadoop.hdfs.web.TestWebHDFSOAuth2 Timed out tests org.apache.hadoop.hdfs.TestDatanodeDeath   org.apache.hadoop.hdfs.TestSafeMode   org.apache.hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits   org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure000 Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12766202/HDFS-9184.004.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / c60a16f checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12943/artifact/patchprocess/diffcheckstylehadoop-common.txt Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12943/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/12943/artifact/patchprocess/testrun_hadoop-common.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12943/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12943/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12943/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 20m 4s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 7m 51s There were no new javac warning messages.
          +1 javadoc 10m 38s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 50s The applied patch generated 9 new checkstyle issues (total was 225, now 233).
          -1 checkstyle 2m 31s The applied patch generated 4 new checkstyle issues (total was 651, now 652).
          +1 whitespace 0m 2s The patch has no lines that end in whitespace.
          +1 install 1m 28s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          -1 findbugs 4m 31s The patch appears to introduce 2 new Findbugs (version 3.0.0) warnings.
          -1 common tests 6m 41s Tests failed in hadoop-common.
          -1 hdfs tests 77m 35s Tests failed in hadoop-hdfs.
              132m 25s  



          Reason Tests
          FindBugs module:hadoop-hdfs
          Failed unit tests hadoop.ipc.TestRPC
            hadoop.net.TestDNS
            hadoop.hdfs.server.namenode.TestINodeFile
            hadoop.hdfs.server.datanode.fsdataset.impl.TestDatanodeRestart
            hadoop.hdfs.TestFileCreationDelete
            hadoop.hdfs.server.namenode.ha.TestHASafeMode
            hadoop.hdfs.TestDFSShell
            hadoop.hdfs.server.namenode.TestNameNodeXAttr
            hadoop.hdfs.shortcircuit.TestShortCircuitCache
            hadoop.hdfs.server.namenode.TestFSEditLogLoader
            hadoop.hdfs.server.blockmanagement.TestNameNodePrunesMissingStorages
            hadoop.hdfs.server.namenode.TestDeleteRace
            hadoop.hdfs.server.namenode.TestParallelImageWrite
            hadoop.hdfs.server.namenode.TestSaveNamespace
            hadoop.hdfs.TestReplaceDatanodeOnFailure
            hadoop.hdfs.server.namenode.TestQuotaWithStripedBlocks
            hadoop.hdfs.server.namenode.TestFsck
            hadoop.hdfs.server.namenode.ha.TestHarFileSystemWithHA
            hadoop.hdfs.server.datanode.TestDeleteBlockPool
            hadoop.hdfs.server.namenode.TestStorageRestore
            hadoop.hdfs.server.namenode.TestFileLimit
            hadoop.hdfs.server.blockmanagement.TestNodeCount
            hadoop.hdfs.TestEncryptionZones
            hadoop.hdfs.server.namenode.snapshot.TestCheckpointsWithSnapshots
            hadoop.hdfs.qjournal.TestNNWithQJM
            hadoop.hdfs.web.TestWebHdfsFileSystemContract
            hadoop.hdfs.TestDFSFinalize
            hadoop.hdfs.server.namenode.TestSecureNameNode
            hadoop.hdfs.server.namenode.TestFileContextAcl
            hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure000
            hadoop.hdfs.TestFsShellPermission
            hadoop.hdfs.TestDisableConnCache
            hadoop.hdfs.server.namenode.ha.TestFailureOfSharedDir
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotNameWithInvalidCharacters
            hadoop.hdfs.server.blockmanagement.TestBlockManager
            hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
            hadoop.hdfs.server.datanode.TestTransferRbw
            hadoop.hdfs.TestGetFileChecksum
            hadoop.hdfs.server.namenode.ha.TestHAAppend
            hadoop.hdfs.server.namenode.TestFSImageWithAcl
            hadoop.hdfs.TestDFSPermission
            hadoop.hdfs.TestParallelRead
            hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks
            hadoop.hdfs.server.namenode.TestAddBlock
            hadoop.hdfs.server.datanode.TestDnRespectsBlockReportSplitThreshold
            hadoop.hdfs.server.namenode.TestMetaSave
            hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
            hadoop.hdfs.web.TestHttpsFileSystem
            hadoop.hdfs.TestDFSStripedInputStream
            hadoop.hdfs.server.datanode.TestTriggerBlockReport
            hadoop.hdfs.server.namenode.TestEditLog
            hadoop.hdfs.server.namenode.snapshot.TestFileContextSnapshot
            hadoop.hdfs.tools.TestDFSZKFailoverController
            hadoop.hdfs.server.namenode.TestHDFSConcat
            hadoop.hdfs.TestReadStripedFileWithMissingBlocks
            hadoop.hdfs.server.namenode.snapshot.TestAclWithSnapshot
            hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFS
            hadoop.hdfs.server.namenode.TestFSImageWithXAttr
            hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer
            hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs
            hadoop.hdfs.TestRollingUpgrade
            hadoop.hdfs.server.namenode.TestDecommissioningStatus
            hadoop.hdfs.server.namenode.TestAddOverReplicatedStripedBlocks
            hadoop.hdfs.server.namenode.TestQuotaByStorageType
            hadoop.hdfs.server.namenode.snapshot.TestDisallowModifyROSnapshot
            hadoop.hdfs.server.blockmanagement.TestComputeInvalidateWork
            hadoop.hdfs.server.namenode.ha.TestQuotasWithHA
            hadoop.hdfs.qjournal.TestSecureNNWithQJM
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
            hadoop.hdfs.server.namenode.ha.TestInitializeSharedEdits
            hadoop.hdfs.server.namenode.ha.TestHAStateTransitions
            hadoop.hdfs.server.namenode.snapshot.TestSetQuotaWithSnapshot
            hadoop.hdfs.server.namenode.metrics.TestNNMetricFilesInGetListingOps
            hadoop.hdfs.TestBlockReaderFactory
            hadoop.hdfs.TestFetchImage
            hadoop.hdfs.server.namenode.TestNameNodeRecovery
            hadoop.hdfs.TestDistributedFileSystem
            hadoop.hdfs.server.datanode.TestFsDatasetCacheRevocation
            hadoop.hdfs.server.namenode.snapshot.TestSnapshot
            hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
            hadoop.hdfs.TestLease
            hadoop.hdfs.server.namenode.TestProtectedDirectories
            hadoop.hdfs.TestHdfsAdmin
            hadoop.hdfs.server.namenode.snapshot.TestXAttrWithSnapshot
            hadoop.hdfs.server.namenode.TestAuditLogs
            hadoop.hdfs.server.namenode.TestFileTruncate
            hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotMetrics
            hadoop.hdfs.server.namenode.TestEditLogJournalFailures
            hadoop.hdfs.TestDFSMkdirs
            hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistFiles
            hadoop.hdfs.server.namenode.ha.TestPendingCorruptDnMessages
            hadoop.hdfs.server.namenode.TestAddStripedBlocks
            hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate
            hadoop.hdfs.server.namenode.TestAclConfigFlag
            hadoop.hdfs.server.namenode.TestFavoredNodesEndToEnd
            hadoop.hdfs.server.namenode.ha.TestXAttrsWithHA
            hadoop.hdfs.server.namenode.TestBackupNode
            hadoop.hdfs.server.namenode.ha.TestStandbyIsHot
            hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation
            hadoop.hdfs.server.datanode.TestNNHandlesCombinedBlockReport
            hadoop.hdfs.server.namenode.TestCheckpoint
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotListing
            hadoop.hdfs.web.TestWebHdfsWithAuthenticationFilter
            hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
            hadoop.hdfs.server.namenode.TestAuditLogger
            hadoop.hdfs.web.TestWebHDFSAcl
            hadoop.hdfs.TestMissingBlocksAlert
            hadoop.hdfs.TestClose
            hadoop.hdfs.tools.TestDebugAdmin
            hadoop.hdfs.TestFileCorruption
            hadoop.hdfs.server.namenode.TestFsckWithMultipleNameNodes
            hadoop.hdfs.server.namenode.snapshot.TestUpdatePipelineWithSnapshots
            hadoop.hdfs.server.namenode.snapshot.TestSnapshottableDirListing
            hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot
            hadoop.hdfs.server.namenode.TestXAttrConfigFlag
            hadoop.hdfs.server.namenode.TestAuditLogAtDebug
            hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication
            hadoop.hdfs.tools.TestStoragePolicyCommands
            hadoop.hdfs.server.namenode.TestStartup
            hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits
            hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics
            hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead
            hadoop.hdfs.TestQuota
            hadoop.hdfs.server.blockmanagement.TestOverReplicatedBlocks
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.server.blockmanagement.TestPendingReplication
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotDeletion
            hadoop.hdfs.TestCrcCorruption
            hadoop.hdfs.TestFileLengthOnClusterRestart
            hadoop.hdfs.TestFileAppend
            hadoop.hdfs.web.TestWebHDFS
            hadoop.hdfs.web.TestWebHDFSOAuth2
            hadoop.hdfs.server.namenode.TestProcessCorruptBlocks
            hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForAcl
            hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock
            hadoop.hdfs.server.namenode.TestCacheDirectives
            hadoop.hdfs.server.namenode.TestNameNodeMXBean
            hadoop.hdfs.server.namenode.TestLargeDirectoryDelete
            hadoop.hdfs.server.namenode.TestFSImageWithSnapshot
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotBlocksMap
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotRename
            hadoop.hdfs.TestRollingUpgradeRollback
            hadoop.hdfs.server.namenode.TestNameEditsConfigs
            hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped
            hadoop.hdfs.server.datanode.TestNNHandlesBlockReportPerStorage
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotReplication
            hadoop.hdfs.web.TestWebHDFSForHA
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotDiffReport
            hadoop.hdfs.server.namenode.TestHostsFiles
            hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA
            hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotFileLength
            hadoop.hdfs.web.TestFSMainOperationsWebHdfs
            hadoop.hdfs.TestDFSUpgradeFromImage
            hadoop.hdfs.server.namenode.ha.TestFailoverWithBlockTokensEnabled
            hadoop.hdfs.TestPersistBlocks
            hadoop.hdfs.TestListFilesInFileContext
            hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
            hadoop.hdfs.server.namenode.TestSnapshotPathINodes
            hadoop.hdfs.server.namenode.TestSecondaryNameNodeUpgrade
            hadoop.hdfs.server.datanode.TestBlockRecovery
            hadoop.hdfs.security.TestDelegationToken
            hadoop.hdfs.server.namenode.TestBlockUnderConstruction
            hadoop.hdfs.server.namenode.TestINodeAttributeProvider
            hadoop.hdfs.TestParallelShortCircuitReadUnCached
            hadoop.hdfs.TestEncryptionZonesWithKMS
            hadoop.hdfs.TestRead
            hadoop.hdfs.server.namenode.TestRecoverStripedBlocks
            hadoop.hdfs.server.namenode.TestFSNamesystemMBean
            hadoop.hdfs.server.blockmanagement.TestSequentialBlockGroupId
            hadoop.hdfs.web.TestWebHDFSXAttr
            hadoop.hdfs.web.TestWebHdfsTokens
            hadoop.hdfs.server.blockmanagement.TestSequentialBlockId
            hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerWithStripedBlocks
            hadoop.hdfs.TestDFSClientFailover
            hadoop.hdfs.server.namenode.TestStripedINodeFile
            hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotStatsMXBean
            hadoop.hdfs.server.namenode.ha.TestHAMetrics
            hadoop.hdfs.server.namenode.TestFSDirectory
            hadoop.hdfs.server.namenode.TestEditLogAutoroll
            hadoop.hdfs.server.namenode.TestFSImage
            hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistPolicy
            hadoop.hdfs.TestSafeModeWithStripedFile
            hadoop.hdfs.server.datanode.TestBlockScanner
            hadoop.hdfs.server.namenode.ha.TestHAFsck
            hadoop.hdfs.TestFileAppend4
            hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer
            hadoop.hdfs.TestExternalBlockReader
            hadoop.hdfs.server.namenode.snapshot.TestGetContentSummaryWithSnapshot
            hadoop.hdfs.TestFSInputChecker
            hadoop.hdfs.TestParallelShortCircuitRead
            hadoop.hdfs.server.namenode.ha.TestStandbyBlockManagement
            hadoop.hdfs.TestDataTransferKeepalive
            hadoop.hdfs.server.namenode.ha.TestBootstrapStandbyWithQJM
            hadoop.hdfs.server.namenode.TestNameNodeAcl
            hadoop.hdfs.server.namenode.snapshot.TestINodeFileUnderConstructionWithSnapshot
            hadoop.hdfs.server.datanode.fsdataset.impl.TestInterDatanodeProtocol
            hadoop.hdfs.web.TestWebHdfsWithMultipleNameNodes
            hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForXAttr
            hadoop.hdfs.security.token.block.TestBlockToken
            hadoop.hdfs.server.datanode.TestIncrementalBrVariations
            hadoop.hdfs.server.namenode.TestNamenodeRetryCache
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
            hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForContentSummary
            hadoop.hdfs.server.namenode.web.resources.TestWebHdfsDataLocality
            hadoop.hdfs.server.namenode.TestListCorruptFileBlocks
            hadoop.hdfs.server.namenode.ha.TestDNFencing
            hadoop.hdfs.server.namenode.TestFileContextXAttr
          Timed out tests org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestScrLazyPersistFiles



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12766226/HDFS-9184.005.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / c60a16f
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12945/artifact/patchprocess/diffcheckstylehadoop-common.txt https://builds.apache.org/job/PreCommit-HDFS-Build/12945/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
          Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12945/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
          hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/12945/artifact/patchprocess/testrun_hadoop-common.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12945/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12945/testReport/
          Java 1.7.0_55
          uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12945/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 20m 4s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 51s There were no new javac warning messages. +1 javadoc 10m 38s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 50s The applied patch generated 9 new checkstyle issues (total was 225, now 233). -1 checkstyle 2m 31s The applied patch generated 4 new checkstyle issues (total was 651, now 652). +1 whitespace 0m 2s The patch has no lines that end in whitespace. +1 install 1m 28s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. -1 findbugs 4m 31s The patch appears to introduce 2 new Findbugs (version 3.0.0) warnings. -1 common tests 6m 41s Tests failed in hadoop-common. -1 hdfs tests 77m 35s Tests failed in hadoop-hdfs.     132m 25s   Reason Tests FindBugs module:hadoop-hdfs Failed unit tests hadoop.ipc.TestRPC   hadoop.net.TestDNS   hadoop.hdfs.server.namenode.TestINodeFile   hadoop.hdfs.server.datanode.fsdataset.impl.TestDatanodeRestart   hadoop.hdfs.TestFileCreationDelete   hadoop.hdfs.server.namenode.ha.TestHASafeMode   hadoop.hdfs.TestDFSShell   hadoop.hdfs.server.namenode.TestNameNodeXAttr   hadoop.hdfs.shortcircuit.TestShortCircuitCache   hadoop.hdfs.server.namenode.TestFSEditLogLoader   hadoop.hdfs.server.blockmanagement.TestNameNodePrunesMissingStorages   hadoop.hdfs.server.namenode.TestDeleteRace   hadoop.hdfs.server.namenode.TestParallelImageWrite   hadoop.hdfs.server.namenode.TestSaveNamespace   hadoop.hdfs.TestReplaceDatanodeOnFailure   hadoop.hdfs.server.namenode.TestQuotaWithStripedBlocks   hadoop.hdfs.server.namenode.TestFsck   hadoop.hdfs.server.namenode.ha.TestHarFileSystemWithHA   hadoop.hdfs.server.datanode.TestDeleteBlockPool   hadoop.hdfs.server.namenode.TestStorageRestore   hadoop.hdfs.server.namenode.TestFileLimit   hadoop.hdfs.server.blockmanagement.TestNodeCount   hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.server.namenode.snapshot.TestCheckpointsWithSnapshots   hadoop.hdfs.qjournal.TestNNWithQJM   hadoop.hdfs.web.TestWebHdfsFileSystemContract   hadoop.hdfs.TestDFSFinalize   hadoop.hdfs.server.namenode.TestSecureNameNode   hadoop.hdfs.server.namenode.TestFileContextAcl   hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure000   hadoop.hdfs.TestFsShellPermission   hadoop.hdfs.TestDisableConnCache   hadoop.hdfs.server.namenode.ha.TestFailureOfSharedDir   hadoop.hdfs.server.namenode.snapshot.TestSnapshotNameWithInvalidCharacters   hadoop.hdfs.server.blockmanagement.TestBlockManager   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.server.datanode.TestTransferRbw   hadoop.hdfs.TestGetFileChecksum   hadoop.hdfs.server.namenode.ha.TestHAAppend   hadoop.hdfs.server.namenode.TestFSImageWithAcl   hadoop.hdfs.TestDFSPermission   hadoop.hdfs.TestParallelRead   hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks   hadoop.hdfs.server.namenode.TestAddBlock   hadoop.hdfs.server.datanode.TestDnRespectsBlockReportSplitThreshold   hadoop.hdfs.server.namenode.TestMetaSave   hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks   hadoop.hdfs.web.TestHttpsFileSystem   hadoop.hdfs.TestDFSStripedInputStream   hadoop.hdfs.server.datanode.TestTriggerBlockReport   hadoop.hdfs.server.namenode.TestEditLog   hadoop.hdfs.server.namenode.snapshot.TestFileContextSnapshot   hadoop.hdfs.tools.TestDFSZKFailoverController   hadoop.hdfs.server.namenode.TestHDFSConcat   hadoop.hdfs.TestReadStripedFileWithMissingBlocks   hadoop.hdfs.server.namenode.snapshot.TestAclWithSnapshot   hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFS   hadoop.hdfs.server.namenode.TestFSImageWithXAttr   hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer   hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs   hadoop.hdfs.TestRollingUpgrade   hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.hdfs.server.namenode.TestAddOverReplicatedStripedBlocks   hadoop.hdfs.server.namenode.TestQuotaByStorageType   hadoop.hdfs.server.namenode.snapshot.TestDisallowModifyROSnapshot   hadoop.hdfs.server.blockmanagement.TestComputeInvalidateWork   hadoop.hdfs.server.namenode.ha.TestQuotasWithHA   hadoop.hdfs.qjournal.TestSecureNNWithQJM   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting   hadoop.hdfs.server.namenode.ha.TestInitializeSharedEdits   hadoop.hdfs.server.namenode.ha.TestHAStateTransitions   hadoop.hdfs.server.namenode.snapshot.TestSetQuotaWithSnapshot   hadoop.hdfs.server.namenode.metrics.TestNNMetricFilesInGetListingOps   hadoop.hdfs.TestBlockReaderFactory   hadoop.hdfs.TestFetchImage   hadoop.hdfs.server.namenode.TestNameNodeRecovery   hadoop.hdfs.TestDistributedFileSystem   hadoop.hdfs.server.datanode.TestFsDatasetCacheRevocation   hadoop.hdfs.server.namenode.snapshot.TestSnapshot   hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots   hadoop.hdfs.TestLease   hadoop.hdfs.server.namenode.TestProtectedDirectories   hadoop.hdfs.TestHdfsAdmin   hadoop.hdfs.server.namenode.snapshot.TestXAttrWithSnapshot   hadoop.hdfs.server.namenode.TestAuditLogs   hadoop.hdfs.server.namenode.TestFileTruncate   hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints   hadoop.hdfs.server.namenode.snapshot.TestSnapshotMetrics   hadoop.hdfs.server.namenode.TestEditLogJournalFailures   hadoop.hdfs.TestDFSMkdirs   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistFiles   hadoop.hdfs.server.namenode.ha.TestPendingCorruptDnMessages   hadoop.hdfs.server.namenode.TestAddStripedBlocks   hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate   hadoop.hdfs.server.namenode.TestAclConfigFlag   hadoop.hdfs.server.namenode.TestFavoredNodesEndToEnd   hadoop.hdfs.server.namenode.ha.TestXAttrsWithHA   hadoop.hdfs.server.namenode.TestBackupNode   hadoop.hdfs.server.namenode.ha.TestStandbyIsHot   hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation   hadoop.hdfs.server.datanode.TestNNHandlesCombinedBlockReport   hadoop.hdfs.server.namenode.TestCheckpoint   hadoop.hdfs.server.namenode.snapshot.TestSnapshotListing   hadoop.hdfs.web.TestWebHdfsWithAuthenticationFilter   hadoop.hdfs.server.namenode.ha.TestPipelinesFailover   hadoop.hdfs.server.namenode.TestAuditLogger   hadoop.hdfs.web.TestWebHDFSAcl   hadoop.hdfs.TestMissingBlocksAlert   hadoop.hdfs.TestClose   hadoop.hdfs.tools.TestDebugAdmin   hadoop.hdfs.TestFileCorruption   hadoop.hdfs.server.namenode.TestFsckWithMultipleNameNodes   hadoop.hdfs.server.namenode.snapshot.TestUpdatePipelineWithSnapshots   hadoop.hdfs.server.namenode.snapshot.TestSnapshottableDirListing   hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot   hadoop.hdfs.server.namenode.TestXAttrConfigFlag   hadoop.hdfs.server.namenode.TestAuditLogAtDebug   hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication   hadoop.hdfs.tools.TestStoragePolicyCommands   hadoop.hdfs.server.namenode.TestStartup   hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits   hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics   hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead   hadoop.hdfs.TestQuota   hadoop.hdfs.server.blockmanagement.TestOverReplicatedBlocks   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.server.blockmanagement.TestPendingReplication   hadoop.hdfs.server.namenode.snapshot.TestSnapshotDeletion   hadoop.hdfs.TestCrcCorruption   hadoop.hdfs.TestFileLengthOnClusterRestart   hadoop.hdfs.TestFileAppend   hadoop.hdfs.web.TestWebHDFS   hadoop.hdfs.web.TestWebHDFSOAuth2   hadoop.hdfs.server.namenode.TestProcessCorruptBlocks   hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForAcl   hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock   hadoop.hdfs.server.namenode.TestCacheDirectives   hadoop.hdfs.server.namenode.TestNameNodeMXBean   hadoop.hdfs.server.namenode.TestLargeDirectoryDelete   hadoop.hdfs.server.namenode.TestFSImageWithSnapshot   hadoop.hdfs.server.namenode.snapshot.TestSnapshotBlocksMap   hadoop.hdfs.server.namenode.snapshot.TestSnapshotRename   hadoop.hdfs.TestRollingUpgradeRollback   hadoop.hdfs.server.namenode.TestNameEditsConfigs   hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped   hadoop.hdfs.server.datanode.TestNNHandlesBlockReportPerStorage   hadoop.hdfs.server.namenode.snapshot.TestSnapshotReplication   hadoop.hdfs.web.TestWebHDFSForHA   hadoop.hdfs.server.namenode.snapshot.TestSnapshotDiffReport   hadoop.hdfs.server.namenode.TestHostsFiles   hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA   hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots   hadoop.hdfs.server.namenode.snapshot.TestSnapshotFileLength   hadoop.hdfs.web.TestFSMainOperationsWebHdfs   hadoop.hdfs.TestDFSUpgradeFromImage   hadoop.hdfs.server.namenode.ha.TestFailoverWithBlockTokensEnabled   hadoop.hdfs.TestPersistBlocks   hadoop.hdfs.TestListFilesInFileContext   hadoop.hdfs.server.namenode.TestNamenodeCapacityReport   hadoop.hdfs.server.namenode.TestSnapshotPathINodes   hadoop.hdfs.server.namenode.TestSecondaryNameNodeUpgrade   hadoop.hdfs.server.datanode.TestBlockRecovery   hadoop.hdfs.security.TestDelegationToken   hadoop.hdfs.server.namenode.TestBlockUnderConstruction   hadoop.hdfs.server.namenode.TestINodeAttributeProvider   hadoop.hdfs.TestParallelShortCircuitReadUnCached   hadoop.hdfs.TestEncryptionZonesWithKMS   hadoop.hdfs.TestRead   hadoop.hdfs.server.namenode.TestRecoverStripedBlocks   hadoop.hdfs.server.namenode.TestFSNamesystemMBean   hadoop.hdfs.server.blockmanagement.TestSequentialBlockGroupId   hadoop.hdfs.web.TestWebHDFSXAttr   hadoop.hdfs.web.TestWebHdfsTokens   hadoop.hdfs.server.blockmanagement.TestSequentialBlockId   hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerWithStripedBlocks   hadoop.hdfs.TestDFSClientFailover   hadoop.hdfs.server.namenode.TestStripedINodeFile   hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes   hadoop.hdfs.server.namenode.snapshot.TestSnapshotStatsMXBean   hadoop.hdfs.server.namenode.ha.TestHAMetrics   hadoop.hdfs.server.namenode.TestFSDirectory   hadoop.hdfs.server.namenode.TestEditLogAutoroll   hadoop.hdfs.server.namenode.TestFSImage   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistPolicy   hadoop.hdfs.TestSafeModeWithStripedFile   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.namenode.ha.TestHAFsck   hadoop.hdfs.TestFileAppend4   hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer   hadoop.hdfs.TestExternalBlockReader   hadoop.hdfs.server.namenode.snapshot.TestGetContentSummaryWithSnapshot   hadoop.hdfs.TestFSInputChecker   hadoop.hdfs.TestParallelShortCircuitRead   hadoop.hdfs.server.namenode.ha.TestStandbyBlockManagement   hadoop.hdfs.TestDataTransferKeepalive   hadoop.hdfs.server.namenode.ha.TestBootstrapStandbyWithQJM   hadoop.hdfs.server.namenode.TestNameNodeAcl   hadoop.hdfs.server.namenode.snapshot.TestINodeFileUnderConstructionWithSnapshot   hadoop.hdfs.server.datanode.fsdataset.impl.TestInterDatanodeProtocol   hadoop.hdfs.web.TestWebHdfsWithMultipleNameNodes   hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForXAttr   hadoop.hdfs.security.token.block.TestBlockToken   hadoop.hdfs.server.datanode.TestIncrementalBrVariations   hadoop.hdfs.server.namenode.TestNamenodeRetryCache   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForContentSummary   hadoop.hdfs.server.namenode.web.resources.TestWebHdfsDataLocality   hadoop.hdfs.server.namenode.TestListCorruptFileBlocks   hadoop.hdfs.server.namenode.ha.TestDNFencing   hadoop.hdfs.server.namenode.TestFileContextXAttr Timed out tests org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestScrLazyPersistFiles Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12766226/HDFS-9184.005.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / c60a16f checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12945/artifact/patchprocess/diffcheckstylehadoop-common.txt https://builds.apache.org/job/PreCommit-HDFS-Build/12945/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12945/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/12945/artifact/patchprocess/testrun_hadoop-common.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12945/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12945/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12945/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 19m 48s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 7m 57s There were no new javac warning messages.
          +1 javadoc 10m 20s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 48s The applied patch generated 9 new checkstyle issues (total was 225, now 233).
          +1 whitespace 0m 1s The patch has no lines that end in whitespace.
          +1 install 1m 39s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          -1 findbugs 4m 26s The patch appears to introduce 2 new Findbugs (version 3.0.0) warnings.
          -1 common tests 6m 34s Tests failed in hadoop-common.
          +1 hdfs tests 49m 15s Tests passed in hadoop-hdfs.
              103m 7s  



          Reason Tests
          FindBugs module:hadoop-hdfs
          Failed unit tests hadoop.net.TestDNS



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12766226/HDFS-9184.005.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 6716f15
          Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12958/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12958/artifact/patchprocess/diffcheckstylehadoop-common.txt
          Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12958/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
          hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/12958/artifact/patchprocess/testrun_hadoop-common.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12958/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12958/testReport/
          Java 1.7.0_55
          uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12958/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 19m 48s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 57s There were no new javac warning messages. +1 javadoc 10m 20s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 48s The applied patch generated 9 new checkstyle issues (total was 225, now 233). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 39s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. -1 findbugs 4m 26s The patch appears to introduce 2 new Findbugs (version 3.0.0) warnings. -1 common tests 6m 34s Tests failed in hadoop-common. +1 hdfs tests 49m 15s Tests passed in hadoop-hdfs.     103m 7s   Reason Tests FindBugs module:hadoop-hdfs Failed unit tests hadoop.net.TestDNS Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12766226/HDFS-9184.005.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 6716f15 Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12958/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12958/artifact/patchprocess/diffcheckstylehadoop-common.txt Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12958/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/12958/artifact/patchprocess/testrun_hadoop-common.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12958/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12958/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12958/console This message was automatically generated.
          Hide
          liuml07 Mingliang Liu added a comment -

          The v6 patch fixes checkstyle and findbugs warnings.

          Show
          liuml07 Mingliang Liu added a comment - The v6 patch fixes checkstyle and findbugs warnings.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 30m 43s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 12m 14s There were no new javac warning messages.
          +1 javadoc 15m 47s There were no new javadoc warning messages.
          -1 release audit 0m 30s The applied patch generated 1 release audit warnings.
          -1 checkstyle 2m 54s The applied patch generated 3 new checkstyle issues (total was 226, now 228).
          +1 whitespace 0m 2s The patch has no lines that end in whitespace.
          +1 install 2m 31s mvn install still works.
          +1 eclipse:eclipse 0m 52s The patch built with eclipse:eclipse.
          +1 findbugs 6m 55s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          -1 common tests 9m 21s Tests failed in hadoop-common.
          -1 hdfs tests 66m 33s Tests failed in hadoop-hdfs.
              148m 52s  



          Reason Tests
          Failed unit tests hadoop.fs.TestLocalFsFCStatistics
            hadoop.ha.TestZKFailoverController
            hadoop.metrics2.impl.TestMetricsSystemImpl
            hadoop.security.ssl.TestReloadingX509TrustManager
            hadoop.test.TestTimedOutTestsListener
            hadoop.fs.TestGlobPaths
            hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.TestReplaceDatanodeOnFailure
            hadoop.hdfs.TestEncryptionZones
          Timed out tests org.apache.hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
            org.apache.hadoop.hdfs.server.namenode.TestNameEditsConfigs
            org.apache.hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
            org.apache.hadoop.hdfs.server.namenode.TestFavoredNodesEndToEnd



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12766693/HDFS-9184.006.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / be7a0ad
          Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12997/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
          Release Audit https://builds.apache.org/job/PreCommit-HDFS-Build/12997/artifact/patchprocess/patchReleaseAuditProblems.txt
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12997/artifact/patchprocess/diffcheckstylehadoop-common.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/12997/artifact/patchprocess/testrun_hadoop-common.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12997/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12997/testReport/
          Java 1.7.0_55
          uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12997/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 30m 43s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 12m 14s There were no new javac warning messages. +1 javadoc 15m 47s There were no new javadoc warning messages. -1 release audit 0m 30s The applied patch generated 1 release audit warnings. -1 checkstyle 2m 54s The applied patch generated 3 new checkstyle issues (total was 226, now 228). +1 whitespace 0m 2s The patch has no lines that end in whitespace. +1 install 2m 31s mvn install still works. +1 eclipse:eclipse 0m 52s The patch built with eclipse:eclipse. +1 findbugs 6m 55s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 common tests 9m 21s Tests failed in hadoop-common. -1 hdfs tests 66m 33s Tests failed in hadoop-hdfs.     148m 52s   Reason Tests Failed unit tests hadoop.fs.TestLocalFsFCStatistics   hadoop.ha.TestZKFailoverController   hadoop.metrics2.impl.TestMetricsSystemImpl   hadoop.security.ssl.TestReloadingX509TrustManager   hadoop.test.TestTimedOutTestsListener   hadoop.fs.TestGlobPaths   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.TestReplaceDatanodeOnFailure   hadoop.hdfs.TestEncryptionZones Timed out tests org.apache.hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints   org.apache.hadoop.hdfs.server.namenode.TestNameEditsConfigs   org.apache.hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA   org.apache.hadoop.hdfs.server.namenode.TestFavoredNodesEndToEnd Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12766693/HDFS-9184.006.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / be7a0ad Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12997/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html Release Audit https://builds.apache.org/job/PreCommit-HDFS-Build/12997/artifact/patchprocess/patchReleaseAuditProblems.txt checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12997/artifact/patchprocess/diffcheckstylehadoop-common.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/12997/artifact/patchprocess/testrun_hadoop-common.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12997/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12997/testReport/ Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12997/console This message was automatically generated.
          Hide
          jnp Jitendra Nath Pandey added a comment -

          Mingliang Liu, I think the InterfaceAudience should be marked as LimitedPrivate for now for some of the projects in the ecosystem, particularly other hadoop components, hive, hbase. Also, please set annotation InterfaceStability as evolving, so that we have room to change the interface if needed.

          Apart from the above the patch looks good to me. +1

          The feature is disabled by default therefore, there is no change to audit log at all. Allen Wittenauer, are you ok to withdraw your veto for commit to branch-2?

          Show
          jnp Jitendra Nath Pandey added a comment - Mingliang Liu , I think the InterfaceAudience should be marked as LimitedPrivate for now for some of the projects in the ecosystem, particularly other hadoop components, hive, hbase. Also, please set annotation InterfaceStability as evolving, so that we have room to change the interface if needed. Apart from the above the patch looks good to me. +1 The feature is disabled by default therefore, there is no change to audit log at all. Allen Wittenauer , are you ok to withdraw your veto for commit to branch-2?
          Hide
          jnp Jitendra Nath Pandey added a comment -

          Mingliang Liu, I think it will be a good idea to move the new configurations to common instead of having them in hdfs, because CallerContext is defined in common.

          Show
          jnp Jitendra Nath Pandey added a comment - Mingliang Liu , I think it will be a good idea to move the new configurations to common instead of having them in hdfs, because CallerContext is defined in common.
          Hide
          liuml07 Mingliang Liu added a comment -

          Thanks for your view, Jitendra Nath Pandey. The v7 patch addresses the latest comments.

          Show
          liuml07 Mingliang Liu added a comment - Thanks for your view, Jitendra Nath Pandey . The v7 patch addresses the latest comments.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 35m 12s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 15m 18s There were no new javac warning messages.
          +1 javadoc 22m 22s There were no new javadoc warning messages.
          +1 release audit 1m 11s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 3m 24s The applied patch generated 3 new checkstyle issues (total was 403, now 405).
          +1 whitespace 0m 3s The patch has no lines that end in whitespace.
          +1 install 3m 20s mvn install still works.
          +1 eclipse:eclipse 1m 13s The patch built with eclipse:eclipse.
          +1 findbugs 8m 16s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          -1 common tests 18m 12s Tests failed in hadoop-common.
          -1 hdfs tests 62m 1s Tests failed in hadoop-hdfs.
              171m 10s  



          Reason Tests
          Failed unit tests hadoop.fs.shell.find.TestIname
            hadoop.fs.shell.find.TestFind
            hadoop.ipc.TestIPC
            hadoop.security.token.delegation.TestZKDelegationTokenSecretManager
            hadoop.fs.shell.find.TestPrint0
            hadoop.fs.shell.find.TestPrint
            hadoop.hdfs.tools.TestDFSZKFailoverController
            hadoop.hdfs.server.namenode.TestFileTruncate
          Timed out tests org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure
            org.apache.hadoop.hdfs.TestConnCache
            org.apache.hadoop.hdfs.TestSetrepDecreasing
            org.apache.hadoop.hdfs.TestEncryptedTransfer



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12766871/HDFS-9184.007.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 8d2d3eb
          Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13012/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/13012/artifact/patchprocess/diffcheckstylehadoop-common.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/13012/artifact/patchprocess/testrun_hadoop-common.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13012/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13012/testReport/
          Java 1.7.0_55
          uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13012/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 35m 12s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 15m 18s There were no new javac warning messages. +1 javadoc 22m 22s There were no new javadoc warning messages. +1 release audit 1m 11s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 3m 24s The applied patch generated 3 new checkstyle issues (total was 403, now 405). +1 whitespace 0m 3s The patch has no lines that end in whitespace. +1 install 3m 20s mvn install still works. +1 eclipse:eclipse 1m 13s The patch built with eclipse:eclipse. +1 findbugs 8m 16s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 common tests 18m 12s Tests failed in hadoop-common. -1 hdfs tests 62m 1s Tests failed in hadoop-hdfs.     171m 10s   Reason Tests Failed unit tests hadoop.fs.shell.find.TestIname   hadoop.fs.shell.find.TestFind   hadoop.ipc.TestIPC   hadoop.security.token.delegation.TestZKDelegationTokenSecretManager   hadoop.fs.shell.find.TestPrint0   hadoop.fs.shell.find.TestPrint   hadoop.hdfs.tools.TestDFSZKFailoverController   hadoop.hdfs.server.namenode.TestFileTruncate Timed out tests org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure   org.apache.hadoop.hdfs.TestConnCache   org.apache.hadoop.hdfs.TestSetrepDecreasing   org.apache.hadoop.hdfs.TestEncryptedTransfer Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12766871/HDFS-9184.007.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 8d2d3eb Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13012/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/13012/artifact/patchprocess/diffcheckstylehadoop-common.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/13012/artifact/patchprocess/testrun_hadoop-common.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13012/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13012/testReport/ Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13012/console This message was automatically generated.
          Hide
          liuml07 Mingliang Liu added a comment -

          The failing tests seem unrelated and can pass locally (Gentoo Linux and Mac).

          Show
          liuml07 Mingliang Liu added a comment - The failing tests seem unrelated and can pass locally (Gentoo Linux and Mac).
          Hide
          jnp Jitendra Nath Pandey added a comment -

          +1

          Show
          jnp Jitendra Nath Pandey added a comment - +1
          Hide
          jnp Jitendra Nath Pandey added a comment -

          I will commit it to trunk if there are no objections.
          Allen Wittenauer, I think the latest patch addresses your concern of change in audit log by keeping it disabled by default. If you are ok, I would like to commit this to branch-2 as well.

          Show
          jnp Jitendra Nath Pandey added a comment - I will commit it to trunk if there are no objections. Allen Wittenauer , I think the latest patch addresses your concern of change in audit log by keeping it disabled by default. If you are ok, I would like to commit this to branch-2 as well.
          Hide
          daijy Daniel Dai added a comment -

          If we want to impose a limitation on the length, it is better to impose on the client side explicitly rather than silently truncate on datanode. This id will be used in other components for cross reference. If hdfs audit log shows a truncated id, it would be hard to cross reference to logs of other components.

          Show
          daijy Daniel Dai added a comment - If we want to impose a limitation on the length, it is better to impose on the client side explicitly rather than silently truncate on datanode. This id will be used in other components for cross reference. If hdfs audit log shows a truncated id, it would be hard to cross reference to logs of other components.
          Hide
          liuml07 Mingliang Liu added a comment -

          Thanks for your comment Daniel Dai. To address this, I think we have several options.

          1. One is that we set the max length of caller context as 128 bytes. The CallerContext.Builder will throw an exception if end user is trying to set a longer context of >128 bytes length. It works just fine if we won't miss the configurability.
          2. Another approach is to validate the length when we create a RPC Client$Connection. We can either truncate the caller context and log a warning, or we can throw an exception. We may have to change the ProtoUtils#makeRpcRequestHeader for this validation, as we need to read the config keys.
          Show
          liuml07 Mingliang Liu added a comment - Thanks for your comment Daniel Dai . To address this, I think we have several options. One is that we set the max length of caller context as 128 bytes. The CallerContext.Builder will throw an exception if end user is trying to set a longer context of >128 bytes length. It works just fine if we won't miss the configurability . Another approach is to validate the length when we create a RPC Client$Connection . We can either truncate the caller context and log a warning, or we can throw an exception. We may have to change the ProtoUtils#makeRpcRequestHeader for this validation, as we need to read the config keys.
          Hide
          liuml07 Mingliang Liu added a comment -

          Per offline discussion, the signature is changed from String to byte[]. We also use LogCapture for testing end-to-end caller context logging.

          Show
          liuml07 Mingliang Liu added a comment - Per offline discussion, the signature is changed from String to byte[] . We also use LogCapture for testing end-to-end caller context logging.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 21m 18s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 8m 38s There were no new javac warning messages.
          +1 javadoc 11m 2s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 57s The applied patch generated 5 new checkstyle issues (total was 402, now 406).
          +1 whitespace 0m 2s The patch has no lines that end in whitespace.
          +1 install 1m 46s mvn install still works.
          +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse.
          +1 findbugs 4m 44s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 8m 19s Tests passed in hadoop-common.
          -1 hdfs tests 66m 58s Tests failed in hadoop-hdfs.
              126m 4s  



          Reason Tests
          Failed unit tests hadoop.hdfs.TestReplaceDatanodeOnFailure
            hadoop.hdfs.server.datanode.TestFsDatasetCache
            hadoop.hdfs.server.namenode.ha.TestEditLogTailer
            hadoop.hdfs.shortcircuit.TestShortCircuitCache
            hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12767223/HDFS-9184.008.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 58590fe
          Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13039/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/13039/artifact/patchprocess/diffcheckstylehadoop-common.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/13039/artifact/patchprocess/testrun_hadoop-common.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13039/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13039/testReport/
          Java 1.7.0_55
          uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13039/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 21m 18s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 8m 38s There were no new javac warning messages. +1 javadoc 11m 2s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 57s The applied patch generated 5 new checkstyle issues (total was 402, now 406). +1 whitespace 0m 2s The patch has no lines that end in whitespace. +1 install 1m 46s mvn install still works. +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse. +1 findbugs 4m 44s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 8m 19s Tests passed in hadoop-common. -1 hdfs tests 66m 58s Tests failed in hadoop-hdfs.     126m 4s   Reason Tests Failed unit tests hadoop.hdfs.TestReplaceDatanodeOnFailure   hadoop.hdfs.server.datanode.TestFsDatasetCache   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.shortcircuit.TestShortCircuitCache   hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12767223/HDFS-9184.008.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 58590fe Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13039/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/13039/artifact/patchprocess/diffcheckstylehadoop-common.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/13039/artifact/patchprocess/testrun_hadoop-common.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13039/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13039/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13039/console This message was automatically generated.
          Hide
          liuml07 Mingliang Liu added a comment -

          The failing tests seem unrelated and can pass locally (Linux and Mac).

          Show
          liuml07 Mingliang Liu added a comment - The failing tests seem unrelated and can pass locally (Linux and Mac).
          Hide
          liuml07 Mingliang Liu added a comment -

          The v9 patch rebases from trunk branch and resolves trivial conflicts.

          Show
          liuml07 Mingliang Liu added a comment - The v9 patch rebases from trunk branch and resolves trivial conflicts.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 19m 43s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 7m 50s There were no new javac warning messages.
          +1 javadoc 10m 20s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 51s The applied patch generated 5 new checkstyle issues (total was 402, now 406).
          +1 whitespace 0m 1s The patch has no lines that end in whitespace.
          +1 install 1m 42s mvn install still works.
          +1 eclipse:eclipse 0m 43s The patch built with eclipse:eclipse.
          +1 findbugs 4m 44s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          -1 common tests 5m 54s Tests failed in hadoop-common.
          -1 hdfs tests 49m 17s Tests failed in hadoop-hdfs.
              102m 51s  



          Reason Tests
          Failed unit tests hadoop.metrics2.sink.TestFileSink
          Timed out tests org.apache.hadoop.util.TestDataChecksum
            org.apache.hadoop.io.compress.TestCodec
            org.apache.hadoop.crypto.TestCryptoStreamsWithJceAesCtrCryptoCodec
            org.apache.hadoop.crypto.TestCryptoStreams
            org.apache.hadoop.hdfs.TestFileAppend4
            org.apache.hadoop.hdfs.TestEncryptionZonesWithKMS
            org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010
            org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure000



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12768219/HDFS-9184.009.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 124a412
          Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13147/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/13147/artifact/patchprocess/diffcheckstylehadoop-common.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/13147/artifact/patchprocess/testrun_hadoop-common.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13147/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13147/testReport/
          Java 1.7.0_55
          uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13147/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 19m 43s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 50s There were no new javac warning messages. +1 javadoc 10m 20s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 51s The applied patch generated 5 new checkstyle issues (total was 402, now 406). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 42s mvn install still works. +1 eclipse:eclipse 0m 43s The patch built with eclipse:eclipse. +1 findbugs 4m 44s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 common tests 5m 54s Tests failed in hadoop-common. -1 hdfs tests 49m 17s Tests failed in hadoop-hdfs.     102m 51s   Reason Tests Failed unit tests hadoop.metrics2.sink.TestFileSink Timed out tests org.apache.hadoop.util.TestDataChecksum   org.apache.hadoop.io.compress.TestCodec   org.apache.hadoop.crypto.TestCryptoStreamsWithJceAesCtrCryptoCodec   org.apache.hadoop.crypto.TestCryptoStreams   org.apache.hadoop.hdfs.TestFileAppend4   org.apache.hadoop.hdfs.TestEncryptionZonesWithKMS   org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010   org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure000 Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12768219/HDFS-9184.009.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 124a412 Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13147/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/13147/artifact/patchprocess/diffcheckstylehadoop-common.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/13147/artifact/patchprocess/testrun_hadoop-common.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13147/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13147/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13147/console This message was automatically generated.
          Hide
          liuml07 Mingliang Liu added a comment -

          The failing tests can pass locally (Linux and Mac), and seem unrelated.

          Show
          liuml07 Mingliang Liu added a comment - The failing tests can pass locally (Linux and Mac), and seem unrelated.
          Hide
          jnp Jitendra Nath Pandey added a comment -

          I think any check at the client side can be followed up as a separate jira. It is not so critical, because rogue clients can circumvent a client side check anyway.

          +1 for the latest patch.
          I also plan to commit it to branch-2, because this patch doesn't change the audit logs at all, unless explicitly enabled.

          Show
          jnp Jitendra Nath Pandey added a comment - I think any check at the client side can be followed up as a separate jira. It is not so critical, because rogue clients can circumvent a client side check anyway. +1 for the latest patch. I also plan to commit it to branch-2, because this patch doesn't change the audit logs at all, unless explicitly enabled.
          Hide
          aw Allen Wittenauer added a comment -

          changing my vote to 0.

          Show
          aw Allen Wittenauer added a comment - changing my vote to 0.
          Hide
          jnp Jitendra Nath Pandey added a comment -

          I have committed this to trunk and branch-2. Thanks to Mingliang Liu.

          Show
          jnp Jitendra Nath Pandey added a comment - I have committed this to trunk and branch-2. Thanks to Mingliang Liu.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8697 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8697/)
          HDFS-9184. Logging HDFS operation's caller context into audit logs. (jitendra: rev 600ad7bf4104bcaeec00a4089d59bb1fdf423299)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ProtoUtil.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogger.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogAtDebug.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/HdfsAuditLogger.java
          • hadoop-common-project/hadoop-common/src/main/proto/RpcHeader.proto
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8697 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8697/ ) HDFS-9184 . Logging HDFS operation's caller context into audit logs. (jitendra: rev 600ad7bf4104bcaeec00a4089d59bb1fdf423299) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ProtoUtil.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogger.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogAtDebug.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/HdfsAuditLogger.java hadoop-common-project/hadoop-common/src/main/proto/RpcHeader.proto
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #576 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/576/)
          HDFS-9184. Logging HDFS operation's caller context into audit logs. (jitendra: rev 600ad7bf4104bcaeec00a4089d59bb1fdf423299)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • hadoop-common-project/hadoop-common/src/main/proto/RpcHeader.proto
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogAtDebug.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogger.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/HdfsAuditLogger.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ProtoUtil.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #576 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/576/ ) HDFS-9184 . Logging HDFS operation's caller context into audit logs. (jitendra: rev 600ad7bf4104bcaeec00a4089d59bb1fdf423299) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java hadoop-common-project/hadoop-common/src/main/proto/RpcHeader.proto hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogAtDebug.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogger.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/HdfsAuditLogger.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ProtoUtil.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #589 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/589/)
          HDFS-9184. Logging HDFS operation's caller context into audit logs. (jitendra: rev 600ad7bf4104bcaeec00a4089d59bb1fdf423299)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/HdfsAuditLogger.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogger.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ProtoUtil.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogAtDebug.java
          • hadoop-common-project/hadoop-common/src/main/proto/RpcHeader.proto
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #589 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/589/ ) HDFS-9184 . Logging HDFS operation's caller context into audit logs. (jitendra: rev 600ad7bf4104bcaeec00a4089d59bb1fdf423299) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/HdfsAuditLogger.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogger.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ProtoUtil.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogAtDebug.java hadoop-common-project/hadoop-common/src/main/proto/RpcHeader.proto hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1312 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1312/)
          HDFS-9184. Logging HDFS operation's caller context into audit logs. (jitendra: rev 600ad7bf4104bcaeec00a4089d59bb1fdf423299)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/HdfsAuditLogger.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ProtoUtil.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogger.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogAtDebug.java
          • hadoop-common-project/hadoop-common/src/main/proto/RpcHeader.proto
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1312 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1312/ ) HDFS-9184 . Logging HDFS operation's caller context into audit logs. (jitendra: rev 600ad7bf4104bcaeec00a4089d59bb1fdf423299) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/HdfsAuditLogger.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ProtoUtil.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogger.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogAtDebug.java hadoop-common-project/hadoop-common/src/main/proto/RpcHeader.proto hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2521 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2521/)
          HDFS-9184. Logging HDFS operation's caller context into audit logs. (jitendra: rev 600ad7bf4104bcaeec00a4089d59bb1fdf423299)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • hadoop-common-project/hadoop-common/src/main/proto/RpcHeader.proto
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/HdfsAuditLogger.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ProtoUtil.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogger.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogAtDebug.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2521 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2521/ ) HDFS-9184 . Logging HDFS operation's caller context into audit logs. (jitendra: rev 600ad7bf4104bcaeec00a4089d59bb1fdf423299) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-common-project/hadoop-common/src/main/proto/RpcHeader.proto hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/HdfsAuditLogger.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ProtoUtil.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogger.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogAtDebug.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #531 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/531/)
          HDFS-9184. Logging HDFS operation's caller context into audit logs. (jitendra: rev 600ad7bf4104bcaeec00a4089d59bb1fdf423299)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ProtoUtil.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • hadoop-common-project/hadoop-common/src/main/proto/RpcHeader.proto
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogger.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/HdfsAuditLogger.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogAtDebug.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #531 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/531/ ) HDFS-9184 . Logging HDFS operation's caller context into audit logs. (jitendra: rev 600ad7bf4104bcaeec00a4089d59bb1fdf423299) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ProtoUtil.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-common-project/hadoop-common/src/main/proto/RpcHeader.proto hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogger.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/HdfsAuditLogger.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogAtDebug.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2467 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2467/)
          HDFS-9184. Logging HDFS operation's caller context into audit logs. (jitendra: rev 600ad7bf4104bcaeec00a4089d59bb1fdf423299)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogAtDebug.java
          • hadoop-common-project/hadoop-common/src/main/proto/RpcHeader.proto
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ProtoUtil.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogger.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/HdfsAuditLogger.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2467 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2467/ ) HDFS-9184 . Logging HDFS operation's caller context into audit logs. (jitendra: rev 600ad7bf4104bcaeec00a4089d59bb1fdf423299) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogAtDebug.java hadoop-common-project/hadoop-common/src/main/proto/RpcHeader.proto hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ProtoUtil.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogger.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/HdfsAuditLogger.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java
          Hide
          cnauroth Chris Nauroth added a comment -

          The new tests written for this patch assume Unix line endings, and therefore they fail when run on Windows. I have submitted a patch on HDFS-9362 to fix this.

          Show
          cnauroth Chris Nauroth added a comment - The new tests written for this patch assume Unix line endings, and therefore they fail when run on Windows. I have submitted a patch on HDFS-9362 to fix this.

            People

            • Assignee:
              liuml07 Mingliang Liu
              Reporter:
              liuml07 Mingliang Liu
            • Votes:
              0 Vote for this issue
              Watchers:
              35 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development