Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The caller context with empty context string is considered invalid, and it should not appear in the audit log.

      Meanwhile, too long signature will not be written to audit log.

      1. HDFS-9343.004.patch
        6 kB
        Mingliang Liu
      2. HDFS-9343.003.patch
        6 kB
        Mingliang Liu
      3. HDFS-9343.002.patch
        5 kB
        Mingliang Liu
      4. HDFS-9343.001.patch
        5 kB
        Mingliang Liu
      5. HDFS-9343.000.patch
        4 kB
        Mingliang Liu

        Issue Links

          Activity

          Hide
          cnauroth Chris Nauroth added a comment -

          The new tests written for this patch assume Unix line endings, and therefore they fail when run on Windows. I have submitted a patch on HDFS-9362 to fix this.

          Show
          cnauroth Chris Nauroth added a comment - The new tests written for this patch assume Unix line endings, and therefore they fail when run on Windows. I have submitted a patch on HDFS-9362 to fix this.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #561 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/561/)
          HDFS-9343. Empty caller context considered invalid. (Contributed by (arp: rev 3cde6931cb5055a9d92503f4ecefa35571e7b07f)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogger.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ProtoUtil.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #561 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/561/ ) HDFS-9343 . Empty caller context considered invalid. (Contributed by (arp: rev 3cde6931cb5055a9d92503f4ecefa35571e7b07f) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogger.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ProtoUtil.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2498 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2498/)
          HDFS-9343. Empty caller context considered invalid. (Contributed by (arp: rev 3cde6931cb5055a9d92503f4ecefa35571e7b07f)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ProtoUtil.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogger.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2498 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2498/ ) HDFS-9343 . Empty caller context considered invalid. (Contributed by (arp: rev 3cde6931cb5055a9d92503f4ecefa35571e7b07f) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ProtoUtil.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogger.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          Hide
          liuml07 Mingliang Liu added a comment -

          Thanks Arpit Agarwal for your review and commit.

          Show
          liuml07 Mingliang Liu added a comment - Thanks Arpit Agarwal for your review and commit.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #613 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/613/)
          HDFS-9343. Empty caller context considered invalid. (Contributed by (arp: rev 3cde6931cb5055a9d92503f4ecefa35571e7b07f)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogger.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ProtoUtil.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #613 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/613/ ) HDFS-9343 . Empty caller context considered invalid. (Contributed by (arp: rev 3cde6931cb5055a9d92503f4ecefa35571e7b07f) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogger.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ProtoUtil.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #625 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/625/)
          HDFS-9343. Empty caller context considered invalid. (Contributed by (arp: rev 3cde6931cb5055a9d92503f4ecefa35571e7b07f)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogger.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ProtoUtil.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #625 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/625/ ) HDFS-9343 . Empty caller context considered invalid. (Contributed by (arp: rev 3cde6931cb5055a9d92503f4ecefa35571e7b07f) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogger.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ProtoUtil.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2555 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2555/)
          HDFS-9343. Empty caller context considered invalid. (Contributed by (arp: rev 3cde6931cb5055a9d92503f4ecefa35571e7b07f)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogger.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ProtoUtil.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2555 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2555/ ) HDFS-9343 . Empty caller context considered invalid. (Contributed by (arp: rev 3cde6931cb5055a9d92503f4ecefa35571e7b07f) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogger.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ProtoUtil.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1348 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1348/)
          HDFS-9343. Empty caller context considered invalid. (Contributed by (arp: rev 3cde6931cb5055a9d92503f4ecefa35571e7b07f)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ProtoUtil.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogger.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1348 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1348/ ) HDFS-9343 . Empty caller context considered invalid. (Contributed by (arp: rev 3cde6931cb5055a9d92503f4ecefa35571e7b07f) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ProtoUtil.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogger.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8739 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8739/)
          HDFS-9343. Empty caller context considered invalid. (Contributed by (arp: rev 3cde6931cb5055a9d92503f4ecefa35571e7b07f)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogger.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ProtoUtil.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8739 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8739/ ) HDFS-9343 . Empty caller context considered invalid. (Contributed by (arp: rev 3cde6931cb5055a9d92503f4ecefa35571e7b07f) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogger.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ProtoUtil.java
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Committed for 2.8.0. Thanks for the contribution Mingliang Liu and reviews Jitendra Nath Pandey and Hitesh Shah.

          Show
          arpitagarwal Arpit Agarwal added a comment - Committed for 2.8.0. Thanks for the contribution Mingliang Liu and reviews Jitendra Nath Pandey and Hitesh Shah .
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          The test failures look unrelated, the failed tests passed for me locally. I will commit this shortly.

          Show
          arpitagarwal Arpit Agarwal added a comment - The test failures look unrelated, the failed tests passed for me locally. I will commit this shortly.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 6s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 3m 11s trunk passed
          +1 compile 5m 0s trunk passed with JDK v1.8.0_60
          +1 compile 4m 47s trunk passed with JDK v1.7.0_79
          +1 checkstyle 1m 6s trunk passed
          +1 mvneclipse 0m 30s trunk passed
          -1 findbugs 2m 10s hadoop-hdfs-project/hadoop-hdfs in trunk cannot run convertXmlToText from findbugs
          +1 javadoc 2m 21s trunk passed with JDK v1.8.0_60
          +1 javadoc 3m 12s trunk passed with JDK v1.7.0_79
          +1 mvninstall 2m 14s the patch passed
          +1 compile 4m 58s the patch passed with JDK v1.8.0_60
          +1 javac 4m 58s the patch passed
          +1 compile 4m 47s the patch passed with JDK v1.7.0_79
          +1 javac 4m 47s the patch passed
          +1 checkstyle 1m 4s the patch passed
          +1 mvneclipse 0m 31s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 4m 26s the patch passed
          +1 javadoc 2m 17s the patch passed with JDK v1.8.0_60
          +1 javadoc 3m 10s the patch passed with JDK v1.7.0_79
          -1 unit 19m 33s hadoop-common in the patch failed with JDK v1.8.0_60.
          -1 unit 64m 19s hadoop-hdfs in the patch failed with JDK v1.8.0_60.
          -1 unit 7m 50s hadoop-common in the patch failed with JDK v1.7.0_79.
          -1 unit 59m 40s hadoop-hdfs in the patch failed with JDK v1.7.0_79.
          -1 asflicense 0m 22s Patch generated 58 ASF License warnings.
          200m 52s



          Reason Tests
          JDK v1.8.0_60 Failed junit tests hadoop.ipc.TestDecayRpcScheduler
            hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
          JDK v1.8.0_60 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle
          JDK v1.7.0_79 Failed junit tests hadoop.ipc.TestIPC
            hadoop.metrics2.impl.TestGangliaMetrics
            hadoop.hdfs.server.datanode.TestFsDatasetCache
            hadoop.hdfs.server.blockmanagement.TestNodeCount
            hadoop.hdfs.TestEncryptionZones
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure140



          Subsystem Report/Notes
          Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-31
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12769964/HDFS-9343.004.patch
          JIRA Issue HDFS-9343
          Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
          uname Linux ff1afb11d4b7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/patchprocess/apache-yetus-e77b1ce/precommit/personality/hadoop.sh
          git revision trunk / 7fd6416
          Default Java 1.7.0_79
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/13319/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13319/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13319/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_60.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13319/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13319/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13319/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13319/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13319/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13319/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13319/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13319/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Max memory used 228MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13319/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 6s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 3m 11s trunk passed +1 compile 5m 0s trunk passed with JDK v1.8.0_60 +1 compile 4m 47s trunk passed with JDK v1.7.0_79 +1 checkstyle 1m 6s trunk passed +1 mvneclipse 0m 30s trunk passed -1 findbugs 2m 10s hadoop-hdfs-project/hadoop-hdfs in trunk cannot run convertXmlToText from findbugs +1 javadoc 2m 21s trunk passed with JDK v1.8.0_60 +1 javadoc 3m 12s trunk passed with JDK v1.7.0_79 +1 mvninstall 2m 14s the patch passed +1 compile 4m 58s the patch passed with JDK v1.8.0_60 +1 javac 4m 58s the patch passed +1 compile 4m 47s the patch passed with JDK v1.7.0_79 +1 javac 4m 47s the patch passed +1 checkstyle 1m 4s the patch passed +1 mvneclipse 0m 31s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 4m 26s the patch passed +1 javadoc 2m 17s the patch passed with JDK v1.8.0_60 +1 javadoc 3m 10s the patch passed with JDK v1.7.0_79 -1 unit 19m 33s hadoop-common in the patch failed with JDK v1.8.0_60. -1 unit 64m 19s hadoop-hdfs in the patch failed with JDK v1.8.0_60. -1 unit 7m 50s hadoop-common in the patch failed with JDK v1.7.0_79. -1 unit 59m 40s hadoop-hdfs in the patch failed with JDK v1.7.0_79. -1 asflicense 0m 22s Patch generated 58 ASF License warnings. 200m 52s Reason Tests JDK v1.8.0_60 Failed junit tests hadoop.ipc.TestDecayRpcScheduler   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes JDK v1.8.0_60 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle JDK v1.7.0_79 Failed junit tests hadoop.ipc.TestIPC   hadoop.metrics2.impl.TestGangliaMetrics   hadoop.hdfs.server.datanode.TestFsDatasetCache   hadoop.hdfs.server.blockmanagement.TestNodeCount   hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure140 Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-31 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12769964/HDFS-9343.004.patch JIRA Issue HDFS-9343 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux ff1afb11d4b7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/patchprocess/apache-yetus-e77b1ce/precommit/personality/hadoop.sh git revision trunk / 7fd6416 Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/13319/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/13319/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13319/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_60.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13319/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13319/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13319/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13319/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13319/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13319/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13319/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13319/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Max memory used 228MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13319/console This message was automatically generated.
          Hide
          liuml07 Mingliang Liu added a comment -

          The v4 patch rebases from trunk code and will trigger the Jenkins again.

          Show
          liuml07 Mingliang Liu added a comment - The v4 patch rebases from trunk code and will trigger the Jenkins again.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 8s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          -1 mvninstall 3m 13s root in trunk failed.
          -1 compile 4m 2s root in trunk failed with JDK v1.8.0_60.
          -1 compile 3m 52s root in trunk failed with JDK v1.7.0_79.
          +1 checkstyle 0m 56s trunk passed
          +1 mvneclipse 0m 27s trunk passed
          -1 findbugs 1m 50s hadoop-hdfs-project/hadoop-hdfs in trunk cannot run convertXmlToText from findbugs
          +1 javadoc 2m 1s trunk passed with JDK v1.8.0_60
          +1 javadoc 3m 2s trunk passed with JDK v1.7.0_79
          +1 mvninstall 2m 10s the patch passed
          -1 compile 4m 17s root in the patch failed with JDK v1.8.0_60.
          -1 javac 4m 17s root in the patch failed with JDK v1.8.0_60.
          -1 compile 4m 4s root in the patch failed with JDK v1.7.0_79.
          -1 javac 4m 4s root in the patch failed with JDK v1.7.0_79.
          +1 checkstyle 1m 2s the patch passed
          +1 mvneclipse 0m 28s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 3m 56s the patch passed
          +1 javadoc 2m 4s the patch passed with JDK v1.8.0_60
          +1 javadoc 2m 52s the patch passed with JDK v1.7.0_79
          -1 unit 6m 11s hadoop-common in the patch failed with JDK v1.8.0_60.
          -1 unit 60m 42s hadoop-hdfs in the patch failed with JDK v1.8.0_60.
          -1 unit 6m 31s hadoop-common in the patch failed with JDK v1.7.0_79.
          -1 unit 58m 30s hadoop-hdfs in the patch failed with JDK v1.7.0_79.
          -1 asflicense 0m 19s Patch generated 56 ASF License warnings.
          175m 27s



          Reason Tests
          JDK v1.8.0_60 Failed junit tests hadoop.ipc.TestDecayRpcScheduler
            hadoop.ipc.TestIPC
            hadoop.metrics2.sink.TestFileSink
            hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes
            hadoop.hdfs.server.namenode.TestAddStripedBlocks
            hadoop.hdfs.server.namenode.TestFSEditLogLoader
            hadoop.hdfs.TestSafeModeWithStripedFile
            hadoop.hdfs.TestPread
            hadoop.hdfs.server.namenode.TestFileTruncate
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure100
            hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock
            hadoop.hdfs.TestReadStripedFileWithMissingBlocks
            hadoop.hdfs.server.namenode.TestRecoverStripedBlocks
            hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFS
            hadoop.hdfs.protocol.datatransfer.sasl.TestSaslDataTransfer
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure160
            hadoop.hdfs.web.TestWebHdfsWithMultipleNameNodes
            hadoop.hdfs.server.blockmanagement.TestNodeCount
            hadoop.hdfs.server.datanode.TestReadOnlySharedStorage
            hadoop.hdfs.TestEncryptedTransfer
            hadoop.hdfs.server.datanode.TestHSync
            hadoop.hdfs.TestAbandonBlock
            hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
            hadoop.hdfs.TestReplication
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure050
            hadoop.hdfs.server.blockmanagement.TestReplicationPolicyWithNodeGroup
            hadoop.hdfs.server.datanode.TestBlockHasMultipleReplicasOnSameDN
            hadoop.hdfs.server.datanode.fsdataset.impl.TestDatanodeRestart
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure110
            hadoop.hdfs.server.namenode.TestDecommissioningStatus
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure190
            hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation
            hadoop.hdfs.TestDecommission
            hadoop.hdfs.TestCrcCorruption
            hadoop.hdfs.server.balancer.TestBalancer
            hadoop.hdfs.server.blockmanagement.TestReplicationPolicy
            hadoop.hdfs.server.mover.TestMover
            hadoop.hdfs.server.blockmanagement.TestComputeInvalidateWork
            hadoop.hdfs.server.namenode.TestDefaultBlockPlacementPolicy
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure170
            hadoop.hdfs.server.blockmanagement.TestBlockManager
            hadoop.hdfs.server.datanode.TestDataNodeMetrics
            hadoop.hdfs.TestDFSStripedOutputStream
            hadoop.hdfs.server.namenode.TestSnapshotPathINodes
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure020
            hadoop.hdfs.server.blockmanagement.TestOverReplicatedBlocks
            hadoop.hdfs.server.namenode.TestFsck
            hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
            hadoop.hdfs.TestGetFileChecksum
            hadoop.hdfs.TestBlockStoragePolicy
            hadoop.hdfs.server.datanode.TestNNHandlesBlockReportPerStorage
            hadoop.fs.permission.TestStickyBit
            hadoop.hdfs.server.blockmanagement.TestReplicationPolicyWithUpgradeDomain
            hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure040
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
            hadoop.hdfs.server.datanode.TestNNHandlesCombinedBlockReport
            hadoop.hdfs.server.namenode.TestFSImageWithSnapshot
            hadoop.hdfs.TestReadStripedFileWithDecoding
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010
            hadoop.hdfs.server.datanode.fsdataset.impl.TestSpaceReservation
            hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped
            hadoop.hdfs.TestRecoverStripedFile
            hadoop.hdfs.server.blockmanagement.TestPendingReplication
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
            hadoop.hdfs.TestReplaceDatanodeOnFailure
            hadoop.hdfs.server.namenode.TestAddBlock
            hadoop.hdfs.server.namenode.TestBlockPlacementPolicyRackFaultTolerant
          JDK v1.7.0_79 Failed junit tests hadoop.metrics2.sink.TestFileSink
            hadoop.hdfs.server.datanode.TestDiskError
            hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes
            hadoop.hdfs.server.namenode.TestAddStripedBlocks
            hadoop.hdfs.TestSafeModeWithStripedFile
            hadoop.hdfs.server.namenode.TestFileTruncate
            hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock
            hadoop.hdfs.TestReadStripedFileWithMissingBlocks
            hadoop.hdfs.server.namenode.TestRecoverStripedBlocks
            hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFS
            hadoop.hdfs.protocol.datatransfer.sasl.TestSaslDataTransfer
            hadoop.hdfs.server.namenode.TestAddBlockRetry
            hadoop.hdfs.web.TestWebHdfsWithMultipleNameNodes
            hadoop.hdfs.TestClientProtocolForPipelineRecovery
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure130
            hadoop.hdfs.server.blockmanagement.TestNodeCount
            hadoop.hdfs.TestEncryptedTransfer
            hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure000
            hadoop.hdfs.TestReplication
            hadoop.hdfs.server.blockmanagement.TestReplicationPolicyWithNodeGroup
            hadoop.hdfs.server.datanode.TestBlockHasMultipleReplicasOnSameDN
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotDiffReport
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure140
            hadoop.hdfs.server.namenode.TestDecommissioningStatus
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure190
            hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation
            hadoop.hdfs.TestDecommission
            hadoop.hdfs.TestCrcCorruption
            hadoop.hdfs.server.balancer.TestBalancer
            hadoop.hdfs.server.blockmanagement.TestReplicationPolicy
            hadoop.hdfs.server.mover.TestMover
            hadoop.hdfs.TestFileAppend2
            hadoop.hdfs.server.namenode.snapshot.TestINodeFileUnderConstructionWithSnapshot
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure170
            hadoop.hdfs.TestWriteReadStripedFile
            hadoop.hdfs.TestInjectionForSimulatedStorage
            hadoop.hdfs.server.blockmanagement.TestBlockManager
            hadoop.hdfs.server.datanode.TestDataNodeMetrics
            hadoop.hdfs.TestDFSStripedOutputStream
            hadoop.hdfs.server.namenode.TestSnapshotPathINodes
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure
            hadoop.hdfs.server.namenode.TestFsck
            hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
            hadoop.hdfs.server.namenode.TestAddOverReplicatedStripedBlocks
            hadoop.hdfs.TestGetFileChecksum
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080
            hadoop.hdfs.TestBlockStoragePolicy
            hadoop.hdfs.server.datanode.TestNNHandlesBlockReportPerStorage
            hadoop.fs.permission.TestStickyBit
            hadoop.hdfs.TestFileCreation
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure200
            hadoop.hdfs.server.blockmanagement.TestReplicationPolicyWithUpgradeDomain
            hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate
            hadoop.hdfs.server.datanode.TestDeleteBlockPool
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
            hadoop.hdfs.server.datanode.TestNNHandlesCombinedBlockReport
            hadoop.hdfs.server.namenode.TestFSImageWithSnapshot
            hadoop.hdfs.TestReadStripedFileWithDecoding
            hadoop.hdfs.server.namenode.TestProcessCorruptBlocks
            hadoop.hdfs.TestFileCorruption
            hadoop.hdfs.server.datanode.fsdataset.impl.TestSpaceReservation
            hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped
            hadoop.hdfs.TestRecoverStripedFile
            hadoop.hdfs.server.blockmanagement.TestPendingReplication
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150
            hadoop.hdfs.server.namenode.ha.TestHAAppend
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
            hadoop.hdfs.TestReplaceDatanodeOnFailure
            hadoop.hdfs.server.namenode.TestAddBlock
            hadoop.hdfs.server.namenode.TestBlockPlacementPolicyRackFaultTolerant
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure030



          Subsystem Report/Notes
          Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-30
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12769826/HDFS-9343.003.patch
          JIRA Issue HDFS-9343
          Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
          uname Linux d049febf595b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/patchprocess/apache-yetus-e77b1ce/precommit/personality/hadoop.sh
          git revision trunk / 2868ca0
          Default Java 1.7.0_79
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
          mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/13302/artifact/patchprocess/branch-mvninstall-root.txt
          compile https://builds.apache.org/job/PreCommit-HDFS-Build/13302/artifact/patchprocess/branch-compile-root-jdk1.8.0_60.txt
          compile https://builds.apache.org/job/PreCommit-HDFS-Build/13302/artifact/patchprocess/branch-compile-root-jdk1.7.0_79.txt
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/13302/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
          compile https://builds.apache.org/job/PreCommit-HDFS-Build/13302/artifact/patchprocess/patch-compile-root-jdk1.8.0_60.txt
          javac https://builds.apache.org/job/PreCommit-HDFS-Build/13302/artifact/patchprocess/patch-compile-root-jdk1.8.0_60.txt
          compile https://builds.apache.org/job/PreCommit-HDFS-Build/13302/artifact/patchprocess/patch-compile-root-jdk1.7.0_79.txt
          javac https://builds.apache.org/job/PreCommit-HDFS-Build/13302/artifact/patchprocess/patch-compile-root-jdk1.7.0_79.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13302/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13302/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_60.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13302/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13302/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13302/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13302/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13302/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13302/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13302/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13302/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Max memory used 224MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13302/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 8s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. -1 mvninstall 3m 13s root in trunk failed. -1 compile 4m 2s root in trunk failed with JDK v1.8.0_60. -1 compile 3m 52s root in trunk failed with JDK v1.7.0_79. +1 checkstyle 0m 56s trunk passed +1 mvneclipse 0m 27s trunk passed -1 findbugs 1m 50s hadoop-hdfs-project/hadoop-hdfs in trunk cannot run convertXmlToText from findbugs +1 javadoc 2m 1s trunk passed with JDK v1.8.0_60 +1 javadoc 3m 2s trunk passed with JDK v1.7.0_79 +1 mvninstall 2m 10s the patch passed -1 compile 4m 17s root in the patch failed with JDK v1.8.0_60. -1 javac 4m 17s root in the patch failed with JDK v1.8.0_60. -1 compile 4m 4s root in the patch failed with JDK v1.7.0_79. -1 javac 4m 4s root in the patch failed with JDK v1.7.0_79. +1 checkstyle 1m 2s the patch passed +1 mvneclipse 0m 28s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 3m 56s the patch passed +1 javadoc 2m 4s the patch passed with JDK v1.8.0_60 +1 javadoc 2m 52s the patch passed with JDK v1.7.0_79 -1 unit 6m 11s hadoop-common in the patch failed with JDK v1.8.0_60. -1 unit 60m 42s hadoop-hdfs in the patch failed with JDK v1.8.0_60. -1 unit 6m 31s hadoop-common in the patch failed with JDK v1.7.0_79. -1 unit 58m 30s hadoop-hdfs in the patch failed with JDK v1.7.0_79. -1 asflicense 0m 19s Patch generated 56 ASF License warnings. 175m 27s Reason Tests JDK v1.8.0_60 Failed junit tests hadoop.ipc.TestDecayRpcScheduler   hadoop.ipc.TestIPC   hadoop.metrics2.sink.TestFileSink   hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes   hadoop.hdfs.server.namenode.TestAddStripedBlocks   hadoop.hdfs.server.namenode.TestFSEditLogLoader   hadoop.hdfs.TestSafeModeWithStripedFile   hadoop.hdfs.TestPread   hadoop.hdfs.server.namenode.TestFileTruncate   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure100   hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock   hadoop.hdfs.TestReadStripedFileWithMissingBlocks   hadoop.hdfs.server.namenode.TestRecoverStripedBlocks   hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFS   hadoop.hdfs.protocol.datatransfer.sasl.TestSaslDataTransfer   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure160   hadoop.hdfs.web.TestWebHdfsWithMultipleNameNodes   hadoop.hdfs.server.blockmanagement.TestNodeCount   hadoop.hdfs.server.datanode.TestReadOnlySharedStorage   hadoop.hdfs.TestEncryptedTransfer   hadoop.hdfs.server.datanode.TestHSync   hadoop.hdfs.TestAbandonBlock   hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA   hadoop.hdfs.TestReplication   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure050   hadoop.hdfs.server.blockmanagement.TestReplicationPolicyWithNodeGroup   hadoop.hdfs.server.datanode.TestBlockHasMultipleReplicasOnSameDN   hadoop.hdfs.server.datanode.fsdataset.impl.TestDatanodeRestart   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure110   hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure190   hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation   hadoop.hdfs.TestDecommission   hadoop.hdfs.TestCrcCorruption   hadoop.hdfs.server.balancer.TestBalancer   hadoop.hdfs.server.blockmanagement.TestReplicationPolicy   hadoop.hdfs.server.mover.TestMover   hadoop.hdfs.server.blockmanagement.TestComputeInvalidateWork   hadoop.hdfs.server.namenode.TestDefaultBlockPlacementPolicy   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure170   hadoop.hdfs.server.blockmanagement.TestBlockManager   hadoop.hdfs.server.datanode.TestDataNodeMetrics   hadoop.hdfs.TestDFSStripedOutputStream   hadoop.hdfs.server.namenode.TestSnapshotPathINodes   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure020   hadoop.hdfs.server.blockmanagement.TestOverReplicatedBlocks   hadoop.hdfs.server.namenode.TestFsck   hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks   hadoop.hdfs.TestGetFileChecksum   hadoop.hdfs.TestBlockStoragePolicy   hadoop.hdfs.server.datanode.TestNNHandlesBlockReportPerStorage   hadoop.fs.permission.TestStickyBit   hadoop.hdfs.server.blockmanagement.TestReplicationPolicyWithUpgradeDomain   hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure040   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting   hadoop.hdfs.server.datanode.TestNNHandlesCombinedBlockReport   hadoop.hdfs.server.namenode.TestFSImageWithSnapshot   hadoop.hdfs.TestReadStripedFileWithDecoding   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010   hadoop.hdfs.server.datanode.fsdataset.impl.TestSpaceReservation   hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped   hadoop.hdfs.TestRecoverStripedFile   hadoop.hdfs.server.blockmanagement.TestPendingReplication   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.TestReplaceDatanodeOnFailure   hadoop.hdfs.server.namenode.TestAddBlock   hadoop.hdfs.server.namenode.TestBlockPlacementPolicyRackFaultTolerant JDK v1.7.0_79 Failed junit tests hadoop.metrics2.sink.TestFileSink   hadoop.hdfs.server.datanode.TestDiskError   hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes   hadoop.hdfs.server.namenode.TestAddStripedBlocks   hadoop.hdfs.TestSafeModeWithStripedFile   hadoop.hdfs.server.namenode.TestFileTruncate   hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock   hadoop.hdfs.TestReadStripedFileWithMissingBlocks   hadoop.hdfs.server.namenode.TestRecoverStripedBlocks   hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFS   hadoop.hdfs.protocol.datatransfer.sasl.TestSaslDataTransfer   hadoop.hdfs.server.namenode.TestAddBlockRetry   hadoop.hdfs.web.TestWebHdfsWithMultipleNameNodes   hadoop.hdfs.TestClientProtocolForPipelineRecovery   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure130   hadoop.hdfs.server.blockmanagement.TestNodeCount   hadoop.hdfs.TestEncryptedTransfer   hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure000   hadoop.hdfs.TestReplication   hadoop.hdfs.server.blockmanagement.TestReplicationPolicyWithNodeGroup   hadoop.hdfs.server.datanode.TestBlockHasMultipleReplicasOnSameDN   hadoop.hdfs.server.namenode.snapshot.TestSnapshotDiffReport   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure140   hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure190   hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation   hadoop.hdfs.TestDecommission   hadoop.hdfs.TestCrcCorruption   hadoop.hdfs.server.balancer.TestBalancer   hadoop.hdfs.server.blockmanagement.TestReplicationPolicy   hadoop.hdfs.server.mover.TestMover   hadoop.hdfs.TestFileAppend2   hadoop.hdfs.server.namenode.snapshot.TestINodeFileUnderConstructionWithSnapshot   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure170   hadoop.hdfs.TestWriteReadStripedFile   hadoop.hdfs.TestInjectionForSimulatedStorage   hadoop.hdfs.server.blockmanagement.TestBlockManager   hadoop.hdfs.server.datanode.TestDataNodeMetrics   hadoop.hdfs.TestDFSStripedOutputStream   hadoop.hdfs.server.namenode.TestSnapshotPathINodes   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure   hadoop.hdfs.server.namenode.TestFsck   hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks   hadoop.hdfs.server.namenode.TestAddOverReplicatedStripedBlocks   hadoop.hdfs.TestGetFileChecksum   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080   hadoop.hdfs.TestBlockStoragePolicy   hadoop.hdfs.server.datanode.TestNNHandlesBlockReportPerStorage   hadoop.fs.permission.TestStickyBit   hadoop.hdfs.TestFileCreation   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure200   hadoop.hdfs.server.blockmanagement.TestReplicationPolicyWithUpgradeDomain   hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate   hadoop.hdfs.server.datanode.TestDeleteBlockPool   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting   hadoop.hdfs.server.datanode.TestNNHandlesCombinedBlockReport   hadoop.hdfs.server.namenode.TestFSImageWithSnapshot   hadoop.hdfs.TestReadStripedFileWithDecoding   hadoop.hdfs.server.namenode.TestProcessCorruptBlocks   hadoop.hdfs.TestFileCorruption   hadoop.hdfs.server.datanode.fsdataset.impl.TestSpaceReservation   hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped   hadoop.hdfs.TestRecoverStripedFile   hadoop.hdfs.server.blockmanagement.TestPendingReplication   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150   hadoop.hdfs.server.namenode.ha.TestHAAppend   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.TestReplaceDatanodeOnFailure   hadoop.hdfs.server.namenode.TestAddBlock   hadoop.hdfs.server.namenode.TestBlockPlacementPolicyRackFaultTolerant   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure030 Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-30 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12769826/HDFS-9343.003.patch JIRA Issue HDFS-9343 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux d049febf595b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/patchprocess/apache-yetus-e77b1ce/precommit/personality/hadoop.sh git revision trunk / 2868ca0 Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/13302/artifact/patchprocess/branch-mvninstall-root.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/13302/artifact/patchprocess/branch-compile-root-jdk1.8.0_60.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/13302/artifact/patchprocess/branch-compile-root-jdk1.7.0_79.txt findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/13302/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs.html compile https://builds.apache.org/job/PreCommit-HDFS-Build/13302/artifact/patchprocess/patch-compile-root-jdk1.8.0_60.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/13302/artifact/patchprocess/patch-compile-root-jdk1.8.0_60.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/13302/artifact/patchprocess/patch-compile-root-jdk1.7.0_79.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/13302/artifact/patchprocess/patch-compile-root-jdk1.7.0_79.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13302/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13302/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_60.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13302/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13302/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13302/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13302/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13302/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13302/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13302/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13302/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Max memory used 224MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13302/console This message was automatically generated.
          Hide
          jnp Jitendra Nath Pandey added a comment -

          +1

          Show
          jnp Jitendra Nath Pandey added a comment - +1
          Hide
          liuml07 Mingliang Liu added a comment -

          Thanks to Jitendra Nath Pandey for the comments. The v3 patch addresses the @InterfaceAudience.Private annotation.

          Show
          liuml07 Mingliang Liu added a comment - Thanks to Jitendra Nath Pandey for the comments. The v3 patch addresses the @InterfaceAudience.Private annotation.
          Hide
          jnp Jitendra Nath Pandey added a comment -

          Mingliang Liu, isContextValid method should not be part of the public API. Please annotate this method with InterfaceAudience.Private.

          Show
          jnp Jitendra Nath Pandey added a comment - Mingliang Liu , isContextValid method should not be part of the public API. Please annotate this method with InterfaceAudience.Private .
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 7s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 3m 16s trunk passed
          +1 compile 5m 13s trunk passed with JDK v1.8.0_60
          +1 compile 5m 2s trunk passed with JDK v1.7.0_79
          +1 checkstyle 1m 10s trunk passed
          +1 mvneclipse 0m 31s trunk passed
          -1 findbugs 2m 16s hadoop-hdfs-project/hadoop-hdfs in trunk cannot run convertXmlToText from findbugs
          +1 javadoc 2m 17s trunk passed with JDK v1.8.0_60
          +1 javadoc 3m 13s trunk passed with JDK v1.7.0_79
          +1 mvninstall 2m 17s the patch passed
          +1 compile 5m 5s the patch passed with JDK v1.8.0_60
          +1 javac 5m 5s the patch passed
          +1 compile 4m 57s the patch passed with JDK v1.7.0_79
          +1 javac 4m 57s the patch passed
          +1 checkstyle 1m 12s the patch passed
          +1 mvneclipse 0m 33s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 4m 51s the patch passed
          +1 javadoc 2m 23s the patch passed with JDK v1.8.0_60
          +1 javadoc 3m 24s the patch passed with JDK v1.7.0_79
          -1 unit 8m 5s hadoop-common in the patch failed with JDK v1.8.0_60.
          -1 unit 62m 28s hadoop-hdfs in the patch failed with JDK v1.8.0_60.
          -1 unit 7m 19s hadoop-common in the patch failed with JDK v1.7.0_79.
          -1 unit 59m 40s hadoop-hdfs in the patch failed with JDK v1.7.0_79.
          -1 asflicense 0m 23s Patch generated 58 ASF License warnings.
          189m 11s



          Reason Tests
          JDK v1.8.0_60 Failed junit tests hadoop.fs.shell.TestCopyPreserveFlag
            hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
            hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010
            hadoop.hdfs.TestDistributedFileSystem
            hadoop.hdfs.server.datanode.TestBlockScanner
          JDK v1.7.0_79 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics
            hadoop.hdfs.server.namenode.ha.TestEditLogTailer



          Subsystem Report/Notes
          Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-30
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12769696/HDFS-9343.002.patch
          JIRA Issue HDFS-9343
          Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
          uname Linux 6658420418a2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build@2/patchprocess/apache-yetus-e77b1ce/precommit/personality/hadoop.sh
          git revision trunk / 7412ff4
          Default Java 1.7.0_79
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/13297/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13297/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13297/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_60.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13297/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13297/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13297/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13297/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13297/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13297/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13297/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13297/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Max memory used 227MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13297/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 7s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 3m 16s trunk passed +1 compile 5m 13s trunk passed with JDK v1.8.0_60 +1 compile 5m 2s trunk passed with JDK v1.7.0_79 +1 checkstyle 1m 10s trunk passed +1 mvneclipse 0m 31s trunk passed -1 findbugs 2m 16s hadoop-hdfs-project/hadoop-hdfs in trunk cannot run convertXmlToText from findbugs +1 javadoc 2m 17s trunk passed with JDK v1.8.0_60 +1 javadoc 3m 13s trunk passed with JDK v1.7.0_79 +1 mvninstall 2m 17s the patch passed +1 compile 5m 5s the patch passed with JDK v1.8.0_60 +1 javac 5m 5s the patch passed +1 compile 4m 57s the patch passed with JDK v1.7.0_79 +1 javac 4m 57s the patch passed +1 checkstyle 1m 12s the patch passed +1 mvneclipse 0m 33s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 4m 51s the patch passed +1 javadoc 2m 23s the patch passed with JDK v1.8.0_60 +1 javadoc 3m 24s the patch passed with JDK v1.7.0_79 -1 unit 8m 5s hadoop-common in the patch failed with JDK v1.8.0_60. -1 unit 62m 28s hadoop-hdfs in the patch failed with JDK v1.8.0_60. -1 unit 7m 19s hadoop-common in the patch failed with JDK v1.7.0_79. -1 unit 59m 40s hadoop-hdfs in the patch failed with JDK v1.7.0_79. -1 asflicense 0m 23s Patch generated 58 ASF License warnings. 189m 11s Reason Tests JDK v1.8.0_60 Failed junit tests hadoop.fs.shell.TestCopyPreserveFlag   hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010   hadoop.hdfs.TestDistributedFileSystem   hadoop.hdfs.server.datanode.TestBlockScanner JDK v1.7.0_79 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics   hadoop.hdfs.server.namenode.ha.TestEditLogTailer Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-30 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12769696/HDFS-9343.002.patch JIRA Issue HDFS-9343 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux 6658420418a2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build@2/patchprocess/apache-yetus-e77b1ce/precommit/personality/hadoop.sh git revision trunk / 7412ff4 Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/13297/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/13297/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13297/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_60.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13297/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13297/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13297/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13297/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13297/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13297/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13297/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13297/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Max memory used 227MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13297/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 7s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 3m 12s trunk passed
          +1 compile 4m 43s trunk passed with JDK v1.8.0_66
          +1 compile 4m 33s trunk passed with JDK v1.7.0_79
          +1 checkstyle 1m 3s trunk passed
          +1 mvneclipse 0m 28s trunk passed
          -1 findbugs 2m 0s hadoop-hdfs-project/hadoop-hdfs in trunk cannot run convertXmlToText from findbugs
          +1 javadoc 2m 4s trunk passed with JDK v1.8.0_66
          +1 javadoc 3m 8s trunk passed with JDK v1.7.0_79
          +1 mvninstall 2m 24s the patch passed
          +1 compile 4m 43s the patch passed with JDK v1.8.0_66
          +1 javac 4m 43s the patch passed
          +1 compile 4m 26s the patch passed with JDK v1.7.0_79
          +1 javac 4m 26s the patch passed
          -1 checkstyle 0m 59s Patch generated 1 new checkstyle issues in root (total was 263, now 263).
          +1 mvneclipse 0m 28s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 4m 10s the patch passed
          +1 javadoc 2m 7s the patch passed with JDK v1.8.0_66
          +1 javadoc 3m 3s the patch passed with JDK v1.7.0_79
          +1 unit 8m 12s hadoop-common in the patch passed with JDK v1.8.0_66.
          -1 unit 66m 48s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          +1 unit 8m 26s hadoop-common in the patch passed with JDK v1.7.0_79.
          -1 unit 67m 45s hadoop-hdfs in the patch failed with JDK v1.7.0_79.
          -1 asflicense 0m 20s Patch generated 56 ASF License warnings.
          198m 16s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.namenode.ha.TestInitializeSharedEdits
            hadoop.hdfs.server.datanode.TestBlockScanner
            hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency
            hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock
          JDK v1.7.0_79 Failed junit tests hadoop.hdfs.server.blockmanagement.TestNodeCount



          Subsystem Report/Notes
          Docker Client=1.7.0 Server=1.7.0 Image:test-patch-base-hadoop-date2015-10-30
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12769678/HDFS-9343.001.patch
          JIRA Issue HDFS-9343
          Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
          uname Linux 69394ed3af82 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/patchprocess/apache-yetus-e77b1ce/precommit/personality/hadoop.sh
          git revision trunk / 7412ff4
          Default Java 1.7.0_79
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/13293/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/13293/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13293/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13293/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13293/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13293/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13293/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13293/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Max memory used 227MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13293/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 7s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 3m 12s trunk passed +1 compile 4m 43s trunk passed with JDK v1.8.0_66 +1 compile 4m 33s trunk passed with JDK v1.7.0_79 +1 checkstyle 1m 3s trunk passed +1 mvneclipse 0m 28s trunk passed -1 findbugs 2m 0s hadoop-hdfs-project/hadoop-hdfs in trunk cannot run convertXmlToText from findbugs +1 javadoc 2m 4s trunk passed with JDK v1.8.0_66 +1 javadoc 3m 8s trunk passed with JDK v1.7.0_79 +1 mvninstall 2m 24s the patch passed +1 compile 4m 43s the patch passed with JDK v1.8.0_66 +1 javac 4m 43s the patch passed +1 compile 4m 26s the patch passed with JDK v1.7.0_79 +1 javac 4m 26s the patch passed -1 checkstyle 0m 59s Patch generated 1 new checkstyle issues in root (total was 263, now 263). +1 mvneclipse 0m 28s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 4m 10s the patch passed +1 javadoc 2m 7s the patch passed with JDK v1.8.0_66 +1 javadoc 3m 3s the patch passed with JDK v1.7.0_79 +1 unit 8m 12s hadoop-common in the patch passed with JDK v1.8.0_66. -1 unit 66m 48s hadoop-hdfs in the patch failed with JDK v1.8.0_66. +1 unit 8m 26s hadoop-common in the patch passed with JDK v1.7.0_79. -1 unit 67m 45s hadoop-hdfs in the patch failed with JDK v1.7.0_79. -1 asflicense 0m 20s Patch generated 56 ASF License warnings. 198m 16s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.namenode.ha.TestInitializeSharedEdits   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency   hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock JDK v1.7.0_79 Failed junit tests hadoop.hdfs.server.blockmanagement.TestNodeCount Subsystem Report/Notes Docker Client=1.7.0 Server=1.7.0 Image:test-patch-base-hadoop-date2015-10-30 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12769678/HDFS-9343.001.patch JIRA Issue HDFS-9343 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux 69394ed3af82 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/patchprocess/apache-yetus-e77b1ce/precommit/personality/hadoop.sh git revision trunk / 7412ff4 Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/13293/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/13293/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13293/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13293/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13293/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13293/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13293/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13293/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Max memory used 227MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13293/console This message was automatically generated.
          Hide
          liuml07 Mingliang Liu added a comment -

          The v2 patch addresses latest comments. Thanks to Hitesh Shah.

          Show
          liuml07 Mingliang Liu added a comment - The v2 patch addresses latest comments. Thanks to Hitesh Shah .
          Hide
          hitesh Hitesh Shah added a comment -

          In any case, the patch looks fine. +1.

          Show
          hitesh Hitesh Shah added a comment - In any case, the patch looks fine. +1.
          Hide
          hitesh Hitesh Shah added a comment -

          Might be safer to do an empty string check anyway as the logger and setSig() are in different parts of the codebase.

          Show
          hitesh Hitesh Shah added a comment - Might be safer to do an empty string check anyway as the logger and setSig() are in different parts of the codebase.
          Hide
          liuml07 Mingliang Liu added a comment -

          Thank you Hitesh Shah for your comment.

          isValid() - is this meant to be a public API? Should this be renamed to isContextValid() as it is only checking the context part?

          Yes, it makes a lot of sense to rename the method as we validate the context only.

          Not checking for zero-length string?
          should signature validity check be moved into a function too?

          Yes we should ignore the signature if user passes an empty string. The signature will be null because the CallerContext.Builder.setSignature() will ignore empty string. We have a test case for this in org.apache.hadoop.hdfs.server.namenode.TestAuditLogger:365. We don't know the maximum signature in caller context class as we don't have access to configuration, moving the validation to CallerContext may be not necessary.

          Show
          liuml07 Mingliang Liu added a comment - Thank you Hitesh Shah for your comment. isValid() - is this meant to be a public API? Should this be renamed to isContextValid() as it is only checking the context part? Yes, it makes a lot of sense to rename the method as we validate the context only. Not checking for zero-length string? should signature validity check be moved into a function too? Yes we should ignore the signature if user passes an empty string. The signature will be null because the CallerContext.Builder.setSignature() will ignore empty string. We have a test case for this in org.apache.hadoop.hdfs.server.namenode.TestAuditLogger:365 . We don't know the maximum signature in caller context class as we don't have access to configuration, moving the validation to CallerContext may be not necessary.
          Hide
          hitesh Hitesh Shah added a comment -

          Comments:

          isValid() - is this meant to be a public API? Should this be renamed to isContextValid() as it is only checking the context part?

          if (callerContext.getSignature() != null &&	              callerContext.getSignature().length <= callerSignatureMaxLen) {
          
          • Not checking for zero-length string?
          • should signature validity check be moved into a function too?
          Show
          hitesh Hitesh Shah added a comment - Comments: isValid() - is this meant to be a public API? Should this be renamed to isContextValid() as it is only checking the context part? if (callerContext.getSignature() != null && callerContext.getSignature().length <= callerSignatureMaxLen) { Not checking for zero-length string? should signature validity check be moved into a function too?

            People

            • Assignee:
              liuml07 Mingliang Liu
              Reporter:
              liuml07 Mingliang Liu
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development