Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10793

Fix HdfsAuditLogger binary incompatibility introduced by HDFS-9184

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:

      Description

      HDFS-9184 added a new parameter to an existing method signature in HdfsAuditLogger, which is a Public/Evolving class. This breaks binary compatibility with implementing subclasses.

      1. HDFS-10793.001.patch
        5 kB
        Manoj Govindassamy
      2. HDFS-10793.002.patch
        4 kB
        Manoj Govindassamy

        Issue Links

          Activity

          Hide
          manojg Manoj Govindassamy added a comment -

          Here is a test showing the problem.
          – Set the config key "dfs.namenode.audit.loggers" to a class implementing HdfsAuditLogger the older way. That is, class implementing the method with no CallerContext arg.
          – Run a client which runs setTimes() operation on the cluster filesystem
          – Client operation fails as the custom AuditLogger is not binary compatible with the new one

          252 2016-08-24 18:27:30,010 [IPC Server handler 0 on 63080] WARN  ipc.Server (Server.java:logException(2494)) - IPC Server handler 0 on 63080, call org.apache.hadoop.hdfs.protocol.ClientProtocol.setTimes from 127.0.0.1:63086 Call#5 Retry#0
          253 java.lang.AbstractMethodError: org.apache.hadoop.hdfs.server.namenode.HdfsAuditLogger.logAuditEvent(ZLjava/lang/String;Ljava/net/InetAddress;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Lorg/apache/hadoop/fs/FileStatus;Lorg/apache/hadoop/ipc/CallerContext;Lorg/apache/hadoop/security/UserGroupInformation;Lorg/apache/hadoop/hdfs/security/token/delegation/DelegationTokenSecretManager;)V
          254         at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.logAuditEvent(FSNamesystem.java:362)
          255         at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.logAuditEvent(FSNamesystem.java:340)
          256         at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.setTimes(FSNamesystem.java:1913)
          257         at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.setTimes(NameNodeRpcServer.java:1344)
          258         at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.setTimes(ClientNamenodeProtocolServerSideTranslatorPB.java:948)
          259         at org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java)
          260         at org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:663)
          261         at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:989)
          262         at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2423)
          263         at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2419)
          264         at java.security.AccessController.doPrivileged(Native Method)
          265         at javax.security.auth.Subject.doAs(Subject.java:422)
          266         at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1790)
          267         at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2419)
          
          Show
          manojg Manoj Govindassamy added a comment - Here is a test showing the problem. – Set the config key "dfs.namenode.audit.loggers" to a class implementing HdfsAuditLogger the older way. That is, class implementing the method with no CallerContext arg. – Run a client which runs setTimes() operation on the cluster filesystem – Client operation fails as the custom AuditLogger is not binary compatible with the new one 252 2016-08-24 18:27:30,010 [IPC Server handler 0 on 63080] WARN ipc.Server (Server.java:logException(2494)) - IPC Server handler 0 on 63080, call org.apache.hadoop.hdfs.protocol.ClientProtocol.setTimes from 127.0.0.1:63086 Call#5 Retry#0 253 java.lang.AbstractMethodError: org.apache.hadoop.hdfs.server.namenode.HdfsAuditLogger.logAuditEvent(ZLjava/lang/String;Ljava/net/InetAddress;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Lorg/apache/hadoop/fs/FileStatus;Lorg/apache/hadoop/ipc/CallerContext;Lorg/apache/hadoop/security/UserGroupInformation;Lorg/apache/hadoop/hdfs/security/token/delegation/DelegationTokenSecretManager;)V 254 at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.logAuditEvent(FSNamesystem.java:362) 255 at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.logAuditEvent(FSNamesystem.java:340) 256 at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.setTimes(FSNamesystem.java:1913) 257 at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.setTimes(NameNodeRpcServer.java:1344) 258 at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.setTimes(ClientNamenodeProtocolServerSideTranslatorPB.java:948) 259 at org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java) 260 at org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:663) 261 at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:989) 262 at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2423) 263 at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2419) 264 at java.security.AccessController.doPrivileged(Native Method) 265 at javax.security.auth.Subject.doAs(Subject.java:422) 266 at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1790) 267 at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2419)
          Hide
          manojg Manoj Govindassamy added a comment -

          Had a chat with Andrew Wang and here is the proposal:

          HdfsAuditLogger.java
          – Retain the old abstract method logAuditEvent, the one with no CallerContext in the args
          – Change the type of current method logAuditEvent (the one with CallerContext arg) to non-abstract and its default method body will be a simple call delegation to the older method (by dropping the CallerContext info). This will make the older AuditLogger class work without any changes and rebuild against new code
          – So, any AuditLogger wanting to make use of CallerContext info, has to override the newer logAuditEvent method with custom implementation

          FSNamesystem.java
          – In DefaultAuditLogger, implement the abstract method logAuditEvent with no CallerContext arg with the method body simply delegating the call to the current version of logAuditEvent by passing null for the CallerContext

          Tested the above with Class implementing HdfsAuditLogger the older way and Client operations are logged as expected without any method signature errors.

          Show
          manojg Manoj Govindassamy added a comment - Had a chat with Andrew Wang and here is the proposal: HdfsAuditLogger.java – Retain the old abstract method logAuditEvent , the one with no CallerContext in the args – Change the type of current method logAuditEvent (the one with CallerContext arg) to non-abstract and its default method body will be a simple call delegation to the older method (by dropping the CallerContext info). This will make the older AuditLogger class work without any changes and rebuild against new code – So, any AuditLogger wanting to make use of CallerContext info, has to override the newer logAuditEvent method with custom implementation FSNamesystem.java – In DefaultAuditLogger , implement the abstract method logAuditEvent with no CallerContext arg with the method body simply delegating the call to the current version of logAuditEvent by passing null for the CallerContext Tested the above with Class implementing HdfsAuditLogger the older way and Client operations are logged as expected without any method signature errors.
          Hide
          manojg Manoj Govindassamy added a comment -

          Attaching v001 patch to address binary compatibility issue with HdfsAuditLogger.

          Show
          manojg Manoj Govindassamy added a comment - Attaching v001 patch to address binary compatibility issue with HdfsAuditLogger.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 37s trunk passed
          +1 compile 0m 46s trunk passed
          +1 checkstyle 0m 28s trunk passed
          +1 mvnsite 0m 50s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 1m 42s trunk passed
          +1 javadoc 0m 56s trunk passed
          +1 mvninstall 0m 46s the patch passed
          +1 compile 0m 42s the patch passed
          +1 javac 0m 42s the patch passed
          -0 checkstyle 0m 25s hadoop-hdfs-project/hadoop-hdfs: The patch generated 3 new + 182 unchanged - 2 fixed = 185 total (was 184)
          +1 mvnsite 0m 48s the patch passed
          +1 mvneclipse 0m 9s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 47s the patch passed
          +1 javadoc 0m 52s the patch passed
          -1 unit 58m 18s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          77m 8s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.namenode.TestEditLogJournalFailures



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-10793
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825511/HDFS-10793.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 29d00ef89787 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 1360bd2
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16541/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/16541/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16541/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16541/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 37s trunk passed +1 compile 0m 46s trunk passed +1 checkstyle 0m 28s trunk passed +1 mvnsite 0m 50s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 42s trunk passed +1 javadoc 0m 56s trunk passed +1 mvninstall 0m 46s the patch passed +1 compile 0m 42s the patch passed +1 javac 0m 42s the patch passed -0 checkstyle 0m 25s hadoop-hdfs-project/hadoop-hdfs: The patch generated 3 new + 182 unchanged - 2 fixed = 185 total (was 184) +1 mvnsite 0m 48s the patch passed +1 mvneclipse 0m 9s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 47s the patch passed +1 javadoc 0m 52s the patch passed -1 unit 58m 18s hadoop-hdfs in the patch failed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 77m 8s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.TestEditLogJournalFailures Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10793 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825511/HDFS-10793.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 29d00ef89787 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1360bd2 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16541/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/16541/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16541/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16541/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          manojg Manoj Govindassamy added a comment -

          – All 3 check style issues are because of number of arguments in the method are beyond 7. Not introduced anything new, just a bit refactoring.
          – TestEditLogJournalFailures are not related to this patch and it fails even without this patch.

          Show
          manojg Manoj Govindassamy added a comment - – All 3 check style issues are because of number of arguments in the method are beyond 7. Not introduced anything new, just a bit refactoring. – TestEditLogJournalFailures are not related to this patch and it fails even without this patch.
          Hide
          andrew.wang Andrew Wang added a comment -

          Overall looks great to me, thanks for picking this up Manoj. One little nit, could we undo some of the whitespace changes? I think your IDE is configured to align parameters, but I think our normal convention is to double indent. I also would mildly prefer if you generate the patch without "--no-prefix", since then I can apply with just "git apply hdfs.patch".

          Arpit Agarwal / Mingliang Liu either of you want to review too? Should be a quick one.

          Show
          andrew.wang Andrew Wang added a comment - Overall looks great to me, thanks for picking this up Manoj. One little nit, could we undo some of the whitespace changes? I think your IDE is configured to align parameters, but I think our normal convention is to double indent. I also would mildly prefer if you generate the patch without "--no-prefix", since then I can apply with just "git apply hdfs.patch". Arpit Agarwal / Mingliang Liu either of you want to review too? Should be a quick one.
          Hide
          manojg Manoj Govindassamy added a comment -

          Sure Andrew Wang. Will do the suggested changes. Will wait for others review so that I can post the next patch with all comments incorporated. Thanks for the review.

          Show
          manojg Manoj Govindassamy added a comment - Sure Andrew Wang . Will do the suggested changes. Will wait for others review so that I can post the next patch with all comments incorporated. Thanks for the review.
          Hide
          liuml07 Mingliang Liu added a comment -

          Looks good once Andrew's comment is addressed. Thanks.

          Show
          liuml07 Mingliang Liu added a comment - Looks good once Andrew's comment is addressed. Thanks.
          Hide
          manojg Manoj Govindassamy added a comment -

          Attaching v002 patch – took care of styling issues.

          Show
          manojg Manoj Govindassamy added a comment - Attaching v002 patch – took care of styling issues.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 22s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 7m 5s trunk passed
          +1 compile 0m 51s trunk passed
          +1 checkstyle 0m 30s trunk passed
          +1 mvnsite 0m 54s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          +1 findbugs 1m 51s trunk passed
          +1 javadoc 1m 4s trunk passed
          +1 mvninstall 0m 52s the patch passed
          +1 compile 0m 44s the patch passed
          +1 javac 0m 44s the patch passed
          -0 checkstyle 0m 26s hadoop-hdfs-project/hadoop-hdfs: The patch generated 3 new + 182 unchanged - 2 fixed = 185 total (was 184)
          +1 mvnsite 0m 51s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 54s the patch passed
          +1 javadoc 0m 59s the patch passed
          -1 unit 77m 50s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          98m 27s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-10793
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825549/HDFS-10793.002.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 433ded302311 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 81485db
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16543/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/16543/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16543/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16543/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 22s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 5s trunk passed +1 compile 0m 51s trunk passed +1 checkstyle 0m 30s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 51s trunk passed +1 javadoc 1m 4s trunk passed +1 mvninstall 0m 52s the patch passed +1 compile 0m 44s the patch passed +1 javac 0m 44s the patch passed -0 checkstyle 0m 26s hadoop-hdfs-project/hadoop-hdfs: The patch generated 3 new + 182 unchanged - 2 fixed = 185 total (was 184) +1 mvnsite 0m 51s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 54s the patch passed +1 javadoc 0m 59s the patch passed -1 unit 77m 50s hadoop-hdfs in the patch failed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 98m 27s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10793 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825549/HDFS-10793.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 433ded302311 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 81485db Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16543/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/16543/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16543/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16543/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          manojg Manoj Govindassamy added a comment -

          – TestNameNodeMetadataConsistency failure is not related to this patch
          – Manually verified the patch as mentioned in comment 1 and 2
          – All check styling issues are related to number of arguments in methods exceeding recommended count of 7

          Show
          manojg Manoj Govindassamy added a comment - – TestNameNodeMetadataConsistency failure is not related to this patch – Manually verified the patch as mentioned in comment 1 and 2 – All check styling issues are related to number of arguments in methods exceeding recommended count of 7
          Hide
          andrew.wang Andrew Wang added a comment -

          Committed to trunk, branch-2, branch-2.8. Thanks for the quick action here Manoj, and Mingliang and Arpit for also taking a look.

          Show
          andrew.wang Andrew Wang added a comment - Committed to trunk, branch-2, branch-2.8. Thanks for the quick action here Manoj, and Mingliang and Arpit for also taking a look.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10359 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10359/)
          HDFS-10793. Fix HdfsAuditLogger binary incompatibility introduced by (wang: rev a445b82baaa58dcaaa3831e724a9915e9dde57c5)

          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/HdfsAuditLogger.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10359 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10359/ ) HDFS-10793 . Fix HdfsAuditLogger binary incompatibility introduced by (wang: rev a445b82baaa58dcaaa3831e724a9915e9dde57c5) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/HdfsAuditLogger.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          Hide
          aw Allen Wittenauer added a comment -

          I also would mildly prefer if you generate the patch without "--no-prefix", since then I can apply with just "git apply hdfs.patch".

          dev-support/bin/smart-apply-patch HDFS-10793
          

          should apply the patch as well, BTW.

          Show
          aw Allen Wittenauer added a comment - I also would mildly prefer if you generate the patch without "--no-prefix", since then I can apply with just "git apply hdfs.patch". dev-support/bin/smart-apply-patch HDFS-10793 should apply the patch as well, BTW.
          Hide
          manojg Manoj Govindassamy added a comment -

          Sure Allen Wittenauer. Will make sure my future patches work with these. Thanks.

          Show
          manojg Manoj Govindassamy added a comment - Sure Allen Wittenauer . Will make sure my future patches work with these. Thanks.
          Hide
          aw Allen Wittenauer added a comment -

          Let me be more specific: Andrew Wang could have used smart-apply-patch to test the patch out rather than having you reformat it.

          Show
          aw Allen Wittenauer added a comment - Let me be more specific: Andrew Wang could have used smart-apply-patch to test the patch out rather than having you reformat it.

            People

            • Assignee:
              manojg Manoj Govindassamy
              Reporter:
              andrew.wang Andrew Wang
            • Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development