Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13527

Add Spark to CallerContext LimitedPrivate scope

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: ipc
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      A lots of Spark applications run on Hadoop. Spark will invoke Hadoop caller context APIs to set up its caller contexts in HDFS/Yarn, so Hadoop should add Spark as one of the users in the LimitedPrivate scope.

        Issue Links

          Activity

          Hide
          stevel@apache.org Steve Loughran added a comment -

          I suggested this BTW

          Show
          stevel@apache.org Steve Loughran added a comment - I suggested this BTW
          Hide
          cnauroth Chris Nauroth added a comment -

          I granted the contributor role to Weiqing Yang, assigned the issue, and clicked Submit Patch. +1 for the patch pending pre-commit run.

          Show
          cnauroth Chris Nauroth added a comment - I granted the contributor role to Weiqing Yang , assigned the issue, and clicked Submit Patch. +1 for the patch pending pre-commit run.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 21s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 46s trunk passed
          +1 compile 6m 42s trunk passed
          +1 checkstyle 0m 22s trunk passed
          +1 mvnsite 0m 54s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 18s trunk passed
          +1 javadoc 0m 45s trunk passed
          +1 mvninstall 0m 37s the patch passed
          +1 compile 6m 40s the patch passed
          +1 javac 6m 40s the patch passed
          +1 checkstyle 0m 22s the patch passed
          +1 mvnsite 0m 52s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 26s the patch passed
          +1 javadoc 0m 45s the patch passed
          -1 unit 10m 6s hadoop-common in the patch failed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          40m 5s



          Reason Tests
          Failed junit tests hadoop.security.ssl.TestSSLFactory



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824719/HADOOP-13527.000.patch
          JIRA Issue HADOOP-13527
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 5fbc78bc20ae 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 0faee62
          Default Java 1.8.0_101
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10327/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10327/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10327/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 46s trunk passed +1 compile 6m 42s trunk passed +1 checkstyle 0m 22s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 18s trunk passed +1 javadoc 0m 45s trunk passed +1 mvninstall 0m 37s the patch passed +1 compile 6m 40s the patch passed +1 javac 6m 40s the patch passed +1 checkstyle 0m 22s the patch passed +1 mvnsite 0m 52s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 26s the patch passed +1 javadoc 0m 45s the patch passed -1 unit 10m 6s hadoop-common in the patch failed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 40m 5s Reason Tests Failed junit tests hadoop.security.ssl.TestSSLFactory Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824719/HADOOP-13527.000.patch JIRA Issue HADOOP-13527 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 5fbc78bc20ae 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0faee62 Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10327/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10327/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10327/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          liuml07 Mingliang Liu added a comment -

          Committed to trunk, branch-2 and branch-2.8 branch. Thanks Weiqing Yang for working on this. Thanks Steve Loughran for the proposal. Thanks Chris Nauroth for review.

          Show
          liuml07 Mingliang Liu added a comment - Committed to trunk , branch-2 and branch-2.8 branch. Thanks Weiqing Yang for working on this. Thanks Steve Loughran for the proposal. Thanks Chris Nauroth for review.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10317 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10317/)
          HADOOP-13527. Add Spark to CallerContext LimitedPrivate scope. (liuml07: rev 115ecb52a86b49aad3d058a6b4c1c7926b8b0a40)

          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10317 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10317/ ) HADOOP-13527 . Add Spark to CallerContext LimitedPrivate scope. (liuml07: rev 115ecb52a86b49aad3d058a6b4c1c7926b8b0a40) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java
          Hide
          WeiqingYang Weiqing Yang added a comment -
          Show
          WeiqingYang Weiqing Yang added a comment - Thank you, Steve Loughran Chris Nauroth Mingliang Liu
          Hide
          aw Allen Wittenauer added a comment -

          Why wasn't this just made public?

          Show
          aw Allen Wittenauer added a comment - Why wasn't this just made public?
          Hide
          stevel@apache.org Steve Loughran added a comment -

          We can do that; it's just making it public would probably stir up some discussion about stability. Adding spark just lists another user without going there

          Show
          stevel@apache.org Steve Loughran added a comment - We can do that; it's just making it public would probably stir up some discussion about stability. Adding spark just lists another user without going there
          Hide
          aw Allen Wittenauer added a comment -

          How many more things need to get added before we declare defeat though? Ignoring the internal bits, we've already got HBase, Hive, Pig, and Spark.

          Show
          aw Allen Wittenauer added a comment - How many more things need to get added before we declare defeat though? Ignoring the internal bits, we've already got HBase, Hive, Pig, and Spark.

            People

            • Assignee:
              WeiqingYang Weiqing Yang
              Reporter:
              WeiqingYang Weiqing Yang
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development