Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.21.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Tags:
      herriot

      Description

      This is HDFS part of HADOOP-6332

      1. HDFS-1134.patch
        69 kB
        Konstantin Boudnik
      2. HDFS-1134.patch
        69 kB
        Konstantin Boudnik
      3. HDFS-1134.patch
        69 kB
        Konstantin Boudnik
      4. HDFS-1134.patch
        69 kB
        Konstantin Boudnik
      5. HDFS-1134.patch
        62 kB
        Konstantin Boudnik
      6. HDFS-1134.patch
        62 kB
        Konstantin Boudnik
      7. HDFS-1134.patch
        60 kB
        Konstantin Boudnik
      8. HDFS-1134.patch
        60 kB
        Konstantin Boudnik
      9. HDFS-1134.patch
        59 kB
        Konstantin Boudnik
      10. HDFS-1134.patch
        60 kB
        Konstantin Boudnik
      11. HDFS-1134.patch
        58 kB
        Konstantin Boudnik
      12. HDFS-1134.patch
        54 kB
        Konstantin Boudnik
      13. HDFS-1134.patch
        28 kB
        Konstantin Boudnik

        Issue Links

          Activity

          Konstantin Boudnik created issue -
          Konstantin Boudnik made changes -
          Field Original Value New Value
          Link This issue is related to HADOOP-6332 [ HADOOP-6332 ]
          Hide
          Konstantin Boudnik added a comment -

          Initial version of forward port patch. No build changes are included at the moment. Need to iron it out in Common first.

          Show
          Konstantin Boudnik added a comment - Initial version of forward port patch. No build changes are included at the moment. Need to iron it out in Common first.
          Konstantin Boudnik made changes -
          Attachment HDFS-1134.patch [ 12443925 ]
          Konstantin Boudnik made changes -
          Affects Version/s 0.22.0 [ 12314241 ]
          Hide
          Konstantin Boudnik added a comment -

          This patch has all working pieces.
          Few notes:

          • new targets are added: binary-system to build test framework (Herriot) related binary package. This package contains instrumented versions of hadoop-core and hadoop-hdfs. However, HADOOP-6332 doesn't perform mvn-deploy for Herriot artifacts. It only installs them to the local ~/.m2/ repository. The question about naming for this new type of artifacts is still open and needs to be solved.
          • new ivy profile is added to make Herriot artifacts' pull orthogonal to everything else. E.g. instrumented hadoop-core artifacts are pulled only when instrumented HDFS build is ran. Old behavior is intact.
          • target test-system added to run real cluster based tests against a deployed clusters
          • targets jar-system and jar-system-test create instrumented jar files.
          • target mvn-system-install installs instrumented HDFS artifacts to the local ~/.m2/ repo to be used by MR later on
          Show
          Konstantin Boudnik added a comment - This patch has all working pieces. Few notes: new targets are added: binary-system to build test framework (Herriot) related binary package. This package contains instrumented versions of hadoop-core and hadoop-hdfs . However, HADOOP-6332 doesn't perform mvn-deploy for Herriot artifacts. It only installs them to the local ~/.m2/ repository. The question about naming for this new type of artifacts is still open and needs to be solved. new ivy profile is added to make Herriot artifacts' pull orthogonal to everything else. E.g. instrumented hadoop-core artifacts are pulled only when instrumented HDFS build is ran. Old behavior is intact. target test-system added to run real cluster based tests against a deployed clusters targets jar-system and jar-system-test create instrumented jar files. target mvn-system-install installs instrumented HDFS artifacts to the local ~/.m2/ repo to be used by MR later on
          Konstantin Boudnik made changes -
          Attachment HDFS-1134.patch [ 12444762 ]
          Hide
          Konstantin Boudnik added a comment -

          The patch can not be verified until the Maven's deployment procedure isn't resolved for hadoop-core instrumented artifacts. However, the build is running locally without any glitches. Anyone is welcome to try it.

          Show
          Konstantin Boudnik added a comment - The patch can not be verified until the Maven's deployment procedure isn't resolved for hadoop-core instrumented artifacts. However, the build is running locally without any glitches. Anyone is welcome to try it.
          Hide
          Konstantin Boudnik added a comment -

          Missed Ivy's files for HDFS artifacts' publishing.

          Show
          Konstantin Boudnik added a comment - Missed Ivy's files for HDFS artifacts' publishing.
          Konstantin Boudnik made changes -
          Attachment HDFS-1134.patch [ 12444763 ]
          Hide
          Konstantin Boudnik added a comment -

          Update in light of HADOOP-6771 modifications.

          Show
          Konstantin Boudnik added a comment - Update in light of HADOOP-6771 modifications.
          Konstantin Boudnik made changes -
          Attachment HDFS-1134.patch [ 12444872 ]
          Hide
          Konstantin Boudnik added a comment -

          Removing redundant ivy files and optimizing set-version target.

          Show
          Konstantin Boudnik added a comment - Removing redundant ivy files and optimizing set-version target.
          Konstantin Boudnik made changes -
          Attachment HDFS-1134.patch [ 12444961 ]
          Hide
          Konstantin Boudnik added a comment -

          Latest changes according to HADOOP-6771

          Show
          Konstantin Boudnik added a comment - Latest changes according to HADOOP-6771
          Konstantin Boudnik made changes -
          Attachment HDFS-1134.patch [ 12445202 ]
          Konstantin Boudnik made changes -
          Link This issue blocks HDFS-1167 [ HDFS-1167 ]
          Konstantin Boudnik made changes -
          Link This issue is blocked by HADOOP-6771 [ HADOOP-6771 ]
          Vinay Kumar Thota made changes -
          Link This issue blocks HDFS-1174 [ HDFS-1174 ]
          Konstantin Boudnik made changes -
          Affects Version/s 0.21.0 [ 12314046 ]
          Affects Version/s 0.22.0 [ 12314241 ]
          Hide
          Konstantin Boudnik added a comment -

          Re-fitting the patch to be applicable after HDFS-1159. One-liner.

          Show
          Konstantin Boudnik added a comment - Re-fitting the patch to be applicable after HDFS-1159 . One-liner.
          Konstantin Boudnik made changes -
          Attachment HDFS-1134.patch [ 12445511 ]
          Hide
          Konstantin Boudnik added a comment -

          HADOOP-6771 has been committed and now Herrior artifacts are deployed to the maven repo. This patch can be verified now.

          Show
          Konstantin Boudnik added a comment - HADOOP-6771 has been committed and now Herrior artifacts are deployed to the maven repo. This patch can be verified now.
          Konstantin Boudnik made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12445511/HDFS-1134.patch
          against trunk revision 948260.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 32 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          -1 release audit. The applied patch generated 113 release audit warnings (more than the trunk's current 112 warnings).

          -1 core tests. The patch failed core unit tests.

          -1 contrib tests. The patch failed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/181/testReport/
          Release audit warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/181/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/181/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/181/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/181/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12445511/HDFS-1134.patch against trunk revision 948260. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 32 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. -1 release audit. The applied patch generated 113 release audit warnings (more than the trunk's current 112 warnings). -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/181/testReport/ Release audit warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/181/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/181/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/181/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/181/console This message is automatically generated.
          Konstantin Boudnik made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Konstantin Boudnik added a comment -

          This patch adds a work around to the test-patch setting of its own version which affects aspectpath and causing fault injection tests to fail.
          Also, adding Apache license boiler plate to the new config file.

          Show
          Konstantin Boudnik added a comment - This patch adds a work around to the test-patch setting of its own version which affects aspectpath and causing fault injection tests to fail. Also, adding Apache license boiler plate to the new config file.
          Konstantin Boudnik made changes -
          Attachment HDFS-1134.patch [ 12445576 ]
          Hide
          Konstantin Boudnik added a comment -

          Previous verification issues were addressed. Re-starting.

          Show
          Konstantin Boudnik added a comment - Previous verification issues were addressed. Re-starting.
          Konstantin Boudnik made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Konstantin Boudnik made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Konstantin Boudnik added a comment -

          Too wide a mask to include aspect files. Fixing and resubmitting...

          Show
          Konstantin Boudnik added a comment - Too wide a mask to include aspect files. Fixing and resubmitting...
          Konstantin Boudnik made changes -
          Attachment HDFS-1134.patch [ 12445585 ]
          Konstantin Boudnik made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12445576/HDFS-1134.patch
          against trunk revision 948260.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 32 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          -1 contrib tests. The patch failed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/379/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/379/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/379/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/379/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12445576/HDFS-1134.patch against trunk revision 948260. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 32 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/379/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/379/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/379/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/379/console This message is automatically generated.
          Hide
          Konstantin Boudnik added a comment -

          {{testDFSClientDeath }] has timed out. Apparently unrelated to the patch.
          TestHdfsProxy has been failing for about a month now.

          Show
          Konstantin Boudnik added a comment - {{testDFSClientDeath }] has timed out. Apparently unrelated to the patch. TestHdfsProxy has been failing for about a month now.
          Konstantin Boudnik made changes -
          Link This issue blocks HADOOP-6786 [ HADOOP-6786 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12445585/HDFS-1134.patch
          against trunk revision 948634.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 32 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          -1 contrib tests. The patch failed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/380/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/380/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/380/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/380/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12445585/HDFS-1134.patch against trunk revision 948634. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 32 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/380/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/380/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/380/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/380/console This message is automatically generated.
          Hide
          Konstantin Boudnik added a comment -

          Now it is different core test org.apache.hadoop.hdfs.TestFileAppend2.testComplexAppend
          So, apparently it's no patch's fault.

          contrib test is the same as before - infamous TestHdfsProxy

          Show
          Konstantin Boudnik added a comment - Now it is different core test org.apache.hadoop.hdfs.TestFileAppend2.testComplexAppend So, apparently it's no patch's fault. contrib test is the same as before - infamous TestHdfsProxy
          Hide
          Sharad Agarwal added a comment -

          Some comments:

          • hadoop-hdfs-instrumented-test-0.22.0-SNAPSHOT.jar contains tests other than system tests
          • ant binary-system failed with following message:
            build.xml:1019: Warning: Could not find file build-fi/ivy/lib/Hadoop-Hdfs/system/hadoop-core-system-0.22.0-SNAPSHOT.jar to copy.
          • minor: Description for 'jar-system' and 'jar-test-system' needs to be corrected
            ant -p |grep system
             binary-system               make system test package for deployment
             inject-system-faults        Inject system faults
             ivy-retrieve-system         Retrieve Ivy-managed artifacts for the system tests
             jar-system                  make hadoop.jar
             jar-test-system             Make hadoop-hdfs-instrumented.jar with system fault-injection
             test-system                 Run system tests
            
          Show
          Sharad Agarwal added a comment - Some comments: hadoop-hdfs-instrumented-test-0.22.0-SNAPSHOT.jar contains tests other than system tests ant binary-system failed with following message: build.xml:1019: Warning: Could not find file build-fi/ivy/lib/Hadoop-Hdfs/system/hadoop-core-system-0.22.0-SNAPSHOT.jar to copy. minor: Description for 'jar-system' and 'jar-test-system' needs to be corrected ant -p |grep system binary-system make system test package for deployment inject-system-faults Inject system faults ivy-retrieve-system Retrieve Ivy-managed artifacts for the system tests jar-system make hadoop.jar jar-test-system Make hadoop-hdfs-instrumented.jar with system fault-injection test-system Run system tests
          Konstantin Boudnik made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Konstantin Boudnik added a comment -

          Addressing Sharad's comments.
          Build is generating and publishing new artifact jar containing system tests and their sources.
          System tests were moved to src/test/system/test to facilitate build process and artifacts creation.

          Show
          Konstantin Boudnik added a comment - Addressing Sharad's comments. Build is generating and publishing new artifact jar containing system tests and their sources. System tests were moved to src/test/system/test to facilitate build process and artifacts creation.
          Konstantin Boudnik made changes -
          Attachment HDFS-1134.patch [ 12445737 ]
          Konstantin Boudnik made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12445737/HDFS-1134.patch
          against trunk revision 949084.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 37 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/183/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12445737/HDFS-1134.patch against trunk revision 949084. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 37 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/183/console This message is automatically generated.
          Hide
          Konstantin Boudnik added a comment -

          Apparently, git-hub didn't have latest changes from HADOOP-6404

          Show
          Konstantin Boudnik added a comment - Apparently, git-hub didn't have latest changes from HADOOP-6404
          Konstantin Boudnik made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Konstantin Boudnik added a comment -

          Re-fitting after HADOOP-6404 has been committed.

          Show
          Konstantin Boudnik added a comment - Re-fitting after HADOOP-6404 has been committed.
          Konstantin Boudnik made changes -
          Attachment HDFS-1134.patch [ 12445748 ]
          Hide
          Konstantin Boudnik added a comment -

          And again....

          Show
          Konstantin Boudnik added a comment - And again....
          Konstantin Boudnik made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12445748/HDFS-1134.patch
          against trunk revision 949084.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 48 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          -1 contrib tests. The patch failed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/384/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/384/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/384/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/384/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12445748/HDFS-1134.patch against trunk revision 949084. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 48 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/384/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/384/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/384/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/384/console This message is automatically generated.
          Hide
          Sharad Agarwal added a comment -

          Tested targets -> jar-system, jar-test-system. Worked fine. However test-system failed with this:
          src/test/aop/build/aop.xml:138: required attribute suite.type not set
          Could be due to some parameter not being passed. Please manually verify that test-system passes against a real cluster. Barring this, patch looks fine to me.

          Show
          Sharad Agarwal added a comment - Tested targets -> jar-system, jar-test-system. Worked fine. However test-system failed with this: src/test/aop/build/aop.xml:138: required attribute suite.type not set Could be due to some parameter not being passed. Please manually verify that test-system passes against a real cluster. Barring this, patch looks fine to me.
          Konstantin Boudnik made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Konstantin Boudnik added a comment -

          test-system is running against a real cluster. To avoid the hassle of configuring a new 0.22 I have simply used an instrumented 0.20 cluster. Since the code is the same for both the test is valid. And it has passed normally.

          Show
          Konstantin Boudnik added a comment - test-system is running against a real cluster. To avoid the hassle of configuring a new 0.22 I have simply used an instrumented 0.20 cluster. Since the code is the same for both the test is valid. And it has passed normally.
          Konstantin Boudnik made changes -
          Attachment HDFS-1134.patch [ 12445801 ]
          Konstantin Boudnik made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12445801/HDFS-1134.patch
          against trunk revision 949084.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 37 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          -1 contrib tests. The patch failed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/385/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/385/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/385/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/385/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12445801/HDFS-1134.patch against trunk revision 949084. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 37 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/385/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/385/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/385/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/385/console This message is automatically generated.
          Hide
          Konstantin Boudnik added a comment -

          TestLargeDirectoryDelete.largeDelete failure is unrelated.
          TestHdfsProxy is failing on contrib for well over a months now.

          Show
          Konstantin Boudnik added a comment - TestLargeDirectoryDelete.largeDelete failure is unrelated. TestHdfsProxy is failing on contrib for well over a months now.
          Hide
          Sharad Agarwal added a comment -

          +1

          Show
          Sharad Agarwal added a comment - +1
          Hide
          Konstantin Boudnik added a comment -

          I'll commit this by tonight if no one has any objections.

          Show
          Konstantin Boudnik added a comment - I'll commit this by tonight if no one has any objections.
          Hide
          Konstantin Boudnik added a comment -

          It turns out that the posted patch has dependency on hadoop-core artifacts instead of hadoop-common. I'm pushing the correct one and here's the difference between the two

          < +    <copy tofile="${system-test-build-dir}/${final.name}/lib/hadoop-core-${version}.jar"
          < +      file="${build-fi.dir}/ivy/lib/${ant.project.name}/system/hadoop-core-${herriot.suffix}-${version}.jar"
          ---
          > +    <copy tofile="${system-test-build-dir}/${final.name}/lib/hadoop-common-${version}.jar"
          > +      file="${build-fi.dir}/ivy/lib/${ant.project.name}/system/hadoop-common-${herriot.suffix}-${version}.jar"
          440c440
          < +      <artifactId>hadoop-core-instrumented</artifactId>
          ---
          > +      <artifactId>hadoop-common-instrumented</artifactId>
          

          I don't think this needs to be verified separately because this particular difference can't be checked by test-patch.sh anyways.

          Show
          Konstantin Boudnik added a comment - It turns out that the posted patch has dependency on hadoop-core artifacts instead of hadoop-common . I'm pushing the correct one and here's the difference between the two < + <copy tofile="${system-test-build-dir}/${final.name}/lib/hadoop-core-${version}.jar" < + file="${build-fi.dir}/ivy/lib/${ant.project.name}/system/hadoop-core-${herriot.suffix}-${version}.jar" --- > + <copy tofile="${system-test-build-dir}/${final.name}/lib/hadoop-common-${version}.jar" > + file="${build-fi.dir}/ivy/lib/${ant.project.name}/system/hadoop-common-${herriot.suffix}-${version}.jar" 440c440 < + <artifactId>hadoop-core-instrumented</artifactId> --- > + <artifactId>hadoop-common-instrumented</artifactId> I don't think this needs to be verified separately because this particular difference can't be checked by test-patch.sh anyways.
          Konstantin Boudnik made changes -
          Attachment HDFS-1134.patch [ 12446080 ]
          Konstantin Boudnik made changes -
          Link This issue blocks HDFS-1157 [ HDFS-1157 ]
          Hide
          Konstantin Boudnik added a comment -

          I've just committed this to the trunk and 0.21 branch. The latter is slightly different from the trunk to account for the difference in the source code (i.e. KerberosInfo class isn't present}}

          Show
          Konstantin Boudnik added a comment - I've just committed this to the trunk and 0.21 branch. The latter is slightly different from the trunk to account for the difference in the source code (i.e. KerberosInfo class isn't present}}
          Konstantin Boudnik made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags [Reviewed]
          Fix Version/s 0.21.0 [ 12314046 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #298 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/298/)

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #298 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/298/ )
          Konstantin Boudnik made changes -
          Link This issue relates to HDFS-1341 [ HDFS-1341 ]
          Tom White made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Konstantin Boudnik made changes -
          Tags herriot
          Gavin made changes -
          Link This issue blocks HDFS-1167 [ HDFS-1167 ]
          Gavin made changes -
          Link This issue is depended upon by HDFS-1167 [ HDFS-1167 ]
          Gavin made changes -
          Link This issue blocks HDFS-1157 [ HDFS-1157 ]
          Gavin made changes -
          Link This issue is depended upon by HDFS-1157 [ HDFS-1157 ]
          Gavin made changes -
          Link This issue blocks HDFS-1174 [ HDFS-1174 ]
          Gavin made changes -
          Link This issue is depended upon by HDFS-1174 [ HDFS-1174 ]

            People

            • Assignee:
              Konstantin Boudnik
              Reporter:
              Konstantin Boudnik
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development