Integrated in Hadoop-Mapreduce-trunk-Commit #523 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/523/)

Integrated in Hadoop-Common-trunk #438 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/438/)
HADOOP-6786. test-patch needs to verify Herriot integrity. Contributed by Konstantin Boudnik

Integrated in Hadoop-Hdfs-trunk-Commit #377 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/377/)
HADOOP-6786. test-patch needs to verify Herriot integrity. Contributed by Konstantin Boudnik

Integrated in Hadoop-Common-trunk-Commit #368 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/368/)
HADOOP-6786. test-patch needs to verify Herriot integrity. Contributed by Konstantin Boudnik

I have committed this to 0.21 and trunk.

I'll be committing this by end of today or Monday if there's no objections.

Hudson seems to be not at his best for the last a couple of weeks. I have ran test-patch.sh on my dev. machine.

-1 overall.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 4 new or modified tests.

    -1 javadoc.  The javadoc tool appears to have generated 1 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

The javadoc warning is apparently not connected to the patch itself. The only warnings I can see are in security related classes.

No luck with Hudson.

Hudson doesn't pick it up even after the queue has been cleaned... One more

+1 the new patch looks good.

Seems to be stuck. resubmitting

Thanks for catching it up, Nicholas. (note to self: there's no 'simple' patches, damn it). Attaching new version and re-submitting the patch.

I think we need

  (( RESULT = RESULT + $? ))

after calling checkInjectSystemFaults.

PreTestTarget is a garbage I have missed out. Removed.
The target inject-system-faults is defined in src/test/aop/build/aop.xml

I may have missed something:

• In the code below, why setting PreTestTarget to a empty string?

  +  PreTestTarget=""
  +
  +  echo "$ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes -Dcompile.c++=yes -Dforrest.home=$FORREST_HOME -Djava5.home=$JAVA5_HOME $PreTestTarget inject-system-faults"
  +  $ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes -Dcompile.c++=yes -Dforrest.home=$FORREST_HOME -Djava5.home=$JAVA5_HOME $PreTestTarget inject-system-faults
  

• The inject-system-faults target is not found in build.xml. Where is it defined?

all the patch test builds run on ubuntu machines and kill cmd seem to reside in /bin/kill

I wonder how it works in two other places (for core and contrib tests) then?

+ $PS auxwww | $GREP HadoopPatchProcess | /usr/bin/nawk '

Unknown macro: {print $2}

' | /usr/bin/xargs -t -I {} /usr/bin/kill -9 {} > /dev/null

all the patch test builds run on ubuntu machines and kill cmd seem to reside in /bin/kill

A review, please? All blockers were resolved.

+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12445609/HADOOP-6786.patch
against trunk revision 948573.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 4 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/549/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/549/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/549/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/549/console

This message is automatically generated.

The patch can be verified in Common because Herriot framework is already integrated here.
Also, I have ran the new version of test-patch.sh locally and I can see that the required target is being invoked and new check's result is printed at the end of the process:

    +1 system tests framework.  The patch passed system tests framework compile.

This shouldn't be committed before these JIRAs are integrated because they introduce inject-system-faults target.

The patch introduces new check which makes sure that system test framework bindings aren't broken by running inject-system-faults target. This is a simple compilation + aspect weaving and doesn't execute any additional tests.

To achieve this test-patch needs to execute one more ant target inject-system-faults which will perform aspects weaving and will guarantee that changes in the source code doesn't brake the integrity of the test code.