Patch changes artifact id to hadoop-core-system-test and adds -mvn-system-deploy target to perform artifacts deployment for test framework's jars. I have tested it locally and seems to do the right thing however I can't do actual deployment for the lack of credentials. Please review.

Ready for verification.

+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12444871/HADOOP-6771.patch
against trunk revision 945953.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 3 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/530/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/530/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/530/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/530/console

This message is automatically generated.

set-version ant target is used to set the version string and create a pom file using the template file.
In this patch I see both the template and the created file.. Any reason?

Here I see:
hadoop-core-test-template.xml
hadoop-core-test.xml
hadoop-core-system-test-template.xml
hadoop-core-system-test.xml

clean target is supposed to clean the created pom files inside the ivy folder.

Adressing Giri's comment I have removed mistakenly added hadoop-core-system-test.xml file and modified set-version target to generate it when needed.

The other file (and a .pom file hadoop-core.pom) were added earlier. I believe those have to go because they seem to be redundant.

Patch has been regenerated thus the verification.

+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12444960/HADOOP-6771.patch
against trunk revision 945953.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 3 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/531/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/531/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/531/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/531/console

This message is automatically generated.

In the conversation with Chris we have agreed that 'instrumented' suffix is more proper way to distinguish Herriot artifacts.

Changed again. Re-verification.

+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12445131/HADOOP-6771.patch
against trunk revision 946815.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 3 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/536/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/536/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/536/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/536/console

This message is automatically generated.

patch works fine in publishing artifacts to the mvn snapshot repo.

minor stuff:
Please use ant clean target to remove the generated ivy/hadoop-core-instrumented.xml file

patch leaves 3 empty files

ivy/hadoop-core-system.xml
ivy/hadoop-core-system-template.xml
ivy/hadoop-core-system.pom

One-liner modification according to Giri's comment: cleaning the generated file during clean invocation.

+1 looks good

I'll gonna commit this in the next a couple of hours unless there are objections.

This JIRA is on critical path and is blocks the progress for above tickets.

I have committed it to the trunk and 0.21 branch.

Integrated in Hadoop-Common-trunk-Commit #265 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/265/)
HADOOP-6771. Herriot's artifact id for Maven deployment should be set to
hadoop-core-instrumented. Contributed by Konstantin Boudnik.

Integrated in Hadoop-Common-trunk #346 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/346/)