Hadoop Common
  1. Hadoop Common
  2. HADOOP-6332 Large-scale Automated Test Framework
  3. HADOOP-6771

Herriot's artifact id for Maven deployment should be set to hadoop-core-instrumented

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.21.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Tags:
      herriot
    1. HADOOP-6771.patch
      26 kB
      Konstantin Boudnik
    2. HADOOP-6771.patch
      26 kB
      Konstantin Boudnik
    3. HADOOP-6771.patch
      26 kB
      Konstantin Boudnik
    4. HADOOP-6771.patch
      29 kB
      Konstantin Boudnik

      Issue Links

        Activity

        Konstantin Boudnik made changes -
        Tags herriot
        Tom White made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Konstantin Boudnik made changes -
        Link This issue relates to HADOOP-6789 [ HADOOP-6789 ]
        Konstantin Boudnik made changes -
        Link This issue relates to HADOOP-6789 [ HADOOP-6789 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #346 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/346/)

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #346 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/346/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #265 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/265/)
        HADOOP-6771. Herriot's artifact id for Maven deployment should be set to
        hadoop-core-instrumented. Contributed by Konstantin Boudnik.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #265 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/265/ ) HADOOP-6771 . Herriot's artifact id for Maven deployment should be set to hadoop-core-instrumented. Contributed by Konstantin Boudnik.
        Konstantin Boudnik made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Resolution Fixed [ 1 ]
        Hide
        Konstantin Boudnik added a comment -

        I have committed it to the trunk and 0.21 branch.

        Show
        Konstantin Boudnik added a comment - I have committed it to the trunk and 0.21 branch.
        Konstantin Boudnik made changes -
        Summary Artifact id for Maven deployment should be set to hadoop-core-instrumented Herriot's artifact id for Maven deployment should be set to hadoop-core-instrumented
        Konstantin Boudnik made changes -
        Link This issue blocks MAPREDUCE-1774 [ MAPREDUCE-1774 ]
        Hide
        Konstantin Boudnik added a comment -

        This JIRA is on critical path and is blocks the progress for above tickets.

        Show
        Konstantin Boudnik added a comment - This JIRA is on critical path and is blocks the progress for above tickets.
        Konstantin Boudnik made changes -
        Link This issue blocks HDFS-1134 [ HDFS-1134 ]
        Hide
        Konstantin Boudnik added a comment -

        I'll gonna commit this in the next a couple of hours unless there are objections.

        Show
        Konstantin Boudnik added a comment - I'll gonna commit this in the next a couple of hours unless there are objections.
        Hide
        Giridharan Kesavan added a comment -

        +1 looks good

        Show
        Giridharan Kesavan added a comment - +1 looks good
        Konstantin Boudnik made changes -
        Attachment HADOOP-6771.patch [ 12445372 ]
        Hide
        Konstantin Boudnik added a comment -

        One-liner modification according to Giri's comment: cleaning the generated file during clean invocation.

        Show
        Konstantin Boudnik added a comment - One-liner modification according to Giri's comment: cleaning the generated file during clean invocation.
        Hide
        Giridharan Kesavan added a comment -

        patch works fine in publishing artifacts to the mvn snapshot repo.

        minor stuff:
        Please use ant clean target to remove the generated ivy/hadoop-core-instrumented.xml file

        patch leaves 3 empty files

        ivy/hadoop-core-system.xml
        ivy/hadoop-core-system-template.xml
        ivy/hadoop-core-system.pom

        Show
        Giridharan Kesavan added a comment - patch works fine in publishing artifacts to the mvn snapshot repo. minor stuff: Please use ant clean target to remove the generated ivy/hadoop-core-instrumented.xml file patch leaves 3 empty files ivy/hadoop-core-system.xml ivy/hadoop-core-system-template.xml ivy/hadoop-core-system.pom
        Konstantin Boudnik made changes -
        Summary Artifact id for Maven deployment should be set to hadoop-core-system-test Artifact id for Maven deployment should be set to hadoop-core-instrumented
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12445131/HADOOP-6771.patch
        against trunk revision 946815.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/536/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/536/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/536/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/536/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12445131/HADOOP-6771.patch against trunk revision 946815. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/536/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/536/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/536/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/536/console This message is automatically generated.
        Konstantin Boudnik made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Konstantin Boudnik added a comment -

        Changed again. Re-verification.

        Show
        Konstantin Boudnik added a comment - Changed again. Re-verification.
        Konstantin Boudnik made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Konstantin Boudnik made changes -
        Attachment HADOOP-6771.patch [ 12445131 ]
        Hide
        Konstantin Boudnik added a comment -

        In the conversation with Chris we have agreed that 'instrumented' suffix is more proper way to distinguish Herriot artifacts.

        Show
        Konstantin Boudnik added a comment - In the conversation with Chris we have agreed that 'instrumented' suffix is more proper way to distinguish Herriot artifacts.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12444960/HADOOP-6771.patch
        against trunk revision 945953.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/531/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/531/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/531/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/531/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12444960/HADOOP-6771.patch against trunk revision 945953. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/531/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/531/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/531/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/531/console This message is automatically generated.
        Konstantin Boudnik made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Konstantin Boudnik added a comment -

        Patch has been regenerated thus the verification.

        Show
        Konstantin Boudnik added a comment - Patch has been regenerated thus the verification.
        Konstantin Boudnik made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Konstantin Boudnik made changes -
        Component/s build [ 12311543 ]
        Konstantin Boudnik made changes -
        Attachment HADOOP-6771.patch [ 12444960 ]
        Hide
        Konstantin Boudnik added a comment -

        Adressing Giri's comment I have removed mistakenly added hadoop-core-system-test.xml file and modified set-version target to generate it when needed.

        The other file (and a .pom file hadoop-core.pom) were added earlier. I believe those have to go because they seem to be redundant.

        Show
        Konstantin Boudnik added a comment - Adressing Giri's comment I have removed mistakenly added hadoop-core-system-test.xml file and modified set-version target to generate it when needed. The other file (and a .pom file hadoop-core.pom ) were added earlier. I believe those have to go because they seem to be redundant.
        Hide
        Giridharan Kesavan added a comment -

        set-version ant target is used to set the version string and create a pom file using the template file.
        In this patch I see both the template and the created file.. Any reason?

        Here I see:
        hadoop-core-test-template.xml
        hadoop-core-test.xml
        hadoop-core-system-test-template.xml
        hadoop-core-system-test.xml

        clean target is supposed to clean the created pom files inside the ivy folder.

        Show
        Giridharan Kesavan added a comment - set-version ant target is used to set the version string and create a pom file using the template file. In this patch I see both the template and the created file.. Any reason? Here I see: hadoop-core-test-template.xml hadoop-core-test.xml hadoop-core-system-test-template.xml hadoop-core-system-test.xml clean target is supposed to clean the created pom files inside the ivy folder.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12444871/HADOOP-6771.patch
        against trunk revision 945953.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/530/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/530/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/530/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/530/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12444871/HADOOP-6771.patch against trunk revision 945953. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/530/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/530/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/530/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/530/console This message is automatically generated.
        Konstantin Boudnik made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Affects Version/s 0.21.0 [ 12313563 ]
        Fix Version/s 0.21.0 [ 12313563 ]
        Hide
        Konstantin Boudnik added a comment -

        Ready for verification.

        Show
        Konstantin Boudnik added a comment - Ready for verification.
        Konstantin Boudnik made changes -
        Field Original Value New Value
        Attachment HADOOP-6771.patch [ 12444871 ]
        Hide
        Konstantin Boudnik added a comment -

        Patch changes artifact id to hadoop-core-system-test and adds -mvn-system-deploy target to perform artifacts deployment for test framework's jars. I have tested it locally and seems to do the right thing however I can't do actual deployment for the lack of credentials. Please review.

        Show
        Konstantin Boudnik added a comment - Patch changes artifact id to hadoop-core-system-test and adds -mvn-system-deploy target to perform artifacts deployment for test framework's jars. I have tested it locally and seems to do the right thing however I can't do actual deployment for the lack of credentials. Please review.
        Konstantin Boudnik created issue -

          People

          • Assignee:
            Konstantin Boudnik
            Reporter:
            Konstantin Boudnik
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development