Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1167

New property for local conf directory in system-test-hdfs.xml file.

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: test
    • Labels:
      None
    • Environment:

      herriot

    • Hadoop Flags:
      Reviewed
    • Tags:
      herriot

      Description

      Adding new property in system-test.xml file for local configuration directory.

      1. HDFS-1167.patch
        0.7 kB
        Vinay Kumar Thota
      2. HDFS-1167.patch
        0.7 kB
        Konstantin Boudnik
      3. hdfs-1167.patch
        0.7 kB
        Konstantin Boudnik

        Issue Links

          Activity

          Hide
          Vinay Kumar Thota added a comment -

          Initial patch.

          Show
          Vinay Kumar Thota added a comment - Initial patch.
          Hide
          Konstantin Boudnik added a comment -

          File name is wrong. Fixed in the new version of the patch.
          +1 looks good otherwise.

          Show
          Konstantin Boudnik added a comment - File name is wrong. Fixed in the new version of the patch. +1 looks good otherwise.
          Hide
          Sharad Agarwal added a comment -

          Isn't is a generic property, not HDFS specific ? I think this should be in common.

          Show
          Sharad Agarwal added a comment - Isn't is a generic property, not HDFS specific ? I think this should be in common.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12445224/HDFS-1167.patch
          against trunk revision 962908.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          -1 release audit. The applied patch generated 103 release audit warnings (more than the trunk's current 0 warnings).

          -1 core tests. The patch failed core unit tests.

          -1 contrib tests. The patch failed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/214/testReport/
          Release audit warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/214/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/214/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/214/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/214/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12445224/HDFS-1167.patch against trunk revision 962908. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. -1 release audit. The applied patch generated 103 release audit warnings (more than the trunk's current 0 warnings). -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/214/testReport/ Release audit warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/214/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/214/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/214/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/214/console This message is automatically generated.
          Hide
          Vinay Kumar Thota added a comment -

          I could see 6 failures and they are unrelated to this patch. I don't think so the patch could raise these failures because the scope is just adds the new property in a xml file.

          Show
          Vinay Kumar Thota added a comment - I could see 6 failures and they are unrelated to this patch. I don't think so the patch could raise these failures because the scope is just adds the new property in a xml file.
          Hide
          Konstantin Boudnik added a comment -

          I am trying to understand the logic behind this patch. Why can't we use a system temp directory for these purposes? Why do we need a special variable just for the configs? Perhaps, I missing something?

          Show
          Konstantin Boudnik added a comment - I am trying to understand the logic behind this patch. Why can't we use a system temp directory for these purposes? Why do we need a special variable just for the configs? Perhaps, I missing something?
          Hide
          Konstantin Boudnik added a comment -

          Ok, looks like the code for this has been committed to Common a long time ago. The change for the config hasn't come through somehow. There should be a similar change for MR.

          As for putting this config thing into common: as much as it might seem suitable we can't do it because Common's part of Herriot doesn't have any config processing in it ;( In fact, I think we did a wrong thing when getHadoopLocalConfDir has been added to Common code. This has created indirect dependency to the config processing logic in upstream components (HDFS, MR).

          Therefore, I think this patch (and its counterpart) can be committed to make the change complete for now. However, a new JIRA needs to be created to refactor this method away from the Common module.

          Show
          Konstantin Boudnik added a comment - Ok, looks like the code for this has been committed to Common a long time ago. The change for the config hasn't come through somehow. There should be a similar change for MR. As for putting this config thing into common: as much as it might seem suitable we can't do it because Common's part of Herriot doesn't have any config processing in it ;( In fact, I think we did a wrong thing when getHadoopLocalConfDir has been added to Common code. This has created indirect dependency to the config processing logic in upstream components (HDFS, MR). Therefore, I think this patch (and its counterpart) can be committed to make the change complete for now. However, a new JIRA needs to be created to refactor this method away from the Common module.
          Hide
          Konstantin Boudnik added a comment -

          Slightly polished description.

          Show
          Konstantin Boudnik added a comment - Slightly polished description.
          Hide
          Konstantin Boudnik added a comment -

          I have committed this to trunk and branch-0.22. Thank you VInay

          Show
          Konstantin Boudnik added a comment - I have committed this to trunk and branch-0.22. Thank you VInay

            People

            • Assignee:
              Vinay Kumar Thota
              Reporter:
              Vinay Kumar Thota
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development