[HBASE-21915] FileLink$FileLinkInputStream doesn't implement CanUnbuffer

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0.0-alpha-1, 2.2.0, 1.4.10, 2.0.5, 2.3.0, 2.1.4
• Component/s: Filesystem Integration
• Hadoop Flags: Reviewed
• Assignee: Josh Elser
• Reporter: Josh Elser
• Created: 15/Feb/19 20:49
• Updated: 28/Oct/19 18:36
• Resolved: 04/Mar/19 19:30

Description

FileLinkInputStream is an InputStream which handles the indirection of where the real HFile lives. This implementation is wrapped via FSDataInputStreamWrapper and is transparent when it's being used by a caller. Often, we have an FSDataInputStreamWrapper wrapping a FileLinkInputStream which wraps an FSDataInputStream.

The problem is that FileLinkInputStream does not implement the CanUnbuffer interface, which means that the underlying FSDataInputStream for the HFile the link refers to doesn't get unbuffer() called on it. This can cause an open Socket to hang around, as described in HBASE-9393.

Both Wellington Chevreuil and myself have run into this, each for different users. We think the commonality as to why these users saw this (but we haven't run into it on our own) is that it requires a very large snapshot to be brought into a new system. Big kudos to Esteban Gutierrez for his help in diagnosing this as well!

If this analysis is accurate, it would affect all branches.

 

Issue Links

• is related to: HBASE-23195 FSDataInputStreamWrapper unbuffer can NOT invoke the classes that NOT implements CanUnbuffer but its parents class implements CanUnbuffer

Sub-Tasks

• Remove hadoop2.6.1-hadoop-2.6.4 as supported on branch-2.0: Resolved
• Revert HBASE-21915 from branch-2.0: Resolved