Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-21915

FileLink$FileLinkInputStream doesn't implement CanUnbuffer

    XMLWordPrintableJSON

    Details

    • Hadoop Flags:
      Reviewed

      Description

      FileLinkInputStream is an InputStream which handles the indirection of where the real HFile lives. This implementation is wrapped via FSDataInputStreamWrapper and is transparent when it's being used by a caller. Often, we have an FSDataInputStreamWrapper wrapping a FileLinkInputStream which wraps an FSDataInputStream.

      The problem is that FileLinkInputStream does not implement the CanUnbuffer interface, which means that the underlying FSDataInputStream for the HFile the link refers to doesn't get unbuffer() called on it. This can cause an open Socket to hang around, as described in HBASE-9393.

      Both Wellington Chevreuil and myself have run into this, each for different users. We think the commonality as to why these users saw this (but we haven't run into it on our own) is that it requires a very large snapshot to be brought into a new system. Big kudos to Esteban Gutierrez for his help in diagnosing this as well!

      If this analysis is accurate, it would affect all branches.

       

        Attachments

        1. HBASE-21915.002.patch
          2 kB
          Josh Elser
        2. HBASE-21915.001.patch
          2 kB
          Josh Elser

          Issue Links

          There are no Sub-Tasks for this issue.

            Activity

              People

              • Assignee:
                elserj Josh Elser
                Reporter:
                elserj Josh Elser
              • Votes:
                0 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: