Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-9393

Hbase does not closing a closed socket resulting in many CLOSE_WAIT

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 0.94.2, 0.98.0, 1.0.1.1, 1.1.2
    • Fix Version/s: 2.0.0, 1.4.0, 1.3.2, 1.2.7, 1.1.12
    • Component/s: None
    • Labels:
      None
    • Environment:

      Centos 6.4 - 7 regionservers/datanodes, 8 TB per node, 7279 regions

    • Hadoop Flags:
      Reviewed
    • Release Note:
      Hide
      To handle this issue client need to have Hadoop client 2.6.4 or 2.7.0+ Hadoop version as CanUnBuffer interface which was added as part of HDFS-7694 is available in only those versions.
      Show
      To handle this issue client need to have Hadoop client 2.6.4 or 2.7.0+ Hadoop version as CanUnBuffer interface which was added as part of HDFS-7694 is available in only those versions.

      Description

      HBase dose not close a dead connection with the datanode.
      This resulting in over 60K CLOSE_WAIT and at some point HBase can not connect to the datanode because too many mapped sockets from one host to another on the same port.

      The example below is with low CLOSE_WAIT count because we had to restart hbase to solve the porblem, later in time it will incease to 60-100K sockets on CLOSE_WAIT

      [root@hd2-region3 ~]# netstat -nap |grep CLOSE_WAIT |grep 21592 |wc -l
      13156
      [root@hd2-region3 ~]# ps -ef |grep 21592
      root 17255 17219 0 12:26 pts/0 00:00:00 grep 21592
      hbase 21592 1 17 Aug29 ? 03:29:06 /usr/java/jdk1.6.0_26/bin/java -XX:OnOutOfMemoryError=kill -9 %p -Xmx8000m -ea -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode -Dhbase.log.dir=/var/log/hbase -Dhbase.log.file=hbase-hbase-regionserver-hd2-region3.swnet.corp.log ...

      1. HBASE-9393.patch
        8 kB
        Ashish Singhi
      2. HBASE-9393.v1.patch
        4 kB
        Ashish Singhi
      3. HBASE-9393.v10.patch
        10 kB
        Ashish Singhi
      4. HBASE-9393.v11.patch
        10 kB
        Ashish Singhi
      5. HBASE-9393.v12.patch
        9 kB
        Ashish Singhi
      6. HBASE-9393.v13.patch
        10 kB
        Ashish Singhi
      7. HBASE-9393.v14.patch
        10 kB
        Ashish Singhi
      8. HBASE-9393.v15.patch
        10 kB
        Ashish Singhi
      9. HBASE-9393.v15.patch
        10 kB
        Ashish Singhi
      10. HBASE-9393.v16.patch
        10 kB
        Ashish Singhi
      11. HBASE-9393.v16.patch
        10 kB
        Ashish Singhi
      12. HBASE-9393.v17.patch
        11 kB
        Ashish Singhi
      13. HBASE-9393.v18.patch
        12 kB
        Ashish Singhi
      14. HBASE-9393.v2.patch
        5 kB
        Ashish Singhi
      15. HBASE-9393.v3.patch
        6 kB
        Ashish Singhi
      16. HBASE-9393.v4.patch
        6 kB
        Ashish Singhi
      17. HBASE-9393.v5.patch
        6 kB
        stack
      18. HBASE-9393.v5.patch
        6 kB
        stack
      19. HBASE-9393.v5.patch
        6 kB
        Ashish Singhi
      20. HBASE-9393.v6.patch
        7 kB
        Ashish Singhi
      21. HBASE-9393.v6.patch
        7 kB
        Ashish Singhi
      22. HBASE-9393.v6.patch
        7 kB
        Ashish Singhi
      23. HBASE-9393.v7.patch
        8 kB
        Ashish Singhi
      24. HBASE-9393.v8.patch
        9 kB
        Ashish Singhi
      25. HBASE-9393.v9.patch
        9 kB
        Ashish Singhi
      26. HBASE-9393-branch-1.patch
        14 kB
        Ashish Singhi

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build HBase-1.1-JDK8 #1966 (See https://builds.apache.org/job/HBase-1.1-JDK8/1966/)
          HBASE-9393 Hbase does not closing a closed socket resulting in many (busbey: rev 0aa1343cdb2256ca1b6c7fab6d9ae569ba35e2fc)

          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileScanner.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileReader.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build HBase-1.1-JDK8 #1966 (See https://builds.apache.org/job/HBase-1.1-JDK8/1966/ ) HBASE-9393 Hbase does not closing a closed socket resulting in many (busbey: rev 0aa1343cdb2256ca1b6c7fab6d9ae569ba35e2fc) (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileScanner.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileReader.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build HBase-1.1-JDK7 #1883 (See https://builds.apache.org/job/HBase-1.1-JDK7/1883/)
          HBASE-9393 Hbase does not closing a closed socket resulting in many (busbey: rev 0aa1343cdb2256ca1b6c7fab6d9ae569ba35e2fc)

          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileScanner.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileReader.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build HBase-1.1-JDK7 #1883 (See https://builds.apache.org/job/HBase-1.1-JDK7/1883/ ) HBASE-9393 Hbase does not closing a closed socket resulting in many (busbey: rev 0aa1343cdb2256ca1b6c7fab6d9ae569ba35e2fc) (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileScanner.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileReader.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java
          Hide
          busbey Sean Busbey added a comment -

          backported to branch-1.1+. Is it worth calling this out in the Hadoop section of the ref guide?

          Show
          busbey Sean Busbey added a comment - backported to branch-1.1+. Is it worth calling this out in the Hadoop section of the ref guide?
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build HBase-1.2-JDK7 #153 (See https://builds.apache.org/job/HBase-1.2-JDK7/153/)
          HBASE-9393 Hbase does not closing a closed socket resulting in many (busbey: rev 2bde1ac4050eeaaa262c41459a6590359e69d78c)

          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileScanner.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileReader.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build HBase-1.2-JDK7 #153 (See https://builds.apache.org/job/HBase-1.2-JDK7/153/ ) HBASE-9393 Hbase does not closing a closed socket resulting in many (busbey: rev 2bde1ac4050eeaaa262c41459a6590359e69d78c) (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileScanner.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileReader.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build HBase-1.2-JDK8 #149 (See https://builds.apache.org/job/HBase-1.2-JDK8/149/)
          HBASE-9393 Hbase does not closing a closed socket resulting in many (busbey: rev 2bde1ac4050eeaaa262c41459a6590359e69d78c)

          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileReader.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileScanner.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build HBase-1.2-JDK8 #149 (See https://builds.apache.org/job/HBase-1.2-JDK8/149/ ) HBASE-9393 Hbase does not closing a closed socket resulting in many (busbey: rev 2bde1ac4050eeaaa262c41459a6590359e69d78c) (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileReader.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileScanner.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build HBase-1.3-JDK7 #183 (See https://builds.apache.org/job/HBase-1.3-JDK7/183/)
          HBASE-9393 Hbase does not closing a closed socket resulting in many (busbey: rev e3bda837947ad2d49fc59942e062a37124a754dc)

          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileReader.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileScanner.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build HBase-1.3-JDK7 #183 (See https://builds.apache.org/job/HBase-1.3-JDK7/183/ ) HBASE-9393 Hbase does not closing a closed socket resulting in many (busbey: rev e3bda837947ad2d49fc59942e062a37124a754dc) (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileReader.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileScanner.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build HBase-1.3-JDK8 #197 (See https://builds.apache.org/job/HBase-1.3-JDK8/197/)
          HBASE-9393 Hbase does not closing a closed socket resulting in many (busbey: rev e3bda837947ad2d49fc59942e062a37124a754dc)

          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileScanner.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileReader.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build HBase-1.3-JDK8 #197 (See https://builds.apache.org/job/HBase-1.3-JDK8/197/ ) HBASE-9393 Hbase does not closing a closed socket resulting in many (busbey: rev e3bda837947ad2d49fc59942e062a37124a754dc) (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileScanner.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileReader.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build HBase-1.2-IT #886 (See https://builds.apache.org/job/HBase-1.2-IT/886/)
          HBASE-9393 Hbase does not closing a closed socket resulting in many (busbey: rev 2bde1ac4050eeaaa262c41459a6590359e69d78c)

          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileReader.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileScanner.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build HBase-1.2-IT #886 (See https://builds.apache.org/job/HBase-1.2-IT/886/ ) HBASE-9393 Hbase does not closing a closed socket resulting in many (busbey: rev 2bde1ac4050eeaaa262c41459a6590359e69d78c) (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileReader.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileScanner.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build HBase-1.3-IT #65 (See https://builds.apache.org/job/HBase-1.3-IT/65/)
          HBASE-9393 Hbase does not closing a closed socket resulting in many (busbey: rev e3bda837947ad2d49fc59942e062a37124a754dc)

          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileReader.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileScanner.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build HBase-1.3-IT #65 (See https://builds.apache.org/job/HBase-1.3-IT/65/ ) HBASE-9393 Hbase does not closing a closed socket resulting in many (busbey: rev e3bda837947ad2d49fc59942e062a37124a754dc) (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileReader.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileScanner.java
          Hide
          mantonov Mikhail Antonov added a comment -

          Missed this one. Yeah, that would be good to get to branch-1.3 Sean Busbey - thanks!

          Show
          mantonov Mikhail Antonov added a comment - Missed this one. Yeah, that would be good to get to branch-1.3 Sean Busbey - thanks!
          Hide
          busbey Sean Busbey added a comment -

          I agree, good for backport. Mikhail Antonov any concerns for branch-1.3?

          Show
          busbey Sean Busbey added a comment - I agree, good for backport. Mikhail Antonov any concerns for branch-1.3?
          Hide
          ndimiduk Nick Dimiduk added a comment -

          This does seem like a good fix to backport.

          Show
          ndimiduk Nick Dimiduk added a comment - This does seem like a good fix to backport.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3148 (See https://builds.apache.org/job/HBase-Trunk_matrix/3148/)
          HBASE-9393 Hbase does not closing a closed socket resulting in many (apurtell: rev 1950acc67a2510be370d6fc7859b562e58070942)

          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3148 (See https://builds.apache.org/job/HBase-Trunk_matrix/3148/ ) HBASE-9393 Hbase does not closing a closed socket resulting in many (apurtell: rev 1950acc67a2510be370d6fc7859b562e58070942) (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Jenkins build HBase-1.4 #762 (See https://builds.apache.org/job/HBase-1.4/762/)
          HBASE-9393 Hbase does not closing a closed socket resulting in many (apurtell: rev 356d4e9187fc6748169d3aaebe516fb2257d8835)

          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileReader.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileScanner.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-1.4 #762 (See https://builds.apache.org/job/HBase-1.4/762/ ) HBASE-9393 Hbase does not closing a closed socket resulting in many (apurtell: rev 356d4e9187fc6748169d3aaebe516fb2257d8835) (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileReader.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileScanner.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
          Hide
          apurtell Andrew Purtell added a comment -

          Pushed to master and branch-1.

          Sean Busbey interested in this for 1.2?
          Mikhail Antonov want this in 1.3?
          Nick Dimiduk maybe for 1.1?

          Show
          apurtell Andrew Purtell added a comment - Pushed to master and branch-1. Sean Busbey interested in this for 1.2? Mikhail Antonov want this in 1.3? Nick Dimiduk maybe for 1.1?
          Hide
          apurtell Andrew Purtell added a comment -

          Thanks Ashish Singhi. Will check if the branch-1 failures are repeatable. That findbugs warning doesn't come from this patch. Master patch looks good in any case. Will commit shortly unless objection

          Show
          apurtell Andrew Purtell added a comment - Thanks Ashish Singhi . Will check if the branch-1 failures are repeatable. That findbugs warning doesn't come from this patch. Master patch looks good in any case. Will commit shortly unless objection
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 26s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 2m 9s branch-1 passed
          +1 compile 0m 42s branch-1 passed with JDK v1.8.0_131
          +1 compile 0m 43s branch-1 passed with JDK v1.7.0_131
          +1 checkstyle 1m 0s branch-1 passed
          +1 mvneclipse 0m 20s branch-1 passed
          -1 findbugs 2m 22s hbase-server in branch-1 has 1 extant Findbugs warnings.
          +1 javadoc 0m 35s branch-1 passed with JDK v1.8.0_131
          +1 javadoc 0m 40s branch-1 passed with JDK v1.7.0_131
          +1 mvninstall 0m 50s the patch passed
          +1 compile 0m 39s the patch passed with JDK v1.8.0_131
          +1 javac 0m 39s the patch passed
          +1 compile 0m 41s the patch passed with JDK v1.7.0_131
          +1 javac 0m 41s the patch passed
          +1 checkstyle 1m 2s the patch passed
          +1 mvneclipse 0m 19s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 hadoopcheck 17m 49s The patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1.
          +1 hbaseprotoc 0m 19s the patch passed
          +1 findbugs 2m 37s the patch passed
          +1 javadoc 0m 32s the patch passed with JDK v1.8.0_131
          +1 javadoc 0m 40s the patch passed with JDK v1.7.0_131
          -1 unit 97m 53s hbase-server in the patch failed.
          +1 asflicense 0m 16s The patch does not generate ASF License warnings.
          133m 5s



          Reason Tests
          Failed junit tests hadoop.hbase.client.TestReplicasClient
            hadoop.hbase.regionserver.TestAtomicOperation



          Subsystem Report/Notes
          Docker Client=1.12.3 Server=1.12.3 Image:yetus/hbase:395d9a0
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12871590/HBASE-9393-branch-1.patch
          JIRA Issue HBASE-9393
          Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux 52a043469a39 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/patchprocess/precommit/personality/hbase.sh
          git revision branch-1 / 8252fe4
          Default Java 1.7.0_131
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/7108/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/7108/artifact/patchprocess/patch-unit-hbase-server.txt
          unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/7108/artifact/patchprocess/patch-unit-hbase-server.txt
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/7108/testReport/
          modules C: hbase-server U: hbase-server
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/7108/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 26s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 2m 9s branch-1 passed +1 compile 0m 42s branch-1 passed with JDK v1.8.0_131 +1 compile 0m 43s branch-1 passed with JDK v1.7.0_131 +1 checkstyle 1m 0s branch-1 passed +1 mvneclipse 0m 20s branch-1 passed -1 findbugs 2m 22s hbase-server in branch-1 has 1 extant Findbugs warnings. +1 javadoc 0m 35s branch-1 passed with JDK v1.8.0_131 +1 javadoc 0m 40s branch-1 passed with JDK v1.7.0_131 +1 mvninstall 0m 50s the patch passed +1 compile 0m 39s the patch passed with JDK v1.8.0_131 +1 javac 0m 39s the patch passed +1 compile 0m 41s the patch passed with JDK v1.7.0_131 +1 javac 0m 41s the patch passed +1 checkstyle 1m 2s the patch passed +1 mvneclipse 0m 19s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 hadoopcheck 17m 49s The patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. +1 hbaseprotoc 0m 19s the patch passed +1 findbugs 2m 37s the patch passed +1 javadoc 0m 32s the patch passed with JDK v1.8.0_131 +1 javadoc 0m 40s the patch passed with JDK v1.7.0_131 -1 unit 97m 53s hbase-server in the patch failed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 133m 5s Reason Tests Failed junit tests hadoop.hbase.client.TestReplicasClient   hadoop.hbase.regionserver.TestAtomicOperation Subsystem Report/Notes Docker Client=1.12.3 Server=1.12.3 Image:yetus/hbase:395d9a0 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12871590/HBASE-9393-branch-1.patch JIRA Issue HBASE-9393 Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux 52a043469a39 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/patchprocess/precommit/personality/hbase.sh git revision branch-1 / 8252fe4 Default Java 1.7.0_131 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/7108/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html unit https://builds.apache.org/job/PreCommit-HBASE-Build/7108/artifact/patchprocess/patch-unit-hbase-server.txt unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/7108/artifact/patchprocess/patch-unit-hbase-server.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/7108/testReport/ modules C: hbase-server U: hbase-server Console output https://builds.apache.org/job/PreCommit-HBASE-Build/7108/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          ashish singhi Ashish Singhi added a comment -

          Patch for branch-1

          Show
          ashish singhi Ashish Singhi added a comment - Patch for branch-1
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 15m 9s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 4m 34s master passed
          +1 compile 0m 46s master passed
          +1 checkstyle 0m 53s master passed
          +1 mvneclipse 0m 17s master passed
          +1 findbugs 2m 17s master passed
          +1 javadoc 0m 36s master passed
          +1 mvninstall 0m 54s the patch passed
          +1 compile 0m 45s the patch passed
          +1 javac 0m 45s the patch passed
          +1 checkstyle 0m 51s the patch passed
          +1 mvneclipse 0m 18s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 hadoopcheck 36m 0s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2.
          +1 findbugs 2m 21s the patch passed
          +1 javadoc 0m 34s the patch passed
          +1 unit 131m 52s hbase-server in the patch passed.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          198m 56s



          Subsystem Report/Notes
          Docker Client=1.12.3 Server=1.12.3 Image:yetus/hbase:757bf37
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12871505/HBASE-9393.v18.patch
          JIRA Issue HBASE-9393
          Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux f49a50d71c79 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / 8bfa8aa
          Default Java 1.8.0_131
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/7093/testReport/
          modules C: hbase-server U: hbase-server
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/7093/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 15m 9s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 4m 34s master passed +1 compile 0m 46s master passed +1 checkstyle 0m 53s master passed +1 mvneclipse 0m 17s master passed +1 findbugs 2m 17s master passed +1 javadoc 0m 36s master passed +1 mvninstall 0m 54s the patch passed +1 compile 0m 45s the patch passed +1 javac 0m 45s the patch passed +1 checkstyle 0m 51s the patch passed +1 mvneclipse 0m 18s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 hadoopcheck 36m 0s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. +1 findbugs 2m 21s the patch passed +1 javadoc 0m 34s the patch passed +1 unit 131m 52s hbase-server in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 198m 56s Subsystem Report/Notes Docker Client=1.12.3 Server=1.12.3 Image:yetus/hbase:757bf37 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12871505/HBASE-9393.v18.patch JIRA Issue HBASE-9393 Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux f49a50d71c79 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / 8bfa8aa Default Java 1.8.0_131 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/7093/testReport/ modules C: hbase-server U: hbase-server Console output https://builds.apache.org/job/PreCommit-HBASE-Build/7093/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          ashish singhi Ashish Singhi added a comment -

          Attached patch fixing the compilation error.

          Show
          ashish singhi Ashish Singhi added a comment - Attached patch fixing the compilation error.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 11m 43s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 3m 59s master passed
          +1 compile 0m 44s master passed
          +1 checkstyle 0m 52s master passed
          +1 mvneclipse 0m 16s master passed
          +1 findbugs 2m 2s master passed
          +1 javadoc 0m 29s master passed
          -1 mvninstall 0m 25s hbase-server in the patch failed.
          -1 compile 0m 25s hbase-server in the patch failed.
          -1 javac 0m 25s hbase-server in the patch failed.
          +1 checkstyle 0m 47s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix.
          -1 hadoopcheck 1m 26s The patch causes 20 errors with Hadoop v2.6.1.
          -1 hadoopcheck 2m 37s The patch causes 20 errors with Hadoop v2.6.2.
          -1 hadoopcheck 3m 50s The patch causes 20 errors with Hadoop v2.6.3.
          -1 hadoopcheck 5m 11s The patch causes 20 errors with Hadoop v2.6.4.
          -1 hadoopcheck 6m 28s The patch causes 20 errors with Hadoop v2.6.5.
          -1 hadoopcheck 7m 49s The patch causes 20 errors with Hadoop v2.7.1.
          -1 hadoopcheck 9m 8s The patch causes 20 errors with Hadoop v2.7.2.
          -1 hadoopcheck 10m 25s The patch causes 20 errors with Hadoop v2.7.3.
          -1 hadoopcheck 11m 41s The patch causes 20 errors with Hadoop v3.0.0-alpha2.
          -1 findbugs 0m 23s hbase-server in the patch failed.
          +1 javadoc 0m 30s the patch passed
          -1 unit 0m 29s hbase-server in the patch failed.
          +1 asflicense 0m 9s The patch does not generate ASF License warnings.
          35m 25s



          Subsystem Report/Notes
          Docker Client=17.03.0-ce Server=17.03.0-ce Image:yetus/hbase:757bf37
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12871484/HBASE-9393.v17.patch
          JIRA Issue HBASE-9393
          Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux d357ebc10d4f 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / 59448cd
          Default Java 1.8.0_131
          findbugs v3.0.0
          mvninstall https://builds.apache.org/job/PreCommit-HBASE-Build/7088/artifact/patchprocess/patch-mvninstall-hbase-server.txt
          compile https://builds.apache.org/job/PreCommit-HBASE-Build/7088/artifact/patchprocess/patch-compile-hbase-server.txt
          javac https://builds.apache.org/job/PreCommit-HBASE-Build/7088/artifact/patchprocess/patch-compile-hbase-server.txt
          whitespace https://builds.apache.org/job/PreCommit-HBASE-Build/7088/artifact/patchprocess/whitespace-eol.txt
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/7088/artifact/patchprocess/patch-findbugs-hbase-server.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/7088/artifact/patchprocess/patch-unit-hbase-server.txt
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/7088/testReport/
          modules C: hbase-server U: hbase-server
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/7088/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 11m 43s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 3m 59s master passed +1 compile 0m 44s master passed +1 checkstyle 0m 52s master passed +1 mvneclipse 0m 16s master passed +1 findbugs 2m 2s master passed +1 javadoc 0m 29s master passed -1 mvninstall 0m 25s hbase-server in the patch failed. -1 compile 0m 25s hbase-server in the patch failed. -1 javac 0m 25s hbase-server in the patch failed. +1 checkstyle 0m 47s the patch passed +1 mvneclipse 0m 14s the patch passed -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. -1 hadoopcheck 1m 26s The patch causes 20 errors with Hadoop v2.6.1. -1 hadoopcheck 2m 37s The patch causes 20 errors with Hadoop v2.6.2. -1 hadoopcheck 3m 50s The patch causes 20 errors with Hadoop v2.6.3. -1 hadoopcheck 5m 11s The patch causes 20 errors with Hadoop v2.6.4. -1 hadoopcheck 6m 28s The patch causes 20 errors with Hadoop v2.6.5. -1 hadoopcheck 7m 49s The patch causes 20 errors with Hadoop v2.7.1. -1 hadoopcheck 9m 8s The patch causes 20 errors with Hadoop v2.7.2. -1 hadoopcheck 10m 25s The patch causes 20 errors with Hadoop v2.7.3. -1 hadoopcheck 11m 41s The patch causes 20 errors with Hadoop v3.0.0-alpha2. -1 findbugs 0m 23s hbase-server in the patch failed. +1 javadoc 0m 30s the patch passed -1 unit 0m 29s hbase-server in the patch failed. +1 asflicense 0m 9s The patch does not generate ASF License warnings. 35m 25s Subsystem Report/Notes Docker Client=17.03.0-ce Server=17.03.0-ce Image:yetus/hbase:757bf37 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12871484/HBASE-9393.v17.patch JIRA Issue HBASE-9393 Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux d357ebc10d4f 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / 59448cd Default Java 1.8.0_131 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-HBASE-Build/7088/artifact/patchprocess/patch-mvninstall-hbase-server.txt compile https://builds.apache.org/job/PreCommit-HBASE-Build/7088/artifact/patchprocess/patch-compile-hbase-server.txt javac https://builds.apache.org/job/PreCommit-HBASE-Build/7088/artifact/patchprocess/patch-compile-hbase-server.txt whitespace https://builds.apache.org/job/PreCommit-HBASE-Build/7088/artifact/patchprocess/whitespace-eol.txt findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/7088/artifact/patchprocess/patch-findbugs-hbase-server.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/7088/artifact/patchprocess/patch-unit-hbase-server.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/7088/testReport/ modules C: hbase-server U: hbase-server Console output https://builds.apache.org/job/PreCommit-HBASE-Build/7088/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          ashish singhi Ashish Singhi added a comment -

          Attached the rebased patch with Javadoc

          Show
          ashish singhi Ashish Singhi added a comment - Attached the rebased patch with Javadoc
          Hide
          apurtell Andrew Purtell added a comment -

          Please rebase and make the changes Sean Busbey wants to javadoc Ashish Singhi and I will commit this, or if you don't have time please let me know and I'll do that to finish it and get it in.

          Show
          apurtell Andrew Purtell added a comment - Please rebase and make the changes Sean Busbey wants to javadoc Ashish Singhi and I will commit this, or if you don't have time please let me know and I'll do that to finish it and get it in.
          Hide
          busbey Sean Busbey added a comment -

          I think I still disagree here:

          The addition of the unbuffer call here means that we need to update the javadocs for HFile.createReader(FileSystem, Path, FSDataInputStreamWrapper, long, CacheConfig, Configuration) and HFile.createReaderFromStream(Path, FSDataInputStream, long, CacheConfig, Configuration) to note that callers need to ensure no other threads have access to the passed FSDISW instance.

          We should also ensure that existing calls to those methods are safely passing the FSDISW instance.

          No need, the new reference of FSDISW is just created and passed from this methods.

          This response sounds like the second half of my concern is addressed; we currently safely pass FSDISW instances. But without the change to the javadoc there's effectively no warning for those who might reuse those methods in the future.

          I think the need to fix this issue outweighs the risk of future incorrect use due to missing the javadoc, so I'm -0.

          Show
          busbey Sean Busbey added a comment - I think I still disagree here: The addition of the unbuffer call here means that we need to update the javadocs for HFile.createReader(FileSystem, Path, FSDataInputStreamWrapper, long, CacheConfig, Configuration) and HFile.createReaderFromStream(Path, FSDataInputStream, long, CacheConfig, Configuration) to note that callers need to ensure no other threads have access to the passed FSDISW instance. We should also ensure that existing calls to those methods are safely passing the FSDISW instance. No need, the new reference of FSDISW is just created and passed from this methods. This response sounds like the second half of my concern is addressed; we currently safely pass FSDISW instances. But without the change to the javadoc there's effectively no warning for those who might reuse those methods in the future. I think the need to fix this issue outweighs the risk of future incorrect use due to missing the javadoc, so I'm -0.
          Hide
          ashish singhi Ashish Singhi added a comment -

          I can rebase this again if I can get reviews on 3rd April patch ?
          We are using this in our customised version for more than one and half years and we didn't receive any complaint from this till now.

          Show
          ashish singhi Ashish Singhi added a comment - I can rebase this again if I can get reviews on 3rd April patch ? We are using this in our customised version for more than one and half years and we didn't receive any complaint from this till now.
          Hide
          esteban Esteban Gutierrez added a comment -

          I don't think there is anything left to do Andrew Purtell. Maybe just rebasing the patch for branch-1 and master is the only thing left to do. Sean Busbey do you have any other comment here?

          Show
          esteban Esteban Gutierrez added a comment - I don't think there is anything left to do Andrew Purtell . Maybe just rebasing the patch for branch-1 and master is the only thing left to do. Sean Busbey do you have any other comment here?
          Hide
          apurtell Andrew Purtell added a comment -

          Esteban Gutierrez Ashish Singhi What are you thinking still needs doing?
          I have this applied on top of 1.3.1 pending deployment to our production later this year. We run on a HDFS that supports CanUnbuffer. If you're looking for someone to take it over I could do that, since we will be trying it out in earnest.

          Show
          apurtell Andrew Purtell added a comment - Esteban Gutierrez Ashish Singhi What are you thinking still needs doing? I have this applied on top of 1.3.1 pending deployment to our production later this year. We run on a HDFS that supports CanUnbuffer. If you're looking for someone to take it over I could do that, since we will be trying it out in earnest.
          Hide
          esteban Esteban Gutierrez added a comment -

          Ashish Singhi are you still working on this patch?

          Show
          esteban Esteban Gutierrez added a comment - Ashish Singhi are you still working on this patch?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 3m 29s master passed
          +1 compile 0m 37s master passed
          +1 checkstyle 0m 46s master passed
          +1 mvneclipse 0m 14s master passed
          +1 findbugs 1m 46s master passed
          +1 javadoc 0m 27s master passed
          +1 mvninstall 0m 42s the patch passed
          +1 compile 0m 37s the patch passed
          +1 javac 0m 37s the patch passed
          +1 checkstyle 0m 47s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          -1 whitespace 0m 0s The patch has 6 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 hadoopcheck 27m 36s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2.
          +1 findbugs 1m 56s the patch passed
          +1 javadoc 0m 26s the patch passed
          -1 unit 102m 13s hbase-server in the patch failed.
          +1 asflicense 0m 16s The patch does not generate ASF License warnings.
          142m 49s



          Subsystem Report/Notes
          Docker Client=1.12.3 Server=1.12.3 Image:yetus/hbase:8d52d23
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12861657/HBASE-9393.v16.patch
          JIRA Issue HBASE-9393
          Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux aa34e09c1275 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / 73e1bcd
          Default Java 1.8.0_121
          findbugs v3.0.0
          whitespace https://builds.apache.org/job/PreCommit-HBASE-Build/6296/artifact/patchprocess/whitespace-eol.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/6296/artifact/patchprocess/patch-unit-hbase-server.txt
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/6296/testReport/
          modules C: hbase-server U: hbase-server
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/6296/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 3m 29s master passed +1 compile 0m 37s master passed +1 checkstyle 0m 46s master passed +1 mvneclipse 0m 14s master passed +1 findbugs 1m 46s master passed +1 javadoc 0m 27s master passed +1 mvninstall 0m 42s the patch passed +1 compile 0m 37s the patch passed +1 javac 0m 37s the patch passed +1 checkstyle 0m 47s the patch passed +1 mvneclipse 0m 14s the patch passed -1 whitespace 0m 0s The patch has 6 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 hadoopcheck 27m 36s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. +1 findbugs 1m 56s the patch passed +1 javadoc 0m 26s the patch passed -1 unit 102m 13s hbase-server in the patch failed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 142m 49s Subsystem Report/Notes Docker Client=1.12.3 Server=1.12.3 Image:yetus/hbase:8d52d23 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12861657/HBASE-9393.v16.patch JIRA Issue HBASE-9393 Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux aa34e09c1275 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / 73e1bcd Default Java 1.8.0_121 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-HBASE-Build/6296/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/6296/artifact/patchprocess/patch-unit-hbase-server.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/6296/testReport/ modules C: hbase-server U: hbase-server Console output https://builds.apache.org/job/PreCommit-HBASE-Build/6296/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          ashish singhi Ashish Singhi added a comment -

          Attaching the same patch again to trigger the QA.

          Show
          ashish singhi Ashish Singhi added a comment - Attaching the same patch again to trigger the QA.
          Hide
          ashish singhi Ashish Singhi added a comment -

          Attached patch v16 for further reviews. Once the master branch patch is accepted I will attach patches for other branches.
          Response to Sean Busbey comments,

          The addition of the unbuffer call here means that we need to update the javadocs for HFile.createReader(FileSystem, Path, FSDataInputStreamWrapper, long, CacheConfig, Configuration) and HFile.createReaderFromStream(Path, FSDataInputStream, long, CacheConfig, Configuration) to note that callers need to ensure no other threads have access to the passed FSDISW instance.
          We should also ensure that existing calls to those methods are safely passing the FSDISW instance.

          No need, the new reference of FSDISW is just created and passed from this methods.

          Just want to make sure I'm following the rationale correctly here. This won't actually take care of unbuffering if the lock is held e.g. for reading. I think this is fine, since it implies someone else is still using the stream and presumably they will also attempt to unbuffer when they are done.

          Yes.

          Show
          ashish singhi Ashish Singhi added a comment - Attached patch v16 for further reviews. Once the master branch patch is accepted I will attach patches for other branches. Response to Sean Busbey comments, The addition of the unbuffer call here means that we need to update the javadocs for HFile.createReader(FileSystem, Path, FSDataInputStreamWrapper, long, CacheConfig, Configuration) and HFile.createReaderFromStream(Path, FSDataInputStream, long, CacheConfig, Configuration) to note that callers need to ensure no other threads have access to the passed FSDISW instance. We should also ensure that existing calls to those methods are safely passing the FSDISW instance. No need, the new reference of FSDISW is just created and passed from this methods. Just want to make sure I'm following the rationale correctly here. This won't actually take care of unbuffering if the lock is held e.g. for reading. I think this is fine, since it implies someone else is still using the stream and presumably they will also attempt to unbuffer when they are done. Yes.
          Hide
          ashish singhi Ashish Singhi added a comment -

          Will get back to this very soon with patches for all the versions.

          Show
          ashish singhi Ashish Singhi added a comment - Will get back to this very soon with patches for all the versions.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 3m 52s master passed
          +1 compile 0m 47s master passed
          +1 checkstyle 0m 56s master passed
          +1 mvneclipse 0m 17s master passed
          +1 findbugs 2m 17s master passed
          +1 javadoc 0m 36s master passed
          +1 mvninstall 0m 55s the patch passed
          +1 compile 0m 47s the patch passed
          +1 javac 0m 47s the patch passed
          +1 checkstyle 0m 49s the patch passed
          +1 mvneclipse 0m 17s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 hadoopcheck 31m 47s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha1.
          +1 findbugs 2m 9s the patch passed
          +1 javadoc 0m 32s the patch passed
          +1 unit 101m 31s hbase-server in the patch passed.
          +1 asflicense 0m 16s The patch does not generate ASF License warnings.
          148m 28s



          Subsystem Report/Notes
          Docker Client=1.11.2 Server=1.11.2 Image:yetus/hbase:8d52d23
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12794484/HBASE-9393.v15.patch
          JIRA Issue HBASE-9393
          Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux 97ef674eb251 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / 4cb09a4
          Default Java 1.8.0_111
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/5281/testReport/
          modules C: hbase-server U: hbase-server
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/5281/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 3m 52s master passed +1 compile 0m 47s master passed +1 checkstyle 0m 56s master passed +1 mvneclipse 0m 17s master passed +1 findbugs 2m 17s master passed +1 javadoc 0m 36s master passed +1 mvninstall 0m 55s the patch passed +1 compile 0m 47s the patch passed +1 javac 0m 47s the patch passed +1 checkstyle 0m 49s the patch passed +1 mvneclipse 0m 17s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 hadoopcheck 31m 47s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha1. +1 findbugs 2m 9s the patch passed +1 javadoc 0m 32s the patch passed +1 unit 101m 31s hbase-server in the patch passed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 148m 28s Subsystem Report/Notes Docker Client=1.11.2 Server=1.11.2 Image:yetus/hbase:8d52d23 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12794484/HBASE-9393.v15.patch JIRA Issue HBASE-9393 Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux 97ef674eb251 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / 4cb09a4 Default Java 1.8.0_111 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/5281/testReport/ modules C: hbase-server U: hbase-server Console output https://builds.apache.org/job/PreCommit-HBASE-Build/5281/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          Ashish Singhi:
          Can you attach patch backported to branch-1.2 ?

          Thanks

          Show
          yuzhihong@gmail.com Ted Yu added a comment - Ashish Singhi : Can you attach patch backported to branch-1.2 ? Thanks
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 3m 3s master passed
          +1 compile 0m 32s master passed with JDK v1.8.0_101
          +1 compile 0m 35s master passed with JDK v1.7.0_111
          +1 checkstyle 0m 50s master passed
          +1 mvneclipse 0m 17s master passed
          +1 findbugs 2m 0s master passed
          +1 javadoc 0m 26s master passed with JDK v1.8.0_101
          +1 javadoc 0m 34s master passed with JDK v1.7.0_111
          +1 mvninstall 0m 47s the patch passed
          +1 compile 0m 32s the patch passed with JDK v1.8.0_101
          +1 javac 0m 32s the patch passed
          +1 compile 0m 36s the patch passed with JDK v1.7.0_111
          +1 javac 0m 36s the patch passed
          +1 checkstyle 0m 50s the patch passed
          +1 mvneclipse 0m 17s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 hadoopcheck 28m 2s Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1.
          +1 hbaseprotoc 0m 15s the patch passed
          +1 findbugs 2m 18s the patch passed
          +1 javadoc 0m 30s the patch passed with JDK v1.8.0_101
          +1 javadoc 0m 36s the patch passed with JDK v1.7.0_111
          +1 unit 94m 50s hbase-server in the patch passed.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          138m 46s



          Subsystem Report/Notes
          Docker Client=1.11.2 Server=1.11.2 Image:yetus/hbase:date2016-09-08
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12794484/HBASE-9393.v15.patch
          JIRA Issue HBASE-9393
          Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux 2fcb24bf9520 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / e65817e
          Default Java 1.7.0_111
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/3448/testReport/
          modules C: hbase-server U: hbase-server
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/3448/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 3m 3s master passed +1 compile 0m 32s master passed with JDK v1.8.0_101 +1 compile 0m 35s master passed with JDK v1.7.0_111 +1 checkstyle 0m 50s master passed +1 mvneclipse 0m 17s master passed +1 findbugs 2m 0s master passed +1 javadoc 0m 26s master passed with JDK v1.8.0_101 +1 javadoc 0m 34s master passed with JDK v1.7.0_111 +1 mvninstall 0m 47s the patch passed +1 compile 0m 32s the patch passed with JDK v1.8.0_101 +1 javac 0m 32s the patch passed +1 compile 0m 36s the patch passed with JDK v1.7.0_111 +1 javac 0m 36s the patch passed +1 checkstyle 0m 50s the patch passed +1 mvneclipse 0m 17s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 hadoopcheck 28m 2s Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. +1 hbaseprotoc 0m 15s the patch passed +1 findbugs 2m 18s the patch passed +1 javadoc 0m 30s the patch passed with JDK v1.8.0_101 +1 javadoc 0m 36s the patch passed with JDK v1.7.0_111 +1 unit 94m 50s hbase-server in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 138m 46s Subsystem Report/Notes Docker Client=1.11.2 Server=1.11.2 Image:yetus/hbase:date2016-09-08 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12794484/HBASE-9393.v15.patch JIRA Issue HBASE-9393 Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux 2fcb24bf9520 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / e65817e Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/3448/testReport/ modules C: hbase-server U: hbase-server Console output https://builds.apache.org/job/PreCommit-HBASE-Build/3448/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          vrodionov Vladimir Rodionov added a comment -

          That was our root cause:
          https://issues.apache.org/jira/browse/HBASE-16062

          in combination with a bad name for WAL splitter class in some old files. RS could not instantiate WAL Readers for such files and did not handle error correctly leaving hanging socket in CLOSE_WAIT state.

          Show
          vrodionov Vladimir Rodionov added a comment - That was our root cause: https://issues.apache.org/jira/browse/HBASE-16062 in combination with a bad name for WAL splitter class in some old files. RS could not instantiate WAL Readers for such files and did not handle error correctly leaving hanging socket in CLOSE_WAIT state.
          Hide
          vrodionov Vladimir Rodionov added a comment - - edited

          Some stats from env:

          1. 15 node cluster / 11 for HBase
          2. HBASE 1.1.2.x (HDP 2.4.2)
          3. Phoenix
          4. 5500 regions
          5. 2844 tables
          6. 3860 snapshots
          7. Kerberos
          8. UI shows 3 dead regions, which are not dead
          9. They run M/R jobs (Phoenix), M/R jobs (with direct HFiles access), Storm and Flume application writes to HBase
          10. Number of files: archive - 7320, data - 43349, rest dirs are small
          11. All CLOSE_WAIT connections are bound to remote nodes on 1019 port (Kerberized DN?)
          12. Distribution of CLOSE_WAIT socket is very uneven: 011 server has 59K, 006 has less than 1K
          13. Enabling / disabling tables does not make any positive effect on # of CLOSE_WAIT connections.

          The number of CLOSE_WAIT connections grows steadily over time, it reached 60K on 011 node in less than 24 hours.

          I hope this will give some clue.

          Show
          vrodionov Vladimir Rodionov added a comment - - edited Some stats from env: 15 node cluster / 11 for HBase HBASE 1.1.2.x (HDP 2.4.2) Phoenix 5500 regions 2844 tables 3860 snapshots Kerberos UI shows 3 dead regions, which are not dead They run M/R jobs (Phoenix), M/R jobs (with direct HFiles access), Storm and Flume application writes to HBase Number of files: archive - 7320, data - 43349, rest dirs are small All CLOSE_WAIT connections are bound to remote nodes on 1019 port (Kerberized DN?) Distribution of CLOSE_WAIT socket is very uneven: 011 server has 59K, 006 has less than 1K Enabling / disabling tables does not make any positive effect on # of CLOSE_WAIT connections. The number of CLOSE_WAIT connections grows steadily over time, it reached 60K on 011 node in less than 24 hours. I hope this will give some clue.
          Hide
          cnauroth Chris Nauroth added a comment -

          Vinayakumar B, I apologize. I re-reviewed this code, and you are correct. Please disregard my prior comment. Thanks for checking on this.

          Show
          cnauroth Chris Nauroth added a comment - Vinayakumar B , I apologize. I re-reviewed this code, and you are correct. Please disregard my prior comment. Thanks for checking on this.
          Hide
          vrodionov Vladimir Rodionov added a comment -

          We see this issue in one of our customer's installation. HBase 1.1.2 (hdfs - 2.5.1).

          Correction: hdfs-2.7.1

          Show
          vrodionov Vladimir Rodionov added a comment - We see this issue in one of our customer's installation. HBase 1.1.2 (hdfs - 2.5.1). Correction: hdfs-2.7.1
          Hide
          busbey Sean Busbey added a comment -
          diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java
          index b06be6b..4f9e96e 100644
          --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java
          +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java
          ...
          +  private volatile Boolean instanceOfCanUnbuffer = null;
          +  // Using reflection to get org.apache.hadoop.fs.CanUnbuffer#unbuffer method to avoid compilation
          +  // errors against Hadoop pre 2.6.4 and 2.7.1 versions.
          +  private volatile Method unbuffer = null;
          +
          

          AFAICT, these are only used in the unbuffer method. That method declares itself not threadsafe, so why are these volatile?

          @@ -493,8 +499,8 @@ public class HFile {
              */
             @edu.umd.cs.findbugs.annotations.SuppressWarnings(value="SF_SWITCH_FALLTHROUGH",
                 justification="Intentional")
          -  private static Reader pickReaderVersion(Path path, FSDataInputStreamWrapper fsdis,
          -      long size, CacheConfig cacheConf, HFileSystem hfs, Configuration conf) throws IOException {
          +  private static Reader openReader(Path path, FSDataInputStreamWrapper fsdis, long size,
          +      CacheConfig cacheConf, HFileSystem hfs, Configuration conf) throws IOException {
               FixedFileTrailer trailer = null;
               try {
                 boolean isHBaseChecksum = fsdis.shouldUseHBaseChecksum();
          @@ -516,6 +522,8 @@ public class HFile {
                   LOG.warn("Error closing fsdis FSDataInputStreamWrapper", t2);
                 }
                 throw new CorruptHFileException("Problem reading HFile Trailer from file " + path, t);
          +    } finally {
          +      fsdis.unbuffer();
               }
             }
          

          The addition of the unbuffer call here means that we need to update the javadocs for HFile.createReader(FileSystem, Path, FSDataInputStreamWrapper, long, CacheConfig, Configuration) and HFile.createReaderFromStream(Path, FSDataInputStream, long, CacheConfig, Configuration) to note that callers need to ensure no other threads have access to the passed FSDISW instance.

          We should also ensure that existing calls to those methods are safely passing the FSDISW instance.

          diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
          index 6268f2e..a68900a 100644
          --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
          +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
          @@ -1351,6 +1351,12 @@ public class HFileBlock implements Cacheable {
           
               void setIncludesMemstoreTS(boolean includesMemstoreTS);
               void setDataBlockEncoder(HFileDataBlockEncoder encoder);
          +
          +    /**
          +     * To close the stream's socket. Note: This can be concurrently called from multiple threads and
          +     * implementation should take care of thread safety
          +     */
          +    void unbufferStream();
             }
           
             /**
          @@ -1817,6 +1823,19 @@ public class HFileBlock implements Cacheable {
               public String toString() {
                 return "hfs=" + hfs + ", path=" + pathName + ", fileContext=" + fileContext;
               }
          +
          +    @Override
          +    public void unbufferStream() {
          +      // To handle concurrent reads, ensure that no other client is accessing the streams while we
          +      // unbuffer it.
          +      if (streamLock.tryLock()) {
          +        try {
          +          this.streamWrapper.unbuffer();
          +        } finally {
          +          streamLock.unlock();
          +        }
          +      }
          +    }
          

          Just want to make sure I'm following the rationale correctly here. This won't actually take care of unbuffering if the lock is held e.g. for reading. I think this is fine, since it implies someone else is still using the stream and presumably they will also attempt to unbuffer when they are done.

          Show
          busbey Sean Busbey added a comment - diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java index b06be6b..4f9e96e 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java ... + private volatile Boolean instanceOfCanUnbuffer = null ; + // Using reflection to get org.apache.hadoop.fs.CanUnbuffer#unbuffer method to avoid compilation + // errors against Hadoop pre 2.6.4 and 2.7.1 versions. + private volatile Method unbuffer = null ; + AFAICT, these are only used in the unbuffer method. That method declares itself not threadsafe, so why are these volatile? @@ -493,8 +499,8 @@ public class HFile { */ @edu.umd.cs.findbugs.annotations.SuppressWarnings(value= "SF_SWITCH_FALLTHROUGH" , justification= "Intentional" ) - private static Reader pickReaderVersion(Path path, FSDataInputStreamWrapper fsdis, - long size, CacheConfig cacheConf, HFileSystem hfs, Configuration conf) throws IOException { + private static Reader openReader(Path path, FSDataInputStreamWrapper fsdis, long size, + CacheConfig cacheConf, HFileSystem hfs, Configuration conf) throws IOException { FixedFileTrailer trailer = null ; try { boolean isHBaseChecksum = fsdis.shouldUseHBaseChecksum(); @@ -516,6 +522,8 @@ public class HFile { LOG.warn( "Error closing fsdis FSDataInputStreamWrapper" , t2); } throw new CorruptHFileException( "Problem reading HFile Trailer from file " + path, t); + } finally { + fsdis.unbuffer(); } } The addition of the unbuffer call here means that we need to update the javadocs for HFile.createReader(FileSystem, Path, FSDataInputStreamWrapper, long, CacheConfig, Configuration) and HFile.createReaderFromStream(Path, FSDataInputStream, long, CacheConfig, Configuration) to note that callers need to ensure no other threads have access to the passed FSDISW instance. We should also ensure that existing calls to those methods are safely passing the FSDISW instance. diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java index 6268f2e..a68900a 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java @@ -1351,6 +1351,12 @@ public class HFileBlock implements Cacheable { void setIncludesMemstoreTS( boolean includesMemstoreTS); void setDataBlockEncoder(HFileDataBlockEncoder encoder); + + /** + * To close the stream's socket. Note: This can be concurrently called from multiple threads and + * implementation should take care of thread safety + */ + void unbufferStream(); } /** @@ -1817,6 +1823,19 @@ public class HFileBlock implements Cacheable { public String toString() { return "hfs=" + hfs + ", path=" + pathName + ", fileContext=" + fileContext; } + + @Override + public void unbufferStream() { + // To handle concurrent reads, ensure that no other client is accessing the streams while we + // unbuffer it. + if (streamLock.tryLock()) { + try { + this .streamWrapper.unbuffer(); + } finally { + streamLock.unlock(); + } + } + } Just want to make sure I'm following the rationale correctly here. This won't actually take care of unbuffering if the lock is held e.g. for reading. I think this is fine, since it implies someone else is still using the stream and presumably they will also attempt to unbuffer when they are done.
          Hide
          busbey Sean Busbey added a comment -

          Okay, I'm rereading the comments and I'll re-review v15 to see if I still hold my same concerns over proper docs / usage for concurrency.

          Show
          busbey Sean Busbey added a comment - Okay, I'm rereading the comments and I'll re-review v15 to see if I still hold my same concerns over proper docs / usage for concurrency.
          Hide
          vinayrpet Vinayakumar B added a comment -

          Its correct that file descriptors will be shared. But from the Latest branch-2 code I can see that, sharing happens via DomainSocket, not TCP socket. Didn't check what was exactly available in 2.5.1.

              new Sender(out).requestShortCircuitFds(block, token, slotId, 1,
                  failureInjector.getSupportsReceiptVerification());
              DataInputStream in = new DataInputStream(peer.getInputStream());
              BlockOpResponseProto resp = BlockOpResponseProto.parseFrom(
                  PBHelperClient.vintPrefixed(in));
              DomainSocket sock = peer.getDomainSocket();
              failureInjector.injectRequestFileDescriptorsFailure();
              switch (resp.getStatus()) {
              case SUCCESS:
                byte buf[] = new byte[1];
                FileInputStream[] fis = new FileInputStream[2];
                sock.recvFileInputStreams(fis, buf, 0, buf.length);

          Will this also count for CLOSE_WAITs? I dont think so.

          If legacy local reader (BlockReaderLocalLegacy) is used, sharing of Block/meta file information was via IPC port, not data port.

          Am I missing something here?

          Show
          vinayrpet Vinayakumar B added a comment - Its correct that file descriptors will be shared. But from the Latest branch-2 code I can see that, sharing happens via DomainSocket, not TCP socket. Didn't check what was exactly available in 2.5.1. new Sender(out).requestShortCircuitFds(block, token, slotId, 1, failureInjector.getSupportsReceiptVerification()); DataInputStream in = new DataInputStream(peer.getInputStream()); BlockOpResponseProto resp = BlockOpResponseProto.parseFrom( PBHelperClient.vintPrefixed(in)); DomainSocket sock = peer.getDomainSocket(); failureInjector.injectRequestFileDescriptorsFailure(); switch (resp.getStatus()) { case SUCCESS: byte buf[] = new byte [1]; FileInputStream[] fis = new FileInputStream[2]; sock.recvFileInputStreams(fis, buf, 0, buf.length); Will this also count for CLOSE_WAITs? I dont think so. If legacy local reader (BlockReaderLocalLegacy) is used, sharing of Block/meta file information was via IPC port, not data port. Am I missing something here?
          Hide
          ashish singhi Ashish Singhi added a comment -

          Thanks for the knowledge sharing.

          Show
          ashish singhi Ashish Singhi added a comment - Thanks for the knowledge sharing.
          Hide
          anoop.hbase Anoop Sam John added a comment -

          Thanks..
          We should get this work in. Seems many users get this issue here and there.

          Show
          anoop.hbase Anoop Sam John added a comment - Thanks.. We should get this work in. Seems many users get this issue here and there.
          Hide
          cnauroth Chris Nauroth added a comment -

          With short-circuit read, there is still a brief interaction between the HDFS client and the DataNode's data transfer port to request sharing file descriptors to perform the direct read. It's much less data compared to an actual block transfer, but the TCP socket is still there.

          Show
          cnauroth Chris Nauroth added a comment - With short-circuit read, there is still a brief interaction between the HDFS client and the DataNode's data transfer port to request sharing file descriptors to perform the direct read. It's much less data compared to an actual block transfer, but the TCP socket is still there.
          Hide
          ashish singhi Ashish Singhi added a comment -

          I think If scr is enabled then there will not be any socket connection to DN port. The sockets in CLOSE_WAIT's are connected to which port then ?

          Show
          ashish singhi Ashish Singhi added a comment - I think If scr is enabled then there will not be any socket connection to DN port. The sockets in CLOSE_WAIT's are connected to which port then ?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 3m 45s master passed
          +1 compile 0m 51s master passed with JDK v1.8.0
          +1 compile 0m 36s master passed with JDK v1.7.0_79
          +1 checkstyle 0m 54s master passed
          +1 mvneclipse 0m 15s master passed
          +1 findbugs 2m 2s master passed
          +1 javadoc 0m 42s master passed with JDK v1.8.0
          +1 javadoc 0m 37s master passed with JDK v1.7.0_79
          +1 mvninstall 0m 50s the patch passed
          +1 compile 0m 53s the patch passed with JDK v1.8.0
          +1 javac 0m 53s the patch passed
          +1 compile 0m 37s the patch passed with JDK v1.7.0_79
          +1 javac 0m 36s the patch passed
          +1 checkstyle 1m 15s the patch passed
          +1 mvneclipse 0m 16s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 hadoopcheck 27m 2s Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1.
          +1 findbugs 2m 25s the patch passed
          +1 javadoc 0m 41s the patch passed with JDK v1.8.0
          +1 javadoc 0m 36s the patch passed with JDK v1.7.0_79
          +1 unit 90m 26s hbase-server in the patch passed.
          +1 asflicense 0m 20s Patch does not generate ASF License warnings.
          135m 29s



          Subsystem Report/Notes
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12794484/HBASE-9393.v15.patch
          JIRA Issue HBASE-9393
          Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / b69c77a
          Default Java 1.7.0_79
          Multi-JDK versions /home/jenkins/tools/java/jdk1.8.0:1.8.0 /usr/local/jenkins/java/jdk1.7.0_79:1.7.0_79
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/2212/testReport/
          modules C: hbase-server U: hbase-server
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/2212/console
          Powered by Apache Yetus 0.2.1 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 3m 45s master passed +1 compile 0m 51s master passed with JDK v1.8.0 +1 compile 0m 36s master passed with JDK v1.7.0_79 +1 checkstyle 0m 54s master passed +1 mvneclipse 0m 15s master passed +1 findbugs 2m 2s master passed +1 javadoc 0m 42s master passed with JDK v1.8.0 +1 javadoc 0m 37s master passed with JDK v1.7.0_79 +1 mvninstall 0m 50s the patch passed +1 compile 0m 53s the patch passed with JDK v1.8.0 +1 javac 0m 53s the patch passed +1 compile 0m 37s the patch passed with JDK v1.7.0_79 +1 javac 0m 36s the patch passed +1 checkstyle 1m 15s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 hadoopcheck 27m 2s Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. +1 findbugs 2m 25s the patch passed +1 javadoc 0m 41s the patch passed with JDK v1.8.0 +1 javadoc 0m 36s the patch passed with JDK v1.7.0_79 +1 unit 90m 26s hbase-server in the patch passed. +1 asflicense 0m 20s Patch does not generate ASF License warnings. 135m 29s Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12794484/HBASE-9393.v15.patch JIRA Issue HBASE-9393 Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / b69c77a Default Java 1.7.0_79 Multi-JDK versions /home/jenkins/tools/java/jdk1.8.0:1.8.0 /usr/local/jenkins/java/jdk1.7.0_79:1.7.0_79 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/2212/testReport/ modules C: hbase-server U: hbase-server Console output https://builds.apache.org/job/PreCommit-HBASE-Build/2212/console Powered by Apache Yetus 0.2.1 http://yetus.apache.org This message was automatically generated.
          Hide
          vrodionov Vladimir Rodionov added a comment - - edited

          We see this issue in one of our customer's installation. HBase 1.1.2 (hdfs - 2.5.1). One question:

          If we have scr enabled (no socket access, direct reads), how it is possible to get into thousands of sockets in CLOSE_WAIT states in RS? I read all this thread but found no explanation, may be I missed something.

          Ping Ashish Singhi.

          Show
          vrodionov Vladimir Rodionov added a comment - - edited We see this issue in one of our customer's installation. HBase 1.1.2 (hdfs - 2.5.1). One question: If we have scr enabled (no socket access, direct reads), how it is possible to get into thousands of sockets in CLOSE_WAIT states in RS? I read all this thread but found no explanation, may be I missed something. Ping Ashish Singhi .
          Hide
          cnauroth Chris Nauroth added a comment -

          Does the above question amount to asking whether or not it is safe for multiple threads to read concurrently from a DFSInputStream? If so, then I can provide some feedback.

          One case to consider is positional read, which is the following method signature:

          int read(long position, byte[] buffer, int offset, int length) throws IOException;
          

          If all calling threads are using positional read, then it's correct that each caller would operate on its own unique instance of BlockReader, backed by its own dedicated socket connection to a DataNode.

          Another case to consider is any of the other non-positional read APIs. These APIs are thread-safe at the method level via synchronized, however that's not sufficient to guarantee isolation for a sequence of multiple method calls, such as seek + read or skip + read. That would require external synchronization. Even with external synchronization, there would be a risk of thrashing if multiple threads were trying to read drastically different positions spanning block boundaries. The DFSInputStream would have to keep updating its single BlockReader instance and related state to point at the new position. That amounts to additional NameNode RPC and connection reestablishment to a DataNode (unless a cached connection is available).

          Caveat: I don't know HBase code well enough to comment authoritatively on its usage patterns. If HBase code additionally relies on locking the stream objects for mutual exclusion around its own higher-level operations, then that's another concern.

          I hope this helps.

          Show
          cnauroth Chris Nauroth added a comment - Does the above question amount to asking whether or not it is safe for multiple threads to read concurrently from a DFSInputStream ? If so, then I can provide some feedback. One case to consider is positional read, which is the following method signature: int read( long position, byte [] buffer, int offset, int length) throws IOException; If all calling threads are using positional read, then it's correct that each caller would operate on its own unique instance of BlockReader , backed by its own dedicated socket connection to a DataNode. Another case to consider is any of the other non-positional read APIs. These APIs are thread-safe at the method level via synchronized , however that's not sufficient to guarantee isolation for a sequence of multiple method calls, such as seek + read or skip + read . That would require external synchronization. Even with external synchronization, there would be a risk of thrashing if multiple threads were trying to read drastically different positions spanning block boundaries. The DFSInputStream would have to keep updating its single BlockReader instance and related state to point at the new position. That amounts to additional NameNode RPC and connection reestablishment to a DataNode (unless a cached connection is available). Caveat: I don't know HBase code well enough to comment authoritatively on its usage patterns. If HBase code additionally relies on locking the stream objects for mutual exclusion around its own higher-level operations, then that's another concern. I hope this helps.
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          Sean Busbey:
          What do you think of Ashish's response ?

          Show
          yuzhihong@gmail.com Ted Yu added a comment - Sean Busbey : What do you think of Ashish's response ?
          Hide
          ashish singhi Ashish Singhi added a comment -

          I replied to them in my above comment. It is not mandatory to call them in a lock so only I did not add any specific javadoc for it.

          This call means that openReader can only be called within a lock for fsdis. The javadocs should say so. (do all uses already do this?)

          This call means that createReader(FileSystem, Path, FSDataInputStreamWrapper, long, CacheConfig, Configuration) can only be called within a lock for fsdis, javadocs should say so. (do all uses already do this?)

          As per my knowledge the concurrent thing is already handled in HDFS. Each client will have its own BlockReader and socket, so if the first client unbuffer the socket also it will not cause any problem to the other client block reads.

          Show
          ashish singhi Ashish Singhi added a comment - I replied to them in my above comment. It is not mandatory to call them in a lock so only I did not add any specific javadoc for it. This call means that openReader can only be called within a lock for fsdis. The javadocs should say so. (do all uses already do this?) This call means that createReader(FileSystem, Path, FSDataInputStreamWrapper, long, CacheConfig, Configuration) can only be called within a lock for fsdis, javadocs should say so. (do all uses already do this?) As per my knowledge the concurrent thing is already handled in HDFS. Each client will have its own BlockReader and socket, so if the first client unbuffer the socket also it will not cause any problem to the other client block reads.
          Hide
          busbey Sean Busbey added a comment -

          I don't see these previous javadoc and verification requests handled in v15:

          +    } finally {
          +      fsdis.unbuffer();
               }
          

          This call means that openReader can only be called within a lock for fsdis. The javadocs should say so. (do all uses already do this?)

          @@ -543,7 +550,7 @@ public class HFile {
               } else {
                 hfs = (HFileSystem)fs;
               }
          -    return pickReaderVersion(path, fsdis, size, cacheConf, hfs, conf);
          +    return openReader(path, fsdis, size, cacheConf, hfs, conf);
             }
          

          This call means that createReader(FileSystem, Path, FSDataInputStreamWrapper, long, CacheConfig, Configuration) can only be called within a lock for fsdis, javadocs should say so. (do all uses already do this?)

          Show
          busbey Sean Busbey added a comment - I don't see these previous javadoc and verification requests handled in v15: + } finally { + fsdis.unbuffer(); } This call means that openReader can only be called within a lock for fsdis . The javadocs should say so. (do all uses already do this?) @@ -543,7 +550,7 @@ public class HFile { } else { hfs = (HFileSystem)fs; } - return pickReaderVersion(path, fsdis, size, cacheConf, hfs, conf); + return openReader(path, fsdis, size, cacheConf, hfs, conf); } This call means that createReader(FileSystem, Path, FSDataInputStreamWrapper, long, CacheConfig, Configuration) can only be called within a lock for fsdis , javadocs should say so. (do all uses already do this?)
          Hide
          ashish singhi Ashish Singhi added a comment -

          Sean Busbey, can you take a look at v15 patch.

          Show
          ashish singhi Ashish Singhi added a comment - Sean Busbey , can you take a look at v15 patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 5m 37s master passed
          +1 compile 1m 14s master passed with JDK v1.8.0
          +1 compile 0m 43s master passed with JDK v1.7.0_79
          +1 checkstyle 4m 56s master passed
          +1 mvneclipse 0m 20s master passed
          +1 findbugs 2m 20s master passed
          +1 javadoc 0m 44s master passed with JDK v1.8.0
          +1 javadoc 0m 43s master passed with JDK v1.7.0_79
          +1 mvninstall 0m 53s the patch passed
          +1 compile 1m 2s the patch passed with JDK v1.8.0
          +1 javac 1m 2s the patch passed
          +1 compile 0m 33s the patch passed with JDK v1.7.0_79
          +1 javac 0m 33s the patch passed
          +1 checkstyle 5m 59s the patch passed
          +1 mvneclipse 0m 31s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 hadoopcheck 32m 48s Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1.
          +1 findbugs 2m 32s the patch passed
          +1 javadoc 0m 44s the patch passed with JDK v1.8.0
          +1 javadoc 0m 41s the patch passed with JDK v1.7.0_79
          -1 unit 142m 37s hbase-server in the patch failed.
          +1 asflicense 0m 27s Patch does not generate ASF License warnings.
          206m 0s



          Reason Tests
          Timed out junit tests org.apache.hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures
            org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient



          Subsystem Report/Notes
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12794484/HBASE-9393.v15.patch
          JIRA Issue HBASE-9393
          Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / f48c92d
          Default Java 1.7.0_79
          Multi-JDK versions /home/jenkins/tools/java/jdk1.8.0:1.8.0 /usr/local/jenkins/java/jdk1.7.0_79:1.7.0_79
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/1103/artifact/patchprocess/patch-unit-hbase-server.txt
          unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/1103/artifact/patchprocess/patch-unit-hbase-server.txt
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/1103/testReport/
          modules C: hbase-server U: hbase-server
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/1103/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 5m 37s master passed +1 compile 1m 14s master passed with JDK v1.8.0 +1 compile 0m 43s master passed with JDK v1.7.0_79 +1 checkstyle 4m 56s master passed +1 mvneclipse 0m 20s master passed +1 findbugs 2m 20s master passed +1 javadoc 0m 44s master passed with JDK v1.8.0 +1 javadoc 0m 43s master passed with JDK v1.7.0_79 +1 mvninstall 0m 53s the patch passed +1 compile 1m 2s the patch passed with JDK v1.8.0 +1 javac 1m 2s the patch passed +1 compile 0m 33s the patch passed with JDK v1.7.0_79 +1 javac 0m 33s the patch passed +1 checkstyle 5m 59s the patch passed +1 mvneclipse 0m 31s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 hadoopcheck 32m 48s Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. +1 findbugs 2m 32s the patch passed +1 javadoc 0m 44s the patch passed with JDK v1.8.0 +1 javadoc 0m 41s the patch passed with JDK v1.7.0_79 -1 unit 142m 37s hbase-server in the patch failed. +1 asflicense 0m 27s Patch does not generate ASF License warnings. 206m 0s Reason Tests Timed out junit tests org.apache.hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures   org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12794484/HBASE-9393.v15.patch JIRA Issue HBASE-9393 Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / f48c92d Default Java 1.7.0_79 Multi-JDK versions /home/jenkins/tools/java/jdk1.8.0:1.8.0 /usr/local/jenkins/java/jdk1.7.0_79:1.7.0_79 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HBASE-Build/1103/artifact/patchprocess/patch-unit-hbase-server.txt unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/1103/artifact/patchprocess/patch-unit-hbase-server.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/1103/testReport/ modules C: hbase-server U: hbase-server Console output https://builds.apache.org/job/PreCommit-HBASE-Build/1103/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          ashish singhi Ashish Singhi added a comment -

          Reattached for another QA run.

          Show
          ashish singhi Ashish Singhi added a comment - Reattached for another QA run.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 3m 5s master passed
          +1 compile 0m 37s master passed with JDK v1.8.0
          +1 compile 0m 32s master passed with JDK v1.7.0_79
          +1 checkstyle 4m 12s master passed
          +1 mvneclipse 0m 17s master passed
          +1 findbugs 1m 52s master passed
          +1 javadoc 0m 25s master passed with JDK v1.8.0
          +1 javadoc 0m 32s master passed with JDK v1.7.0_79
          +1 mvninstall 0m 43s the patch passed
          +1 compile 0m 39s the patch passed with JDK v1.8.0
          +1 javac 0m 39s the patch passed
          +1 compile 0m 32s the patch passed with JDK v1.7.0_79
          +1 javac 0m 32s the patch passed
          +1 checkstyle 4m 45s the patch passed
          +1 mvneclipse 0m 18s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 hadoopcheck 29m 32s Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1.
          +1 findbugs 2m 42s the patch passed
          +1 javadoc 0m 29s the patch passed with JDK v1.8.0
          +1 javadoc 0m 38s the patch passed with JDK v1.7.0_79
          -1 unit 109m 1s hbase-server in the patch failed with JDK v1.8.0.
          -1 unit 82m 34s hbase-server in the patch failed with JDK v1.7.0_79.
          +1 asflicense 0m 27s Patch does not generate ASF License warnings.
          244m 30s



          Reason Tests
          JDK v1.8.0 Timed out junit tests org.apache.hadoop.hbase.master.procedure.TestServerCrashProcedure
            org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId
            org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2
            org.apache.hadoop.hbase.master.TestMasterFailover
            org.apache.hadoop.hbase.util.TestHBaseFsckOneRS
            org.apache.hadoop.hbase.mapred.TestTableInputFormat
            org.apache.hadoop.hbase.wal.TestWALFiltering
            org.apache.hadoop.hbase.mapred.TestTableMapReduceUtil
            org.apache.hadoop.hbase.master.TestGetInfoPort
            org.apache.hadoop.hbase.wal.TestWALSplitCompressed
            org.apache.hadoop.hbase.master.TestMasterFailoverBalancerPersistence
            org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildHole
            org.apache.hadoop.hbase.util.TestHBaseFsckEncryption
            org.apache.hadoop.hbase.util.TestHBaseFsckReplicas
            org.apache.hadoop.hbase.master.TestTableStateManager
            org.apache.hadoop.hbase.master.TestTableLockManager
            org.apache.hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures
            org.apache.hadoop.hbase.master.TestMasterRestartAfterDisablingTable
            org.apache.hadoop.hbase.master.procedure.TestWALProcedureStoreOnHDFS
            org.apache.hadoop.hbase.master.TestSplitLogManager
            org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildOverlap
            org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer
            org.apache.hadoop.hbase.master.TestRollingRestart
            org.apache.hadoop.hbase.util.TestMiniClusterLoadEncoded
            org.apache.hadoop.hbase.master.TestDistributedLogSplitting
            org.apache.hadoop.hbase.util.TestMiniClusterLoadSequential
            org.apache.hadoop.hbase.util.TestFanOutOneBlockAsyncDFSOutput
            org.apache.hadoop.hbase.master.TestMasterShutdown
            org.apache.hadoop.hbase.util.TestRegionSplitter
            org.apache.hadoop.hbase.util.TestMergeTable
            org.apache.hadoop.hbase.util.TestMergeTool
            org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildBase
            org.apache.hadoop.hbase.util.TestRegionMover
            org.apache.hadoop.hbase.master.snapshot.TestSnapshotFileCache
            org.apache.hadoop.hbase.master.TestMasterNoCluster
            org.apache.hadoop.hbase.master.TestRestartCluster
            org.apache.hadoop.hbase.util.TestMiniClusterLoadParallel
            org.apache.hadoop.hbase.TestIOFencing
            org.apache.hadoop.hbase.TestLocalHBaseCluster
            org.apache.hadoop.hbase.util.TestHBaseFsckMOB
            org.apache.hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient
            org.apache.hadoop.hbase.TestMetaTableAccessor
            org.apache.hadoop.hbase.util.TestConnectionCache
            org.apache.hadoop.hbase.master.handler.TestCreateTableHandler
            org.apache.hadoop.hbase.master.handler.TestEnableTableHandler
            org.apache.hadoop.hbase.mapred.TestTableSnapshotInputFormat
            org.apache.hadoop.hbase.master.procedure.TestAddColumnFamilyProcedure
            org.apache.hadoop.hbase.util.TestFSUtils
            org.apache.hadoop.hbase.util.TestHBaseFsckTwoRS
          JDK v1.7.0_79 Timed out junit tests org.apache.hadoop.hbase.master.procedure.TestDisableTableProcedure
            org.apache.hadoop.hbase.master.procedure.TestDeleteTableProcedure
            org.apache.hadoop.hbase.master.procedure.TestServerCrashProcedure
            org.apache.hadoop.hbase.master.procedure.TestModifyTableProcedure
            org.apache.hadoop.hbase.master.procedure.TestCreateTableProcedure
            org.apache.hadoop.hbase.master.procedure.TestEnableTableProcedure
            org.apache.hadoop.hbase.mapreduce.TestWALPlayer
            org.apache.hadoop.hbase.mapreduce.TestTableInputFormat
            org.apache.hadoop.hbase.mapreduce.TestHRegionPartitioner
            org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId
            org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2
            org.apache.hadoop.hbase.master.TestMasterFailover
            org.apache.hadoop.hbase.trace.TestHTraceHooks
            org.apache.hadoop.hbase.snapshot.TestSnapshotClientRetries
            org.apache.hadoop.hbase.util.TestHBaseFsckOneRS
            org.apache.hadoop.hbase.mapred.TestTableInputFormat
            org.apache.hadoop.hbase.namespace.TestNamespaceAuditor
            org.apache.hadoop.hbase.TestHBaseTestingUtility
            org.apache.hadoop.hbase.wal.TestWALFiltering
            org.apache.hadoop.hbase.mapred.TestTableMapReduceUtil
            org.apache.hadoop.hbase.wal.TestDefaultWALProviderWithHLogKey
            org.apache.hadoop.hbase.mapreduce.TestCellCounter
            org.apache.hadoop.hbase.master.TestGetInfoPort
            org.apache.hadoop.hbase.wal.TestWALSplitCompressed
            org.apache.hadoop.hbase.master.TestMasterFailoverBalancerPersistence
            org.apache.hadoop.hbase.master.cleaner.TestSnapshotFromMaster
            org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildHole
            org.apache.hadoop.hbase.util.TestHBaseFsckEncryption
            org.apache.hadoop.hbase.util.TestHBaseFsckReplicas
            org.apache.hadoop.hbase.master.normalizer.TestSimpleRegionNormalizerOnCluster
            org.apache.hadoop.hbase.master.TestTableStateManager
            org.apache.hadoop.hbase.master.TestMasterMetrics
            org.apache.hadoop.hbase.mapreduce.TestImportTSVWithOperationAttributes
            org.apache.hadoop.hbase.master.TestTableLockManager
            org.apache.hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures
            org.apache.hadoop.hbase.master.TestMasterRestartAfterDisablingTable
            org.apache.hadoop.hbase.master.procedure.TestWALProcedureStoreOnHDFS
            org.apache.hadoop.hbase.master.TestSplitLogManager
            org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildOverlap
            org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer
            org.apache.hadoop.hbase.master.TestRollingRestart
            org.apache.hadoop.hbase.util.TestCoprocessorScanPolicy
            org.apache.hadoop.hbase.util.TestMiniClusterLoadEncoded
            org.apache.hadoop.hbase.master.TestDistributedLogSplitting
            org.apache.hadoop.hbase.io.encoding.TestDataBlockEncoders
            org.apache.hadoop.hbase.util.TestMiniClusterLoadSequential
            org.apache.hadoop.hbase.util.TestFanOutOneBlockAsyncDFSOutput
            org.apache.hadoop.hbase.master.TestMasterShutdown
            org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster
            org.apache.hadoop.hbase.master.TestMaster
            org.apache.hadoop.hbase.security.access.TestAccessControlFilter
            org.apache.hadoop.hbase.TestAcidGuarantees
            org.apache.hadoop.hbase.TestGlobalMemStoreSize
            org.apache.hadoop.hbase.TestNamespace
            org.apache.hadoop.hbase.io.encoding.TestChangingEncoding
            org.apache.hadoop.hbase.TestRegionRebalancing
            org.apache.hadoop.hbase.util.TestRegionSplitter
            org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelReplicationWithExpAsString
            org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsReplication
            org.apache.hadoop.hbase.util.TestMergeTable
            org.apache.hadoop.hbase.util.TestMergeTool
            org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildBase
            org.apache.hadoop.hbase.util.TestRegionMover
            org.apache.hadoop.hbase.master.snapshot.TestSnapshotFileCache
            org.apache.hadoop.hbase.master.TestMasterNoCluster
            org.apache.hadoop.hbase.security.access.TestCellACLs
            org.apache.hadoop.hbase.master.TestRestartCluster
            org.apache.hadoop.hbase.master.procedure.TestProcedureAdmin
            org.apache.hadoop.hbase.util.TestMiniClusterLoadParallel
            org.apache.hadoop.hbase.TestIOFencing
            org.apache.hadoop.hbase.snapshot.TestRestoreFlushSnapshotFromClient
            org.apache.hadoop.hbase.mapreduce.TestImportExport
            org.apache.hadoop.hbase.master.procedure.TestMasterProcedureEvents
            org.apache.hadoop.hbase.TestLocalHBaseCluster
            org.apache.hadoop.hbase.security.access.TestWithDisabledAuthorization
            org.apache.hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk
            org.apache.hadoop.hbase.io.hfile.TestCacheOnWrite
            org.apache.hadoop.hbase.master.handler.TestTableDeleteFamilyHandler
            org.apache.hadoop.hbase.util.TestHBaseFsckMOB
            org.apache.hadoop.hbase.TestHColumnDescriptorDefaultVersions
            org.apache.hadoop.hbase.fs.TestBlockReorder
            org.apache.hadoop.hbase.wal.TestDefaultWALProvider
            org.apache.hadoop.hbase.TestMetaTableAccessor
            org.apache.hadoop.hbase.util.TestConnectionCache
            org.apache.hadoop.hbase.master.handler.TestCreateTableHandler
            org.apache.hadoop.hbase.master.handler.TestEnableTableHandler
            org.apache.hadoop.hbase.security.access.TestZKPermissionsWatcher
            org.apache.hadoop.hbase.mapreduce.TestImportTSVWithTTLs
            org.apache.hadoop.hbase.io.hfile.TestHFileBlock
            org.apache.hadoop.hbase.wal.TestBoundedRegionGroupingStrategy
            org.apache.hadoop.hbase.wal.TestWALFactory
            org.apache.hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFilesSplitRecovery
            org.apache.hadoop.hbase.master.procedure.TestDeleteColumnFamilyProcedure
            org.apache.hadoop.hbase.master.procedure.TestModifyColumnFamilyProcedure
            org.apache.hadoop.hbase.mapreduce.TestTableSnapshotInputFormat
            org.apache.hadoop.hbase.replication.TestMasterReplication
            org.apache.hadoop.hbase.mapred.TestTableSnapshotInputFormat
            org.apache.hadoop.hbase.master.procedure.TestCreateNamespaceProcedure
            org.apache.hadoop.hbase.master.procedure.TestDeleteNamespaceProcedure
            org.apache.hadoop.hbase.master.procedure.TestModifyNamespaceProcedure
            org.apache.hadoop.hbase.master.procedure.TestAddColumnFamilyProcedure
            org.apache.hadoop.hbase.master.TestMasterOperationsForRegionReplicas
            org.apache.hadoop.hbase.io.TestFileLink
            org.apache.hadoop.hbase.util.TestFSUtils
            org.apache.hadoop.hbase.master.TestMetaShutdownHandler
            org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery
            org.apache.hadoop.hbase.master.procedure.TestTruncateTableProcedure
            org.apache.hadoop.hbase.wal.TestWALSplit
            org.apache.hadoop.hbase.mapreduce.TestImportTsv
            org.apache.hadoop.hbase.io.encoding.TestEncodedSeekers



          Subsystem Report/Notes
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12793741/HBASE-9393.v15.patch
          JIRA Issue HBASE-9393
          Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux proserpina.apache.org 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
          git revision master / f120602
          Default Java 1.7.0_79
          Multi-JDK versions /home/jenkins/tools/java/jdk1.8.0:1.8.0 /usr/local/jenkins/java/jdk1.7.0_79:1.7.0_79
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/1013/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/1013/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_79.txt
          unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/1013/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0.txt https://builds.apache.org/job/PreCommit-HBASE-Build/1013/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_79.txt
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/1013/testReport/
          modules C: hbase-server U: hbase-server
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/1013/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 3m 5s master passed +1 compile 0m 37s master passed with JDK v1.8.0 +1 compile 0m 32s master passed with JDK v1.7.0_79 +1 checkstyle 4m 12s master passed +1 mvneclipse 0m 17s master passed +1 findbugs 1m 52s master passed +1 javadoc 0m 25s master passed with JDK v1.8.0 +1 javadoc 0m 32s master passed with JDK v1.7.0_79 +1 mvninstall 0m 43s the patch passed +1 compile 0m 39s the patch passed with JDK v1.8.0 +1 javac 0m 39s the patch passed +1 compile 0m 32s the patch passed with JDK v1.7.0_79 +1 javac 0m 32s the patch passed +1 checkstyle 4m 45s the patch passed +1 mvneclipse 0m 18s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 hadoopcheck 29m 32s Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. +1 findbugs 2m 42s the patch passed +1 javadoc 0m 29s the patch passed with JDK v1.8.0 +1 javadoc 0m 38s the patch passed with JDK v1.7.0_79 -1 unit 109m 1s hbase-server in the patch failed with JDK v1.8.0. -1 unit 82m 34s hbase-server in the patch failed with JDK v1.7.0_79. +1 asflicense 0m 27s Patch does not generate ASF License warnings. 244m 30s Reason Tests JDK v1.8.0 Timed out junit tests org.apache.hadoop.hbase.master.procedure.TestServerCrashProcedure   org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId   org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2   org.apache.hadoop.hbase.master.TestMasterFailover   org.apache.hadoop.hbase.util.TestHBaseFsckOneRS   org.apache.hadoop.hbase.mapred.TestTableInputFormat   org.apache.hadoop.hbase.wal.TestWALFiltering   org.apache.hadoop.hbase.mapred.TestTableMapReduceUtil   org.apache.hadoop.hbase.master.TestGetInfoPort   org.apache.hadoop.hbase.wal.TestWALSplitCompressed   org.apache.hadoop.hbase.master.TestMasterFailoverBalancerPersistence   org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildHole   org.apache.hadoop.hbase.util.TestHBaseFsckEncryption   org.apache.hadoop.hbase.util.TestHBaseFsckReplicas   org.apache.hadoop.hbase.master.TestTableStateManager   org.apache.hadoop.hbase.master.TestTableLockManager   org.apache.hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures   org.apache.hadoop.hbase.master.TestMasterRestartAfterDisablingTable   org.apache.hadoop.hbase.master.procedure.TestWALProcedureStoreOnHDFS   org.apache.hadoop.hbase.master.TestSplitLogManager   org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildOverlap   org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer   org.apache.hadoop.hbase.master.TestRollingRestart   org.apache.hadoop.hbase.util.TestMiniClusterLoadEncoded   org.apache.hadoop.hbase.master.TestDistributedLogSplitting   org.apache.hadoop.hbase.util.TestMiniClusterLoadSequential   org.apache.hadoop.hbase.util.TestFanOutOneBlockAsyncDFSOutput   org.apache.hadoop.hbase.master.TestMasterShutdown   org.apache.hadoop.hbase.util.TestRegionSplitter   org.apache.hadoop.hbase.util.TestMergeTable   org.apache.hadoop.hbase.util.TestMergeTool   org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildBase   org.apache.hadoop.hbase.util.TestRegionMover   org.apache.hadoop.hbase.master.snapshot.TestSnapshotFileCache   org.apache.hadoop.hbase.master.TestMasterNoCluster   org.apache.hadoop.hbase.master.TestRestartCluster   org.apache.hadoop.hbase.util.TestMiniClusterLoadParallel   org.apache.hadoop.hbase.TestIOFencing   org.apache.hadoop.hbase.TestLocalHBaseCluster   org.apache.hadoop.hbase.util.TestHBaseFsckMOB   org.apache.hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient   org.apache.hadoop.hbase.TestMetaTableAccessor   org.apache.hadoop.hbase.util.TestConnectionCache   org.apache.hadoop.hbase.master.handler.TestCreateTableHandler   org.apache.hadoop.hbase.master.handler.TestEnableTableHandler   org.apache.hadoop.hbase.mapred.TestTableSnapshotInputFormat   org.apache.hadoop.hbase.master.procedure.TestAddColumnFamilyProcedure   org.apache.hadoop.hbase.util.TestFSUtils   org.apache.hadoop.hbase.util.TestHBaseFsckTwoRS JDK v1.7.0_79 Timed out junit tests org.apache.hadoop.hbase.master.procedure.TestDisableTableProcedure   org.apache.hadoop.hbase.master.procedure.TestDeleteTableProcedure   org.apache.hadoop.hbase.master.procedure.TestServerCrashProcedure   org.apache.hadoop.hbase.master.procedure.TestModifyTableProcedure   org.apache.hadoop.hbase.master.procedure.TestCreateTableProcedure   org.apache.hadoop.hbase.master.procedure.TestEnableTableProcedure   org.apache.hadoop.hbase.mapreduce.TestWALPlayer   org.apache.hadoop.hbase.mapreduce.TestTableInputFormat   org.apache.hadoop.hbase.mapreduce.TestHRegionPartitioner   org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId   org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2   org.apache.hadoop.hbase.master.TestMasterFailover   org.apache.hadoop.hbase.trace.TestHTraceHooks   org.apache.hadoop.hbase.snapshot.TestSnapshotClientRetries   org.apache.hadoop.hbase.util.TestHBaseFsckOneRS   org.apache.hadoop.hbase.mapred.TestTableInputFormat   org.apache.hadoop.hbase.namespace.TestNamespaceAuditor   org.apache.hadoop.hbase.TestHBaseTestingUtility   org.apache.hadoop.hbase.wal.TestWALFiltering   org.apache.hadoop.hbase.mapred.TestTableMapReduceUtil   org.apache.hadoop.hbase.wal.TestDefaultWALProviderWithHLogKey   org.apache.hadoop.hbase.mapreduce.TestCellCounter   org.apache.hadoop.hbase.master.TestGetInfoPort   org.apache.hadoop.hbase.wal.TestWALSplitCompressed   org.apache.hadoop.hbase.master.TestMasterFailoverBalancerPersistence   org.apache.hadoop.hbase.master.cleaner.TestSnapshotFromMaster   org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildHole   org.apache.hadoop.hbase.util.TestHBaseFsckEncryption   org.apache.hadoop.hbase.util.TestHBaseFsckReplicas   org.apache.hadoop.hbase.master.normalizer.TestSimpleRegionNormalizerOnCluster   org.apache.hadoop.hbase.master.TestTableStateManager   org.apache.hadoop.hbase.master.TestMasterMetrics   org.apache.hadoop.hbase.mapreduce.TestImportTSVWithOperationAttributes   org.apache.hadoop.hbase.master.TestTableLockManager   org.apache.hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures   org.apache.hadoop.hbase.master.TestMasterRestartAfterDisablingTable   org.apache.hadoop.hbase.master.procedure.TestWALProcedureStoreOnHDFS   org.apache.hadoop.hbase.master.TestSplitLogManager   org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildOverlap   org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer   org.apache.hadoop.hbase.master.TestRollingRestart   org.apache.hadoop.hbase.util.TestCoprocessorScanPolicy   org.apache.hadoop.hbase.util.TestMiniClusterLoadEncoded   org.apache.hadoop.hbase.master.TestDistributedLogSplitting   org.apache.hadoop.hbase.io.encoding.TestDataBlockEncoders   org.apache.hadoop.hbase.util.TestMiniClusterLoadSequential   org.apache.hadoop.hbase.util.TestFanOutOneBlockAsyncDFSOutput   org.apache.hadoop.hbase.master.TestMasterShutdown   org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster   org.apache.hadoop.hbase.master.TestMaster   org.apache.hadoop.hbase.security.access.TestAccessControlFilter   org.apache.hadoop.hbase.TestAcidGuarantees   org.apache.hadoop.hbase.TestGlobalMemStoreSize   org.apache.hadoop.hbase.TestNamespace   org.apache.hadoop.hbase.io.encoding.TestChangingEncoding   org.apache.hadoop.hbase.TestRegionRebalancing   org.apache.hadoop.hbase.util.TestRegionSplitter   org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelReplicationWithExpAsString   org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsReplication   org.apache.hadoop.hbase.util.TestMergeTable   org.apache.hadoop.hbase.util.TestMergeTool   org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildBase   org.apache.hadoop.hbase.util.TestRegionMover   org.apache.hadoop.hbase.master.snapshot.TestSnapshotFileCache   org.apache.hadoop.hbase.master.TestMasterNoCluster   org.apache.hadoop.hbase.security.access.TestCellACLs   org.apache.hadoop.hbase.master.TestRestartCluster   org.apache.hadoop.hbase.master.procedure.TestProcedureAdmin   org.apache.hadoop.hbase.util.TestMiniClusterLoadParallel   org.apache.hadoop.hbase.TestIOFencing   org.apache.hadoop.hbase.snapshot.TestRestoreFlushSnapshotFromClient   org.apache.hadoop.hbase.mapreduce.TestImportExport   org.apache.hadoop.hbase.master.procedure.TestMasterProcedureEvents   org.apache.hadoop.hbase.TestLocalHBaseCluster   org.apache.hadoop.hbase.security.access.TestWithDisabledAuthorization   org.apache.hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk   org.apache.hadoop.hbase.io.hfile.TestCacheOnWrite   org.apache.hadoop.hbase.master.handler.TestTableDeleteFamilyHandler   org.apache.hadoop.hbase.util.TestHBaseFsckMOB   org.apache.hadoop.hbase.TestHColumnDescriptorDefaultVersions   org.apache.hadoop.hbase.fs.TestBlockReorder   org.apache.hadoop.hbase.wal.TestDefaultWALProvider   org.apache.hadoop.hbase.TestMetaTableAccessor   org.apache.hadoop.hbase.util.TestConnectionCache   org.apache.hadoop.hbase.master.handler.TestCreateTableHandler   org.apache.hadoop.hbase.master.handler.TestEnableTableHandler   org.apache.hadoop.hbase.security.access.TestZKPermissionsWatcher   org.apache.hadoop.hbase.mapreduce.TestImportTSVWithTTLs   org.apache.hadoop.hbase.io.hfile.TestHFileBlock   org.apache.hadoop.hbase.wal.TestBoundedRegionGroupingStrategy   org.apache.hadoop.hbase.wal.TestWALFactory   org.apache.hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFilesSplitRecovery   org.apache.hadoop.hbase.master.procedure.TestDeleteColumnFamilyProcedure   org.apache.hadoop.hbase.master.procedure.TestModifyColumnFamilyProcedure   org.apache.hadoop.hbase.mapreduce.TestTableSnapshotInputFormat   org.apache.hadoop.hbase.replication.TestMasterReplication   org.apache.hadoop.hbase.mapred.TestTableSnapshotInputFormat   org.apache.hadoop.hbase.master.procedure.TestCreateNamespaceProcedure   org.apache.hadoop.hbase.master.procedure.TestDeleteNamespaceProcedure   org.apache.hadoop.hbase.master.procedure.TestModifyNamespaceProcedure   org.apache.hadoop.hbase.master.procedure.TestAddColumnFamilyProcedure   org.apache.hadoop.hbase.master.TestMasterOperationsForRegionReplicas   org.apache.hadoop.hbase.io.TestFileLink   org.apache.hadoop.hbase.util.TestFSUtils   org.apache.hadoop.hbase.master.TestMetaShutdownHandler   org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery   org.apache.hadoop.hbase.master.procedure.TestTruncateTableProcedure   org.apache.hadoop.hbase.wal.TestWALSplit   org.apache.hadoop.hbase.mapreduce.TestImportTsv   org.apache.hadoop.hbase.io.encoding.TestEncodedSeekers Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12793741/HBASE-9393.v15.patch JIRA Issue HBASE-9393 Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux proserpina.apache.org 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh git revision master / f120602 Default Java 1.7.0_79 Multi-JDK versions /home/jenkins/tools/java/jdk1.8.0:1.8.0 /usr/local/jenkins/java/jdk1.7.0_79:1.7.0_79 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HBASE-Build/1013/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/1013/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_79.txt unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/1013/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0.txt https://builds.apache.org/job/PreCommit-HBASE-Build/1013/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_79.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/1013/testReport/ modules C: hbase-server U: hbase-server Console output https://builds.apache.org/job/PreCommit-HBASE-Build/1013/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          ashish singhi Ashish Singhi added a comment -

          Thanks for the comments Sean Busbey. Sorry for the late response.

          Can we do the initialization in the constructor (and make the related instance variables final) rather than rely on doing this lazy initialization?

          We cannot make them final as the variables value are set at two different places in the method based on the condition and java compiler will not allow for that if we make it final.

          Can we catch specific exceptions instead of Exception?

          Addressed.

          this doesn't need to reference the JIRA (both instances). Should specify that implementers should make it threadsafe (since we use it without locks in various places)

          Addressed.

          This call means that openReader can only be called within a lock for fsdis. The javadocs should say so. (do all uses already do this?)

          This call means that createReader(FileSystem, Path, FSDataInputStreamWrapper, long, CacheConfig, Configuration) can only be called within a lock for fsdis, javadocs should say so. (do all uses already do this?)

          As per my knowledge the concurrent thing is already handled in HDFS. Each client will have its own BlockReader and socket, so if the first client unbuffer the socket also it will not cause any problem to the other client block reads.

          Please review and let me know your thoughts.
          Thanks.

          Show
          ashish singhi Ashish Singhi added a comment - Thanks for the comments Sean Busbey . Sorry for the late response. Can we do the initialization in the constructor (and make the related instance variables final) rather than rely on doing this lazy initialization? We cannot make them final as the variables value are set at two different places in the method based on the condition and java compiler will not allow for that if we make it final. Can we catch specific exceptions instead of Exception? Addressed. this doesn't need to reference the JIRA (both instances). Should specify that implementers should make it threadsafe (since we use it without locks in various places) Addressed. This call means that openReader can only be called within a lock for fsdis. The javadocs should say so. (do all uses already do this?) This call means that createReader(FileSystem, Path, FSDataInputStreamWrapper, long, CacheConfig, Configuration) can only be called within a lock for fsdis, javadocs should say so. (do all uses already do this?) As per my knowledge the concurrent thing is already handled in HDFS. Each client will have its own BlockReader and socket, so if the first client unbuffer the socket also it will not cause any problem to the other client block reads. Please review and let me know your thoughts. Thanks.
          Hide
          busbey Sean Busbey added a comment -

          Can we do the initialization in the constructor (and make the related instance variables final) rather than rely on doing this lazy initialization?

          +            } catch (Exception e) {
          +              LOG.warn("Failed to find 'unbuffer' method in class " + streamClass
          +                  + " . So there may be a TCP socket connection "
          +                  + "left open in CLOSE_WAIT state.", e);
          +              return;
          +            }
          

          Can we catch specific exceptions instead of Exception?

          +
          +    /**
          +     * To close the stream's socket. HBASE-9393
          +     */
          +    void unbufferStream();
          

          this doesn't need to reference the JIRA (both instances). Should specify that implementers should make it threadsafe (since we use it without locks in various places)

          +    } finally {
          +      fsdis.unbuffer();
               }
          

          This call means that openReader can only be called within a lock for fsdis. The javadocs should say so. (do all uses already do this?)

          @@ -543,7 +550,7 @@ public class HFile {
               } else {
                 hfs = (HFileSystem)fs;
               }
          -    return pickReaderVersion(path, fsdis, size, cacheConf, hfs, conf);
          +    return openReader(path, fsdis, size, cacheConf, hfs, conf);
             }
          

          This call means that createReader(FileSystem, Path, FSDataInputStreamWrapper, long, CacheConfig, Configuration) can only be called within a lock for fsdis, javadocs should say so. (do all uses already do this?)

          Show
          busbey Sean Busbey added a comment - Can we do the initialization in the constructor (and make the related instance variables final) rather than rely on doing this lazy initialization? + } catch (Exception e) { + LOG.warn( "Failed to find 'unbuffer' method in class " + streamClass + + " . So there may be a TCP socket connection " + + "left open in CLOSE_WAIT state." , e); + return ; + } Can we catch specific exceptions instead of Exception ? + + /** + * To close the stream's socket. HBASE-9393 + */ + void unbufferStream(); this doesn't need to reference the JIRA (both instances). Should specify that implementers should make it threadsafe (since we use it without locks in various places) + } finally { + fsdis.unbuffer(); } This call means that openReader can only be called within a lock for fsdis . The javadocs should say so. (do all uses already do this?) @@ -543,7 +550,7 @@ public class HFile { } else { hfs = (HFileSystem)fs; } - return pickReaderVersion(path, fsdis, size, cacheConf, hfs, conf); + return openReader(path, fsdis, size, cacheConf, hfs, conf); } This call means that createReader(FileSystem, Path, FSDataInputStreamWrapper, long, CacheConfig, Configuration) can only be called within a lock for fsdis, javadocs should say so. (do all uses already do this?)
          Hide
          ashish singhi Ashish Singhi added a comment -

          Anoop Sam John, Sean Busbey, can you please review the latest patch ?

          Show
          ashish singhi Ashish Singhi added a comment - Anoop Sam John , Sean Busbey , can you please review the latest patch ?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 3m 3s master passed
          +1 compile 0m 46s master passed with JDK v1.8.0
          +1 compile 0m 31s master passed with JDK v1.7.0_79
          +1 checkstyle 4m 35s master passed
          +1 mvneclipse 0m 15s master passed
          +1 findbugs 1m 50s master passed
          +1 javadoc 0m 28s master passed with JDK v1.8.0
          +1 javadoc 0m 35s master passed with JDK v1.7.0_79
          +1 mvninstall 0m 45s the patch passed
          +1 compile 0m 50s the patch passed with JDK v1.8.0
          +1 javac 0m 50s the patch passed
          +1 compile 0m 35s the patch passed with JDK v1.7.0_79
          +1 javac 0m 35s the patch passed
          +1 checkstyle 4m 35s the patch passed
          +1 mvneclipse 0m 16s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 hadoopcheck 24m 36s Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1.
          +1 findbugs 2m 7s the patch passed
          +1 javadoc 0m 25s the patch passed with JDK v1.8.0
          +1 javadoc 0m 32s the patch passed with JDK v1.7.0_79
          -1 unit 84m 24s hbase-server in the patch failed with JDK v1.8.0.
          +1 unit 88m 17s hbase-server in the patch passed with JDK v1.7.0_79.
          +1 asflicense 0m 16s Patch does not generate ASF License warnings.
          220m 11s



          Reason Tests
          JDK v1.8.0 Timed out junit tests org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2
            org.apache.hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint
            org.apache.hadoop.hbase.filter.TestFilterWithScanLimits
            org.apache.hadoop.hbase.constraint.TestConstraint
            org.apache.hadoop.hbase.master.TestAssignmentListener
            org.apache.hadoop.hbase.master.cleaner.TestSnapshotFromMaster
            org.apache.hadoop.hbase.master.TestSplitLogManager
            org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer
            org.apache.hadoop.hbase.io.encoding.TestDataBlockEncoders
            org.apache.hadoop.hbase.replication.regionserver.TestReplicationSink
            org.apache.hadoop.hbase.io.hfile.TestScannerSelectionUsingTTL
            org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster
            org.apache.hadoop.hbase.TestNamespace
            org.apache.hadoop.hbase.io.encoding.TestChangingEncoding
            org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks
            org.apache.hadoop.hbase.master.TestClusterStatusPublisher
            org.apache.hadoop.hbase.filter.TestMultiRowRangeFilter
            org.apache.hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpointNoMaster
            org.apache.hadoop.hbase.filter.TestColumnRangeFilter
            org.apache.hadoop.hbase.master.TestRestartCluster
            org.apache.hadoop.hbase.regionserver.TestHRegion
            org.apache.hadoop.hbase.io.hfile.TestCacheOnWrite
            org.apache.hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk
            org.apache.hadoop.hbase.replication.regionserver.TestReplicationWALReaderManager
            org.apache.hadoop.hbase.replication.TestMultiSlaveReplication
            org.apache.hadoop.hbase.io.hfile.TestHFileBlock
            org.apache.hadoop.hbase.filter.TestFuzzyRowFilterEndToEnd
            org.apache.hadoop.hbase.replication.TestMasterReplication
            org.apache.hadoop.hbase.TestPartialResultsFromClientSide
            org.apache.hadoop.hbase.master.TestMasterOperationsForRegionReplicas
            org.apache.hadoop.hbase.io.encoding.TestEncodedSeekers



          Subsystem Report/Notes
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790922/HBASE-9393.v14.patch
          JIRA Issue HBASE-9393
          Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / 4b3e387
          Default Java 1.7.0_79
          Multi-JDK versions /home/jenkins/tools/java/jdk1.8.0:1.8.0 /usr/local/jenkins/java/jdk1.7.0_79:1.7.0_79
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/823/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0.txt
          unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/823/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0.txt
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/823/testReport/
          modules C: hbase-server U: hbase-server
          Max memory used 210MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/823/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 3m 3s master passed +1 compile 0m 46s master passed with JDK v1.8.0 +1 compile 0m 31s master passed with JDK v1.7.0_79 +1 checkstyle 4m 35s master passed +1 mvneclipse 0m 15s master passed +1 findbugs 1m 50s master passed +1 javadoc 0m 28s master passed with JDK v1.8.0 +1 javadoc 0m 35s master passed with JDK v1.7.0_79 +1 mvninstall 0m 45s the patch passed +1 compile 0m 50s the patch passed with JDK v1.8.0 +1 javac 0m 50s the patch passed +1 compile 0m 35s the patch passed with JDK v1.7.0_79 +1 javac 0m 35s the patch passed +1 checkstyle 4m 35s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 hadoopcheck 24m 36s Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. +1 findbugs 2m 7s the patch passed +1 javadoc 0m 25s the patch passed with JDK v1.8.0 +1 javadoc 0m 32s the patch passed with JDK v1.7.0_79 -1 unit 84m 24s hbase-server in the patch failed with JDK v1.8.0. +1 unit 88m 17s hbase-server in the patch passed with JDK v1.7.0_79. +1 asflicense 0m 16s Patch does not generate ASF License warnings. 220m 11s Reason Tests JDK v1.8.0 Timed out junit tests org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2   org.apache.hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint   org.apache.hadoop.hbase.filter.TestFilterWithScanLimits   org.apache.hadoop.hbase.constraint.TestConstraint   org.apache.hadoop.hbase.master.TestAssignmentListener   org.apache.hadoop.hbase.master.cleaner.TestSnapshotFromMaster   org.apache.hadoop.hbase.master.TestSplitLogManager   org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer   org.apache.hadoop.hbase.io.encoding.TestDataBlockEncoders   org.apache.hadoop.hbase.replication.regionserver.TestReplicationSink   org.apache.hadoop.hbase.io.hfile.TestScannerSelectionUsingTTL   org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster   org.apache.hadoop.hbase.TestNamespace   org.apache.hadoop.hbase.io.encoding.TestChangingEncoding   org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks   org.apache.hadoop.hbase.master.TestClusterStatusPublisher   org.apache.hadoop.hbase.filter.TestMultiRowRangeFilter   org.apache.hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpointNoMaster   org.apache.hadoop.hbase.filter.TestColumnRangeFilter   org.apache.hadoop.hbase.master.TestRestartCluster   org.apache.hadoop.hbase.regionserver.TestHRegion   org.apache.hadoop.hbase.io.hfile.TestCacheOnWrite   org.apache.hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk   org.apache.hadoop.hbase.replication.regionserver.TestReplicationWALReaderManager   org.apache.hadoop.hbase.replication.TestMultiSlaveReplication   org.apache.hadoop.hbase.io.hfile.TestHFileBlock   org.apache.hadoop.hbase.filter.TestFuzzyRowFilterEndToEnd   org.apache.hadoop.hbase.replication.TestMasterReplication   org.apache.hadoop.hbase.TestPartialResultsFromClientSide   org.apache.hadoop.hbase.master.TestMasterOperationsForRegionReplicas   org.apache.hadoop.hbase.io.encoding.TestEncodedSeekers Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790922/HBASE-9393.v14.patch JIRA Issue HBASE-9393 Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / 4b3e387 Default Java 1.7.0_79 Multi-JDK versions /home/jenkins/tools/java/jdk1.8.0:1.8.0 /usr/local/jenkins/java/jdk1.7.0_79:1.7.0_79 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HBASE-Build/823/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0.txt unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/823/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/823/testReport/ modules C: hbase-server U: hbase-server Max memory used 210MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HBASE-Build/823/console This message was automatically generated.
          Hide
          ashish singhi Ashish Singhi added a comment -

          Test failures are not related to patch.

          Show
          ashish singhi Ashish Singhi added a comment - Test failures are not related to patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 3m 40s master passed
          +1 compile 1m 15s master passed with JDK v1.8.0_72
          +1 compile 0m 59s master passed with JDK v1.7.0_95
          +1 checkstyle 5m 31s master passed
          +1 mvneclipse 0m 27s master passed
          +1 findbugs 2m 45s master passed
          +1 javadoc 0m 55s master passed with JDK v1.8.0_72
          +1 javadoc 0m 59s master passed with JDK v1.7.0_95
          +1 mvninstall 1m 14s the patch passed
          +1 compile 1m 20s the patch passed with JDK v1.8.0_72
          +1 javac 1m 20s the patch passed
          +1 compile 0m 57s the patch passed with JDK v1.7.0_95
          +1 javac 0m 57s the patch passed
          +1 checkstyle 5m 3s the patch passed
          +1 mvneclipse 0m 27s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 hadoopcheck 29m 17s Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1.
          +1 findbugs 2m 24s the patch passed
          +1 javadoc 0m 35s the patch passed with JDK v1.8.0_72
          +1 javadoc 0m 38s the patch passed with JDK v1.7.0_95
          -1 unit 25m 9s hbase-server in the patch failed with JDK v1.8.0_72.
          -1 unit 82m 4s hbase-server in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 27s Patch does not generate ASF License warnings.
          166m 46s



          Reason Tests
          JDK v1.8.0_72 Failed junit tests hadoop.hbase.ipc.TestSimpleRpcScheduler
          JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.hbase.regionserver.TestCorruptedRegionStoreFile
            org.apache.hadoop.hbase.regionserver.TestSplitLogWorker
            org.apache.hadoop.hbase.regionserver.compactions.TestFIFOCompactionPolicy
            org.apache.hadoop.hbase.regionserver.wal.TestFSHLog
            org.apache.hadoop.hbase.regionserver.TestCompaction
            org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId
            org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2
            org.apache.hadoop.hbase.coprocessor.TestRegionObserverScannerOpenHook
            org.apache.hadoop.hbase.wal.TestWALFiltering
            org.apache.hadoop.hbase.wal.TestDefaultWALProviderWithHLogKey
            org.apache.hadoop.hbase.coprocessor.TestRegionServerObserver
            org.apache.hadoop.hbase.wal.TestWALSplitCompressed
            org.apache.hadoop.hbase.TestZooKeeper
            org.apache.hadoop.hbase.master.TestGetInfoPort
            org.apache.hadoop.hbase.regionserver.TestColumnSeeking
            org.apache.hadoop.hbase.client.TestMetaWithReplicas
            org.apache.hadoop.hbase.regionserver.wal.TestLogRollAbort
            org.apache.hadoop.hbase.regionserver.TestCompactSplitThread
            org.apache.hadoop.hbase.regionserver.TestRegionIncrement
            org.apache.hadoop.hbase.master.TestTableStateManager
            org.apache.hadoop.hbase.master.TestTableLockManager
            org.apache.hadoop.hbase.master.TestSplitLogManager
            org.apache.hadoop.hbase.regionserver.TestSplitWalDataLoss
            org.apache.hadoop.hbase.master.TestRollingRestart
            org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer
            org.apache.hadoop.hbase.master.TestDistributedLogSplitting
            org.apache.hadoop.hbase.regionserver.TestRegionServerReportForDuty
            org.apache.hadoop.hbase.regionserver.wal.TestLogRolling
            org.apache.hadoop.hbase.master.TestMasterShutdown
            org.apache.hadoop.hbase.regionserver.throttle.TestCompactionWithThroughputController
            org.apache.hadoop.hbase.regionserver.TestPerColumnFamilyFlush
            org.apache.hadoop.hbase.regionserver.TestJoinedScanners
            org.apache.hadoop.hbase.regionserver.throttle.TestFlushWithThroughputController
            org.apache.hadoop.hbase.regionserver.TestCompactionWithCoprocessor
            org.apache.hadoop.hbase.TestGlobalMemStoreSize
            org.apache.hadoop.hbase.zookeeper.lock.TestZKInterProcessReadWriteLock
            org.apache.hadoop.hbase.regionserver.TestHRegionOnCluster
            org.apache.hadoop.hbase.regionserver.TestCompoundBloomFilter
            org.apache.hadoop.hbase.TestMovedRegionsCleaner
            org.apache.hadoop.hbase.TestRegionRebalancing
            org.apache.hadoop.hbase.regionserver.TestRecoveredEdits
            org.apache.hadoop.hbase.mapreduce.TestHLogRecordReader
            org.apache.hadoop.hbase.master.TestMasterNoCluster
            org.apache.hadoop.hbase.TestIOFencing
            org.apache.hadoop.hbase.regionserver.TestRSKilledWhenInitializing
            org.apache.hadoop.hbase.regionserver.TestHRegion
            org.apache.hadoop.hbase.regionserver.TestDefaultMemStore
            org.apache.hadoop.hbase.master.handler.TestTableDescriptorModification
            org.apache.hadoop.hbase.TestLocalHBaseCluster
            org.apache.hadoop.hbase.regionserver.TestMultiColumnScanner
            org.apache.hadoop.hbase.regionserver.TestFSErrorsExposed
            org.apache.hadoop.hbase.regionserver.TestRegionServerHostname
            org.apache.hadoop.hbase.regionserver.TestClusterId
            org.apache.hadoop.hbase.fs.TestBlockReorder
            org.apache.hadoop.hbase.replication.regionserver.TestReplicationWALReaderManager
            org.apache.hadoop.hbase.client.TestTableSnapshotScanner
            org.apache.hadoop.hbase.wal.TestDefaultWALProvider
            org.apache.hadoop.hbase.regionserver.TestHRegionReplayEvents
            org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient
            org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort
            org.apache.hadoop.hbase.regionserver.TestSeekOptimizations
            org.apache.hadoop.hbase.replication.TestMultiSlaveReplication
            org.apache.hadoop.hbase.regionserver.TestRegionReplicaFailover
            org.apache.hadoop.hbase.wal.TestBoundedRegionGroupingStrategy
            org.apache.hadoop.hbase.wal.TestWALFactory
            org.apache.hadoop.hbase.regionserver.TestStore
            org.apache.hadoop.hbase.regionserver.TestParallelPut
            org.apache.hadoop.hbase.mapreduce.TestTableSnapshotInputFormat
            org.apache.hadoop.hbase.regionserver.TestHRegionServerBulkLoad
            org.apache.hadoop.hbase.replication.TestMasterReplication
            org.apache.hadoop.hbase.regionserver.TestAtomicOperation
            org.apache.hadoop.hbase.regionserver.wal.TestDurability
            org.apache.hadoop.hbase.mapred.TestTableSnapshotInputFormat
            org.apache.hadoop.hbase.regionserver.TestMajorCompaction
            org.apache.hadoop.hbase.wal.TestWALSplit



          Subsystem Report/Notes
          Docker Client=1.9.1 Server=1.9.1 Image:yetus/hbase:date2016-03-02
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790922/HBASE-9393.v14.patch
          JIRA Issue HBASE-9393
          Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux bc732b985d47 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / 5e395c4
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/802/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/802/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/802/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HBASE-Build/802/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/802/testReport/
          modules C: hbase-server U: hbase-server
          Max memory used 193MB
          Powered by Apache Yetus 0.1.0 http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/802/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 3m 40s master passed +1 compile 1m 15s master passed with JDK v1.8.0_72 +1 compile 0m 59s master passed with JDK v1.7.0_95 +1 checkstyle 5m 31s master passed +1 mvneclipse 0m 27s master passed +1 findbugs 2m 45s master passed +1 javadoc 0m 55s master passed with JDK v1.8.0_72 +1 javadoc 0m 59s master passed with JDK v1.7.0_95 +1 mvninstall 1m 14s the patch passed +1 compile 1m 20s the patch passed with JDK v1.8.0_72 +1 javac 1m 20s the patch passed +1 compile 0m 57s the patch passed with JDK v1.7.0_95 +1 javac 0m 57s the patch passed +1 checkstyle 5m 3s the patch passed +1 mvneclipse 0m 27s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 hadoopcheck 29m 17s Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. +1 findbugs 2m 24s the patch passed +1 javadoc 0m 35s the patch passed with JDK v1.8.0_72 +1 javadoc 0m 38s the patch passed with JDK v1.7.0_95 -1 unit 25m 9s hbase-server in the patch failed with JDK v1.8.0_72. -1 unit 82m 4s hbase-server in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 27s Patch does not generate ASF License warnings. 166m 46s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.hbase.ipc.TestSimpleRpcScheduler JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.hbase.regionserver.TestCorruptedRegionStoreFile   org.apache.hadoop.hbase.regionserver.TestSplitLogWorker   org.apache.hadoop.hbase.regionserver.compactions.TestFIFOCompactionPolicy   org.apache.hadoop.hbase.regionserver.wal.TestFSHLog   org.apache.hadoop.hbase.regionserver.TestCompaction   org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId   org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2   org.apache.hadoop.hbase.coprocessor.TestRegionObserverScannerOpenHook   org.apache.hadoop.hbase.wal.TestWALFiltering   org.apache.hadoop.hbase.wal.TestDefaultWALProviderWithHLogKey   org.apache.hadoop.hbase.coprocessor.TestRegionServerObserver   org.apache.hadoop.hbase.wal.TestWALSplitCompressed   org.apache.hadoop.hbase.TestZooKeeper   org.apache.hadoop.hbase.master.TestGetInfoPort   org.apache.hadoop.hbase.regionserver.TestColumnSeeking   org.apache.hadoop.hbase.client.TestMetaWithReplicas   org.apache.hadoop.hbase.regionserver.wal.TestLogRollAbort   org.apache.hadoop.hbase.regionserver.TestCompactSplitThread   org.apache.hadoop.hbase.regionserver.TestRegionIncrement   org.apache.hadoop.hbase.master.TestTableStateManager   org.apache.hadoop.hbase.master.TestTableLockManager   org.apache.hadoop.hbase.master.TestSplitLogManager   org.apache.hadoop.hbase.regionserver.TestSplitWalDataLoss   org.apache.hadoop.hbase.master.TestRollingRestart   org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer   org.apache.hadoop.hbase.master.TestDistributedLogSplitting   org.apache.hadoop.hbase.regionserver.TestRegionServerReportForDuty   org.apache.hadoop.hbase.regionserver.wal.TestLogRolling   org.apache.hadoop.hbase.master.TestMasterShutdown   org.apache.hadoop.hbase.regionserver.throttle.TestCompactionWithThroughputController   org.apache.hadoop.hbase.regionserver.TestPerColumnFamilyFlush   org.apache.hadoop.hbase.regionserver.TestJoinedScanners   org.apache.hadoop.hbase.regionserver.throttle.TestFlushWithThroughputController   org.apache.hadoop.hbase.regionserver.TestCompactionWithCoprocessor   org.apache.hadoop.hbase.TestGlobalMemStoreSize   org.apache.hadoop.hbase.zookeeper.lock.TestZKInterProcessReadWriteLock   org.apache.hadoop.hbase.regionserver.TestHRegionOnCluster   org.apache.hadoop.hbase.regionserver.TestCompoundBloomFilter   org.apache.hadoop.hbase.TestMovedRegionsCleaner   org.apache.hadoop.hbase.TestRegionRebalancing   org.apache.hadoop.hbase.regionserver.TestRecoveredEdits   org.apache.hadoop.hbase.mapreduce.TestHLogRecordReader   org.apache.hadoop.hbase.master.TestMasterNoCluster   org.apache.hadoop.hbase.TestIOFencing   org.apache.hadoop.hbase.regionserver.TestRSKilledWhenInitializing   org.apache.hadoop.hbase.regionserver.TestHRegion   org.apache.hadoop.hbase.regionserver.TestDefaultMemStore   org.apache.hadoop.hbase.master.handler.TestTableDescriptorModification   org.apache.hadoop.hbase.TestLocalHBaseCluster   org.apache.hadoop.hbase.regionserver.TestMultiColumnScanner   org.apache.hadoop.hbase.regionserver.TestFSErrorsExposed   org.apache.hadoop.hbase.regionserver.TestRegionServerHostname   org.apache.hadoop.hbase.regionserver.TestClusterId   org.apache.hadoop.hbase.fs.TestBlockReorder   org.apache.hadoop.hbase.replication.regionserver.TestReplicationWALReaderManager   org.apache.hadoop.hbase.client.TestTableSnapshotScanner   org.apache.hadoop.hbase.wal.TestDefaultWALProvider   org.apache.hadoop.hbase.regionserver.TestHRegionReplayEvents   org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient   org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort   org.apache.hadoop.hbase.regionserver.TestSeekOptimizations   org.apache.hadoop.hbase.replication.TestMultiSlaveReplication   org.apache.hadoop.hbase.regionserver.TestRegionReplicaFailover   org.apache.hadoop.hbase.wal.TestBoundedRegionGroupingStrategy   org.apache.hadoop.hbase.wal.TestWALFactory   org.apache.hadoop.hbase.regionserver.TestStore   org.apache.hadoop.hbase.regionserver.TestParallelPut   org.apache.hadoop.hbase.mapreduce.TestTableSnapshotInputFormat   org.apache.hadoop.hbase.regionserver.TestHRegionServerBulkLoad   org.apache.hadoop.hbase.replication.TestMasterReplication   org.apache.hadoop.hbase.regionserver.TestAtomicOperation   org.apache.hadoop.hbase.regionserver.wal.TestDurability   org.apache.hadoop.hbase.mapred.TestTableSnapshotInputFormat   org.apache.hadoop.hbase.regionserver.TestMajorCompaction   org.apache.hadoop.hbase.wal.TestWALSplit Subsystem Report/Notes Docker Client=1.9.1 Server=1.9.1 Image:yetus/hbase:date2016-03-02 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790922/HBASE-9393.v14.patch JIRA Issue HBASE-9393 Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux bc732b985d47 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / 5e395c4 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HBASE-Build/802/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/802/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/802/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HBASE-Build/802/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/802/testReport/ modules C: hbase-server U: hbase-server Max memory used 193MB Powered by Apache Yetus 0.1.0 http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HBASE-Build/802/console This message was automatically generated.
          Hide
          ashish singhi Ashish Singhi added a comment -

          Please review patch v14 and let me know your comments.
          Thanks.

          Show
          ashish singhi Ashish Singhi added a comment - Please review patch v14 and let me know your comments. Thanks.
          Hide
          ashish singhi Ashish Singhi added a comment -

          Are the characteristics of stream something we can determine in a static initializer from configs, perhaps by instantiating a dummy version?

          No we cannot do that way. I checked the code and the same is stated in the javadoc

            /** Two stream handles, one with and one without FS-level checksum.
             * HDFS checksum setting is on FS level, not single read level, so you have to keep two
             * FS objects and two handles open to interleave different reads freely, which is very sad.
             * This is what we do:
             * 1) First, we need to read the trailer of HFile to determine checksum parameters.
             *  We always use FS checksum to do that, so ctor opens {@link #stream}.
             * 2.1) After that, if HBase checksum is not used, we'd just always use {@link #stream};
             * 2.2) If HBase checksum can be used, we'll open {@link #streamNoFsChecksum},
             *  and close {@link #stream}. User MUST call prepareForBlockReader for that to happen;
             *  if they don't, (2.1) will be the default.
             * 3) The users can call {@link #shouldUseHBaseChecksum()}, and pass its result to
             *  {@link #getStream(boolean)} to get stream (if Java had out/pointer params we could
             *  return both in one call). This stream is guaranteed to be set.
             * 4) The first time HBase checksum fails, one would call {@link #fallbackToFsChecksum(int)}.
             * That will take lock, and open {@link #stream}. While this is going on, others will
             * continue to use the old stream; if they also want to fall back, they'll also call
             * {@link #fallbackToFsChecksum(int)}, and block until {@link #stream} is set.
             * 5) After some number of checksumOk() calls, we will go back to using HBase checksum.
             * We will have 2 handles; however we presume checksums fail so rarely that we don't care.
             */
          

          The value of hbase checksum and stream will be used cannot be determined in a static initializer. I think unbuffer method type should be a instance variable and cannot be shared.

          Show
          ashish singhi Ashish Singhi added a comment - Are the characteristics of stream something we can determine in a static initializer from configs, perhaps by instantiating a dummy version? No we cannot do that way. I checked the code and the same is stated in the javadoc /** Two stream handles, one with and one without FS-level checksum. * HDFS checksum setting is on FS level, not single read level, so you have to keep two * FS objects and two handles open to interleave different reads freely, which is very sad. * This is what we do: * 1) First, we need to read the trailer of HFile to determine checksum parameters. * We always use FS checksum to do that, so ctor opens {@link #stream}. * 2.1) After that, if HBase checksum is not used, we'd just always use {@link #stream}; * 2.2) If HBase checksum can be used, we'll open {@link #streamNoFsChecksum}, * and close {@link #stream}. User MUST call prepareForBlockReader for that to happen; * if they don't, (2.1) will be the default. * 3) The users can call {@link #shouldUseHBaseChecksum()}, and pass its result to * {@link #getStream(boolean)} to get stream (if Java had out/pointer params we could * return both in one call). This stream is guaranteed to be set. * 4) The first time HBase checksum fails, one would call {@link #fallbackToFsChecksum(int)}. * That will take lock, and open {@link #stream}. While this is going on, others will * continue to use the old stream; if they also want to fall back, they'll also call * {@link #fallbackToFsChecksum(int)}, and block until {@link #stream} is set. * 5) After some number of checksumOk() calls, we will go back to using HBase checksum. * We will have 2 handles; however we presume checksums fail so rarely that we don't care. */ The value of hbase checksum and stream will be used cannot be determined in a static initializer. I think unbuffer method type should be a instance variable and cannot be shared.
          Hide
          ashish singhi Ashish Singhi added a comment -

          Thanks for the comments Sean Busbey and Anoop Sam John.
          Sorry for my absence here, I was not keeping well from last few days.
          Will check the comments in detail and get back on this tomorrow (IST).

          Show
          ashish singhi Ashish Singhi added a comment - Thanks for the comments Sean Busbey and Anoop Sam John . Sorry for my absence here, I was not keeping well from last few days. Will check the comments in detail and get back on this tomorrow (IST).
          Hide
          busbey Sean Busbey added a comment - - edited

          The static boolean tells whether the underlying FS supports unbuffer call or not. Depending on the useHBaseChecksum and stream it wont change.. So there is no confusion as such abt this.

          But this is static across all instances in the same JVM. if it "depends on the stream" then that means we can't have a single static instance unless we know all the streams will be the same. If they'll all be the same, then we can do this in a static initializer.

          Regarding the init of the static boolean, IMHO there is no need to worry abt the multi thread. We dont want every op to do the interfaces listing and check (String op). Even if, at begin, 2 threads do it parallely, its ok. Both will give same result only.

          This is not true. The current code is not threadsafe and will fail in some cases. If we can't do this in a static initializer or otherwise assure that hte code itself will be threadsafe, then we need to mark the method as not thread safe (similar to he current non-threadsafe portion of this class) and then we need to ensure that it is only called within proper fencing across all instances within the same JVM.

          To be clear, I am currently -1 for thread safety incorrectness.

          Show
          busbey Sean Busbey added a comment - - edited The static boolean tells whether the underlying FS supports unbuffer call or not. Depending on the useHBaseChecksum and stream it wont change.. So there is no confusion as such abt this. But this is static across all instances in the same JVM. if it "depends on the stream" then that means we can't have a single static instance unless we know all the streams will be the same. If they'll all be the same, then we can do this in a static initializer. Regarding the init of the static boolean, IMHO there is no need to worry abt the multi thread. We dont want every op to do the interfaces listing and check (String op). Even if, at begin, 2 threads do it parallely, its ok. Both will give same result only. This is not true. The current code is not threadsafe and will fail in some cases. If we can't do this in a static initializer or otherwise assure that hte code itself will be threadsafe, then we need to mark the method as not thread safe (similar to he current non-threadsafe portion of this class) and then we need to ensure that it is only called within proper fencing across all instances within the same JVM . To be clear, I am currently -1 for thread safety incorrectness.
          Hide
          anoop.hbase Anoop Sam John added a comment -

          can useHBaseChecksum vary amongst instances in the same JVM? if it can, then we shouldn't be sharing cached information about the unbuffer call at all (or we need to have one of them per streamClass). That would solve the "assign to static" business by moving to per-instance caches of the reflection information.

          The static boolean tells whether the underlying FS supports unbuffer call or not. Depending on the useHBaseChecksum and stream it wont change.. So there is no confusion as such abt this.
          Regarding the init of the static boolean, IMHO there is no need to worry abt the multi thread. We dont want every op to do the interfaces listing and check (String op). Even if, at begin, 2 threads do it parallely, its ok. Both will give same result only. Pls add proper comments here. And no need to add extra things to get away with findbugs warn. Write clearly why no worry abt findbugs comment here and we can add ignore annotate for the findbugs so that it wont list this comment.

          Show
          anoop.hbase Anoop Sam John added a comment - can useHBaseChecksum vary amongst instances in the same JVM? if it can, then we shouldn't be sharing cached information about the unbuffer call at all (or we need to have one of them per streamClass). That would solve the "assign to static" business by moving to per-instance caches of the reflection information. The static boolean tells whether the underlying FS supports unbuffer call or not. Depending on the useHBaseChecksum and stream it wont change.. So there is no confusion as such abt this. Regarding the init of the static boolean, IMHO there is no need to worry abt the multi thread. We dont want every op to do the interfaces listing and check (String op). Even if, at begin, 2 threads do it parallely, its ok. Both will give same result only. Pls add proper comments here. And no need to add extra things to get away with findbugs warn. Write clearly why no worry abt findbugs comment here and we can add ignore annotate for the findbugs so that it wont list this comment.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 2m 55s master passed
          +1 compile 0m 32s master passed with JDK v1.8.0_72
          +1 compile 0m 34s master passed with JDK v1.7.0_95
          +1 checkstyle 4m 19s master passed
          +1 mvneclipse 0m 17s master passed
          +1 findbugs 1m 50s master passed
          +1 javadoc 0m 26s master passed with JDK v1.8.0_72
          +1 javadoc 0m 33s master passed with JDK v1.7.0_95
          +1 mvninstall 0m 45s the patch passed
          +1 compile 0m 32s the patch passed with JDK v1.8.0_72
          +1 javac 0m 32s the patch passed
          +1 compile 0m 34s the patch passed with JDK v1.7.0_95
          +1 javac 0m 34s the patch passed
          +1 checkstyle 4m 20s the patch passed
          +1 mvneclipse 0m 16s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 hadoopcheck 23m 44s Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1.
          +1 findbugs 1m 59s the patch passed
          +1 javadoc 0m 25s the patch passed with JDK v1.8.0_72
          +1 javadoc 0m 34s the patch passed with JDK v1.7.0_95
          -1 unit 13m 28s hbase-server in the patch failed with JDK v1.8.0_72.
          -1 unit 15m 35s hbase-server in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 11s Patch does not generate ASF License warnings.
          74m 17s



          Reason Tests
          JDK v1.8.0_72 Failed junit tests hadoop.hbase.ipc.TestRpcMetrics
            hadoop.hbase.regionserver.TestMetricsRegionServer
            hadoop.hbase.regionserver.TestMetricsRegion
          JDK v1.7.0_95 Failed junit tests hadoop.hbase.ipc.TestRpcMetrics
            hadoop.hbase.regionserver.TestMetricsRegionServer
            hadoop.hbase.regionserver.TestMetricsRegion



          Subsystem Report/Notes
          Docker Client=1.9.1 Server=1.9.1 Image:yetus/hbase:date2016-02-25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12789946/HBASE-9393.v13.patch
          JIRA Issue HBASE-9393
          Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux 7e3d8773cb1c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / 43f99de
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/697/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/697/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/697/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HBASE-Build/697/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/697/testReport/
          modules C: hbase-server U: hbase-server
          Max memory used 186MB
          Powered by Apache Yetus 0.1.0 http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/697/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 2m 55s master passed +1 compile 0m 32s master passed with JDK v1.8.0_72 +1 compile 0m 34s master passed with JDK v1.7.0_95 +1 checkstyle 4m 19s master passed +1 mvneclipse 0m 17s master passed +1 findbugs 1m 50s master passed +1 javadoc 0m 26s master passed with JDK v1.8.0_72 +1 javadoc 0m 33s master passed with JDK v1.7.0_95 +1 mvninstall 0m 45s the patch passed +1 compile 0m 32s the patch passed with JDK v1.8.0_72 +1 javac 0m 32s the patch passed +1 compile 0m 34s the patch passed with JDK v1.7.0_95 +1 javac 0m 34s the patch passed +1 checkstyle 4m 20s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 hadoopcheck 23m 44s Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. +1 findbugs 1m 59s the patch passed +1 javadoc 0m 25s the patch passed with JDK v1.8.0_72 +1 javadoc 0m 34s the patch passed with JDK v1.7.0_95 -1 unit 13m 28s hbase-server in the patch failed with JDK v1.8.0_72. -1 unit 15m 35s hbase-server in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 11s Patch does not generate ASF License warnings. 74m 17s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.hbase.ipc.TestRpcMetrics   hadoop.hbase.regionserver.TestMetricsRegionServer   hadoop.hbase.regionserver.TestMetricsRegion JDK v1.7.0_95 Failed junit tests hadoop.hbase.ipc.TestRpcMetrics   hadoop.hbase.regionserver.TestMetricsRegionServer   hadoop.hbase.regionserver.TestMetricsRegion Subsystem Report/Notes Docker Client=1.9.1 Server=1.9.1 Image:yetus/hbase:date2016-02-25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12789946/HBASE-9393.v13.patch JIRA Issue HBASE-9393 Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux 7e3d8773cb1c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / 43f99de findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HBASE-Build/697/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/697/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/697/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HBASE-Build/697/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/697/testReport/ modules C: hbase-server U: hbase-server Max memory used 186MB Powered by Apache Yetus 0.1.0 http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HBASE-Build/697/console This message was automatically generated.
          Hide
          busbey Sean Busbey added a comment -

          Why are we making these assignments indirectly via methods?

          To handle the findbugs warnings ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD: Write to static field from instance method.

          But these methods have the same underlying problem: we're unsafely updating from multiple instance locations.

          This doesn't look like it will behave correctly in presence of concurrency. Can we do the reflection set up during a static initializer?

          Intial plan was to do that way and do this set up only once (which we still do only once in the patch) but then the stream is a instance object so could not do that way. Regarding concurrency we have handled that, the parallel reads will come through HFileBlock reads and there we acquiring the stream lock and then call the stream unbuffer, same as we do the for the block reads.

          There's nothing in this class that lets anyone know that this method must be accessed within a lock. The top level class description even claims that it is threadsafe for normal operations. Additionally, this change requires us to lock across all instances rather than just one as the current non-threadsafe portions do.

          Are the characteristics of stream something we can determine in a static initializer from configs, perhaps by instantiating a dummy version?

          FSDataInputStream stream = this.useHBaseChecksum ? this.streamNoFsChecksum : this.stream;
          

          can useHBaseChecksum vary amongst instances in the same JVM? if it can, then we shouldn't be sharing cached information about the unbuffer call at all (or we need to have one of them per streamClass). That would solve the "assign to static" business by moving to per-instance caches of the reflection information.

          Show
          busbey Sean Busbey added a comment - Why are we making these assignments indirectly via methods? To handle the findbugs warnings ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD: Write to static field from instance method. But these methods have the same underlying problem: we're unsafely updating from multiple instance locations. This doesn't look like it will behave correctly in presence of concurrency. Can we do the reflection set up during a static initializer? Intial plan was to do that way and do this set up only once (which we still do only once in the patch) but then the stream is a instance object so could not do that way. Regarding concurrency we have handled that, the parallel reads will come through HFileBlock reads and there we acquiring the stream lock and then call the stream unbuffer, same as we do the for the block reads. There's nothing in this class that lets anyone know that this method must be accessed within a lock. The top level class description even claims that it is threadsafe for normal operations. Additionally, this change requires us to lock across all instances rather than just one as the current non-threadsafe portions do. Are the characteristics of stream something we can determine in a static initializer from configs, perhaps by instantiating a dummy version? FSDataInputStream stream = this .useHBaseChecksum ? this .streamNoFsChecksum : this .stream; can useHBaseChecksum vary amongst instances in the same JVM? if it can, then we shouldn't be sharing cached information about the unbuffer call at all (or we need to have one of them per streamClass). That would solve the "assign to static" business by moving to per-instance caches of the reflection information.
          Hide
          ashish singhi Ashish Singhi added a comment -

          Patch addressing comments.
          Please review.

          Show
          ashish singhi Ashish Singhi added a comment - Patch addressing comments. Please review.
          Hide
          ashish singhi Ashish Singhi added a comment -

          Thanks for the comments.

          Several of your log messages are at ERROR but they don't give an operator any idea about what to do next. No info on finding a root cause, something to correct, or get more information. Could we add some of that kind of information or change them to be INFO or WARN?

          I will change the level and point to this jira in the log message.

          Why are we making these assignments indirectly via methods?

          To handle the findbugs warnings ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD: Write to static field from instance method.

          This doesn't look like it will behave correctly in presence of concurrency. Can we do the reflection set up during a static initializer?

          Intial plan was to do that way and do this set up only once (which we still do only once in the patch) but then the stream is a instance object so could not do that way. Regarding concurrency we have handled that, the parallel reads will come through HFileBlock reads and there we acquiring the stream lock and then call the stream unbuffer, same as we do the for the block reads.

          This should probably have an else clause that similarly gives the warning. In that case, it should probably give a pointer to this issue.

          Will address it.

          Show
          ashish singhi Ashish Singhi added a comment - Thanks for the comments. Several of your log messages are at ERROR but they don't give an operator any idea about what to do next. No info on finding a root cause, something to correct, or get more information. Could we add some of that kind of information or change them to be INFO or WARN? I will change the level and point to this jira in the log message. Why are we making these assignments indirectly via methods? To handle the findbugs warnings ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD: Write to static field from instance method . This doesn't look like it will behave correctly in presence of concurrency. Can we do the reflection set up during a static initializer? Intial plan was to do that way and do this set up only once (which we still do only once in the patch) but then the stream is a instance object so could not do that way. Regarding concurrency we have handled that, the parallel reads will come through HFileBlock reads and there we acquiring the stream lock and then call the stream unbuffer, same as we do the for the block reads. This should probably have an else clause that similarly gives the warning. In that case, it should probably give a pointer to this issue. Will address it.
          Hide
          busbey Sean Busbey added a comment -

          Ah. next time I'll try to read more of the background. That part makes sense now.

          Show
          busbey Sean Busbey added a comment - Ah. next time I'll try to read more of the background. That part makes sense now.
          Hide
          stack stack added a comment -

          Sean Busbey The method rename was done at my suggestion. If you read what the method does, previous name made no sense.

          Show
          stack stack added a comment - Sean Busbey The method rename was done at my suggestion. If you read what the method does, previous name made no sense.
          Hide
          busbey Sean Busbey added a comment -
          -  private static Reader pickReaderVersion(Path path, FSDataInputStreamWrapper fsdis,
          -      long size, CacheConfig cacheConf, HFileSystem hfs, Configuration conf) throws IOException {
          +  private static Reader openReader(Path path, FSDataInputStreamWrapper fsdis, long size,
          +      CacheConfig cacheConf, HFileSystem hfs, Configuration conf) throws IOException {
          

          Why the method rename?

          Show
          busbey Sean Busbey added a comment - - private static Reader pickReaderVersion(Path path, FSDataInputStreamWrapper fsdis, - long size, CacheConfig cacheConf, HFileSystem hfs, Configuration conf) throws IOException { + private static Reader openReader(Path path, FSDataInputStreamWrapper fsdis, long size, + CacheConfig cacheConf, HFileSystem hfs, Configuration conf) throws IOException { Why the method rename?
          Hide
          busbey Sean Busbey added a comment -

          Several of your log messages are at ERROR but they don't give an operator any idea about what to do next. No info on finding a root cause, something to correct, or get more information. Could we add some of that kind of information or change them to be INFO or WARN?

          +  private static void setInstanceOfCanUnbuffer(boolean instanceOfCanUnbuffer) {
          +    FSDataInputStreamWrapper.instanceOfCanUnbuffer = instanceOfCanUnbuffer;
          +  }
          +
          +  private static void setUnbufferMethod(Method unbuffer) {
          +    FSDataInputStreamWrapper.unbuffer = unbuffer;
          +  }
          

          Why are we making these assignments indirectly via methods?

          +      if (FSDataInputStreamWrapper.instanceOfCanUnbuffer == null) {
          +        // To ensure we compute whether the stream is instance of CanUnbuffer only once.
          +        FSDataInputStreamWrapper.setInstanceOfCanUnbuffer(false);
          +        Class<?>[] streamInterfaces = streamClass.getInterfaces();
          +        for (Class c : streamInterfaces) {
          +          if (c.getCanonicalName().toString().equals("org.apache.hadoop.fs.CanUnbuffer")) {
          +            try {
          +              FSDataInputStreamWrapper.setUnbufferMethod(streamClass.getDeclaredMethod("unbuffer"));
          +            } catch (Exception e) {
          +              LOG.error("Failed to find 'unbuffer' method in class " + streamClass, e);
          +              return;
          +            }
          +            FSDataInputStreamWrapper.setInstanceOfCanUnbuffer(true);
          +            break;
          +          }
          +        }
          +      }
          

          This doesn't look like it will behave correctly in presence of concurrency. Can we do the reflection set up during a static initializer?

          +      if (FSDataInputStreamWrapper.instanceOfCanUnbuffer) {
          +        try {
          +          FSDataInputStreamWrapper.unbuffer.invoke(wrappedStream);
          +        } catch (Exception e) {
          +          LOG.error("Failed to unbuffer the stream so possibly there may be a TCP socket "
          +              + "connection left open in CLOSE_WAIT state for this RegionServer.", e);
          +        }
          +      }
          

          This should probably have an else clause that similarly gives the warning. In that case, it should probably give a pointer to this issue.

          Show
          busbey Sean Busbey added a comment - Several of your log messages are at ERROR but they don't give an operator any idea about what to do next. No info on finding a root cause, something to correct, or get more information. Could we add some of that kind of information or change them to be INFO or WARN? + private static void setInstanceOfCanUnbuffer( boolean instanceOfCanUnbuffer) { + FSDataInputStreamWrapper.instanceOfCanUnbuffer = instanceOfCanUnbuffer; + } + + private static void setUnbufferMethod(Method unbuffer) { + FSDataInputStreamWrapper.unbuffer = unbuffer; + } Why are we making these assignments indirectly via methods? + if (FSDataInputStreamWrapper.instanceOfCanUnbuffer == null ) { + // To ensure we compute whether the stream is instance of CanUnbuffer only once. + FSDataInputStreamWrapper.setInstanceOfCanUnbuffer( false ); + Class <?>[] streamInterfaces = streamClass.getInterfaces(); + for ( Class c : streamInterfaces) { + if (c.getCanonicalName().toString().equals( "org.apache.hadoop.fs.CanUnbuffer" )) { + try { + FSDataInputStreamWrapper.setUnbufferMethod(streamClass.getDeclaredMethod( "unbuffer" )); + } catch (Exception e) { + LOG.error( "Failed to find 'unbuffer' method in class " + streamClass, e); + return ; + } + FSDataInputStreamWrapper.setInstanceOfCanUnbuffer( true ); + break ; + } + } + } This doesn't look like it will behave correctly in presence of concurrency. Can we do the reflection set up during a static initializer? + if (FSDataInputStreamWrapper.instanceOfCanUnbuffer) { + try { + FSDataInputStreamWrapper.unbuffer.invoke(wrappedStream); + } catch (Exception e) { + LOG.error( "Failed to unbuffer the stream so possibly there may be a TCP socket " + + "connection left open in CLOSE_WAIT state for this RegionServer." , e); + } + } This should probably have an else clause that similarly gives the warning. In that case, it should probably give a pointer to this issue.
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          +1 on v12

          Show
          yuzhihong@gmail.com Ted Yu added a comment - +1 on v12
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 3m 5s master passed
          +1 compile 0m 36s master passed with JDK v1.8.0_72
          +1 compile 0m 37s master passed with JDK v1.7.0_95
          +1 checkstyle 4m 36s master passed
          +1 mvneclipse 0m 18s master passed
          +1 findbugs 2m 0s master passed
          +1 javadoc 0m 29s master passed with JDK v1.8.0_72
          +1 javadoc 0m 36s master passed with JDK v1.7.0_95
          +1 mvninstall 0m 50s the patch passed
          +1 compile 0m 37s the patch passed with JDK v1.8.0_72
          +1 javac 0m 37s the patch passed
          +1 compile 0m 39s the patch passed with JDK v1.7.0_95
          +1 javac 0m 39s the patch passed
          +1 checkstyle 4m 15s the patch passed
          +1 mvneclipse 0m 19s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 hadoopcheck 25m 24s Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1.
          +1 findbugs 2m 14s the patch passed
          +1 javadoc 0m 29s the patch passed with JDK v1.8.0_72
          +1 javadoc 0m 37s the patch passed with JDK v1.7.0_95
          -1 unit 112m 9s hbase-server in the patch failed with JDK v1.8.0_72.
          -1 unit 110m 0s hbase-server in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 21s Patch does not generate ASF License warnings.
          271m 2s



          Reason Tests
          JDK v1.8.0_72 Timed out junit tests org.apache.hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster
          JDK v1.7.0_95 Failed junit tests hadoop.hbase.mapreduce.TestImportExport



          Subsystem Report/Notes
          Docker Client=1.9.1 Server=1.9.1 Image:yetus/hbase:date2016-02-19
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788618/HBASE-9393.v12.patch
          JIRA Issue HBASE-9393
          Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux 3c7b1176f2a3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / f352f3c
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/600/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/600/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/600/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HBASE-Build/600/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/600/testReport/
          modules C: hbase-server U: hbase-server
          Max memory used 425MB
          Powered by Apache Yetus 0.1.0 http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/600/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 3m 5s master passed +1 compile 0m 36s master passed with JDK v1.8.0_72 +1 compile 0m 37s master passed with JDK v1.7.0_95 +1 checkstyle 4m 36s master passed +1 mvneclipse 0m 18s master passed +1 findbugs 2m 0s master passed +1 javadoc 0m 29s master passed with JDK v1.8.0_72 +1 javadoc 0m 36s master passed with JDK v1.7.0_95 +1 mvninstall 0m 50s the patch passed +1 compile 0m 37s the patch passed with JDK v1.8.0_72 +1 javac 0m 37s the patch passed +1 compile 0m 39s the patch passed with JDK v1.7.0_95 +1 javac 0m 39s the patch passed +1 checkstyle 4m 15s the patch passed +1 mvneclipse 0m 19s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 hadoopcheck 25m 24s Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. +1 findbugs 2m 14s the patch passed +1 javadoc 0m 29s the patch passed with JDK v1.8.0_72 +1 javadoc 0m 37s the patch passed with JDK v1.7.0_95 -1 unit 112m 9s hbase-server in the patch failed with JDK v1.8.0_72. -1 unit 110m 0s hbase-server in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 271m 2s Reason Tests JDK v1.8.0_72 Timed out junit tests org.apache.hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster JDK v1.7.0_95 Failed junit tests hadoop.hbase.mapreduce.TestImportExport Subsystem Report/Notes Docker Client=1.9.1 Server=1.9.1 Image:yetus/hbase:date2016-02-19 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788618/HBASE-9393.v12.patch JIRA Issue HBASE-9393 Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux 3c7b1176f2a3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / f352f3c findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HBASE-Build/600/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/600/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/600/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HBASE-Build/600/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/600/testReport/ modules C: hbase-server U: hbase-server Max memory used 425MB Powered by Apache Yetus 0.1.0 http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HBASE-Build/600/console This message was automatically generated.
          Hide
          ashish singhi Ashish Singhi added a comment -

          Patch addressing Ted's comment.
          Please review.

          Show
          ashish singhi Ashish Singhi added a comment - Patch addressing Ted's comment. Please review.
          Hide
          ashish singhi Ashish Singhi added a comment -

          That I added for extra protection if its still null we can do it another time. Now I feel its not required. Will attach a patch in a short time.
          Thanks for the review.

          Show
          ashish singhi Ashish Singhi added a comment - That I added for extra protection if its still null we can do it another time. Now I feel its not required. Will attach a patch in a short time. Thanks for the review.
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -
          +      if (FSDataInputStreamWrapper.instanceOfCanUnbuffer) {
          +        try {
          +          if (FSDataInputStreamWrapper.unbuffer == null) {
          +            try {
          +              FSDataInputStreamWrapper.setUnbufferMethod(streamClass.getDeclaredMethod("unbuffer"));
          

          FSDataInputStreamWrapper.setUnbufferMethod() has been called in the for loop ahead of the above if block. Why do we need to call it again ?

          Show
          yuzhihong@gmail.com Ted Yu added a comment - + if (FSDataInputStreamWrapper.instanceOfCanUnbuffer) { + try { + if (FSDataInputStreamWrapper.unbuffer == null ) { + try { + FSDataInputStreamWrapper.setUnbufferMethod(streamClass.getDeclaredMethod( "unbuffer" )); FSDataInputStreamWrapper.setUnbufferMethod() has been called in the for loop ahead of the above if block. Why do we need to call it again ?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 2m 38s master passed
          +1 compile 0m 32s master passed with JDK v1.8.0_72
          +1 compile 0m 34s master passed with JDK v1.7.0_95
          +1 checkstyle 4m 22s master passed
          +1 mvneclipse 0m 16s master passed
          +1 findbugs 1m 50s master passed
          +1 javadoc 0m 26s master passed with JDK v1.8.0_72
          +1 javadoc 0m 31s master passed with JDK v1.7.0_95
          +1 mvninstall 0m 46s the patch passed
          +1 compile 0m 30s the patch passed with JDK v1.8.0_72
          +1 javac 0m 30s the patch passed
          +1 compile 0m 36s the patch passed with JDK v1.7.0_95
          +1 javac 0m 36s the patch passed
          +1 checkstyle 4m 2s the patch passed
          +1 mvneclipse 0m 16s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 hadoopcheck 24m 14s Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1.
          +1 findbugs 2m 8s the patch passed
          +1 javadoc 0m 32s the patch passed with JDK v1.8.0_72
          +1 javadoc 0m 39s the patch passed with JDK v1.7.0_95
          -1 unit 106m 18s hbase-server in the patch failed with JDK v1.8.0_72.
          -1 unit 99m 12s hbase-server in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 16s Patch does not generate ASF License warnings.
          251m 9s



          Reason Tests
          JDK v1.8.0_72 Failed junit tests hadoop.hbase.replication.TestReplicationEndpoint
          JDK v1.8.0_72 Timed out junit tests org.apache.hadoop.hbase.regionserver.TestHRegion
          JDK v1.7.0_95 Failed junit tests hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort
            hadoop.hbase.snapshot.TestSecureExportSnapshot



          Subsystem Report/Notes
          Docker Client=1.9.1 Server=1.9.1 Image:yetus/hbase:date2016-02-18
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788467/HBASE-9393.v11.patch
          JIRA Issue HBASE-9393
          Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux 07421da49440 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / d2ba875
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/590/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/590/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/590/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HBASE-Build/590/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/590/testReport/
          modules C: hbase-server U: hbase-server
          Max memory used 420MB
          Powered by Apache Yetus 0.1.0 http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/590/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 2m 38s master passed +1 compile 0m 32s master passed with JDK v1.8.0_72 +1 compile 0m 34s master passed with JDK v1.7.0_95 +1 checkstyle 4m 22s master passed +1 mvneclipse 0m 16s master passed +1 findbugs 1m 50s master passed +1 javadoc 0m 26s master passed with JDK v1.8.0_72 +1 javadoc 0m 31s master passed with JDK v1.7.0_95 +1 mvninstall 0m 46s the patch passed +1 compile 0m 30s the patch passed with JDK v1.8.0_72 +1 javac 0m 30s the patch passed +1 compile 0m 36s the patch passed with JDK v1.7.0_95 +1 javac 0m 36s the patch passed +1 checkstyle 4m 2s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 hadoopcheck 24m 14s Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. +1 findbugs 2m 8s the patch passed +1 javadoc 0m 32s the patch passed with JDK v1.8.0_72 +1 javadoc 0m 39s the patch passed with JDK v1.7.0_95 -1 unit 106m 18s hbase-server in the patch failed with JDK v1.8.0_72. -1 unit 99m 12s hbase-server in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 16s Patch does not generate ASF License warnings. 251m 9s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.hbase.replication.TestReplicationEndpoint JDK v1.8.0_72 Timed out junit tests org.apache.hadoop.hbase.regionserver.TestHRegion JDK v1.7.0_95 Failed junit tests hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort   hadoop.hbase.snapshot.TestSecureExportSnapshot Subsystem Report/Notes Docker Client=1.9.1 Server=1.9.1 Image:yetus/hbase:date2016-02-18 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788467/HBASE-9393.v11.patch JIRA Issue HBASE-9393 Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux 07421da49440 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / d2ba875 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HBASE-Build/590/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/590/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/590/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HBASE-Build/590/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/590/testReport/ modules C: hbase-server U: hbase-server Max memory used 420MB Powered by Apache Yetus 0.1.0 http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HBASE-Build/590/console This message was automatically generated.
          Hide
          ashish singhi Ashish Singhi added a comment -

          Fixed the last findbugs warning.
          Please review.

          Show
          ashish singhi Ashish Singhi added a comment - Fixed the last findbugs warning. Please review.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 2m 36s master passed
          +1 compile 0m 30s master passed with JDK v1.8.0_72
          +1 compile 0m 34s master passed with JDK v1.7.0_95
          +1 checkstyle 4m 20s master passed
          +1 mvneclipse 0m 17s master passed
          +1 findbugs 1m 49s master passed
          +1 javadoc 0m 24s master passed with JDK v1.8.0_72
          +1 javadoc 0m 32s master passed with JDK v1.7.0_95
          +1 mvninstall 0m 45s the patch passed
          +1 compile 0m 30s the patch passed with JDK v1.8.0_72
          +1 javac 0m 30s the patch passed
          +1 compile 0m 34s the patch passed with JDK v1.7.0_95
          +1 javac 0m 34s the patch passed
          +1 checkstyle 4m 24s the patch passed
          +1 mvneclipse 0m 17s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 hadoopcheck 21m 34s Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1.
          -1 findbugs 2m 0s hbase-server introduced 1 new FindBugs issues.
          +1 javadoc 0m 25s the patch passed with JDK v1.8.0_72
          +1 javadoc 0m 32s the patch passed with JDK v1.7.0_95
          -1 unit 87m 18s hbase-server in the patch failed with JDK v1.8.0_72.
          -1 unit 85m 1s hbase-server in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 17s Patch does not generate ASF License warnings.
          215m 7s



          Reason Tests
          FindBugs module:hbase-server
            Write to static field org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer from instance method org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java:from instance method org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java:[line 254]
          JDK v1.8.0_72 Timed out junit tests org.apache.hadoop.hbase.regionserver.TestHRegion
            org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient
          JDK v1.7.0_95 Failed junit tests hadoop.hbase.snapshot.TestSecureExportSnapshot



          Subsystem Report/Notes
          Docker Client=1.9.1 Server=1.9.1 Image:yetus/hbase:date2016-02-18
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788442/HBASE-9393.v10.patch
          JIRA Issue HBASE-9393
          Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux daa5984e7989 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / d2ba875
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/588/artifact/patchprocess/new-findbugs-hbase-server.html
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/588/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/588/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/588/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HBASE-Build/588/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/588/testReport/
          modules C: hbase-server U: hbase-server
          Max memory used 412MB
          Powered by Apache Yetus 0.1.0 http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/588/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 2m 36s master passed +1 compile 0m 30s master passed with JDK v1.8.0_72 +1 compile 0m 34s master passed with JDK v1.7.0_95 +1 checkstyle 4m 20s master passed +1 mvneclipse 0m 17s master passed +1 findbugs 1m 49s master passed +1 javadoc 0m 24s master passed with JDK v1.8.0_72 +1 javadoc 0m 32s master passed with JDK v1.7.0_95 +1 mvninstall 0m 45s the patch passed +1 compile 0m 30s the patch passed with JDK v1.8.0_72 +1 javac 0m 30s the patch passed +1 compile 0m 34s the patch passed with JDK v1.7.0_95 +1 javac 0m 34s the patch passed +1 checkstyle 4m 24s the patch passed +1 mvneclipse 0m 17s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 hadoopcheck 21m 34s Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. -1 findbugs 2m 0s hbase-server introduced 1 new FindBugs issues. +1 javadoc 0m 25s the patch passed with JDK v1.8.0_72 +1 javadoc 0m 32s the patch passed with JDK v1.7.0_95 -1 unit 87m 18s hbase-server in the patch failed with JDK v1.8.0_72. -1 unit 85m 1s hbase-server in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 17s Patch does not generate ASF License warnings. 215m 7s Reason Tests FindBugs module:hbase-server   Write to static field org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer from instance method org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java:from instance method org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java: [line 254] JDK v1.8.0_72 Timed out junit tests org.apache.hadoop.hbase.regionserver.TestHRegion   org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient JDK v1.7.0_95 Failed junit tests hadoop.hbase.snapshot.TestSecureExportSnapshot Subsystem Report/Notes Docker Client=1.9.1 Server=1.9.1 Image:yetus/hbase:date2016-02-18 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788442/HBASE-9393.v10.patch JIRA Issue HBASE-9393 Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux daa5984e7989 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / d2ba875 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/588/artifact/patchprocess/new-findbugs-hbase-server.html unit https://builds.apache.org/job/PreCommit-HBASE-Build/588/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/588/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/588/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HBASE-Build/588/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/588/testReport/ modules C: hbase-server U: hbase-server Max memory used 412MB Powered by Apache Yetus 0.1.0 http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HBASE-Build/588/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 2m 27s master passed
          +1 compile 0m 37s master passed with JDK v1.8.0_72
          +1 compile 0m 35s master passed with JDK v1.7.0_95
          +1 checkstyle 3m 51s master passed
          +1 mvneclipse 0m 17s master passed
          +1 findbugs 1m 51s master passed
          +1 javadoc 0m 28s master passed with JDK v1.8.0_72
          +1 javadoc 0m 32s master passed with JDK v1.7.0_95
          +1 mvninstall 0m 46s the patch passed
          +1 compile 0m 37s the patch passed with JDK v1.8.0_72
          +1 javac 0m 37s the patch passed
          +1 compile 0m 35s the patch passed with JDK v1.7.0_95
          +1 javac 0m 35s the patch passed
          +1 checkstyle 3m 51s the patch passed
          +1 mvneclipse 0m 17s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 hadoopcheck 22m 40s Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1.
          -1 findbugs 2m 10s hbase-server introduced 2 new FindBugs issues.
          +1 javadoc 0m 32s the patch passed with JDK v1.8.0_72
          +1 javadoc 0m 36s the patch passed with JDK v1.7.0_95
          -1 unit 102m 26s hbase-server in the patch failed with JDK v1.8.0_72.
          -1 unit 98m 33s hbase-server in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 17s Patch does not generate ASF License warnings.
          244m 31s



          Reason Tests
          FindBugs module:hbase-server
            Write to static field org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.instanceOfCanUnbuffer from instance method org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java:from instance method org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java:[line 249]
            Write to static field org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer from instance method org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java:from instance method org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java:[line 254]
          JDK v1.7.0_95 Failed junit tests hadoop.hbase.mob.TestMobDataBlockEncoding
            hadoop.hbase.regionserver.compactions.TestFIFOCompactionPolicy
          JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient



          Subsystem Report/Notes
          Docker Client=1.9.1 Server=1.9.1 Image:yetus/hbase:date2016-02-18
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788394/HBASE-9393.v10.patch
          JIRA Issue HBASE-9393
          Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux b2fe1eb68484 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / 6f8c7dc
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/583/artifact/patchprocess/new-findbugs-hbase-server.html
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/583/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/583/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/583/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/583/testReport/
          modules C: hbase-server U: hbase-server
          Max memory used 421MB
          Powered by Apache Yetus 0.1.0 http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/583/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 2m 27s master passed +1 compile 0m 37s master passed with JDK v1.8.0_72 +1 compile 0m 35s master passed with JDK v1.7.0_95 +1 checkstyle 3m 51s master passed +1 mvneclipse 0m 17s master passed +1 findbugs 1m 51s master passed +1 javadoc 0m 28s master passed with JDK v1.8.0_72 +1 javadoc 0m 32s master passed with JDK v1.7.0_95 +1 mvninstall 0m 46s the patch passed +1 compile 0m 37s the patch passed with JDK v1.8.0_72 +1 javac 0m 37s the patch passed +1 compile 0m 35s the patch passed with JDK v1.7.0_95 +1 javac 0m 35s the patch passed +1 checkstyle 3m 51s the patch passed +1 mvneclipse 0m 17s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 hadoopcheck 22m 40s Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. -1 findbugs 2m 10s hbase-server introduced 2 new FindBugs issues. +1 javadoc 0m 32s the patch passed with JDK v1.8.0_72 +1 javadoc 0m 36s the patch passed with JDK v1.7.0_95 -1 unit 102m 26s hbase-server in the patch failed with JDK v1.8.0_72. -1 unit 98m 33s hbase-server in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 17s Patch does not generate ASF License warnings. 244m 31s Reason Tests FindBugs module:hbase-server   Write to static field org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.instanceOfCanUnbuffer from instance method org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java:from instance method org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java: [line 249]   Write to static field org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer from instance method org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java:from instance method org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java: [line 254] JDK v1.7.0_95 Failed junit tests hadoop.hbase.mob.TestMobDataBlockEncoding   hadoop.hbase.regionserver.compactions.TestFIFOCompactionPolicy JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient Subsystem Report/Notes Docker Client=1.9.1 Server=1.9.1 Image:yetus/hbase:date2016-02-18 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788394/HBASE-9393.v10.patch JIRA Issue HBASE-9393 Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux b2fe1eb68484 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / 6f8c7dc findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/583/artifact/patchprocess/new-findbugs-hbase-server.html unit https://builds.apache.org/job/PreCommit-HBASE-Build/583/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/583/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/583/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/583/testReport/ modules C: hbase-server U: hbase-server Max memory used 421MB Powered by Apache Yetus 0.1.0 http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HBASE-Build/583/console This message was automatically generated.
          Hide
          ashish singhi Ashish Singhi added a comment -

          Addressed findbugs warnings.
          Please review.

          Show
          ashish singhi Ashish Singhi added a comment - Addressed findbugs warnings. Please review.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 2m 43s master passed
          +1 compile 0m 31s master passed with JDK v1.8.0_72
          +1 compile 0m 34s master passed with JDK v1.7.0_95
          +1 checkstyle 4m 15s master passed
          +1 mvneclipse 0m 17s master passed
          +1 findbugs 1m 50s master passed
          +1 javadoc 0m 25s master passed with JDK v1.8.0_72
          +1 javadoc 0m 33s master passed with JDK v1.7.0_95
          +1 mvninstall 0m 45s the patch passed
          +1 compile 0m 31s the patch passed with JDK v1.8.0_72
          +1 javac 0m 31s the patch passed
          +1 compile 0m 34s the patch passed with JDK v1.7.0_95
          +1 javac 0m 34s the patch passed
          +1 checkstyle 4m 19s the patch passed
          +1 mvneclipse 0m 16s the patch passed
          +1 whitespace 0m 1s Patch has no whitespace issues.
          +1 hadoopcheck 21m 54s Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1.
          -1 findbugs 2m 2s hbase-server introduced 2 new FindBugs issues.
          +1 javadoc 0m 24s the patch passed with JDK v1.8.0_72
          +1 javadoc 0m 32s the patch passed with JDK v1.7.0_95
          +1 unit 78m 34s hbase-server in the patch passed with JDK v1.8.0_72.
          +1 unit 80m 57s hbase-server in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 16s Patch does not generate ASF License warnings.
          202m 44s



          Reason Tests
          FindBugs module:hbase-server
            Write to static field org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.instanceOfCanUnbuffer from instance method org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java:from instance method org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java:[line 249]
            Write to static field org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer from instance method org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java:from instance method org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java:[line 254]



          Subsystem Report/Notes
          Docker Client=1.9.1 Server=1.9.1 Image:yetus/hbase:date2016-02-17
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788246/HBASE-9393.v9.patch
          JIRA Issue HBASE-9393
          Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux 80817b85faf4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / 9f8273e
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/569/artifact/patchprocess/new-findbugs-hbase-server.html
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/569/testReport/
          modules C: hbase-server U: hbase-server
          Max memory used 173MB
          Powered by Apache Yetus 0.1.0 http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/569/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 2m 43s master passed +1 compile 0m 31s master passed with JDK v1.8.0_72 +1 compile 0m 34s master passed with JDK v1.7.0_95 +1 checkstyle 4m 15s master passed +1 mvneclipse 0m 17s master passed +1 findbugs 1m 50s master passed +1 javadoc 0m 25s master passed with JDK v1.8.0_72 +1 javadoc 0m 33s master passed with JDK v1.7.0_95 +1 mvninstall 0m 45s the patch passed +1 compile 0m 31s the patch passed with JDK v1.8.0_72 +1 javac 0m 31s the patch passed +1 compile 0m 34s the patch passed with JDK v1.7.0_95 +1 javac 0m 34s the patch passed +1 checkstyle 4m 19s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 1s Patch has no whitespace issues. +1 hadoopcheck 21m 54s Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. -1 findbugs 2m 2s hbase-server introduced 2 new FindBugs issues. +1 javadoc 0m 24s the patch passed with JDK v1.8.0_72 +1 javadoc 0m 32s the patch passed with JDK v1.7.0_95 +1 unit 78m 34s hbase-server in the patch passed with JDK v1.8.0_72. +1 unit 80m 57s hbase-server in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 16s Patch does not generate ASF License warnings. 202m 44s Reason Tests FindBugs module:hbase-server   Write to static field org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.instanceOfCanUnbuffer from instance method org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java:from instance method org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java: [line 249]   Write to static field org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer from instance method org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java:from instance method org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java: [line 254] Subsystem Report/Notes Docker Client=1.9.1 Server=1.9.1 Image:yetus/hbase:date2016-02-17 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788246/HBASE-9393.v9.patch JIRA Issue HBASE-9393 Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux 80817b85faf4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / 9f8273e findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/569/artifact/patchprocess/new-findbugs-hbase-server.html JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/569/testReport/ modules C: hbase-server U: hbase-server Max memory used 173MB Powered by Apache Yetus 0.1.0 http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HBASE-Build/569/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 3m 58s master passed
          +1 compile 0m 55s master passed with JDK v1.8.0_72
          +1 compile 0m 47s master passed with JDK v1.7.0_95
          +1 checkstyle 4m 21s master passed
          +1 mvneclipse 0m 22s master passed
          +1 findbugs 2m 33s master passed
          +1 javadoc 0m 44s master passed with JDK v1.8.0_72
          +1 javadoc 0m 50s master passed with JDK v1.7.0_95
          +1 mvninstall 0m 58s the patch passed
          +1 compile 0m 56s the patch passed with JDK v1.8.0_72
          +1 javac 0m 56s the patch passed
          +1 compile 0m 46s the patch passed with JDK v1.7.0_95
          +1 javac 0m 46s the patch passed
          +1 checkstyle 4m 47s the patch passed
          +1 mvneclipse 0m 21s the patch passed
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 hadoopcheck 28m 57s Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1.
          -1 findbugs 2m 41s hbase-server introduced 4 new FindBugs issues.
          +1 javadoc 0m 45s the patch passed with JDK v1.8.0_72
          +1 javadoc 0m 46s the patch passed with JDK v1.7.0_95
          -1 unit 148m 11s hbase-server in the patch failed with JDK v1.8.0_72.
          +1 unit 133m 2s hbase-server in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 27s Patch does not generate ASF License warnings.
          354m 32s



          Reason Tests
          FindBugs module:hbase-server
            Incorrect lazy initialization of static field org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.instanceOfCanUnbuffer in org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java:field org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.instanceOfCanUnbuffer in org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java:[lines 247-249]
            Incorrect lazy initialization of static field org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer in org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java:field org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer in org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java:[lines 266-268]
            Write to static field org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.instanceOfCanUnbuffer from instance method org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java:from instance method org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java:[line 249]
            Write to static field org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer from instance method org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java:from instance method org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java:[line 254]
          JDK v1.8.0_72 Timed out junit tests org.apache.hadoop.hbase.regionserver.wal.TestSecureWALReplay



          Subsystem Report/Notes
          Docker Client=1.9.1 Server=1.9.1 Image:yetus/hbase:date2016-02-17
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788186/HBASE-9393.v8.patch
          JIRA Issue HBASE-9393
          Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux 1469cebb7708 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / 9f8273e
          findbugs v3.0.0
          whitespace https://builds.apache.org/job/PreCommit-HBASE-Build/563/artifact/patchprocess/whitespace-eol.txt
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/563/artifact/patchprocess/new-findbugs-hbase-server.html
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/563/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_72.txt
          unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/563/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_72.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/563/testReport/
          modules C: hbase-server U: hbase-server
          Max memory used 175MB
          Powered by Apache Yetus 0.1.0 http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/563/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 3m 58s master passed +1 compile 0m 55s master passed with JDK v1.8.0_72 +1 compile 0m 47s master passed with JDK v1.7.0_95 +1 checkstyle 4m 21s master passed +1 mvneclipse 0m 22s master passed +1 findbugs 2m 33s master passed +1 javadoc 0m 44s master passed with JDK v1.8.0_72 +1 javadoc 0m 50s master passed with JDK v1.7.0_95 +1 mvninstall 0m 58s the patch passed +1 compile 0m 56s the patch passed with JDK v1.8.0_72 +1 javac 0m 56s the patch passed +1 compile 0m 46s the patch passed with JDK v1.7.0_95 +1 javac 0m 46s the patch passed +1 checkstyle 4m 47s the patch passed +1 mvneclipse 0m 21s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 hadoopcheck 28m 57s Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. -1 findbugs 2m 41s hbase-server introduced 4 new FindBugs issues. +1 javadoc 0m 45s the patch passed with JDK v1.8.0_72 +1 javadoc 0m 46s the patch passed with JDK v1.7.0_95 -1 unit 148m 11s hbase-server in the patch failed with JDK v1.8.0_72. +1 unit 133m 2s hbase-server in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 27s Patch does not generate ASF License warnings. 354m 32s Reason Tests FindBugs module:hbase-server   Incorrect lazy initialization of static field org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.instanceOfCanUnbuffer in org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java:field org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.instanceOfCanUnbuffer in org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java: [lines 247-249]   Incorrect lazy initialization of static field org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer in org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java:field org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer in org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java: [lines 266-268]   Write to static field org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.instanceOfCanUnbuffer from instance method org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java:from instance method org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java: [line 249]   Write to static field org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer from instance method org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java:from instance method org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java: [line 254] JDK v1.8.0_72 Timed out junit tests org.apache.hadoop.hbase.regionserver.wal.TestSecureWALReplay Subsystem Report/Notes Docker Client=1.9.1 Server=1.9.1 Image:yetus/hbase:date2016-02-17 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788186/HBASE-9393.v8.patch JIRA Issue HBASE-9393 Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux 1469cebb7708 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / 9f8273e findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-HBASE-Build/563/artifact/patchprocess/whitespace-eol.txt findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/563/artifact/patchprocess/new-findbugs-hbase-server.html unit https://builds.apache.org/job/PreCommit-HBASE-Build/563/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_72.txt unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/563/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_72.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/563/testReport/ modules C: hbase-server U: hbase-server Max memory used 175MB Powered by Apache Yetus 0.1.0 http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HBASE-Build/563/console This message was automatically generated.
          Hide
          ashish singhi Ashish Singhi added a comment -

          Patch addressing check style warning and compilation error with pre Hadoop 2.6.4 and 2.7.1 versions.

          Show
          ashish singhi Ashish Singhi added a comment - Patch addressing check style warning and compilation error with pre Hadoop 2.6.4 and 2.7.1 versions.
          Hide
          ashish singhi Ashish Singhi added a comment -

          Thanks Stack.

          [ERROR] /home/root1/Code/H-Master/hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java:[253,17] cannot find symbol
          [ERROR] symbol:   method unbuffer()
          

          I will handle this in my next version of the patch along with the checkstyle warning.

          Show
          ashish singhi Ashish Singhi added a comment - Thanks Stack. [ERROR] /home/root1/Code/H-Master/hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java:[253,17] cannot find symbol [ERROR] symbol: method unbuffer() I will handle this in my next version of the patch along with the checkstyle warning.
          Hide
          stack stack added a comment -

          If you try

          mvn clean install -DskipTests -DHBasePatchProcess -Dhadoop-two.version=2.4.0 > /testptch/patchprocess/patch-javac-2.4.0.txt

          locallly, what is the complaint? Are you making use of an API that is not in earlier hadoops? (I don't see it looking at patch...)

          And the warnings about whitespace, etc., seem easy enough to clean up. Thanks Ashish Singhi

          Show
          stack stack added a comment - If you try mvn clean install -DskipTests -DHBasePatchProcess -Dhadoop-two.version=2.4.0 > /testptch/patchprocess/patch-javac-2.4.0.txt locallly, what is the complaint? Are you making use of an API that is not in earlier hadoops? (I don't see it looking at patch...) And the warnings about whitespace, etc., seem easy enough to clean up. Thanks Ashish Singhi
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 2m 25s master passed
          +1 compile 0m 36s master passed with JDK v1.8.0_72
          +1 compile 0m 34s master passed with JDK v1.7.0_95
          +1 checkstyle 3m 58s master passed
          +1 mvneclipse 0m 16s master passed
          +1 findbugs 1m 52s master passed
          +1 javadoc 0m 30s master passed with JDK v1.8.0_72
          +1 javadoc 0m 31s master passed with JDK v1.7.0_95
          +1 mvninstall 0m 44s the patch passed
          +1 compile 0m 36s the patch passed with JDK v1.8.0_72
          +1 javac 0m 36s the patch passed
          +1 compile 0m 35s the patch passed with JDK v1.7.0_95
          +1 javac 0m 35s the patch passed
          -1 checkstyle 3m 52s Patch generated 1 new checkstyle issues in hbase-server (total was 160, now 161).
          +1 mvneclipse 0m 16s the patch passed
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          -1 hadoopcheck 0m 51s Patch causes 16 errors with Hadoop v2.4.0.
          -1 hadoopcheck 1m 41s Patch causes 16 errors with Hadoop v2.4.1.
          -1 hadoopcheck 2m 31s Patch causes 16 errors with Hadoop v2.5.0.
          -1 hadoopcheck 3m 23s Patch causes 16 errors with Hadoop v2.5.1.
          -1 hadoopcheck 4m 13s Patch causes 16 errors with Hadoop v2.5.2.
          -1 hadoopcheck 5m 4s Patch causes 16 errors with Hadoop v2.6.1.
          -1 hadoopcheck 5m 54s Patch causes 16 errors with Hadoop v2.6.2.
          -1 hadoopcheck 6m 45s Patch causes 16 errors with Hadoop v2.6.3.
          -1 findbugs 2m 3s hbase-server introduced 2 new FindBugs issues.
          +1 javadoc 0m 29s the patch passed with JDK v1.8.0_72
          +1 javadoc 0m 32s the patch passed with JDK v1.7.0_95
          -1 unit 97m 18s hbase-server in the patch failed with JDK v1.8.0_72.
          -1 unit 87m 4s hbase-server in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 13s Patch does not generate ASF License warnings.
          214m 3s



          Reason Tests
          FindBugs module:hbase-server
            Incorrect lazy initialization of static field org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.instanceOfCanUnbuffer in org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java:field org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.instanceOfCanUnbuffer in org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java:[lines 239-241]
            Write to static field org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.instanceOfCanUnbuffer from instance method org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java:from instance method org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java:[line 241]
          JDK v1.8.0_72 Failed junit tests hadoop.hbase.mapreduce.TestImportExport
            hadoop.hbase.regionserver.TestHRegionOnCluster
            hadoop.hbase.client.TestUpdateConfiguration
          JDK v1.8.0_72 Timed out junit tests org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient



          Subsystem Report/Notes
          Docker Client=1.9.1 Server=1.9.1 Image:yetus/hbase:date2016-02-16
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788043/HBASE-9393.v7.patch
          JIRA Issue HBASE-9393
          Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux 2ac19aacb0a2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / 7063562
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/558/artifact/patchprocess/diff-checkstyle-hbase-server.txt
          whitespace https://builds.apache.org/job/PreCommit-HBASE-Build/558/artifact/patchprocess/whitespace-eol.txt
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/558/artifact/patchprocess/new-findbugs-hbase-server.html
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/558/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/558/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/558/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_72.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/558/testReport/
          modules C: hbase-server U: hbase-server
          Max memory used 418MB
          Powered by Apache Yetus 0.1.0 http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/558/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 2m 25s master passed +1 compile 0m 36s master passed with JDK v1.8.0_72 +1 compile 0m 34s master passed with JDK v1.7.0_95 +1 checkstyle 3m 58s master passed +1 mvneclipse 0m 16s master passed +1 findbugs 1m 52s master passed +1 javadoc 0m 30s master passed with JDK v1.8.0_72 +1 javadoc 0m 31s master passed with JDK v1.7.0_95 +1 mvninstall 0m 44s the patch passed +1 compile 0m 36s the patch passed with JDK v1.8.0_72 +1 javac 0m 36s the patch passed +1 compile 0m 35s the patch passed with JDK v1.7.0_95 +1 javac 0m 35s the patch passed -1 checkstyle 3m 52s Patch generated 1 new checkstyle issues in hbase-server (total was 160, now 161). +1 mvneclipse 0m 16s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. -1 hadoopcheck 0m 51s Patch causes 16 errors with Hadoop v2.4.0. -1 hadoopcheck 1m 41s Patch causes 16 errors with Hadoop v2.4.1. -1 hadoopcheck 2m 31s Patch causes 16 errors with Hadoop v2.5.0. -1 hadoopcheck 3m 23s Patch causes 16 errors with Hadoop v2.5.1. -1 hadoopcheck 4m 13s Patch causes 16 errors with Hadoop v2.5.2. -1 hadoopcheck 5m 4s Patch causes 16 errors with Hadoop v2.6.1. -1 hadoopcheck 5m 54s Patch causes 16 errors with Hadoop v2.6.2. -1 hadoopcheck 6m 45s Patch causes 16 errors with Hadoop v2.6.3. -1 findbugs 2m 3s hbase-server introduced 2 new FindBugs issues. +1 javadoc 0m 29s the patch passed with JDK v1.8.0_72 +1 javadoc 0m 32s the patch passed with JDK v1.7.0_95 -1 unit 97m 18s hbase-server in the patch failed with JDK v1.8.0_72. -1 unit 87m 4s hbase-server in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 13s Patch does not generate ASF License warnings. 214m 3s Reason Tests FindBugs module:hbase-server   Incorrect lazy initialization of static field org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.instanceOfCanUnbuffer in org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java:field org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.instanceOfCanUnbuffer in org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java: [lines 239-241]   Write to static field org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.instanceOfCanUnbuffer from instance method org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java:from instance method org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.unbuffer() At FSDataInputStreamWrapper.java: [line 241] JDK v1.8.0_72 Failed junit tests hadoop.hbase.mapreduce.TestImportExport   hadoop.hbase.regionserver.TestHRegionOnCluster   hadoop.hbase.client.TestUpdateConfiguration JDK v1.8.0_72 Timed out junit tests org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient Subsystem Report/Notes Docker Client=1.9.1 Server=1.9.1 Image:yetus/hbase:date2016-02-16 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788043/HBASE-9393.v7.patch JIRA Issue HBASE-9393 Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux 2ac19aacb0a2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / 7063562 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/558/artifact/patchprocess/diff-checkstyle-hbase-server.txt whitespace https://builds.apache.org/job/PreCommit-HBASE-Build/558/artifact/patchprocess/whitespace-eol.txt findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/558/artifact/patchprocess/new-findbugs-hbase-server.html unit https://builds.apache.org/job/PreCommit-HBASE-Build/558/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/558/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/558/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_72.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/558/testReport/ modules C: hbase-server U: hbase-server Max memory used 418MB Powered by Apache Yetus 0.1.0 http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HBASE-Build/558/console This message was automatically generated.
          Hide
          ashish singhi Ashish Singhi added a comment -

          Attached patch v7 after HADOOP-12805 is committed.
          Please review and let me know your thoughts.

          Show
          ashish singhi Ashish Singhi added a comment - Attached patch v7 after HADOOP-12805 is committed. Please review and let me know your thoughts.
          Hide
          stack stack added a comment -

          Thanks for the revert Sean Busbey Makes sense. Sorry for making work for others.

          Show
          stack stack added a comment - Thanks for the revert Sean Busbey Makes sense. Sorry for making work for others.
          Hide
          ashish singhi Ashish Singhi added a comment -

          First of all, please make sure discussions get reflected in a public place (like this jira or dev@). Not just the decision, but the reasoning is important so that others can chime in.

          All the discussions, reviews and comments are put up in the jira. The offline discussion was only about handling these in HBase versions which by default have Hadoop jars prior to 2.7.1 version and this point was also noted down in the jira.

          The patch was implemented based on one of the Colin suggestion(#2) and we have commented the reason also for not going with other suggestion.

          Please don't catch and then discard Throwable

          I agree and can handle this once we have a conclusion on this jira.

          Pardon me for my oversight on CanBuffer interface compatibility check.
          And I saw that Ted has already raised HADOOP-12805 to handle the interface compatibility.

          Show
          ashish singhi Ashish Singhi added a comment - First of all, please make sure discussions get reflected in a public place (like this jira or dev@). Not just the decision, but the reasoning is important so that others can chime in. All the discussions, reviews and comments are put up in the jira. The offline discussion was only about handling these in HBase versions which by default have Hadoop jars prior to 2.7.1 version and this point was also noted down in the jira. The patch was implemented based on one of the Colin suggestion(#2) and we have commented the reason also for not going with other suggestion. Please don't catch and then discard Throwable I agree and can handle this once we have a conclusion on this jira. Pardon me for my oversight on CanBuffer interface compatibility check. And I saw that Ted has already raised HADOOP-12805 to handle the interface compatibility.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-Trunk_matrix #707 (See https://builds.apache.org/job/HBase-Trunk_matrix/707/)
          Revert "HBASE-9393 Hbase does not closing a closed socket resulting in (busbey: rev 3897c4e102b223847e1ceedf363df59fe24eb294)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-Trunk_matrix #707 (See https://builds.apache.org/job/HBase-Trunk_matrix/707/ ) Revert " HBASE-9393 Hbase does not closing a closed socket resulting in (busbey: rev 3897c4e102b223847e1ceedf363df59fe24eb294) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
          Hide
          apurtell Andrew Purtell added a comment -

          FWIW I agree with Sean about changes that would tie us to specific Hadoop versions. Not only should discussion to that effect go on the issue (with at mentions to publicize it) but also please email dev@ to start a discussion. It is a really, really serious change to contemplate. We need to have the opposite of the casual way in this issue that question was approached.

          Show
          apurtell Andrew Purtell added a comment - FWIW I agree with Sean about changes that would tie us to specific Hadoop versions. Not only should discussion to that effect go on the issue (with at mentions to publicize it) but also please email dev@ to start a discussion. It is a really, really serious change to contemplate. We need to have the opposite of the casual way in this issue that question was approached.
          Hide
          busbey Sean Busbey added a comment -

          and in general review feedback:

          +      } catch (Throwable e) {
          +        LOG.error("Failed to unbuffer the stream so possibly there may be a TCP socket connection "
          +            + "left open in CLOSE_WAIT state.", e);
          +      }
          

          Please don't catch and then discard Throwable. It's overly broad and includes e.g. all the Error cases like ThreadDeath and OutOfMemoryError. Given the signature of unbuffer why is this not simply catching RuntimeException?

          Show
          busbey Sean Busbey added a comment - and in general review feedback: + } catch (Throwable e) { + LOG.error( "Failed to unbuffer the stream so possibly there may be a TCP socket connection " + + "left open in CLOSE_WAIT state." , e); + } Please don't catch and then discard Throwable. It's overly broad and includes e.g. all the Error cases like ThreadDeath and OutOfMemoryError. Given the signature of unbuffer why is this not simply catching RuntimeException?
          Hide
          busbey Sean Busbey added a comment -

          Anoop:

          We will get this fix in for 2.0 only. (As there we have hadoop 2.7.0+ version by default).
          Users on older version seeing this issue can get it fixed by upping their hadoop version in client side to 2.7.0 at least and apply this patch.
          Branch-1 is on hadoop 2.5.x only by default. So unless our default version is not upped there, there is no point in adding the fix there.
          Can open a backport jira when applicable.

          Ashish:

          Attached patch addressing review comment.
          Thanks for all the offline discussion on this, Anoop & Ram.
          For now this issue will be fixed only for 2.0.0. Once we plan to up our hadoop version to 2.7.x+ in any our branch code we can fix the issue there also as part of a back port jira.

          Okay, now I am even more -1 on this patch.

          First of all, please make sure discussions get reflected in a public place (like this jira or dev@). Not just the decision, but the reasoning is important so that others can chime in.

          Requiring our users to have the Hadoop 2.7.1 client libraries in their deployment is a terrible user experience and idea. 1) AFAICT we have not had any discussion nor decision to change our "supported Hadoop versions" in HBase 2.0 to only be Hadoop 2.7.1+. 2) I do not trust Hadoop to have the 2.7.1 clients work reliably across the HDFS server versions we support now and in the future. 3) we expressly tell folks in our operational guides that they should replace the hadoop jars we ship with those for their actual Hadoop distribution. This patch goes directly counter to that advice and does not change it (nor should it change, see #1 and #2).

          The fact that Unbuffer is Private / Evolving in the Hadoop code base just makes the above more severe. We risk ending up beached on a very tight range of possible Hadoop client library versions.

          Show
          busbey Sean Busbey added a comment - Anoop: We will get this fix in for 2.0 only. (As there we have hadoop 2.7.0+ version by default). Users on older version seeing this issue can get it fixed by upping their hadoop version in client side to 2.7.0 at least and apply this patch. Branch-1 is on hadoop 2.5.x only by default. So unless our default version is not upped there, there is no point in adding the fix there. Can open a backport jira when applicable. Ashish: Attached patch addressing review comment. Thanks for all the offline discussion on this, Anoop & Ram. For now this issue will be fixed only for 2.0.0. Once we plan to up our hadoop version to 2.7.x+ in any our branch code we can fix the issue there also as part of a back port jira. Okay, now I am even more -1 on this patch. First of all, please make sure discussions get reflected in a public place (like this jira or dev@). Not just the decision, but the reasoning is important so that others can chime in. Requiring our users to have the Hadoop 2.7.1 client libraries in their deployment is a terrible user experience and idea. 1) AFAICT we have not had any discussion nor decision to change our "supported Hadoop versions" in HBase 2.0 to only be Hadoop 2.7.1+. 2) I do not trust Hadoop to have the 2.7.1 clients work reliably across the HDFS server versions we support now and in the future. 3) we expressly tell folks in our operational guides that they should replace the hadoop jars we ship with those for their actual Hadoop distribution. This patch goes directly counter to that advice and does not change it (nor should it change, see #1 and #2). The fact that Unbuffer is Private / Evolving in the Hadoop code base just makes the above more severe. We risk ending up beached on a very tight range of possible Hadoop client library versions.
          Hide
          busbey Sean Busbey added a comment -

          Also, we expressly do not support Hadoop 2.7.0, so please phrase any reference to the Hadoop 2.7 line as "Hadoop 2.7.1+"

          Show
          busbey Sean Busbey added a comment - Also, we expressly do not support Hadoop 2.7.0, so please phrase any reference to the Hadoop 2.7 line as "Hadoop 2.7.1+"
          Hide
          busbey Sean Busbey added a comment -

          Sorry for not waiting on more discussion, but reverted from master so that Ted Yu has an easier time getting precommit verification of HBASE-15219

          Show
          busbey Sean Busbey added a comment - Sorry for not waiting on more discussion, but reverted from master so that Ted Yu has an easier time getting precommit verification of HBASE-15219
          Hide
          busbey Sean Busbey added a comment -

          essentially, is there a compelling reason not to put this behind our normal hadoop-compatibility-mess-mitigation so that it can be more widely applicable?

          Additionally, the CanUnbuffer interface is labeled IA.Private, so I am -1 on having a hard dependency on it in our code base. We should petition Hadoop to make it LimitedPrivate(HBASE) or better yet Public.

          Show
          busbey Sean Busbey added a comment - essentially, is there a compelling reason not to put this behind our normal hadoop-compatibility-mess-mitigation so that it can be more widely applicable? Additionally, the CanUnbuffer interface is labeled IA.Private, so I am -1 on having a hard dependency on it in our code base. We should petition Hadoop to make it LimitedPrivate(HBASE) or better yet Public.
          Hide
          busbey Sean Busbey added a comment -

          this is breaking all precommit runs because it does not work with versions of hadoop prior to 2.7 / 2.6.5. I am inclined to revert.

          Show
          busbey Sean Busbey added a comment - this is breaking all precommit runs because it does not work with versions of hadoop prior to 2.7 / 2.6.5. I am inclined to revert.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-Trunk_matrix #706 (See https://builds.apache.org/job/HBase-Trunk_matrix/706/)
          HBASE-9393 Hbase does not closing a closed socket resulting in many (stack: rev c8d133186b85a4e7298bab3376ad96899860b1c7)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-Trunk_matrix #706 (See https://builds.apache.org/job/HBase-Trunk_matrix/706/ ) HBASE-9393 Hbase does not closing a closed socket resulting in many (stack: rev c8d133186b85a4e7298bab3376ad96899860b1c7) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
          Hide
          stack stack added a comment -

          Thanks for clarification Ashish Singhi I see you have it already covered in the release note.

          Show
          stack stack added a comment - Thanks for clarification Ashish Singhi I see you have it already covered in the release note.
          Hide
          ashish singhi Ashish Singhi added a comment -

          As Anoop Sam John quoted above,

          After some discussion this is what we think
          We will get this fix in for 2.0 only. (As there we have hadoop 2.7.0+ version by default).
          Users on older version seeing this issue can get it fixed by upping their hadoop version in client side to 2.7.0 at least and apply this patch.
          Branch-1 is on hadoop 2.5.x only by default. So unless our default version is not upped there, there is no point in adding the fix there.
          Can open a backport jira when applicable.

          So only I did not provide the patch for branch-1 earlier. Let me add the same in the release note.

          Thanks Colin P. McCabe for the inputs.
          Thanks Ted Yu, Anoop Sam John, ramkrishna vasudevan and stack for the reviews and discussions.

          Show
          ashish singhi Ashish Singhi added a comment - As Anoop Sam John quoted above, After some discussion this is what we think We will get this fix in for 2.0 only. (As there we have hadoop 2.7.0+ version by default). Users on older version seeing this issue can get it fixed by upping their hadoop version in client side to 2.7.0 at least and apply this patch. Branch-1 is on hadoop 2.5.x only by default. So unless our default version is not upped there, there is no point in adding the fix there. Can open a backport jira when applicable. So only I did not provide the patch for branch-1 earlier. Let me add the same in the release note. Thanks Colin P. McCabe for the inputs. Thanks Ted Yu , Anoop Sam John , ramkrishna vasudevan and stack for the reviews and discussions.
          Hide
          stack stack added a comment -

          I tried to backport to branch-1 but doesn't apply cleanly.

          Show
          stack stack added a comment - I tried to backport to branch-1 but doesn't apply cleanly.
          Hide
          stack stack added a comment -

          Pushed to master branch. Thanks for the patch Ashish Singhi. Sorry for delay in review.

          Show
          stack stack added a comment - Pushed to master branch. Thanks for the patch Ashish Singhi . Sorry for delay in review.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Stack - Do you have any feedback? We think it is good to go in 2.0 atleast.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Stack - Do you have any feedback? We think it is good to go in 2.0 atleast.
          Hide
          ashish singhi Ashish Singhi added a comment -

          stack any feedback? Thanks.

          Show
          ashish singhi Ashish Singhi added a comment - stack any feedback? Thanks.
          Hide
          ashish singhi Ashish Singhi added a comment -

          TestFlushSnapshotFromClient failure is not related to patch. I have manually ran 3 times locally and not able to reproduce it.

          -------------------------------------------------------
           T E S T S
          -------------------------------------------------------
          Running org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient
          Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 95.841 sec - in org.apache.hadoop.hbase.snapshot.TestFlushSnapshot
          FromClient
          
          Results :
          
          Tests run: 9, Failures: 0, Errors: 0, Skipped: 0
          
          [INFO]
          [INFO] --- maven-surefire-plugin:2.18.1:test (secondPartTestsExecution) @ hbase-server ---
          [INFO] Tests are skipped.
          [INFO] ------------------------------------------------------------------------
          [INFO] BUILD SUCCESS
          [INFO] ------------------------------------------------------------------------
          [INFO] Total time: 1:50.899s
          [INFO] Finished at: Fri Jan 29 14:07:38 GMT+05:30 2016
          [INFO] Final Memory: 36M/96M
          [INFO] ------------------------------------------------------------------------
          
          
          -------------------------------------------------------
           T E S T S
          -------------------------------------------------------
          Running org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient
          Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 93.399 sec - in org.apache.hadoop.hbase.snapshot.TestFlushSnapshot
          FromClient
          
          Results :
          
          Tests run: 9, Failures: 0, Errors: 0, Skipped: 0
          
          [INFO]
          [INFO] --- maven-surefire-plugin:2.18.1:test (secondPartTestsExecution) @ hbase-server ---
          [INFO] Tests are skipped.
          [INFO] ------------------------------------------------------------------------
          [INFO] BUILD SUCCESS
          [INFO] ------------------------------------------------------------------------
          [INFO] Total time: 1:48.177s
          [INFO] Finished at: Fri Jan 29 14:13:52 GMT+05:30 2016
          [INFO] Final Memory: 35M/89M
          [INFO] ------------------------------------------------------------------------
          
          
          -------------------------------------------------------
           T E S T S
          -------------------------------------------------------
          Running org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient
          Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 94.072 sec - in org.apache.hadoop.hbase.snapshot.TestFlushSnapshot
          FromClient
          
          Results :
          
          Tests run: 9, Failures: 0, Errors: 0, Skipped: 0
          
          [INFO]
          [INFO] --- maven-surefire-plugin:2.18.1:test (secondPartTestsExecution) @ hbase-server ---
          [INFO] Tests are skipped.
          [INFO] ------------------------------------------------------------------------
          [INFO] BUILD SUCCESS
          [INFO] ------------------------------------------------------------------------
          [INFO] Total time: 1:48.012s
          [INFO] Finished at: Fri Jan 29 14:16:28 GMT+05:30 2016
          [INFO] Final Memory: 36M/100M
          [INFO] ------------------------------------------------------------------------
          

          Stack, is v6 patch ok to commit ?
          Thanks.

          Show
          ashish singhi Ashish Singhi added a comment - TestFlushSnapshotFromClient failure is not related to patch. I have manually ran 3 times locally and not able to reproduce it. ------------------------------------------------------- T E S T S ------------------------------------------------------- Running org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 95.841 sec - in org.apache.hadoop.hbase.snapshot.TestFlushSnapshot FromClient Results : Tests run: 9, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] --- maven-surefire-plugin:2.18.1:test (secondPartTestsExecution) @ hbase-server --- [INFO] Tests are skipped. [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 1:50.899s [INFO] Finished at: Fri Jan 29 14:07:38 GMT+05:30 2016 [INFO] Final Memory: 36M/96M [INFO] ------------------------------------------------------------------------ ------------------------------------------------------- T E S T S ------------------------------------------------------- Running org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 93.399 sec - in org.apache.hadoop.hbase.snapshot.TestFlushSnapshot FromClient Results : Tests run: 9, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] --- maven-surefire-plugin:2.18.1:test (secondPartTestsExecution) @ hbase-server --- [INFO] Tests are skipped. [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 1:48.177s [INFO] Finished at: Fri Jan 29 14:13:52 GMT+05:30 2016 [INFO] Final Memory: 35M/89M [INFO] ------------------------------------------------------------------------ ------------------------------------------------------- T E S T S ------------------------------------------------------- Running org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 94.072 sec - in org.apache.hadoop.hbase.snapshot.TestFlushSnapshot FromClient Results : Tests run: 9, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] --- maven-surefire-plugin:2.18.1:test (secondPartTestsExecution) @ hbase-server --- [INFO] Tests are skipped. [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 1:48.012s [INFO] Finished at: Fri Jan 29 14:16:28 GMT+05:30 2016 [INFO] Final Memory: 36M/100M [INFO] ------------------------------------------------------------------------ Stack , is v6 patch ok to commit ? Thanks.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 hbaseanti 0m 1s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 2m 42s master passed
          +1 compile 0m 32s master passed with JDK v1.8.0_66
          +1 compile 0m 34s master passed with JDK v1.7.0_91
          +1 checkstyle 4m 19s master passed
          +1 mvneclipse 0m 16s master passed
          -1 findbugs 1m 51s hbase-server in master has 1 extant Findbugs warnings.
          +1 javadoc 0m 24s master passed with JDK v1.8.0_66
          +1 javadoc 0m 32s master passed with JDK v1.7.0_91
          +1 mvninstall 0m 45s the patch passed
          +1 compile 0m 31s the patch passed with JDK v1.8.0_66
          +1 javac 0m 31s the patch passed
          +1 compile 0m 34s the patch passed with JDK v1.7.0_91
          +1 javac 0m 34s the patch passed
          +1 checkstyle 3m 55s the patch passed
          +1 mvneclipse 0m 16s the patch passed
          +1 whitespace 0m 1s Patch has no whitespace issues.
          -1 hadoopcheck 0m 51s Patch causes 24 errors with Hadoop v2.4.0.
          -1 hadoopcheck 1m 42s Patch causes 24 errors with Hadoop v2.4.1.
          -1 hadoopcheck 2m 33s Patch causes 24 errors with Hadoop v2.5.0.
          -1 hadoopcheck 3m 23s Patch causes 24 errors with Hadoop v2.5.1.
          -1 hadoopcheck 4m 13s Patch causes 24 errors with Hadoop v2.5.2.
          -1 hadoopcheck 5m 4s Patch causes 24 errors with Hadoop v2.6.1.
          -1 hadoopcheck 5m 57s Patch causes 24 errors with Hadoop v2.6.2.
          -1 hadoopcheck 6m 48s Patch causes 24 errors with Hadoop v2.6.3.
          +1 findbugs 2m 7s the patch passed
          +1 javadoc 0m 32s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 34s the patch passed with JDK v1.7.0_91
          -1 unit 88m 33s hbase-server in the patch failed with JDK v1.8.0_66.
          +1 unit 88m 54s hbase-server in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 19s Patch does not generate ASF License warnings.
          207m 56s



          Reason Tests
          JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient



          Subsystem Report/Notes
          Docker Client=1.9.1 Server=1.9.1 Image:yetus/hbase:date2016-01-29
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785077/HBASE-9393.v6.patch
          JIRA Issue HBASE-9393
          Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux d527aa941a0a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / b3b1ce9
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/344/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/344/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_66.txt
          unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/344/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_66.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/344/testReport/
          modules C: hbase-server U: hbase-server
          Max memory used 418MB
          Powered by Apache Yetus 0.1.0 http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/344/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 hbaseanti 0m 1s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 2m 42s master passed +1 compile 0m 32s master passed with JDK v1.8.0_66 +1 compile 0m 34s master passed with JDK v1.7.0_91 +1 checkstyle 4m 19s master passed +1 mvneclipse 0m 16s master passed -1 findbugs 1m 51s hbase-server in master has 1 extant Findbugs warnings. +1 javadoc 0m 24s master passed with JDK v1.8.0_66 +1 javadoc 0m 32s master passed with JDK v1.7.0_91 +1 mvninstall 0m 45s the patch passed +1 compile 0m 31s the patch passed with JDK v1.8.0_66 +1 javac 0m 31s the patch passed +1 compile 0m 34s the patch passed with JDK v1.7.0_91 +1 javac 0m 34s the patch passed +1 checkstyle 3m 55s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 1s Patch has no whitespace issues. -1 hadoopcheck 0m 51s Patch causes 24 errors with Hadoop v2.4.0. -1 hadoopcheck 1m 42s Patch causes 24 errors with Hadoop v2.4.1. -1 hadoopcheck 2m 33s Patch causes 24 errors with Hadoop v2.5.0. -1 hadoopcheck 3m 23s Patch causes 24 errors with Hadoop v2.5.1. -1 hadoopcheck 4m 13s Patch causes 24 errors with Hadoop v2.5.2. -1 hadoopcheck 5m 4s Patch causes 24 errors with Hadoop v2.6.1. -1 hadoopcheck 5m 57s Patch causes 24 errors with Hadoop v2.6.2. -1 hadoopcheck 6m 48s Patch causes 24 errors with Hadoop v2.6.3. +1 findbugs 2m 7s the patch passed +1 javadoc 0m 32s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 34s the patch passed with JDK v1.7.0_91 -1 unit 88m 33s hbase-server in the patch failed with JDK v1.8.0_66. +1 unit 88m 54s hbase-server in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 19s Patch does not generate ASF License warnings. 207m 56s Reason Tests JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient Subsystem Report/Notes Docker Client=1.9.1 Server=1.9.1 Image:yetus/hbase:date2016-01-29 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785077/HBASE-9393.v6.patch JIRA Issue HBASE-9393 Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux d527aa941a0a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / b3b1ce9 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/344/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html unit https://builds.apache.org/job/PreCommit-HBASE-Build/344/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_66.txt unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/344/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_66.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/344/testReport/ modules C: hbase-server U: hbase-server Max memory used 418MB Powered by Apache Yetus 0.1.0 http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HBASE-Build/344/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 3m 48s master passed
          +1 compile 1m 7s master passed with JDK v1.8.0_72
          +1 compile 0m 52s master passed with JDK v1.7.0_91
          +1 checkstyle 5m 15s master passed
          +1 mvneclipse 0m 23s master passed
          -1 findbugs 2m 51s hbase-server in master has 1 extant Findbugs warnings.
          +1 javadoc 0m 58s master passed with JDK v1.8.0_72
          +1 javadoc 0m 50s master passed with JDK v1.7.0_91
          +1 mvninstall 1m 7s the patch passed
          +1 compile 1m 10s the patch passed with JDK v1.8.0_72
          +1 javac 1m 10s the patch passed
          +1 compile 0m 50s the patch passed with JDK v1.7.0_91
          +1 javac 0m 50s the patch passed
          +1 checkstyle 5m 26s the patch passed
          +1 mvneclipse 0m 23s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          -1 hadoopcheck 1m 14s Patch causes 24 errors with Hadoop v2.4.0.
          -1 hadoopcheck 2m 26s Patch causes 24 errors with Hadoop v2.4.1.
          -1 hadoopcheck 3m 47s Patch causes 24 errors with Hadoop v2.5.0.
          -1 hadoopcheck 5m 4s Patch causes 24 errors with Hadoop v2.5.1.
          -1 hadoopcheck 6m 22s Patch causes 24 errors with Hadoop v2.5.2.
          -1 hadoopcheck 7m 40s Patch causes 24 errors with Hadoop v2.6.1.
          -1 hadoopcheck 9m 4s Patch causes 24 errors with Hadoop v2.6.2.
          -1 hadoopcheck 10m 21s Patch causes 24 errors with Hadoop v2.6.3.
          +1 findbugs 2m 52s the patch passed
          +1 javadoc 0m 54s the patch passed with JDK v1.8.0_72
          +1 javadoc 0m 53s the patch passed with JDK v1.7.0_91
          -1 unit 188m 44s hbase-server in the patch failed with JDK v1.8.0_72.
          -1 unit 97m 20s hbase-server in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 46s Patch does not generate ASF License warnings.
          331m 10s



          Reason Tests
          JDK v1.8.0_72 Failed junit tests hadoop.hbase.master.balancer.TestStochasticLoadBalancer
            hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort
          JDK v1.8.0_72 Timed out junit tests org.apache.hadoop.hbase.snapshot.TestMobSecureExportSnapshot
            org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot
            org.apache.hadoop.hbase.snapshot.TestMobExportSnapshot
          JDK v1.7.0_91 Failed junit tests hadoop.hbase.master.balancer.TestStochasticLoadBalancer
            hadoop.hbase.replication.TestReplicationSyncUpTool
            hadoop.hbase.mapreduce.TestRowCounter
          JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.hbase.util.TestIdLock
            org.apache.hadoop.hbase.regionserver.TestRSKilledWhenInitializing
            org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFiles
            org.apache.hadoop.hbase.mapreduce.TestMultiTableSnapshotInputFormat
            org.apache.hadoop.hbase.mapreduce.TestImportTSVWithVisibilityLabels



          Subsystem Report/Notes
          Docker Client=1.9.1 Server=1.9.1 Image:yetus/hbase:date2016-01-28
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784912/HBASE-9393.v6.patch
          JIRA Issue HBASE-9393
          Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux bc8f25bff8a7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
          git revision master / 47c4147
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/338/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/338/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/338/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/338/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HBASE-Build/338/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/338/testReport/
          modules C: hbase-server U: hbase-server
          Max memory used 404MB
          Powered by Apache Yetus 0.1.0 http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/338/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 3m 48s master passed +1 compile 1m 7s master passed with JDK v1.8.0_72 +1 compile 0m 52s master passed with JDK v1.7.0_91 +1 checkstyle 5m 15s master passed +1 mvneclipse 0m 23s master passed -1 findbugs 2m 51s hbase-server in master has 1 extant Findbugs warnings. +1 javadoc 0m 58s master passed with JDK v1.8.0_72 +1 javadoc 0m 50s master passed with JDK v1.7.0_91 +1 mvninstall 1m 7s the patch passed +1 compile 1m 10s the patch passed with JDK v1.8.0_72 +1 javac 1m 10s the patch passed +1 compile 0m 50s the patch passed with JDK v1.7.0_91 +1 javac 0m 50s the patch passed +1 checkstyle 5m 26s the patch passed +1 mvneclipse 0m 23s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. -1 hadoopcheck 1m 14s Patch causes 24 errors with Hadoop v2.4.0. -1 hadoopcheck 2m 26s Patch causes 24 errors with Hadoop v2.4.1. -1 hadoopcheck 3m 47s Patch causes 24 errors with Hadoop v2.5.0. -1 hadoopcheck 5m 4s Patch causes 24 errors with Hadoop v2.5.1. -1 hadoopcheck 6m 22s Patch causes 24 errors with Hadoop v2.5.2. -1 hadoopcheck 7m 40s Patch causes 24 errors with Hadoop v2.6.1. -1 hadoopcheck 9m 4s Patch causes 24 errors with Hadoop v2.6.2. -1 hadoopcheck 10m 21s Patch causes 24 errors with Hadoop v2.6.3. +1 findbugs 2m 52s the patch passed +1 javadoc 0m 54s the patch passed with JDK v1.8.0_72 +1 javadoc 0m 53s the patch passed with JDK v1.7.0_91 -1 unit 188m 44s hbase-server in the patch failed with JDK v1.8.0_72. -1 unit 97m 20s hbase-server in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 46s Patch does not generate ASF License warnings. 331m 10s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.hbase.master.balancer.TestStochasticLoadBalancer   hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort JDK v1.8.0_72 Timed out junit tests org.apache.hadoop.hbase.snapshot.TestMobSecureExportSnapshot   org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot   org.apache.hadoop.hbase.snapshot.TestMobExportSnapshot JDK v1.7.0_91 Failed junit tests hadoop.hbase.master.balancer.TestStochasticLoadBalancer   hadoop.hbase.replication.TestReplicationSyncUpTool   hadoop.hbase.mapreduce.TestRowCounter JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.hbase.util.TestIdLock   org.apache.hadoop.hbase.regionserver.TestRSKilledWhenInitializing   org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFiles   org.apache.hadoop.hbase.mapreduce.TestMultiTableSnapshotInputFormat   org.apache.hadoop.hbase.mapreduce.TestImportTSVWithVisibilityLabels Subsystem Report/Notes Docker Client=1.9.1 Server=1.9.1 Image:yetus/hbase:date2016-01-28 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784912/HBASE-9393.v6.patch JIRA Issue HBASE-9393 Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux bc8f25bff8a7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh git revision master / 47c4147 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/338/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html unit https://builds.apache.org/job/PreCommit-HBASE-Build/338/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/338/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/338/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HBASE-Build/338/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/338/testReport/ modules C: hbase-server U: hbase-server Max memory used 404MB Powered by Apache Yetus 0.1.0 http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HBASE-Build/338/console This message was automatically generated.
          Hide
          ashish singhi Ashish Singhi added a comment -

          Retry...

          Show
          ashish singhi Ashish Singhi added a comment - Retry...
          Hide
          ashish singhi Ashish Singhi added a comment -

          TestReplicationSmallTests failed due to some XML issue.

          Caused by: org.xml.sax.SAXParseException; systemId: file:///home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/hbase-server/target/surefire-reports/TEST-org.apache.hadoop.hbase.replication.TestReplicationSmallTests.xml; lineNumber: 424; columnNumber: 28; XML document structures must start and end within the same entity.
          
          Show
          ashish singhi Ashish Singhi added a comment - TestReplicationSmallTests failed due to some XML issue. Caused by: org.xml.sax.SAXParseException; systemId: file:///home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/hbase-server/target/surefire-reports/TEST-org.apache.hadoop.hbase.replication.TestReplicationSmallTests.xml; lineNumber: 424; columnNumber: 28; XML document structures must start and end within the same entity.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 2m 44s master passed
          +1 compile 0m 31s master passed with JDK v1.8.0_72
          +1 compile 0m 35s master passed with JDK v1.7.0_91
          +1 checkstyle 4m 1s master passed
          +1 mvneclipse 0m 17s master passed
          -1 findbugs 1m 50s hbase-server in master has 1 extant Findbugs warnings.
          +1 javadoc 0m 25s master passed with JDK v1.8.0_72
          +1 javadoc 0m 33s master passed with JDK v1.7.0_91
          +1 mvninstall 0m 45s the patch passed
          +1 compile 0m 30s the patch passed with JDK v1.8.0_72
          +1 javac 0m 30s the patch passed
          +1 compile 0m 34s the patch passed with JDK v1.7.0_91
          +1 javac 0m 34s the patch passed
          +1 checkstyle 4m 15s the patch passed
          +1 mvneclipse 0m 17s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          -1 hadoopcheck 0m 50s Patch causes 24 errors with Hadoop v2.4.0.
          -1 hadoopcheck 1m 41s Patch causes 24 errors with Hadoop v2.4.1.
          -1 hadoopcheck 2m 32s Patch causes 24 errors with Hadoop v2.5.0.
          -1 hadoopcheck 3m 23s Patch causes 24 errors with Hadoop v2.5.1.
          -1 hadoopcheck 4m 16s Patch causes 24 errors with Hadoop v2.5.2.
          -1 hadoopcheck 5m 11s Patch causes 24 errors with Hadoop v2.6.1.
          -1 hadoopcheck 6m 5s Patch causes 24 errors with Hadoop v2.6.2.
          -1 hadoopcheck 6m 59s Patch causes 24 errors with Hadoop v2.6.3.
          +1 findbugs 1m 57s the patch passed
          +1 javadoc 0m 25s the patch passed with JDK v1.8.0_72
          +1 javadoc 0m 31s the patch passed with JDK v1.7.0_91
          +1 unit 98m 1s hbase-server in the patch passed with JDK v1.8.0_72.
          -1 unit 103m 34s hbase-server in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 19s Patch does not generate ASF License warnings.
          232m 7s



          Subsystem Report/Notes
          Docker Client=1.9.1 Server=1.9.1 Image:yetus/hbase:date2016-01-28
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784866/HBASE-9393.v6.patch
          JIRA Issue HBASE-9393
          Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux e14576f3cba6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / 47c4147
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/333/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/333/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/333/testReport/
          modules C: hbase-server U: hbase-server
          Max memory used 174MB
          Powered by Apache Yetus 0.1.0 http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/333/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 2m 44s master passed +1 compile 0m 31s master passed with JDK v1.8.0_72 +1 compile 0m 35s master passed with JDK v1.7.0_91 +1 checkstyle 4m 1s master passed +1 mvneclipse 0m 17s master passed -1 findbugs 1m 50s hbase-server in master has 1 extant Findbugs warnings. +1 javadoc 0m 25s master passed with JDK v1.8.0_72 +1 javadoc 0m 33s master passed with JDK v1.7.0_91 +1 mvninstall 0m 45s the patch passed +1 compile 0m 30s the patch passed with JDK v1.8.0_72 +1 javac 0m 30s the patch passed +1 compile 0m 34s the patch passed with JDK v1.7.0_91 +1 javac 0m 34s the patch passed +1 checkstyle 4m 15s the patch passed +1 mvneclipse 0m 17s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. -1 hadoopcheck 0m 50s Patch causes 24 errors with Hadoop v2.4.0. -1 hadoopcheck 1m 41s Patch causes 24 errors with Hadoop v2.4.1. -1 hadoopcheck 2m 32s Patch causes 24 errors with Hadoop v2.5.0. -1 hadoopcheck 3m 23s Patch causes 24 errors with Hadoop v2.5.1. -1 hadoopcheck 4m 16s Patch causes 24 errors with Hadoop v2.5.2. -1 hadoopcheck 5m 11s Patch causes 24 errors with Hadoop v2.6.1. -1 hadoopcheck 6m 5s Patch causes 24 errors with Hadoop v2.6.2. -1 hadoopcheck 6m 59s Patch causes 24 errors with Hadoop v2.6.3. +1 findbugs 1m 57s the patch passed +1 javadoc 0m 25s the patch passed with JDK v1.8.0_72 +1 javadoc 0m 31s the patch passed with JDK v1.7.0_91 +1 unit 98m 1s hbase-server in the patch passed with JDK v1.8.0_72. -1 unit 103m 34s hbase-server in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 19s Patch does not generate ASF License warnings. 232m 7s Subsystem Report/Notes Docker Client=1.9.1 Server=1.9.1 Image:yetus/hbase:date2016-01-28 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784866/HBASE-9393.v6.patch JIRA Issue HBASE-9393 Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux e14576f3cba6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / 47c4147 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/333/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html unit https://builds.apache.org/job/PreCommit-HBASE-Build/333/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/333/testReport/ modules C: hbase-server U: hbase-server Max memory used 174MB Powered by Apache Yetus 0.1.0 http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HBASE-Build/333/console This message was automatically generated.
          Hide
          ashish singhi Ashish Singhi added a comment -

          Thanks for the comments.
          Sorry for delay in repsonse, I was on holidays.

          Adding the below as finally in a method named pickReaderVersion seems a bit odd... is pickReaderVersion only place we read in the file trailer? That seems odd (not your issue Ashish Singhi). You'd think we'd want to keep the trailer around in the reader.

          Anoop Sam John has already replied for this. Thanks.

          Bq. Is it odd adding this unbufferStream to hbase types when there is the Interface CanUnbuffer up in hdfs? Should we have a local hbase equivalent... and put it on HFileBlock, HFileReader... Then the relation is more clear? Perhaps overkill?

          From HBase side we do not have any control over the socket, so I don’t think we can do anything here apart from calling the unbuffer api for the stream which implements CanBuffer class. I also think this is not needed.

          May be we should at least rename this method pickReaderVersion ?

          Changed it to openReader as per the suggestion.

          Last QA run for v5 was clean. Updated patch addressing method rename comment.
          Thanks all again.

          Show
          ashish singhi Ashish Singhi added a comment - Thanks for the comments. Sorry for delay in repsonse, I was on holidays. Adding the below as finally in a method named pickReaderVersion seems a bit odd... is pickReaderVersion only place we read in the file trailer? That seems odd (not your issue Ashish Singhi). You'd think we'd want to keep the trailer around in the reader. Anoop Sam John has already replied for this. Thanks. Bq. Is it odd adding this unbufferStream to hbase types when there is the Interface CanUnbuffer up in hdfs? Should we have a local hbase equivalent... and put it on HFileBlock, HFileReader... Then the relation is more clear? Perhaps overkill? From HBase side we do not have any control over the socket, so I don’t think we can do anything here apart from calling the unbuffer api for the stream which implements CanBuffer class. I also think this is not needed. May be we should at least rename this method pickReaderVersion ? Changed it to openReader as per the suggestion. Last QA run for v5 was clean. Updated patch addressing method rename comment. Thanks all again.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 3m 41s master passed
          +1 compile 0m 55s master passed with JDK v1.8.0_66
          +1 compile 0m 48s master passed with JDK v1.7.0_91
          +1 checkstyle 4m 59s master passed
          +1 mvneclipse 0m 22s master passed
          -1 findbugs 2m 36s hbase-server in master has 1 extant Findbugs warnings.
          +1 javadoc 0m 43s master passed with JDK v1.8.0_66
          +1 javadoc 0m 46s master passed with JDK v1.7.0_91
          +1 mvninstall 1m 3s the patch passed
          +1 compile 0m 52s the patch passed with JDK v1.8.0_66
          +1 javac 0m 52s the patch passed
          +1 compile 0m 48s the patch passed with JDK v1.7.0_91
          +1 javac 0m 48s the patch passed
          +1 checkstyle 4m 54s the patch passed
          +1 mvneclipse 0m 22s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          -1 hadoopcheck 1m 13s Patch causes 24 errors with Hadoop v2.4.0.
          -1 hadoopcheck 2m 22s Patch causes 24 errors with Hadoop v2.4.1.
          -1 hadoopcheck 3m 31s Patch causes 24 errors with Hadoop v2.5.0.
          -1 hadoopcheck 4m 41s Patch causes 24 errors with Hadoop v2.5.1.
          -1 hadoopcheck 5m 51s Patch causes 24 errors with Hadoop v2.5.2.
          -1 hadoopcheck 7m 1s Patch causes 24 errors with Hadoop v2.6.1.
          -1 hadoopcheck 8m 8s Patch causes 24 errors with Hadoop v2.6.2.
          -1 hadoopcheck 9m 20s Patch causes 24 errors with Hadoop v2.6.3.
          +1 findbugs 2m 47s the patch passed
          +1 javadoc 0m 42s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 46s the patch passed with JDK v1.7.0_91
          +1 unit 129m 14s hbase-server in the patch passed with JDK v1.8.0_66.
          +1 unit 119m 39s hbase-server in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          289m 45s



          Subsystem Report/Notes
          Docker Client=1.9.1 Server=1.9.1 Image:yetus/hbase:date2016-01-26
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784305/HBASE-9393.v5.patch
          JIRA Issue HBASE-9393
          Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux 4f294db27100 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / d6b3d83
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/282/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/282/testReport/
          modules C: hbase-server U: hbase-server
          Max memory used 177MB
          Powered by Apache Yetus 0.1.0 http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/282/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 3m 41s master passed +1 compile 0m 55s master passed with JDK v1.8.0_66 +1 compile 0m 48s master passed with JDK v1.7.0_91 +1 checkstyle 4m 59s master passed +1 mvneclipse 0m 22s master passed -1 findbugs 2m 36s hbase-server in master has 1 extant Findbugs warnings. +1 javadoc 0m 43s master passed with JDK v1.8.0_66 +1 javadoc 0m 46s master passed with JDK v1.7.0_91 +1 mvninstall 1m 3s the patch passed +1 compile 0m 52s the patch passed with JDK v1.8.0_66 +1 javac 0m 52s the patch passed +1 compile 0m 48s the patch passed with JDK v1.7.0_91 +1 javac 0m 48s the patch passed +1 checkstyle 4m 54s the patch passed +1 mvneclipse 0m 22s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. -1 hadoopcheck 1m 13s Patch causes 24 errors with Hadoop v2.4.0. -1 hadoopcheck 2m 22s Patch causes 24 errors with Hadoop v2.4.1. -1 hadoopcheck 3m 31s Patch causes 24 errors with Hadoop v2.5.0. -1 hadoopcheck 4m 41s Patch causes 24 errors with Hadoop v2.5.1. -1 hadoopcheck 5m 51s Patch causes 24 errors with Hadoop v2.5.2. -1 hadoopcheck 7m 1s Patch causes 24 errors with Hadoop v2.6.1. -1 hadoopcheck 8m 8s Patch causes 24 errors with Hadoop v2.6.2. -1 hadoopcheck 9m 20s Patch causes 24 errors with Hadoop v2.6.3. +1 findbugs 2m 47s the patch passed +1 javadoc 0m 42s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 46s the patch passed with JDK v1.7.0_91 +1 unit 129m 14s hbase-server in the patch passed with JDK v1.8.0_66. +1 unit 119m 39s hbase-server in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 289m 45s Subsystem Report/Notes Docker Client=1.9.1 Server=1.9.1 Image:yetus/hbase:date2016-01-26 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784305/HBASE-9393.v5.patch JIRA Issue HBASE-9393 Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux 4f294db27100 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / d6b3d83 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/282/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/282/testReport/ modules C: hbase-server U: hbase-server Max memory used 177MB Powered by Apache Yetus 0.1.0 http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HBASE-Build/282/console This message was automatically generated.
          Hide
          anoop.hbase Anoop Sam John added a comment -

          Adding the below as finally in a method named pickReaderVersion seems a bit odd... is pickReaderVersion only place we read in the file trailer? That seems odd (not your issue Ashish Singhi). You'd think we'd want to keep the trailer around in the reader.

          We do read FFT in isHFileFormat() method also. This is used for a check on an HFile which is being bulk loaded (LoadIncrementalHFiles)

          Actually reading the FFT, we can do as pread. Now it is seek and then read. In this method of pickReaderVersion, we actually create the HFileReader also which will read the root level index blocks, bloom block etc. Those are also done as seek + read (reading blocks) which is fine IMO.
          May be we should at least rename this method pickReaderVersion ?

          Show
          anoop.hbase Anoop Sam John added a comment - Adding the below as finally in a method named pickReaderVersion seems a bit odd... is pickReaderVersion only place we read in the file trailer? That seems odd (not your issue Ashish Singhi). You'd think we'd want to keep the trailer around in the reader. We do read FFT in isHFileFormat() method also. This is used for a check on an HFile which is being bulk loaded (LoadIncrementalHFiles) Actually reading the FFT, we can do as pread. Now it is seek and then read. In this method of pickReaderVersion, we actually create the HFileReader also which will read the root level index blocks, bloom block etc. Those are also done as seek + read (reading blocks) which is fine IMO. May be we should at least rename this method pickReaderVersion ?
          Hide
          stack stack added a comment -

          Retry

          Show
          stack stack added a comment - Retry
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          From https://builds.apache.org/job/PreCommit-HBASE-Build/280/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_66.txt :

          Caused by: java.lang.RuntimeException: Error while running command to get file permissions : ExitCodeException exitCode=127: /bin/ls: error while loading shared libraries: libattr.so.1: failed to map segment from shared object: Permission denied
          
          	at org.apache.hadoop.util.Shell.runCommand(Shell.java:545)
          	at org.apache.hadoop.util.Shell.run(Shell.java:456)
          
          Show
          yuzhihong@gmail.com Ted Yu added a comment - From https://builds.apache.org/job/PreCommit-HBASE-Build/280/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_66.txt : Caused by: java.lang.RuntimeException: Error while running command to get file permissions : ExitCodeException exitCode=127: /bin/ls: error while loading shared libraries: libattr.so.1: failed to map segment from shared object: Permission denied at org.apache.hadoop.util.Shell.runCommand(Shell.java:545) at org.apache.hadoop.util.Shell.run(Shell.java:456)
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 2m 56s master passed
          +1 compile 0m 52s master passed with JDK v1.8.0_66
          +1 compile 0m 41s master passed with JDK v1.7.0_91
          +1 checkstyle 4m 29s master passed
          +1 mvneclipse 0m 20s master passed
          -1 findbugs 2m 12s hbase-server in master has 1 extant Findbugs warnings.
          +1 javadoc 0m 41s master passed with JDK v1.8.0_66
          +1 javadoc 0m 38s master passed with JDK v1.7.0_91
          +1 mvninstall 0m 51s the patch passed
          +1 compile 0m 53s the patch passed with JDK v1.8.0_66
          +1 javac 0m 53s the patch passed
          +1 compile 0m 41s the patch passed with JDK v1.7.0_91
          +1 javac 0m 41s the patch passed
          +1 checkstyle 4m 11s the patch passed
          +1 mvneclipse 0m 22s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          -1 hadoopcheck 1m 7s Patch causes 24 errors with Hadoop v2.4.0.
          -1 hadoopcheck 2m 11s Patch causes 24 errors with Hadoop v2.4.1.
          -1 hadoopcheck 3m 16s Patch causes 24 errors with Hadoop v2.5.0.
          -1 hadoopcheck 4m 18s Patch causes 24 errors with Hadoop v2.5.1.
          -1 hadoopcheck 5m 22s Patch causes 24 errors with Hadoop v2.5.2.
          -1 hadoopcheck 6m 30s Patch causes 24 errors with Hadoop v2.6.1.
          -1 hadoopcheck 7m 35s Patch causes 24 errors with Hadoop v2.6.2.
          -1 hadoopcheck 8m 43s Patch causes 24 errors with Hadoop v2.6.3.
          +1 findbugs 2m 41s the patch passed
          +1 javadoc 0m 46s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 43s the patch passed with JDK v1.7.0_91
          -1 unit 125m 7s hbase-server in the patch failed with JDK v1.8.0_66.
          +1 unit 100m 12s hbase-server in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 14s Patch does not generate ASF License warnings.
          261m 50s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hbase.master.balancer.TestStochasticLoadBalancer
            hadoop.hbase.replication.TestPerTableCFReplication
          JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.hbase.regionserver.wal.TestWALReplay
            org.apache.hadoop.hbase.regionserver.TestHRegion



          Subsystem Report/Notes
          Docker Client=1.9.1 Server=1.9.1 Image:yetus/hbase:date2016-01-25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784214/HBASE-9393.v5.patch
          JIRA Issue HBASE-9393
          Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux 78db1953f664 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / d6b3d83
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/280/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/280/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_66.txt
          unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/280/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_66.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/280/testReport/
          modules C: hbase-server U: hbase-server
          Max memory used 410MB
          Powered by Apache Yetus 0.1.0 http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/280/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 2m 56s master passed +1 compile 0m 52s master passed with JDK v1.8.0_66 +1 compile 0m 41s master passed with JDK v1.7.0_91 +1 checkstyle 4m 29s master passed +1 mvneclipse 0m 20s master passed -1 findbugs 2m 12s hbase-server in master has 1 extant Findbugs warnings. +1 javadoc 0m 41s master passed with JDK v1.8.0_66 +1 javadoc 0m 38s master passed with JDK v1.7.0_91 +1 mvninstall 0m 51s the patch passed +1 compile 0m 53s the patch passed with JDK v1.8.0_66 +1 javac 0m 53s the patch passed +1 compile 0m 41s the patch passed with JDK v1.7.0_91 +1 javac 0m 41s the patch passed +1 checkstyle 4m 11s the patch passed +1 mvneclipse 0m 22s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. -1 hadoopcheck 1m 7s Patch causes 24 errors with Hadoop v2.4.0. -1 hadoopcheck 2m 11s Patch causes 24 errors with Hadoop v2.4.1. -1 hadoopcheck 3m 16s Patch causes 24 errors with Hadoop v2.5.0. -1 hadoopcheck 4m 18s Patch causes 24 errors with Hadoop v2.5.1. -1 hadoopcheck 5m 22s Patch causes 24 errors with Hadoop v2.5.2. -1 hadoopcheck 6m 30s Patch causes 24 errors with Hadoop v2.6.1. -1 hadoopcheck 7m 35s Patch causes 24 errors with Hadoop v2.6.2. -1 hadoopcheck 8m 43s Patch causes 24 errors with Hadoop v2.6.3. +1 findbugs 2m 41s the patch passed +1 javadoc 0m 46s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 43s the patch passed with JDK v1.7.0_91 -1 unit 125m 7s hbase-server in the patch failed with JDK v1.8.0_66. +1 unit 100m 12s hbase-server in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 14s Patch does not generate ASF License warnings. 261m 50s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hbase.master.balancer.TestStochasticLoadBalancer   hadoop.hbase.replication.TestPerTableCFReplication JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.hbase.regionserver.wal.TestWALReplay   org.apache.hadoop.hbase.regionserver.TestHRegion Subsystem Report/Notes Docker Client=1.9.1 Server=1.9.1 Image:yetus/hbase:date2016-01-25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784214/HBASE-9393.v5.patch JIRA Issue HBASE-9393 Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux 78db1953f664 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / d6b3d83 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/280/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html unit https://builds.apache.org/job/PreCommit-HBASE-Build/280/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_66.txt unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/280/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_66.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/280/testReport/ modules C: hbase-server U: hbase-server Max memory used 410MB Powered by Apache Yetus 0.1.0 http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HBASE-Build/280/console This message was automatically generated.