Hadoop Common
  1. Hadoop Common
  2. HADOOP-8399

Remove JDK5 dependency from Hadoop 1.0+ line

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.2
    • Fix Version/s: 1.1.0
    • Component/s: build
    • Labels:
      None

      Description

      This issues has been fixed in Hadoop starting from 0.21 (see HDFS-1552).
      I propose to make the same fix for 1.0 line and get rid of JDK5 dependency all together.

      1. HADOOP-8399.patch
        11 kB
        Konstantin Boudnik

        Issue Links

          Activity

          Hide
          Konstantin Boudnik added a comment -

          That seems to do the job.
          The patch includes changes both for test-patch.sh and the build.xml file

          Show
          Konstantin Boudnik added a comment - That seems to do the job. The patch includes changes both for test-patch.sh and the build.xml file
          Hide
          Konstantin Boudnik added a comment -

          I am not sure if this is possible to test with usual patch validation process because it affects test-patch.sh.

          However, it works in my local run of ant -Dforrest.home=$FORREST_HOME docs

          Show
          Konstantin Boudnik added a comment - I am not sure if this is possible to test with usual patch validation process because it affects test-patch.sh. However, it works in my local run of ant -Dforrest.home=$FORREST_HOME docs
          Hide
          Roman Shaposhnik added a comment -

          A strong +1 – would be really nice to get rid of this ancient dependency.

          Show
          Roman Shaposhnik added a comment - A strong +1 – would be really nice to get rid of this ancient dependency.
          Hide
          Matt Foley added a comment -

          BTW, until this fix goes in, you may be interested to know there's a work-around:
          I don't actually use Java 5. As long as you're using Forrest version 0.9 or higher, you can just create a symlink to Java 6 and name it Java 5, and all works well.

          Show
          Matt Foley added a comment - BTW, until this fix goes in, you may be interested to know there's a work-around: I don't actually use Java 5. As long as you're using Forrest version 0.9 or higher, you can just create a symlink to Java 6 and name it Java 5, and all works well.
          Hide
          Matt Foley added a comment -

          We have two competing versions of this patch, the one here in HADOOP-8399, and a pair of patches in HADOOP-8166. I have compared them and found this one to be superior in terms of match to current branch-1.1.

          HADOOP-8399 patches files: build.xml, forrest.properties, test-patch.sh
          hadoop-8166 patches files: build.xml, do-release-build, forrest.properties, test-patch.sh
          The changes to build.xml and forrest.properties are equivalent.
          The file cloudera/do-release-build does not exist in Apache code.
          The changes to test-patch.sh differ in several ways, but seem to match the branch-1.1 code better in HADOOP-8399.

          In particular, HADOOP-8399 applies smoothly to test-patch.sh, while HADOOP-8166 fails 3 of 9 chunks. Furthermore, after applying HADOOP-8399, all instances of 'java5' are gone, which makes all the substantive differences between the two patches irrelevant.

          +1 on this patch. Committing to branch-1.1 and branch-1. Marking HADOOP-8166 as duplicate.

          Show
          Matt Foley added a comment - We have two competing versions of this patch, the one here in HADOOP-8399 , and a pair of patches in HADOOP-8166 . I have compared them and found this one to be superior in terms of match to current branch-1.1. HADOOP-8399 patches files: build.xml, forrest.properties, test-patch.sh hadoop-8166 patches files: build.xml, do-release-build, forrest.properties, test-patch.sh The changes to build.xml and forrest.properties are equivalent. The file cloudera/do-release-build does not exist in Apache code. The changes to test-patch.sh differ in several ways, but seem to match the branch-1.1 code better in HADOOP-8399 . In particular, HADOOP-8399 applies smoothly to test-patch.sh, while HADOOP-8166 fails 3 of 9 chunks. Furthermore, after applying HADOOP-8399 , all instances of 'java5' are gone, which makes all the substantive differences between the two patches irrelevant. +1 on this patch. Committing to branch-1.1 and branch-1. Marking HADOOP-8166 as duplicate.
          Hide
          Matt Foley added a comment -

          Closed upon release of Hadoop-1.1.0.

          Show
          Matt Foley added a comment - Closed upon release of Hadoop-1.1.0.

            People

            • Assignee:
              Konstantin Boudnik
              Reporter:
              Konstantin Boudnik
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development