Hadoop Common
  1. Hadoop Common
  2. HADOOP-8166

Remove JDK 1.5 dependency from building forrest docs

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Duplicate
    • Affects Version/s: 0.20.203.0, 0.20.204.0, 0.20.205.0, 1.0.0, 1.0.1
    • Fix Version/s: None
    • Component/s: documentation
    • Labels:
      None
    • Target Version/s:

      Description

      Currently Hadoop requires both JDK 1.6 and JDK 1.5. JDK 1.5 is a requirement of Forrest. It is easy to remove the latter requirement by turning off forrest.validate.sitemap and forrest.validate.skins.stylesheets.

      1. hadoop-8166.txt
        13 kB
        Eli Collins
      2. forrest.patch
        1 kB
        Mark Butler

        Issue Links

          Activity

          Hide
          Mark Butler added a comment -

          This removes sitemap and skins.stylesheets validation which makes it possible to build Hadoop without a JDK 1.5

          Show
          Mark Butler added a comment - This removes sitemap and skins.stylesheets validation which makes it possible to build Hadoop without a JDK 1.5
          Hide
          Eli Collins added a comment -

          See HADOOP-7072 for the trunk version.

          Show
          Eli Collins added a comment - See HADOOP-7072 for the trunk version.
          Hide
          Eli Collins added a comment -

          Here's a backport of HADOOP-7072 to 20, for comparison with your change. Not sure which is better.

          Show
          Eli Collins added a comment - Here's a backport of HADOOP-7072 to 20, for comparison with your change. Not sure which is better.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12518196/hadoop-8166.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/709//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12518196/hadoop-8166.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/709//console This message is automatically generated.
          Hide
          Matt Foley added a comment -

          Not complete in time for 1.0.3. Please consider continuing the contribution in 1.1.

          Show
          Matt Foley added a comment - Not complete in time for 1.0.3. Please consider continuing the contribution in 1.1.
          Hide
          Konstantin Boudnik added a comment -

          This seems like a backported version of Hadoop-7072 and a dup of HADOOP-8399 (or vice versa)

          Show
          Konstantin Boudnik added a comment - This seems like a backported version of Hadoop-7072 and a dup of HADOOP-8399 (or vice versa)
          Hide
          Matt Foley added a comment -

          We have two competing versions of this patch, the one in HADOOP-8399, and a pair of patches here in HADOOP-8166. I have compared them and found HADOOP-8399 to be superior in terms of match to current branch-1.1.

          HADOOP-8399 patches files: build.xml, forrest.properties, test-patch.sh
          hadoop-8166 patches files: build.xml, do-release-build, forrest.properties, test-patch.sh
          The changes to build.xml and forrest.properties are equivalent.
          The file cloudera/do-release-build does not exist in Apache code.
          The changes to test-patch.sh differ in several ways, but seem to match the branch-1.1 code better in HADOOP-8399.

          In particular, HADOOP-8399 applies smoothly to test-patch.sh, while HADOOP-8166 fails 3 of 9 chunks. Furthermore, after applying HADOOP-8399, all instances of 'java5' are gone, which makes all the substantive differences between the two patches irrelevant.

          Show
          Matt Foley added a comment - We have two competing versions of this patch, the one in HADOOP-8399 , and a pair of patches here in HADOOP-8166 . I have compared them and found HADOOP-8399 to be superior in terms of match to current branch-1.1. HADOOP-8399 patches files: build.xml, forrest.properties, test-patch.sh hadoop-8166 patches files: build.xml, do-release-build, forrest.properties, test-patch.sh The changes to build.xml and forrest.properties are equivalent. The file cloudera/do-release-build does not exist in Apache code. The changes to test-patch.sh differ in several ways, but seem to match the branch-1.1 code better in HADOOP-8399 . In particular, HADOOP-8399 applies smoothly to test-patch.sh, while HADOOP-8166 fails 3 of 9 chunks. Furthermore, after applying HADOOP-8399 , all instances of 'java5' are gone, which makes all the substantive differences between the two patches irrelevant.

            People

            • Assignee:
              Unassigned
              Reporter:
              Mark Butler
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development