[HADOOP-14414] Calling maven-site-plugin directly for docs profile is unnecessary

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.0.0-beta1
• Target Version/s: 3.0.0-beta1
• Hadoop Flags: Incompatible change
• Release Note: maven-site-plugin is no longer called directly at package phase.
• Assignee: Andras Bokor
• Reporter: Andras Bokor
• Created: 11/May/17 19:15
• Updated: 01/Sep/17 15:56
• Resolved: 01/Sep/17 15:40

Description

For a few modules:

• hadoop-auth
• hadoop-kms
• hadoop-hdfs-httpfs
• hadoop-sls

we call mave-site-plugin directly when docs profile is active.
In main pom we use excludeDefaults in reporting section and allow only javadoc and dependency-plugin for the report. Since javadoc plugin is set to inherited false it won't be called on individual child modules. So actually maven-dependency-plugin:analyze-report is the only additional goal which will run.
I debugged the process with mvn clean package -DskipTests -Dmaven.javadoc.skip=true -DskipShade -Pdocs -X command and in all the 4 affected modules I found the following configuration for site plugin:

<reportPlugins>
    <reportPlugin>
      <groupId>org.apache.maven.plugins</groupId>
      <artifactId>maven-dependency-plugin</artifactId>
      <version>2.10</version>
      <reportSets>
        <reportSet>
          <id>default</id>
          <reports>
            <report>analyze-report</report>
          </reports>
        </reportSet>
      </reportSets>
    </reportPlugin>
  </reportPlugins>

At this point I do not see the purpose of calling mave-site-plugin for docs profile. It does not contain useful information. Or if it does why don't we call for other modules? It's inconsistent.
Considering to remove.

Issue Links

• is depended upon by: HADOOP-9991 Fix up Hadoop POMs, roll up JARs to latest versions
• is related to: HADOOP-14401 maven-project-info-reports-plugin can be removed