Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14414

Calling maven-site-plugin directly for docs profile is unnecessary

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-beta1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Incompatible change
    • Release Note:
      maven-site-plugin is no longer called directly at package phase.

      Description

      For a few modules:

      • hadoop-auth
      • hadoop-kms
      • hadoop-hdfs-httpfs
      • hadoop-sls

      we call mave-site-plugin directly when docs profile is active.
      In main pom we use excludeDefaults in reporting section and allow only javadoc and dependency-plugin for the report. Since javadoc plugin is set to inherited false it won't be called on individual child modules. So actually maven-dependency-plugin:analyze-report is the only additional goal which will run.
      I debugged the process with mvn clean package -DskipTests -Dmaven.javadoc.skip=true -DskipShade -Pdocs -X command and in all the 4 affected modules I found the following configuration for site plugin:

      <reportPlugins>
          <reportPlugin>
            <groupId>org.apache.maven.plugins</groupId>
            <artifactId>maven-dependency-plugin</artifactId>
            <version>2.10</version>
            <reportSets>
              <reportSet>
                <id>default</id>
                <reports>
                  <report>analyze-report</report>
                </reports>
              </reportSet>
            </reportSets>
          </reportPlugin>
        </reportPlugins>

      At this point I do not see the purpose of calling mave-site-plugin for docs profile. It does not contain useful information. Or if it does why don't we call for other modules? It's inconsistent.
      Considering to remove.

        Attachments

        1. missingFiles
          9 kB
          Andras Bokor
        2. HADOOP-14414.02.patch
          4 kB
          Andras Bokor
        3. HADOOP-14414.01.patch
          4 kB
          Andras Bokor

          Issue Links

            Activity

              People

              • Assignee:
                boky01 Andras Bokor
                Reporter:
                boky01 Andras Bokor
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: