Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14401

maven-project-info-reports-plugin can be removed

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha4
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      hadoop-auth and hadoop-hdfs-httpfs modules no longer generate dependencies.html via maven-project-info-reports-plugin.

      Description

      By default maven-project-info-reports-plugin is called at site phrase but in Hadoop Main's pom we use excludeDefaults tag which excludes maven-project-info-reports-plugin from the process. It will run only when it is called directly.
      I found two invocation: hadoop-hdfs-httpfs and hadoop-auth.
      These invocations seems unnecessary as I pointed in HADOOP-14393.

      This plugin can be removed. Makes the understanding of site generation harder. It took me a while finding out the role of the plugin.

        Issue Links

          Activity

          Hide
          boky01 Andras Bokor added a comment -

          Thanks a lot Akira Ajisaka!

          Show
          boky01 Andras Bokor added a comment - Thanks a lot Akira Ajisaka !
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11727 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11727/)
          HADOOP-14401. maven-project-info-reports-plugin can be removed. (aajisaka: rev 0d5c8ed8e0176909ee4d68b2969a882c21c0df55)

          • (edit) hadoop-tools/hadoop-openstack/pom.xml
          • (edit) hadoop-tools/hadoop-kafka/pom.xml
          • (edit) hadoop-project/pom.xml
          • (edit) hadoop-common-project/hadoop-auth/pom.xml
          • (edit) hadoop-tools/hadoop-azure-datalake/pom.xml
          • (edit) hadoop-tools/hadoop-aliyun/pom.xml
          • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/pom.xml
          • (edit) hadoop-tools/hadoop-aws/pom.xml
          • (edit) hadoop-tools/hadoop-azure/pom.xml
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11727 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11727/ ) HADOOP-14401 . maven-project-info-reports-plugin can be removed. (aajisaka: rev 0d5c8ed8e0176909ee4d68b2969a882c21c0df55) (edit) hadoop-tools/hadoop-openstack/pom.xml (edit) hadoop-tools/hadoop-kafka/pom.xml (edit) hadoop-project/pom.xml (edit) hadoop-common-project/hadoop-auth/pom.xml (edit) hadoop-tools/hadoop-azure-datalake/pom.xml (edit) hadoop-tools/hadoop-aliyun/pom.xml (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/pom.xml (edit) hadoop-tools/hadoop-aws/pom.xml (edit) hadoop-tools/hadoop-azure/pom.xml
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk. Thanks Andras Bokor for the contribution!

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk. Thanks Andras Bokor for the contribution!
          Hide
          ajisakaa Akira Ajisaka added a comment -

          LGTM, +1

          Show
          ajisakaa Akira Ajisaka added a comment - LGTM, +1
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 13m 3s trunk passed
          +1 compile 17m 32s trunk passed
          +1 mvnsite 3m 39s trunk passed
          +1 mvneclipse 3m 11s trunk passed
          +1 javadoc 2m 23s trunk passed
          0 mvndep 0m 13s Maven dependency ordering for patch
          +1 mvninstall 2m 3s the patch passed
          +1 compile 13m 44s the patch passed
          +1 javac 13m 44s the patch passed
          +1 mvnsite 3m 18s the patch passed
          +1 mvneclipse 2m 19s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 11s The patch has no ill-formed XML file.
          +1 javadoc 2m 5s the patch passed
          +1 unit 0m 10s hadoop-project in the patch passed.
          +1 unit 2m 42s hadoop-auth in the patch passed.
          +1 unit 3m 21s hadoop-hdfs-httpfs in the patch passed.
          +1 unit 0m 16s hadoop-openstack in the patch passed.
          +1 unit 0m 23s hadoop-aws in the patch passed.
          +1 unit 0m 18s hadoop-kafka in the patch passed.
          +1 unit 1m 22s hadoop-azure in the patch passed.
          +1 unit 0m 15s hadoop-aliyun in the patch passed.
          +1 unit 3m 32s hadoop-azure-datalake in the patch passed.
          +1 asflicense 0m 25s The patch does not generate ASF License warnings.
          78m 20s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-14401
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12867111/HADOOP-14401.01.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
          uname Linux 32ae643a1296 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / c60164f
          Default Java 1.8.0_121
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12280/testReport/
          modules C: hadoop-project hadoop-common-project/hadoop-auth hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-tools/hadoop-openstack hadoop-tools/hadoop-aws hadoop-tools/hadoop-kafka hadoop-tools/hadoop-azure hadoop-tools/hadoop-aliyun hadoop-tools/hadoop-azure-datalake U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12280/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 13m 3s trunk passed +1 compile 17m 32s trunk passed +1 mvnsite 3m 39s trunk passed +1 mvneclipse 3m 11s trunk passed +1 javadoc 2m 23s trunk passed 0 mvndep 0m 13s Maven dependency ordering for patch +1 mvninstall 2m 3s the patch passed +1 compile 13m 44s the patch passed +1 javac 13m 44s the patch passed +1 mvnsite 3m 18s the patch passed +1 mvneclipse 2m 19s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 11s The patch has no ill-formed XML file. +1 javadoc 2m 5s the patch passed +1 unit 0m 10s hadoop-project in the patch passed. +1 unit 2m 42s hadoop-auth in the patch passed. +1 unit 3m 21s hadoop-hdfs-httpfs in the patch passed. +1 unit 0m 16s hadoop-openstack in the patch passed. +1 unit 0m 23s hadoop-aws in the patch passed. +1 unit 0m 18s hadoop-kafka in the patch passed. +1 unit 1m 22s hadoop-azure in the patch passed. +1 unit 0m 15s hadoop-aliyun in the patch passed. +1 unit 3m 32s hadoop-azure-datalake in the patch passed. +1 asflicense 0m 25s The patch does not generate ASF License warnings. 78m 20s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14401 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12867111/HADOOP-14401.01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux 32ae643a1296 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c60164f Default Java 1.8.0_121 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12280/testReport/ modules C: hadoop-project hadoop-common-project/hadoop-auth hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-tools/hadoop-openstack hadoop-tools/hadoop-aws hadoop-tools/hadoop-kafka hadoop-tools/hadoop-azure hadoop-tools/hadoop-aliyun hadoop-tools/hadoop-azure-datalake U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12280/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          boky01 Andras Bokor added a comment -

          Not 100% sure if it is because of my patch, but mvn clean package -DskipTests -Dmaven.javadoc.skip=true -DskipShade -Pdocs took 90 sec less than before patch. I just tried once.

          Show
          boky01 Andras Bokor added a comment - Not 100% sure if it is because of my patch, but mvn clean package -DskipTests -Dmaven.javadoc.skip=true -DskipShade -Pdocs took 90 sec less than before patch. I just tried once.

            People

            • Assignee:
              boky01 Andras Bokor
              Reporter:
              boky01 Andras Bokor
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development