[HADOOP-12693] Many misusages of assertEquals(expected, actual)

• Type: Test
• Status: Open
• Priority: Trivial
• Resolution: Unresolved
• Assignee: Unassigned
• Reporter: Akihiro Suda
• Created: 07/Jan/16 05:45
• Updated: 12/Aug/19 16:40

Description

The first arg of org.JUnit.Assert.assertEquals() should be an expected value, and the second one should be an actual value.

void assertEquals(T expected, T actual);

http://junit.org/apidocs/org/junit/Assert.html#assertEquals(java.lang.Object, java.lang.Object)

However, there are so many violations in Hadoop, which can make a misleading message like this:

AssertionError: expected:<actual> but was:<expected>

.

Please refer to just-rough-approx.txt.

Issue Links

• is related to: HADOOP-16508 [hadoop-yarn-project] Fix order of actual and expected expression in assert statements
• is related to: HADOOP-16509 [hadoop-mapreduce-project] Fix order of actual and expected expression in assert statements
• is related to: MAPREDUCE-6508 TestNetworkedJob fails consistently due to delegation token changes on RM.
• relates to: YARN-4543 TestNodeStatusUpdater.testStopReentrant fails + JUnit misusage

Sub-Tasks

• [hadoop-common] Fix order of actual and expected expression in assert statements: In Progress
• [hadoop-hdfs] Fix order of actual and expected expression in assert statements: Open
• [hadoop-tools] Fix order of actual and expected expression in assert statements: Patch Available