Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12693 Many misusages of assertEquals(expected, actual)
  3. HADOOP-16510

[hadoop-common] Fix order of actual and expected expression in assert statements

    XMLWordPrintableJSON

    Details

    • Type: Sub-task
    • Status: Patch Available
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 3.2.0
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Target Version/s:

      Description

      Fix order of actual and expected expression in assert statements which gives misleading message when test case fails. Attached file has some of the places where it is placed wrongly.

      [ERROR] testNodeRemovalGracefully(org.apache.hadoop.yarn.server.resourcemanager.TestResourceTrackerService)  Time elapsed: 3.385 s  <<< FAILURE!
      java.lang.AssertionError: Shutdown nodes should be 0 now expected:<1> but was:<0>
      

      For long term, AssertJ can be used for new test cases which avoids such mistakes.

      This is a follow-up jira for the hadoop-common project.

        Attachments

        1. HADOOP-16510.003.patch
          87 kB
          Adam Antal
        2. HADOOP-16510.002.patch
          87 kB
          Adam Antal
        3. HADOOP-16510.001.patch
          86 kB
          Adam Antal

          Activity

            People

            • Assignee:
              adam.antal Adam Antal
              Reporter:
              adam.antal Adam Antal
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated: