[FINERACT-1014] From/To Amount Range and Period Validatation broken

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.4.0
• Assignee: Percy Ashu
• Reporter: Michael Vorburger
• Created: 01/Jun/20 09:20
• Updated: 01/Jun/20 09:30
• Resolved: 01/Jun/20 09:30

Description

Percy Ashu's work for FINERACT-822 in https://github.com/apache/fineract/pull/951/files thanks to https://errorprone.info/bugpattern/CompareToZero has uncovered real bugs (not just "nice to have for hypothetical exotic JDKs, like that Error Prone doc makes it sound) in Fineract's From/To Amount Range and Period Validatation.. there were 4 places which did a Comparable compareTo() > 1 - which is obviously never the case; those validations were simply completely broken, and we're fixing them as part of enabling code quality checks with Error Prone.

In theory, this code break clients who sent this wrong to the API, but that's a Good Thing.

Issue Links

• requires: FINERACT-822 Enable and enforce (!) Google's Error Prone quality check tool in Fineract