[ZOOKEEPER-1870] flakey test in StandaloneDisabledTest.startSingleServerTest

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 3.4.6
• Fix Version/s: 3.5.0
• Component/s: tests
• Assignee: Helen Hastings
• Reporter: Patrick D. Hunt
• Created: 28/Jan/14 18:45
• Updated: 28/Aug/14 16:50
• Resolved: 28/Aug/14 16:49

Description

I'm seeing lots of the following failure. Seems like a flakey test (passes every so often).

junit.framework.AssertionFailedError: client could not connect to reestablished quorum: giving up after 30+ seconds.
	at org.apache.zookeeper.test.ReconfigTest.testNormalOperation(ReconfigTest.java:143)
	at org.apache.zookeeper.server.quorum.StandaloneDisabledTest.startSingleServerTest(StandaloneDisabledTest.java:75)
	at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)

I've found 3 problems:

1. QuorumCnxManager.Listener.run() leaks the socket depending on when the shutdown flag gets set.
2. QuorumCnxManager.halt() doesn't wait for the listener to terminate.
3. QuorumPeer.shuttingDownLE flag doesn't get reset when restarting the leader election.

Issue Links

• is broken by: ZOOKEEPER-1810 Add version to FLE notifications for trunk
• is broken by: ZOOKEEPER-1805 "Don't care" value in ZooKeeper election breaks rolling upgrades
• is related to: ZOOKEEPER-1691 Add a flag to disable standalone mode