ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1810

Add version to FLE notifications for trunk

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.5.0
    • Fix Version/s: 3.5.0
    • Component/s: leaderElection
    • Labels:
      None

      Description

      The same as ZOOKEEPER-1808 but for trunk.

      1. ZOOKEEPER-1810.patch
        55 kB
        Flavio Junqueira
      2. ZOOKEEPER-1810.patch
        54 kB
        Flavio Junqueira
      3. ZOOKEEPER-1810.patch
        54 kB
        Germán Blanco
      4. ZOOKEEPER-1810.patch
        40 kB
        Germán Blanco
      5. ZOOKEEPER-1810.patch
        53 kB
        Germán Blanco
      6. ZOOKEEPER-1810.patch
        54 kB
        Germán Blanco
      7. ZOOKEEPER-1810.patch
        53 kB
        Germán Blanco
      8. ZOOKEEPER-1810.patch
        24 kB
        Germán Blanco

        Issue Links

          Activity

          Hide
          Alexander Shraer added a comment -

          W.r.t. zk-107 the change in message format was the additional configuration fiend in notifications, which
          is assumed to be at the end. Then there are the new backwardCompatibility flag

          // ZK-107 sends the configuration info in every message.
          // So messages are 36 bytes + size of configuration info
          // (variable length, shoulld be at the end of the message).
          boolean backCompatibility36 = (response.buffer.capacity() == 36);

          which need to be adjusted because now we may have the version so the size without config may be bigger.

          Instead of this flag perhaps we could just check the size to determine that there's a version, and then use the version to see if the message has a config field. Also perhaps it would be cleaner to have a config size field before the config field,so that we get rid of the assumption that config must be last in the message, which makes it more difficult to extend.

          Show
          Alexander Shraer added a comment - W.r.t. zk-107 the change in message format was the additional configuration fiend in notifications, which is assumed to be at the end. Then there are the new backwardCompatibility flag // ZK-107 sends the configuration info in every message. // So messages are 36 bytes + size of configuration info // (variable length, shoulld be at the end of the message). boolean backCompatibility36 = (response.buffer.capacity() == 36); which need to be adjusted because now we may have the version so the size without config may be bigger. Instead of this flag perhaps we could just check the size to determine that there's a version, and then use the version to see if the message has a config field. Also perhaps it would be cleaner to have a config size field before the config field,so that we get rid of the assumption that config must be last in the message, which makes it more difficult to extend.
          Hide
          Germán Blanco added a comment -

          patch following the suggestions in the thread.

          Show
          Germán Blanco added a comment - patch following the suggestions in the thread.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12613859/ZOOKEEPER-1810.patch
          against trunk revision 1541810.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 9 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 javac. The patch appears to cause tar ant target to fail.

          -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1765//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1765//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1765//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12613859/ZOOKEEPER-1810.patch against trunk revision 1541810. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1765//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1765//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1765//console This message is automatically generated.
          Hide
          Germán Blanco added a comment -

          The previous patch was missing some files.

          Show
          Germán Blanco added a comment - The previous patch was missing some files.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12613868/ZOOKEEPER-1810.patch
          against trunk revision 1541810.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 21 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1767//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1767//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1767//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12613868/ZOOKEEPER-1810.patch against trunk revision 1541810. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 21 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1767//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1767//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1767//console This message is automatically generated.
          Hide
          Germán Blanco added a comment -

          This is strange. There is a new findbugs warning about the constructor of class Messenger in FastLeaderElection, but there were no changes in that constructor.
          And I think the core tests complains about the tests that have been moved from package org.apache.zookeeper.test to org.apache.zookeeper.server.quorum.

          Show
          Germán Blanco added a comment - This is strange. There is a new findbugs warning about the constructor of class Messenger in FastLeaderElection, but there were no changes in that constructor. And I think the core tests complains about the tests that have been moved from package org.apache.zookeeper.test to org.apache.zookeeper.server.quorum.
          Hide
          Raul Gutierrez Segales added a comment -

          I think that:

          +                                if(LOG.isInfoEnabled()){
          +                                    LOG.info("Backward compatibility mode (36 bits), server id: " + response.sid);
          +                                }
          

          can do without the LOG.isInfoEnabled since it's already called by LOG.info and response.sid isn't computed (just a value accessed, so no savings).

          Show
          Raul Gutierrez Segales added a comment - I think that: + if(LOG.isInfoEnabled()){ + LOG.info("Backward compatibility mode (36 bits), server id: " + response.sid); + } can do without the LOG.isInfoEnabled since it's already called by LOG.info and response.sid isn't computed (just a value accessed, so no savings).
          Hide
          Raul Gutierrez Segales added a comment -

          Extra newline in:

          +public class FLELostMessageTest extends ZKTestCase {
          +    protected static final Logger LOG = LoggerFactory.getLogger(FLELostMessageTest.class);
          +
          +
          +    int count;
          

          Super nit in src/java/test/org/apache/zookeeper/server/quorum/FLEBackwardElectionRoundTest.java:

          +        cnxManagers[0].toSend(0l, FLETestUtils.createMsg(ServerState.FOLLOWING.ordinal(), 0, 0, 1));
          

          if the same Msg is created again and again, can't we just create it once and reuse?

          In :

          +                            if (LOG.isDebugEnabled()) {
          +                                LOG.debug("Receive new notification message. My id = "
          +                                        + self.getId());
          +                            }
          

          no need for LOG.isDebugEnabled.

          Show
          Raul Gutierrez Segales added a comment - Extra newline in: +public class FLELostMessageTest extends ZKTestCase { + protected static final Logger LOG = LoggerFactory.getLogger(FLELostMessageTest.class); + + + int count; Super nit in src/java/test/org/apache/zookeeper/server/quorum/FLEBackwardElectionRoundTest.java: + cnxManagers[0].toSend(0l, FLETestUtils.createMsg(ServerState.FOLLOWING.ordinal(), 0, 0, 1)); if the same Msg is created again and again, can't we just create it once and reuse? In : + if (LOG.isDebugEnabled()) { + LOG.debug("Receive new notification message. My id = " + + self.getId()); + } no need for LOG.isDebugEnabled.
          Hide
          Germán Blanco added a comment -

          Thank you for the comments Raul Gutierrez Segales!
          I will do the clean up.
          I don't know what you mean with the "Super nit" in:

          Super nit in src/java/test/org/apache/zookeeper/server/quorum/FLEBackwardElectionRoundTest.java:

          Is it that the line is too long?

          Show
          Germán Blanco added a comment - Thank you for the comments Raul Gutierrez Segales ! I will do the clean up. I don't know what you mean with the "Super nit" in: Super nit in src/java/test/org/apache/zookeeper/server/quorum/FLEBackwardElectionRoundTest.java: Is it that the line is too long?
          Hide
          Germán Blanco added a comment -

          Ok, now I get it. I thought the next line belonged to the next comment.

          Show
          Germán Blanco added a comment - Ok, now I get it. I thought the next line belonged to the next comment.
          Hide
          Raul Gutierrez Segales added a comment -

          Yeah - sorry that was a bit confusing. I guess - if it isn't too much of a hassle - reviewboards to make things a bit easier.

          Show
          Raul Gutierrez Segales added a comment - Yeah - sorry that was a bit confusing. I guess - if it isn't too much of a hassle - reviewboards to make things a bit easier.
          Hide
          Raul Gutierrez Segales added a comment -

          (I meant for future patches - we can keep on going with this one inside the ticket if it's easier.)

          Show
          Raul Gutierrez Segales added a comment - (I meant for future patches - we can keep on going with this one inside the ticket if it's easier.)
          Hide
          Germán Blanco added a comment -

          I think this covers the comments from Raul Gutierrez Segales and findbug warning issue.
          Regarding "isDebugEnabled", my understanding is that this is required for points in which there could be a drop in performance, but it doesn't make a big difference in other points. I have understood also that there is a preference for using "{}" in the logs instead of concatenating strings.

          Show
          Germán Blanco added a comment - I think this covers the comments from Raul Gutierrez Segales and findbug warning issue. Regarding "isDebugEnabled", my understanding is that this is required for points in which there could be a drop in performance, but it doesn't make a big difference in other points. I have understood also that there is a preference for using "{}" in the logs instead of concatenating strings.
          Hide
          Germán Blanco added a comment -

          Some style changes.
          Review in https://reviews.apache.org/r/15568/

          Show
          Germán Blanco added a comment - Some style changes. Review in https://reviews.apache.org/r/15568/
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12614027/ZOOKEEPER-1810.patch
          against trunk revision 1541810.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 33 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1769//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1769//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1769//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12614027/ZOOKEEPER-1810.patch against trunk revision 1541810. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 33 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1769//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1769//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1769//console This message is automatically generated.
          Hide
          Raul Gutierrez Segales added a comment -

          Doesn't look like https://reviews.apache.org/r/15568/ was updated? Or should we continue the review (and give the +1s) here?

          Show
          Raul Gutierrez Segales added a comment - Doesn't look like https://reviews.apache.org/r/15568/ was updated? Or should we continue the review (and give the +1s) here?
          Hide
          Raul Gutierrez Segales added a comment -

          Reviewed https://reviews.apache.org/r/15568/ after the update landed.

          Show
          Raul Gutierrez Segales added a comment - Reviewed https://reviews.apache.org/r/15568/ after the update landed.
          Hide
          Germán Blanco added a comment -

          Updated with last comments from review board.

          Show
          Germán Blanco added a comment - Updated with last comments from review board.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12632841/ZOOKEEPER-1810.patch
          against trunk revision 1569590.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 24 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1941//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1941//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1941//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12632841/ZOOKEEPER-1810.patch against trunk revision 1569590. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 24 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1941//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1941//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1941//console This message is automatically generated.
          Hide
          Raul Gutierrez Segales added a comment -

          Thanks for the update, Germán Blanco. I added some extra comments in the review board.

          Show
          Raul Gutierrez Segales added a comment - Thanks for the update, Germán Blanco . I added some extra comments in the review board.
          Hide
          Germán Blanco added a comment -

          a couple of unnecessary comments and lines of code removed according to comments

          Show
          Germán Blanco added a comment - a couple of unnecessary comments and lines of code removed according to comments
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12633366/ZOOKEEPER-1810.patch
          against trunk revision 1574686.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 33 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1942//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1942//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1942//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12633366/ZOOKEEPER-1810.patch against trunk revision 1574686. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 33 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1942//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1942//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1942//console This message is automatically generated.
          Hide
          Flavio Junqueira added a comment -

          According to ZOOKEEPER-1896, we need to update the size of 3.4 notification messages for backward compatibility.

          Show
          Flavio Junqueira added a comment - According to ZOOKEEPER-1896 , we need to update the size of 3.4 notification messages for backward compatibility.
          Hide
          Flavio Junqueira added a comment -

          Updated size of notifications to 40 bytes for backward compatibility.

          Show
          Flavio Junqueira added a comment - Updated size of notifications to 40 bytes for backward compatibility.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12643983/ZOOKEEPER-1810.patch
          against trunk revision 1592341.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 33 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2081//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2081//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2081//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12643983/ZOOKEEPER-1810.patch against trunk revision 1592341. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 33 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2081//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2081//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2081//console This message is automatically generated.
          Hide
          Flavio Junqueira added a comment -

          The failure is in the C tests, and I don't see any reason for this patch to cause any problem with the C tests.

          Show
          Flavio Junqueira added a comment - The failure is in the C tests, and I don't see any reason for this patch to cause any problem with the C tests.
          Hide
          Michi Mutsuzaki added a comment -

          I'll check this in after running the build one more time. Right now Jenkins seems to be down...

          Show
          Michi Mutsuzaki added a comment - I'll check this in after running the build one more time. Right now Jenkins seems to be down...
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12643983/ZOOKEEPER-1810.patch
          against trunk revision 1598087.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 33 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2118//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2118//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2118//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12643983/ZOOKEEPER-1810.patch against trunk revision 1598087. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 33 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2118//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2118//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2118//console This message is automatically generated.
          Hide
          Michi Mutsuzaki added a comment -

          org.apache.zookeeper.test.LETest.testLE failed. The test is occasionally failing in trunk as well, so it might not be related to this patch, but we should probably fix the test failure first.

          Show
          Michi Mutsuzaki added a comment - org.apache.zookeeper.test.LETest.testLE failed. The test is occasionally failing in trunk as well, so it might not be related to this patch, but we should probably fix the test failure first.
          Hide
          Michi Mutsuzaki added a comment -

          I've been running org.apache.zookeeper.test.LETest.testLE on my box since yesterday, but I can't reproduce the failure...

          Show
          Michi Mutsuzaki added a comment - I've been running org.apache.zookeeper.test.LETest.testLE on my box since yesterday, but I can't reproduce the failure...
          Hide
          Flavio Junqueira added a comment -

          Michi Mutsuzaki, if you agree with what I said in ZOOKEEPER-1932, can we have this one in?

          Show
          Flavio Junqueira added a comment - Michi Mutsuzaki , if you agree with what I said in ZOOKEEPER-1932 , can we have this one in?
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12643983/ZOOKEEPER-1810.patch
          against trunk revision 1607525.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 33 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2170//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12643983/ZOOKEEPER-1810.patch against trunk revision 1607525. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 33 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2170//console This message is automatically generated.
          Hide
          Michi Mutsuzaki added a comment -

          The patch doesn't apply anymore. I'll check this in once the patch is rebased.

          Show
          Michi Mutsuzaki added a comment - The patch doesn't apply anymore. I'll check this in once the patch is rebased.
          Hide
          Flavio Junqueira added a comment -

          Rebased patch.

          Show
          Flavio Junqueira added a comment - Rebased patch.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12654006/ZOOKEEPER-1810.patch
          against trunk revision 1607525.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 33 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2173//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2173//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2173//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12654006/ZOOKEEPER-1810.patch against trunk revision 1607525. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 33 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2173//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2173//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2173//console This message is automatically generated.
          Hide
          Flavio Junqueira added a comment -

          The C tests are a bit flaky, we need to get it fixed. Can I get this one in, please, Michi Mutsuzaki?

          Show
          Flavio Junqueira added a comment - The C tests are a bit flaky, we need to get it fixed. Can I get this one in, please, Michi Mutsuzaki ?
          Hide
          Michi Mutsuzaki added a comment -

          +1 Thanks Flavio!

          Show
          Michi Mutsuzaki added a comment - +1 Thanks Flavio!
          Show
          Michi Mutsuzaki added a comment - trunk: http://svn.apache.org/viewvc?view=revision&revision=1608648
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in ZooKeeper-trunk #2359 (See https://builds.apache.org/job/ZooKeeper-trunk/2359/)
          ZOOKEEPER-1810. Add version to FLE notifications for trunk Germán Blanco via michim) (michim: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1608648)

          • /zookeeper/trunk/CHANGES.txt
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/Vote.java
          • /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/FLEBackwardElectionRoundTest.java
          • /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/FLELostMessageTest.java
          • /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/FLETestUtils.java
          • /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FLEBackwardElectionRoundTest.java
          • /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FLELostMessageTest.java
          • /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FLENewEpochTest.java
          • /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FLEPredicateTest.java
          • /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FLETest.java
          • /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FLETestUtils.java
          • /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FLEZeroWeightTest.java
          • /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/LENonTerminateTest.java
          Show
          Hudson added a comment - SUCCESS: Integrated in ZooKeeper-trunk #2359 (See https://builds.apache.org/job/ZooKeeper-trunk/2359/ ) ZOOKEEPER-1810 . Add version to FLE notifications for trunk Germán Blanco via michim) (michim: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1608648 ) /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/Vote.java /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/FLEBackwardElectionRoundTest.java /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/FLELostMessageTest.java /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/FLETestUtils.java /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FLEBackwardElectionRoundTest.java /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FLELostMessageTest.java /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FLENewEpochTest.java /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FLEPredicateTest.java /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FLETest.java /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FLETestUtils.java /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FLEZeroWeightTest.java /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/LENonTerminateTest.java

            People

            • Assignee:
              Germán Blanco
              Reporter:
              Flavio Junqueira
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development