Details

    • Hadoop Flags:
      Reviewed

      Description

      Found these with Rohith Sharma K S while browsing the code

      • In stop: it calls shutdownNow which doens't wait for pending tasks, should it use shutdown instead ?
            public void stop() {
              LOG.info("Stopping TimelineClient.");
              executor.shutdownNow();
              try {
                executor.awaitTermination(DRAIN_TIME_PERIOD, TimeUnit.MILLISECONDS);
              } catch (InterruptedException e) {
        
      • In TimelineClientImpl#createRunnable:
        If any exception happens when publish one entity (publishWithoutBlockingOnQueue), the thread exists. I think it should try best effort to continue publishing the timeline entities, one failure should not cause all followup entities not published.

        Attachments

        1. YARN-6342.02.patch
          4 kB
          Haibo Chen
        2. YARN-6342.01.patch
          4 kB
          Haibo Chen
        3. YARN-6342.00.patch
          3 kB
          Haibo Chen

          Issue Links

            Activity

              People

              • Assignee:
                haibochen Haibo Chen
                Reporter:
                jianhe Jian He
              • Votes:
                0 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: