Found these with Rohith Sharma K S while browsing the code
- In stop: it calls shutdownNow which doens't wait for pending tasks, should it use shutdown instead ?
- In TimelineClientImpl#createRunnable:
If any exception happens when publish one entity (publishWithoutBlockingOnQueue), the thread exists. I think it should try best effort to continue publishing the timeline entities, one failure should not cause all followup entities not published.