[YARN-6342] Make TimelineV2Client's drain timeout after stop configurable

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.9.0, YARN-5355, YARN-5355-branch-2, 3.0.0-alpha4
• Hadoop Flags: Reviewed
• Assignee: Haibo Chen
• Reporter: Jian He
• Created: 15/Mar/17 09:23
• Updated: 21/Oct/17 06:06
• Resolved: 30/Mar/17 20:44

Description

Found these with rohithsharma while browsing the code

• In stop: it calls shutdownNow which doens't wait for pending tasks, should it use shutdown instead ?

      public void stop() {
        LOG.info("Stopping TimelineClient.");
        executor.shutdownNow();
        try {
          executor.awaitTermination(DRAIN_TIME_PERIOD, TimeUnit.MILLISECONDS);
        } catch (InterruptedException e) {
  

• In TimelineClientImpl#createRunnable:
  If any exception happens when publish one entity (publishWithoutBlockingOnQueue), the thread exists. I think it should try best effort to continue publishing the timeline entities, one failure should not cause all followup entities not published.

Issue Links

• is related to: YARN-6357 Implement putEntitiesAsync API in TimelineCollector
• relates to: YARN-4061 [Fault tolerance] Fault tolerant writer for timeline v2