Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: yarn
    • Labels:
      None
    1. YARN-5922.01.patch
      7 kB
      Haibo Chen
    2. YARN-5922.02.patch
      8 kB
      Haibo Chen
    3. YARN-5922.03.patch
      7 kB
      Haibo Chen
    4. YARN-5922.04.patch
      13 kB
      Haibo Chen
    5. YARN-5922.05.patch
      14 kB
      Haibo Chen
    6. YARN-5922-YARN-5355.01.patch
      7 kB
      Haibo Chen
    7. YARN-5922-YARN-5355.02.patch
      8 kB
      Haibo Chen
    8. YARN-5922-YARN-5355.04.patch
      13 kB
      Haibo Chen
    9. YARN-5922-YARN-5355.05.patch
      13 kB
      Haibo Chen

      Issue Links

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 patch 0m 4s YARN-5922 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



        Subsystem Report/Notes
        JIRA Issue YARN-5922
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12839915/yarn5922.001.yarn5355.patch
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14022/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 4s YARN-5922 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue YARN-5922 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12839915/yarn5922.001.yarn5355.patch Console output https://builds.apache.org/job/PreCommit-YARN-Build/14022/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        sjlee0 Sangjin Lee added a comment -

        Haibo Chen, you'd need to name the patch files differently for the right builds to kick in. The YARN-5355 patch should be named yarn5922-YARN-5355.001.patch for yetus to recognize it as a patch against YARN-5355.

        Show
        sjlee0 Sangjin Lee added a comment - Haibo Chen , you'd need to name the patch files differently for the right builds to kick in. The YARN-5355 patch should be named yarn5922- YARN-5355 .001.patch for yetus to recognize it as a patch against YARN-5355 .
        Hide
        haibochen Haibo Chen added a comment -

        Thanks for pointing it out Sangjin Lee. Will upload a new patch to kick off the build.

        Show
        haibochen Haibo Chen added a comment - Thanks for pointing it out Sangjin Lee . Will upload a new patch to kick off the build.
        Hide
        sjlee0 Sangjin Lee added a comment - - edited

        Please remove the erroneous patch (yarn5922.001.yarn5355.patch). You may also want to kick off a trunk build (for yarn5922.001.trunk.patch).

        Going forward, please use the patch naming convention. It's (this JIRA id)-(optional baseline branch name).(sequence).patch. For example, for a trunk patch it would be something like YARN-5922.01.patch and for YARN-5355 YARN-5922-YARN-5355.01.patch. Hope that helps.

        Show
        sjlee0 Sangjin Lee added a comment - - edited Please remove the erroneous patch (yarn5922.001.yarn5355.patch). You may also want to kick off a trunk build (for yarn5922.001.trunk.patch). Going forward, please use the patch naming convention. It's (this JIRA id)-(optional baseline branch name).(sequence).patch. For example, for a trunk patch it would be something like YARN-5922 .01.patch and for YARN-5355 YARN-5922 - YARN-5355 .01.patch . Hope that helps.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 1m 1s Maven dependency ordering for branch
        +1 mvninstall 7m 49s trunk passed
        +1 compile 5m 11s trunk passed
        +1 checkstyle 0m 47s trunk passed
        +1 mvnsite 1m 0s trunk passed
        +1 mvneclipse 0m 36s trunk passed
        +1 findbugs 1m 43s trunk passed
        +1 javadoc 0m 42s trunk passed
        0 mvndep 0m 10s Maven dependency ordering for patch
        +1 mvninstall 0m 44s the patch passed
        +1 compile 4m 44s the patch passed
        +1 javac 4m 44s the patch passed
        +1 checkstyle 0m 43s the patch passed
        +1 mvnsite 0m 59s the patch passed
        +1 mvneclipse 0m 35s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 59s the patch passed
        +1 javadoc 0m 41s the patch passed
        -1 unit 0m 30s hadoop-yarn-api in the patch failed.
        +1 unit 0m 51s hadoop-yarn-server-timelineservice in the patch passed.
        +1 asflicense 0m 31s The patch does not generate ASF License warnings.
        39m 24s



        Reason Tests
        Failed junit tests hadoop.yarn.conf.TestYarnConfigurationFields



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-5922
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840080/yarn5922.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 0d2afeeaa65b 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 83cc726
        Default Java 1.8.0_111
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-YARN-Build/14029/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14029/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14029/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 1m 1s Maven dependency ordering for branch +1 mvninstall 7m 49s trunk passed +1 compile 5m 11s trunk passed +1 checkstyle 0m 47s trunk passed +1 mvnsite 1m 0s trunk passed +1 mvneclipse 0m 36s trunk passed +1 findbugs 1m 43s trunk passed +1 javadoc 0m 42s trunk passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 0m 44s the patch passed +1 compile 4m 44s the patch passed +1 javac 4m 44s the patch passed +1 checkstyle 0m 43s the patch passed +1 mvnsite 0m 59s the patch passed +1 mvneclipse 0m 35s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 59s the patch passed +1 javadoc 0m 41s the patch passed -1 unit 0m 30s hadoop-yarn-api in the patch failed. +1 unit 0m 51s hadoop-yarn-server-timelineservice in the patch passed. +1 asflicense 0m 31s The patch does not generate ASF License warnings. 39m 24s Reason Tests Failed junit tests hadoop.yarn.conf.TestYarnConfigurationFields Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5922 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840080/yarn5922.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0d2afeeaa65b 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 83cc726 Default Java 1.8.0_111 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/14029/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14029/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14029/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 1m 4s Maven dependency ordering for branch
        +1 mvninstall 7m 42s trunk passed
        +1 compile 5m 18s trunk passed
        +1 checkstyle 0m 50s trunk passed
        +1 mvnsite 1m 3s trunk passed
        +1 mvneclipse 0m 37s trunk passed
        +1 findbugs 1m 56s trunk passed
        +1 javadoc 0m 45s trunk passed
        0 mvndep 0m 11s Maven dependency ordering for patch
        +1 mvninstall 0m 50s the patch passed
        +1 compile 5m 3s the patch passed
        +1 javac 5m 3s the patch passed
        +1 checkstyle 0m 48s the patch passed
        +1 mvnsite 1m 0s the patch passed
        +1 mvneclipse 0m 36s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 7s the patch passed
        +1 javadoc 0m 44s the patch passed
        -1 unit 0m 33s hadoop-yarn-api in the patch failed.
        +1 unit 0m 52s hadoop-yarn-server-timelineservice in the patch passed.
        +1 asflicense 0m 33s The patch does not generate ASF License warnings.
        40m 48s



        Reason Tests
        Failed junit tests hadoop.yarn.conf.TestYarnConfigurationFields



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-5922
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840090/YARN-5922.01.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 45d6b64071d8 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 83cc726
        Default Java 1.8.0_111
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-YARN-Build/14032/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14032/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14032/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 1m 4s Maven dependency ordering for branch +1 mvninstall 7m 42s trunk passed +1 compile 5m 18s trunk passed +1 checkstyle 0m 50s trunk passed +1 mvnsite 1m 3s trunk passed +1 mvneclipse 0m 37s trunk passed +1 findbugs 1m 56s trunk passed +1 javadoc 0m 45s trunk passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 0m 50s the patch passed +1 compile 5m 3s the patch passed +1 javac 5m 3s the patch passed +1 checkstyle 0m 48s the patch passed +1 mvnsite 1m 0s the patch passed +1 mvneclipse 0m 36s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 7s the patch passed +1 javadoc 0m 44s the patch passed -1 unit 0m 33s hadoop-yarn-api in the patch failed. +1 unit 0m 52s hadoop-yarn-server-timelineservice in the patch passed. +1 asflicense 0m 33s The patch does not generate ASF License warnings. 40m 48s Reason Tests Failed junit tests hadoop.yarn.conf.TestYarnConfigurationFields Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5922 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840090/YARN-5922.01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 45d6b64071d8 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 83cc726 Default Java 1.8.0_111 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/14032/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14032/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14032/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        haibochen Haibo Chen added a comment -

        Uploading new patches to address the unit test issue.

        Show
        haibochen Haibo Chen added a comment - Uploading new patches to address the unit test issue.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 24s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 20s Maven dependency ordering for branch
        +1 mvninstall 8m 30s trunk passed
        +1 compile 11m 9s trunk passed
        +1 checkstyle 1m 36s trunk passed
        +1 mvnsite 2m 9s trunk passed
        +1 mvneclipse 1m 4s trunk passed
        +1 findbugs 3m 23s trunk passed
        +1 javadoc 1m 39s trunk passed
        0 mvndep 0m 18s Maven dependency ordering for patch
        +1 mvninstall 1m 28s the patch passed
        +1 compile 10m 46s the patch passed
        +1 javac 10m 46s the patch passed
        +1 checkstyle 1m 41s the patch passed
        +1 mvnsite 2m 22s the patch passed
        +1 mvneclipse 1m 0s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 59s the patch passed
        +1 javadoc 1m 57s the patch passed
        +1 unit 8m 50s hadoop-common in the patch passed.
        +1 unit 0m 37s hadoop-yarn-api in the patch passed.
        +1 unit 1m 2s hadoop-yarn-server-timelineservice in the patch passed.
        +1 asflicense 0m 50s The patch does not generate ASF License warnings.
        88m 52s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-5922
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840148/YARN-5922.02.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 347d9f44d5b5 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 69fb70c
        Default Java 1.8.0_111
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14132/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice U: .
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14132/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 24s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 20s Maven dependency ordering for branch +1 mvninstall 8m 30s trunk passed +1 compile 11m 9s trunk passed +1 checkstyle 1m 36s trunk passed +1 mvnsite 2m 9s trunk passed +1 mvneclipse 1m 4s trunk passed +1 findbugs 3m 23s trunk passed +1 javadoc 1m 39s trunk passed 0 mvndep 0m 18s Maven dependency ordering for patch +1 mvninstall 1m 28s the patch passed +1 compile 10m 46s the patch passed +1 javac 10m 46s the patch passed +1 checkstyle 1m 41s the patch passed +1 mvnsite 2m 22s the patch passed +1 mvneclipse 1m 0s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 59s the patch passed +1 javadoc 1m 57s the patch passed +1 unit 8m 50s hadoop-common in the patch passed. +1 unit 0m 37s hadoop-yarn-api in the patch passed. +1 unit 1m 2s hadoop-yarn-server-timelineservice in the patch passed. +1 asflicense 0m 50s The patch does not generate ASF License warnings. 88m 52s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5922 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840148/YARN-5922.02.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 347d9f44d5b5 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 69fb70c Default Java 1.8.0_111 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14132/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/14132/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        sjlee0 Sangjin Lee added a comment -

        Thanks Haibo Chen for the updated patch!

        Actually I think the right way to fix the unit test is to add the new properties to yarn-default.xml rather than modifying the TestConfigurationFieldsBase class. Could you please update the patch to do that?

        Show
        sjlee0 Sangjin Lee added a comment - Thanks Haibo Chen for the updated patch! Actually I think the right way to fix the unit test is to add the new properties to yarn-default.xml rather than modifying the TestConfigurationFieldsBase class. Could you please update the patch to do that?
        Hide
        haibochen Haibo Chen added a comment -

        Thanks Sangjin Lee for your review! Does it make sense to add the new properties to yarn-default.xml given that they are the default values of two other properties (yarn.timeline-service.writer.class and yarn.timeline-service.reader.class) that are already in YarnConfiguration and yarn-default.xml? In TestYarnConfigurationFields, all timeline-service related configurations are skipped. I believe that's the reason why the test is not recognizing the new properties as default values of other existing properties.

        Show
        haibochen Haibo Chen added a comment - Thanks Sangjin Lee for your review! Does it make sense to add the new properties to yarn-default.xml given that they are the default values of two other properties (yarn.timeline-service.writer.class and yarn.timeline-service.reader.class) that are already in YarnConfiguration and yarn-default.xml? In TestYarnConfigurationFields, all timeline-service related configurations are skipped. I believe that's the reason why the test is not recognizing the new properties as default values of other existing properties.
        Hide
        sjlee0 Sangjin Lee added a comment -

        Sorry I was assuming incorrectly that these properties were not already in yarn-default.xml.

        The real reason that the test is failing is because these default value definitions in YarnConfiguration are mistakenly flagged as property keys. You'd need to skip them using configurationPropsToSkipCompare. This is how a similar issue is addressed in TestYarnConfigurationFields:

            configurationPropsToSkipCompare
                .add(YarnConfiguration.DEFAULT_IPC_RECORD_FACTORY_CLASS);
            configurationPropsToSkipCompare
                .add(YarnConfiguration.DEFAULT_IPC_CLIENT_FACTORY_CLASS);
            configurationPropsToSkipCompare
                .add(YarnConfiguration.DEFAULT_IPC_SERVER_FACTORY_CLASS);
        

        We should add our 2 default fields to get around this.

        Show
        sjlee0 Sangjin Lee added a comment - Sorry I was assuming incorrectly that these properties were not already in yarn-default.xml . The real reason that the test is failing is because these default value definitions in YarnConfiguration are mistakenly flagged as property keys . You'd need to skip them using configurationPropsToSkipCompare . This is how a similar issue is addressed in TestYarnConfigurationFields : configurationPropsToSkipCompare .add(YarnConfiguration.DEFAULT_IPC_RECORD_FACTORY_CLASS); configurationPropsToSkipCompare .add(YarnConfiguration.DEFAULT_IPC_CLIENT_FACTORY_CLASS); configurationPropsToSkipCompare .add(YarnConfiguration.DEFAULT_IPC_SERVER_FACTORY_CLASS); We should add our 2 default fields to get around this.
        Hide
        sjlee0 Sangjin Lee added a comment -

        That said, it sounds bit silly that people need to work around it to avoid having DEFAULT_ constants getting flagged as properties incorrectly. Perhaps we should file a separate HADOOP JIRA to filter out DEFAULT_ constants in TestConfigurationFieldsBase.

        Show
        sjlee0 Sangjin Lee added a comment - That said, it sounds bit silly that people need to work around it to avoid having DEFAULT_ constants getting flagged as properties incorrectly. Perhaps we should file a separate HADOOP JIRA to filter out DEFAULT_ constants in TestConfigurationFieldsBase .
        Hide
        haibochen Haibo Chen added a comment -

        Agreed. That's why I made the change in TestConfigurationFiledsBase instead of skipping them. I'll file a hadoop jira to fix that first.

        Show
        haibochen Haibo Chen added a comment - Agreed. That's why I made the change in TestConfigurationFiledsBase instead of skipping them. I'll file a hadoop jira to fix that first.
        Hide
        sjlee0 Sangjin Lee added a comment -

        Yes, I see that. That's a little different in that it filters out (default) values from the supposed config "keys". What I am suggesting is to prevent "DEFAULT_..." variables from being identified as config keys in the first place in TestConfigurationFieldsBase.extractMemberVariablesFromConfigurationFields(). Then we could remove the workaround registered in places like TestYarnConfigurationFields etc.

        Show
        sjlee0 Sangjin Lee added a comment - Yes, I see that. That's a little different in that it filters out (default) values from the supposed config "keys". What I am suggesting is to prevent "DEFAULT_..." variables from being identified as config keys in the first place in TestConfigurationFieldsBase.extractMemberVariablesFromConfigurationFields() . Then we could remove the workaround registered in places like TestYarnConfigurationFields etc.
        Hide
        haibochen Haibo Chen added a comment -

        I see. I have uploaded a patch in HADOOP-13859 with the fix you suggested.

        Show
        haibochen Haibo Chen added a comment - I see. I have uploaded a patch in HADOOP-13859 with the fix you suggested.
        Hide
        haibochen Haibo Chen added a comment -

        Uploaded a new patch for trunk branch now that HADOOP-13859 has been committed. Sangjin Lee Can you please cherry-pick hadoop-13859 into YARN-5355? I can then upload a patch for branch YARN-5355.

        Show
        haibochen Haibo Chen added a comment - Uploaded a new patch for trunk branch now that HADOOP-13859 has been committed. Sangjin Lee Can you please cherry-pick hadoop-13859 into YARN-5355 ? I can then upload a patch for branch YARN-5355 .
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 20m 45s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 0m 10s Maven dependency ordering for branch
        +1 mvninstall 10m 44s trunk passed
        +1 compile 4m 56s trunk passed
        +1 checkstyle 0m 47s trunk passed
        +1 mvnsite 1m 1s trunk passed
        +1 mvneclipse 0m 39s trunk passed
        +1 findbugs 1m 45s trunk passed
        +1 javadoc 0m 46s trunk passed
        0 mvndep 0m 10s Maven dependency ordering for patch
        +1 mvninstall 0m 42s the patch passed
        +1 compile 4m 34s the patch passed
        +1 javac 4m 34s the patch passed
        +1 checkstyle 0m 45s the patch passed
        +1 mvnsite 0m 59s the patch passed
        +1 mvneclipse 0m 36s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 57s the patch passed
        +1 javadoc 0m 43s the patch passed
        +1 unit 0m 32s hadoop-yarn-api in the patch passed.
        +1 unit 0m 51s hadoop-yarn-server-timelineservice in the patch passed.
        +1 asflicense 0m 33s The patch does not generate ASF License warnings.
        62m 15s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-5922
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842040/YARN-5922.03.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 5d8ee26fd270 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / a7288da
        Default Java 1.8.0_111
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14199/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14199/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 20m 45s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 10s Maven dependency ordering for branch +1 mvninstall 10m 44s trunk passed +1 compile 4m 56s trunk passed +1 checkstyle 0m 47s trunk passed +1 mvnsite 1m 1s trunk passed +1 mvneclipse 0m 39s trunk passed +1 findbugs 1m 45s trunk passed +1 javadoc 0m 46s trunk passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 0m 42s the patch passed +1 compile 4m 34s the patch passed +1 javac 4m 34s the patch passed +1 checkstyle 0m 45s the patch passed +1 mvnsite 0m 59s the patch passed +1 mvneclipse 0m 36s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 57s the patch passed +1 javadoc 0m 43s the patch passed +1 unit 0m 32s hadoop-yarn-api in the patch passed. +1 unit 0m 51s hadoop-yarn-server-timelineservice in the patch passed. +1 asflicense 0m 33s The patch does not generate ASF License warnings. 62m 15s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5922 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842040/YARN-5922.03.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 5d8ee26fd270 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a7288da Default Java 1.8.0_111 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14199/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14199/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        sjlee0 Sangjin Lee added a comment -

        I cherry-picked that commit into YARN-5355 and YARN-5355-branch-2 respectively.

        The latest trunk patch LGTM. Please add the YARN-5355 patch if different, and I'll commit them once the CI turns green.

        Show
        sjlee0 Sangjin Lee added a comment - I cherry-picked that commit into YARN-5355 and YARN-5355 -branch-2 respectively. The latest trunk patch LGTM. Please add the YARN-5355 patch if different, and I'll commit them once the CI turns green.
        Hide
        haibochen Haibo Chen added a comment -

        Uploading a new patch for trunk that includes tests

        Show
        haibochen Haibo Chen added a comment - Uploading a new patch for trunk that includes tests
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 20s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 0m 57s Maven dependency ordering for branch
        +1 mvninstall 8m 5s trunk passed
        +1 compile 5m 14s trunk passed
        +1 checkstyle 1m 3s trunk passed
        +1 mvnsite 1m 10s trunk passed
        +1 mvneclipse 0m 36s trunk passed
        +1 findbugs 1m 48s trunk passed
        +1 javadoc 0m 44s trunk passed
        0 mvndep 0m 11s Maven dependency ordering for patch
        +1 mvninstall 0m 44s the patch passed
        +1 compile 4m 50s the patch passed
        +1 javac 4m 50s the patch passed
        -0 checkstyle 0m 45s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 206 unchanged - 0 fixed = 207 total (was 206)
        +1 mvnsite 1m 2s the patch passed
        +1 mvneclipse 0m 39s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 19s the patch passed
        +1 javadoc 0m 50s the patch passed
        +1 unit 0m 35s hadoop-yarn-api in the patch passed.
        +1 unit 1m 5s hadoop-yarn-server-timelineservice in the patch passed.
        +1 asflicense 0m 37s The patch does not generate ASF License warnings.
        41m 43s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-5922
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842245/YARN-5922.04.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux ea55d09bfeb8 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 72fe546
        Default Java 1.8.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14214/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14214/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14214/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 57s Maven dependency ordering for branch +1 mvninstall 8m 5s trunk passed +1 compile 5m 14s trunk passed +1 checkstyle 1m 3s trunk passed +1 mvnsite 1m 10s trunk passed +1 mvneclipse 0m 36s trunk passed +1 findbugs 1m 48s trunk passed +1 javadoc 0m 44s trunk passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 0m 44s the patch passed +1 compile 4m 50s the patch passed +1 javac 4m 50s the patch passed -0 checkstyle 0m 45s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 206 unchanged - 0 fixed = 207 total (was 206) +1 mvnsite 1m 2s the patch passed +1 mvneclipse 0m 39s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 19s the patch passed +1 javadoc 0m 50s the patch passed +1 unit 0m 35s hadoop-yarn-api in the patch passed. +1 unit 1m 5s hadoop-yarn-server-timelineservice in the patch passed. +1 asflicense 0m 37s The patch does not generate ASF License warnings. 41m 43s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5922 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842245/YARN-5922.04.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ea55d09bfeb8 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 72fe546 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14214/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14214/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14214/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 3m 22s Maven dependency ordering for branch
        +1 mvninstall 9m 12s YARN-5355 passed
        +1 compile 2m 38s YARN-5355 passed
        +1 checkstyle 0m 47s YARN-5355 passed
        +1 mvnsite 0m 54s YARN-5355 passed
        +1 mvneclipse 0m 30s YARN-5355 passed
        +1 findbugs 1m 46s YARN-5355 passed
        +1 javadoc 0m 37s YARN-5355 passed
        0 mvndep 0m 11s Maven dependency ordering for patch
        +1 mvninstall 0m 45s the patch passed
        +1 compile 2m 35s the patch passed
        +1 javac 2m 35s the patch passed
        -0 checkstyle 0m 49s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 205 unchanged - 0 fixed = 206 total (was 205)
        +1 mvnsite 0m 58s the patch passed
        +1 mvneclipse 0m 29s the patch passed
        +1 whitespace 0m 1s The patch has no whitespace issues.
        +1 findbugs 2m 2s the patch passed
        +1 javadoc 0m 37s the patch passed
        +1 unit 0m 29s hadoop-yarn-api in the patch passed.
        +1 unit 0m 52s hadoop-yarn-server-timelineservice in the patch passed.
        +1 asflicense 0m 24s The patch does not generate ASF License warnings.
        38m 5s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue YARN-5922
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842246/YARN-5922-YARN-5355.04.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 9ffc001bb6ac 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision YARN-5355 / 12bce02
        Default Java 1.8.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14216/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14216/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14216/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 3m 22s Maven dependency ordering for branch +1 mvninstall 9m 12s YARN-5355 passed +1 compile 2m 38s YARN-5355 passed +1 checkstyle 0m 47s YARN-5355 passed +1 mvnsite 0m 54s YARN-5355 passed +1 mvneclipse 0m 30s YARN-5355 passed +1 findbugs 1m 46s YARN-5355 passed +1 javadoc 0m 37s YARN-5355 passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 0m 45s the patch passed +1 compile 2m 35s the patch passed +1 javac 2m 35s the patch passed -0 checkstyle 0m 49s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 205 unchanged - 0 fixed = 206 total (was 205) +1 mvnsite 0m 58s the patch passed +1 mvneclipse 0m 29s the patch passed +1 whitespace 0m 1s The patch has no whitespace issues. +1 findbugs 2m 2s the patch passed +1 javadoc 0m 37s the patch passed +1 unit 0m 29s hadoop-yarn-api in the patch passed. +1 unit 0m 52s hadoop-yarn-server-timelineservice in the patch passed. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 38m 5s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue YARN-5922 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842246/YARN-5922-YARN-5355.04.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 9ffc001bb6ac 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-5355 / 12bce02 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14216/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14216/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14216/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        sjlee0 Sangjin Lee added a comment -

        Thanks Haibo Chen. Can you address the lone checkstyle comments?

        Show
        sjlee0 Sangjin Lee added a comment - Thanks Haibo Chen . Can you address the lone checkstyle comments?
        Hide
        haibochen Haibo Chen added a comment -

        Attaching new patches to address the javadoc warning

        Show
        haibochen Haibo Chen added a comment - Attaching new patches to address the javadoc warning
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 0m 50s Maven dependency ordering for branch
        +1 mvninstall 6m 53s trunk passed
        +1 compile 4m 58s trunk passed
        +1 checkstyle 0m 47s trunk passed
        +1 mvnsite 1m 0s trunk passed
        +1 mvneclipse 0m 38s trunk passed
        +1 findbugs 1m 43s trunk passed
        +1 javadoc 0m 45s trunk passed
        0 mvndep 0m 10s Maven dependency ordering for patch
        +1 mvninstall 0m 42s the patch passed
        +1 compile 4m 35s the patch passed
        +1 javac 4m 35s the patch passed
        +1 checkstyle 0m 45s the patch passed
        +1 mvnsite 1m 0s the patch passed
        +1 mvneclipse 0m 36s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 56s the patch passed
        +1 javadoc 0m 42s the patch passed
        +1 unit 0m 31s hadoop-yarn-api in the patch passed.
        +1 unit 0m 53s hadoop-yarn-server-timelineservice in the patch passed.
        +1 asflicense 0m 29s The patch does not generate ASF License warnings.
        38m 19s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-5922
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842374/YARN-5922.05.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 3c1fd0d58f34 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 0ef7961
        Default Java 1.8.0_111
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14226/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14226/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 50s Maven dependency ordering for branch +1 mvninstall 6m 53s trunk passed +1 compile 4m 58s trunk passed +1 checkstyle 0m 47s trunk passed +1 mvnsite 1m 0s trunk passed +1 mvneclipse 0m 38s trunk passed +1 findbugs 1m 43s trunk passed +1 javadoc 0m 45s trunk passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 0m 42s the patch passed +1 compile 4m 35s the patch passed +1 javac 4m 35s the patch passed +1 checkstyle 0m 45s the patch passed +1 mvnsite 1m 0s the patch passed +1 mvneclipse 0m 36s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 56s the patch passed +1 javadoc 0m 42s the patch passed +1 unit 0m 31s hadoop-yarn-api in the patch passed. +1 unit 0m 53s hadoop-yarn-server-timelineservice in the patch passed. +1 asflicense 0m 29s The patch does not generate ASF License warnings. 38m 19s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5922 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842374/YARN-5922.05.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3c1fd0d58f34 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0ef7961 Default Java 1.8.0_111 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14226/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14226/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        sjlee0 Sangjin Lee added a comment -

        LGTM. Committing shortly.

        Show
        sjlee0 Sangjin Lee added a comment - LGTM. Committing shortly.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10972 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10972/)
        YARN-5922. Remove direct references of HBaseTimelineWriter/Reader in (sjlee: rev a5a55a54ab1568e941062ea3dabdd237f71f15c4)

        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice/src/main/java/org/apache/hadoop/yarn/server/timelineservice/collector/TimelineCollectorManager.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice/src/test/java/org/apache/hadoop/yarn/server/timelineservice/reader/TestTimelineReaderServer.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice/src/main/java/org/apache/hadoop/yarn/server/timelineservice/reader/TimelineReaderServer.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
        • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice/src/test/java/org/apache/hadoop/yarn/server/timelineservice/collector/TestTimelineCollectorManager.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10972 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10972/ ) YARN-5922 . Remove direct references of HBaseTimelineWriter/Reader in (sjlee: rev a5a55a54ab1568e941062ea3dabdd237f71f15c4) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice/src/main/java/org/apache/hadoop/yarn/server/timelineservice/collector/TimelineCollectorManager.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice/src/test/java/org/apache/hadoop/yarn/server/timelineservice/reader/TestTimelineReaderServer.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice/src/main/java/org/apache/hadoop/yarn/server/timelineservice/reader/TimelineReaderServer.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice/src/test/java/org/apache/hadoop/yarn/server/timelineservice/collector/TestTimelineCollectorManager.java
        Hide
        sjlee0 Sangjin Lee added a comment -

        Committed it to trunk, YARN-5355, and YARN-5355-branch-2. Thanks Haibo Chen for your contribution!

        Show
        sjlee0 Sangjin Lee added a comment - Committed it to trunk, YARN-5355 , and YARN-5355 -branch-2. Thanks Haibo Chen for your contribution!
        Hide
        haibochen Haibo Chen added a comment -

        Thanks Sangjin Lee for your reviews!

        Show
        haibochen Haibo Chen added a comment - Thanks Sangjin Lee for your reviews!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12271 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12271/)
        YARN-5922. Remove direct references of HBaseTimelineWriter/Reader in (varunsaxena: rev ecbc8d481659ded00d23de1ab366722932792e95)

        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12271 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12271/ ) YARN-5922 . Remove direct references of HBaseTimelineWriter/Reader in (varunsaxena: rev ecbc8d481659ded00d23de1ab366722932792e95) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java

          People

          • Assignee:
            haibochen Haibo Chen
            Reporter:
            haibochen Haibo Chen
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development