Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13859

TestConfigurationFieldsBase fails for fields that are DEFAULT values of skipped properties.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 2.9.0, 3.0.0-alpha2
    • Component/s: common
    • Labels:
      None

      Description

      In YARN-5922, two new default values are added in YarnConfiguration for two timeline-service properties that are skipped in TestConfigurationFieldsBase. TestConfigurationFieldsBase fails as it mistakenly treats the two newly added default-values as regular properties.

        Issue Links

          Activity

          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 7m 53s trunk passed
          +1 compile 11m 3s trunk passed
          +1 checkstyle 1m 36s trunk passed
          +1 mvnsite 2m 49s trunk passed
          +1 mvneclipse 0m 58s trunk passed
          -1 findbugs 1m 58s hadoop-hdfs-project/hadoop-hdfs in trunk has 1 extant Findbugs warnings.
          +1 javadoc 2m 3s trunk passed
          0 mvndep 0m 18s Maven dependency ordering for patch
          +1 mvninstall 2m 3s the patch passed
          +1 compile 10m 42s the patch passed
          +1 javac 10m 42s the patch passed
          +1 checkstyle 1m 56s the patch passed
          +1 mvnsite 3m 13s the patch passed
          +1 mvneclipse 1m 9s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 6m 14s the patch passed
          +1 javadoc 2m 30s the patch passed
          -1 unit 8m 46s hadoop-common in the patch failed.
          +1 unit 66m 10s hadoop-hdfs in the patch passed.
          +1 unit 0m 41s hadoop-yarn-api in the patch passed.
          +1 asflicense 0m 39s The patch does not generate ASF License warnings.
          160m 2s



          Reason Tests
          Failed junit tests hadoop.security.token.delegation.TestZKDelegationTokenSecretManager
            hadoop.ha.TestZKFailoverController
            hadoop.test.TestLambdaTestUtils



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HADOOP-13859
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841549/HADOOP-13859.01.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 66e9b96dece0 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / c7ff34f
          Default Java 1.8.0_111
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/11186/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11186/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11186/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11186/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 7m 53s trunk passed +1 compile 11m 3s trunk passed +1 checkstyle 1m 36s trunk passed +1 mvnsite 2m 49s trunk passed +1 mvneclipse 0m 58s trunk passed -1 findbugs 1m 58s hadoop-hdfs-project/hadoop-hdfs in trunk has 1 extant Findbugs warnings. +1 javadoc 2m 3s trunk passed 0 mvndep 0m 18s Maven dependency ordering for patch +1 mvninstall 2m 3s the patch passed +1 compile 10m 42s the patch passed +1 javac 10m 42s the patch passed +1 checkstyle 1m 56s the patch passed +1 mvnsite 3m 13s the patch passed +1 mvneclipse 1m 9s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 6m 14s the patch passed +1 javadoc 2m 30s the patch passed -1 unit 8m 46s hadoop-common in the patch failed. +1 unit 66m 10s hadoop-hdfs in the patch passed. +1 unit 0m 41s hadoop-yarn-api in the patch passed. +1 asflicense 0m 39s The patch does not generate ASF License warnings. 160m 2s Reason Tests Failed junit tests hadoop.security.token.delegation.TestZKDelegationTokenSecretManager   hadoop.ha.TestZKFailoverController   hadoop.test.TestLambdaTestUtils Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13859 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841549/HADOOP-13859.01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 66e9b96dece0 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c7ff34f Default Java 1.8.0_111 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/11186/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11186/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11186/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11186/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          haibochen Haibo Chen added a comment -

          The unit test failure as well as the findbug warning looks irrelevant to me .

          Show
          haibochen Haibo Chen added a comment - The unit test failure as well as the findbug warning looks irrelevant to me .
          Hide
          kasha Karthik Kambatla added a comment -

          +1. Checking this in..

          Show
          kasha Karthik Kambatla added a comment - +1. Checking this in..
          Hide
          kasha Karthik Kambatla added a comment -

          Haibo, thanks for fixing the test failures and future-proofing for other such cases.

          Just committed this to trunk and branch-2.

          Show
          kasha Karthik Kambatla added a comment - Haibo, thanks for fixing the test failures and future-proofing for other such cases. Just committed this to trunk and branch-2.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10956 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10956/)
          HADOOP-13859. TestConfigurationFieldsBase fails for fields that are (kasha: rev c8d0a049b00536385f06fad412a2288f005bf2ce)

          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfigurationFieldsBase.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestHdfsConfigFields.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10956 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10956/ ) HADOOP-13859 . TestConfigurationFieldsBase fails for fields that are (kasha: rev c8d0a049b00536385f06fad412a2288f005bf2ce) (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfigurationFieldsBase.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestHdfsConfigFields.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java

            People

            • Assignee:
              haibochen Haibo Chen
              Reporter:
              haibochen Haibo Chen
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development