Uploaded image for project: 'Struts 2'
  1. Struts 2
  2. WW-4121

Wasted work in RolesInterceptor.isAllowed()

    Details

    • Flags:
      Patch, Important

      Description

      The problem appears in version 2.3.14.3 and in revision 1495522. I
      attached a one-line patch that fixes it. This problem and the
      attached patch are similar to the previously fixed WW-4115 and its
      patch.

      In method "RolesInterceptor.isAllowed", the loop over "allowedRoles"
      should break immediately after "result" is set to "true". All the
      iterations after "result" is set to "true" do not perform any useful
      work, at best they just set "result" again to "true".

      1. patch.diff
        0.6 kB
        Adrian Nistor

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1502451 from Lukasz Lenart
        [ https://svn.apache.org/r1502451 ]

        WW-4121 Improves loop

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1502451 from Lukasz Lenart [ https://svn.apache.org/r1502451 ] WW-4121 Improves loop
        Hide
        lukaszlenart Lukasz Lenart added a comment -

        Patch applied, thanks!

        Show
        lukaszlenart Lukasz Lenart added a comment - Patch applied, thanks!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Struts2-JDK6 #749 (See https://builds.apache.org/job/Struts2-JDK6/749/)
        WW-4121 Improves loop (lukaszlenart: rev 1502451)

        • /struts/struts2/trunk/core/src/main/java/org/apache/struts2/interceptor/RolesInterceptor.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Struts2-JDK6 #749 (See https://builds.apache.org/job/Struts2-JDK6/749/ ) WW-4121 Improves loop (lukaszlenart: rev 1502451) /struts/struts2/trunk/core/src/main/java/org/apache/struts2/interceptor/RolesInterceptor.java

          People

          • Assignee:
            lukaszlenart Lukasz Lenart
            Reporter:
            adriannistor Adrian Nistor
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development