Uploaded image for project: 'Struts 2'
  1. Struts 2
  2. WW-4121

Wasted work in RolesInterceptor.isAllowed()

    XMLWordPrintableJSON

Details

    • Patch, Important

    Description

      The problem appears in version 2.3.14.3 and in revision 1495522. I
      attached a one-line patch that fixes it. This problem and the
      attached patch are similar to the previously fixed WW-4115 and its
      patch.

      In method "RolesInterceptor.isAllowed", the loop over "allowedRoles"
      should break immediately after "result" is set to "true". All the
      iterations after "result" is set to "true" do not perform any useful
      work, at best they just set "result" again to "true".

      Attachments

        1. patch.diff
          0.6 kB
          Adrian Nistor

        Activity

          People

            lukaszlenart Lukasz Lenart
            adriannistor Adrian Nistor
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: