Uploaded image for project: 'Struts 2'
  1. Struts 2
  2. WW-4115

Wasted work in ValidateVisitor.getJspAttribute()

    Details

    • Flags:
      Patch

      Description

      The problem appears in version 2.3.14.3 and in revision 1493157. I
      attached a one-line patch that fixes it.

      In method "ValidateVisitor.getJspAttribute", the loop over
      "el.iterator()" should break immediately after "deferred" is set to
      "true". All the iterations after "deferred" is set to "true" do not
      perform any useful work, at best they just set "deferred" again to
      "true".

      Method "evaluateExtraParams" in class "ActionError" has a similar loop
      (over "actionMessages"), and this loop breaks immediately after
      "isEmptyList" is set to "false", just like in the proposed patch.
      Other methods (e.g., "DebuggingInterceptor.printContext",
      "FileUploadInterceptor.isNonEmpty", "CollectVisitor.checkSeen",
      "JspDocumentParser.processChars") also have similar loops with similar
      breaks, just like in the proposed patch.

        Attachments

        1. patch.diff
          0.7 kB
          Adrian Nistor

          Activity

            People

            • Assignee:
              lukaszlenart Lukasz Lenart
              Reporter:
              adriannistor Adrian Nistor
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: