[THRIFT-4380] Compiler incorrect generates code which treats a Java enum as a binary type

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 0.10.0
• Component/s: Java - Compiler
• External issue URL: https://bugzilla.redhat.com/show_bug.cgi?id=1507518
• Assignee: James E. King III
• Reporter: Christopher Tubbs
• Created: 07/Nov/17 11:02
• Updated: 22/Dec/17 12:52
• Resolved: 22/Dec/17 04:14

Description

./compiler/cpp/src/thrift/generate/t_java_generator.cc around line 4661 seems to incorrectly wrap an enum with TBaseHelper.copyBinary. This caused a build failure when building the java tutorial on s390x.

Cannot reproduce this bug on x86_64, only on s390x so far. Could use the assistance of an upstream Thrift developer to take a look at the C++ code to examine for correctness. It looks like it's trying to cast enums to a base type, and then check if it's a binary type.

Please see external tracker: https://bugzilla.redhat.com/show_bug.cgi?id=1507518

Issue Links

• is superceded by: THRIFT-4136 Align is_binary() method with is_string() to simplify those checks
• is superceded by: THRIFT-4177 Java compiler produces deep copy constructor that could make shallow copy instead