[THRIFT-4177] Java compiler produces deep copy constructor that could make shallow copy instead

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9.2
• Fix Version/s: 0.11.0
• Component/s: Java - Compiler
• Assignee: James E. King III
• Reporter: Deniss Afonin
• Created: 18/Apr/17 13:17
• Updated: 22/Dec/17 04:04
• Resolved: 19/Apr/17 16:39

Description

Java compiler produces deep copy constructor that makes shallow copies for referenced objects from collections when they are defined after the root object in the thrift file.

For example, consider following thrift file:

struct Foo {
1: optional list<Bar> bars,
}

struct Bar {
1: optional string value,
}

new Foo().deepCopy() will produce a copy of Foo with a copy of a list that reference the same Bar object.

Issue Links

• is duplicated by: THRIFT-3674 Java generated deep copy is shallow
• supercedes: THRIFT-4380 Compiler incorrect generates code which treats a Java enum as a binary type
• links to: GitHub Pull Request #1254