Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-4134 Fix remaining undefined behavior invalid vptr casts
  3. THRIFT-4136

Align is_binary() method with is_string() to simplify those checks

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.11.0
    • Compiler (General)
    • None
    • Patch Available

    Description

      Similar to is_string() the is_binary() method should be virtual and implemented at t_type. This simplifies the code and reduces possibilities for making technically wrong casts.

      Attachments

        Issue Links

          supercedes

          Bug - A problem which impairs or prevents the functions of the product. THRIFT-4380 Compiler incorrect generates code which treats a Java enum as a binary type

          • Major - Major loss of function.
          • Closed
          links to

          Web Link GitHub Pull Request #1221

          Activity

            People

              jensg Jens Geyer
              jensg Jens Geyer
              Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: