[THRIFT-3314] Dots in file names of includes causes dots in javascript variable names

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.10.0
• Component/s: JavaScript - Compiler
• Assignee: Kapil Joshi
• Reporter: Matt Fysh
• Created: 04/Sep/15 02:43
• Updated: 18/Mar/16 17:54
• Resolved: 18/Mar/16 17:54

Description

Hi there,

a.thrift

include "b.c.thrift"

b.c.thrift

# nada

$ thrift -r --gen js:node a.thrift

gen-nodejs/a_types

//
// Autogenerated by Thrift Compiler (0.9.2)
//
// DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
//
var thrift = require('thrift');
var Thrift = thrift.Thrift;
var Q = thrift.Q;

var b.c_ttypes = require('./b.c_types')


var ttypes = module.exports = {};

One variable in the auto-generated thrift output contains a dot, which is not valid JavaScript and will not compile.

Cheers,

Issue Links

• relates to: THRIFT-1383 Spaces in thrift input file lead to incorrectly generated code