Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-3314

Dots in file names of includes causes dots in javascript variable names

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Component/s: JavaScript - Compiler
    • Labels:
      None

      Description

      Hi there,

      a.thrift
      include "b.c.thrift"
      
      b.c.thrift
      # nada
      

      $ thrift -r --gen js:node a.thrift

      gen-nodejs/a_types
      //
      // Autogenerated by Thrift Compiler (0.9.2)
      //
      // DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
      //
      var thrift = require('thrift');
      var Thrift = thrift.Thrift;
      var Q = thrift.Q;
      
      var b.c_ttypes = require('./b.c_types')
      
      
      var ttypes = module.exports = {};
      
      

      One variable in the auto-generated thrift output contains a dot, which is not valid JavaScript and will not compile.

      Cheers,

        Attachments

        Issue Links

          Activity

            People

            • Assignee:
              joshkaps Kapil Joshi
              Reporter:
              mattfysh Matt Fysh

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment