Details
-
Bug
-
Status: Open
-
Major
-
Resolution: Unresolved
-
None
-
None
-
None
Description
Spaces in file names produce identifiers (e.g. namespaces) with spaces, which is illegal. I checked that only for the C++ generator, but there are probably other generators affected as well.
Attachments
Issue Links
- is related to
-
THRIFT-3707 In Python module names cannot contain a dash
- Open
-
THRIFT-1866 java compiler generates non-compiling code with const's defined in a thrift file whose name includes non-identifier chars
- Closed
-
THRIFT-2065 Not valid constants filename in Java
- Closed
-
THRIFT-3314 Dots in file names of includes causes dots in javascript variable names
- Closed
-
THRIFT-3333 Using filenames containing chars not valid within identifiers will create uncompileable code
- Closed
-
THRIFT-1977 C# compiler should generate constant files prefixed with thrift file name
- Closed
- relates to
-
THRIFT-5067 Invalid Cpp generated for include guards from valid Thrift IDL when the file name has characters that are not valid in a c++ #define
- Open
It is not only about spaces, actually. If done right, each language's generator needs to check for invalid characters when rendering identifiers etc. and take action, e.g. replace with underscore, or what else seems appropriate.