Details
-
Improvement
-
Status: Closed
-
Minor
-
Resolution: Fixed
-
all
-
None
Description
A number of svn_path functions are documented as accepting URLs in particular positions. This practice can lead to trouble if a caller assumes without checking that what it has is a path; for instance, if you svn_path_canonicalize() a URL and then pass it to svn_path_dirname(), what should happen if you reach the "http://hostname" part of the URL? In 2.0, we should have separate functions for operating on paths and URLs, and a third set for operating on "targets" which might be either (e.g. svn_target_is_url to distinguish between path targets and URL targets). Then if you canonicalize a URL as a path, what you will get back is a canonicalized path (e.g. "http:/hostname/path"), not a URL, and the behavior of svn_path_dirname and friends are well-specified.
Attachments
Issue Links
- blocks
-
SVN-1711 Many svn_path functions cannot handle Windows paths
- Closed
-
SVN-3601 ra_serf gets PROPFIND failure on certain non-ASCII paths
- Closed
-
SVN-2490 Subversion is too sensitive to particulars of URL encoding in working copy
- Closed
-
SVN-2676 Add svn_path_from_user_input() to the public API.
- Open
-
SVN-1880 API improvements for 2.0 (meta issue)
- Open
- is depended upon by
-
SVN-1711 Many svn_path functions cannot handle Windows paths
- Closed
-
SVN-3601 ra_serf gets PROPFIND failure on certain non-ASCII paths
- Closed
-
SVN-2490 Subversion is too sensitive to particulars of URL encoding in working copy
- Closed
-
SVN-2676 Add svn_path_from_user_input() to the public API.
- Open
-
SVN-1880 API improvements for 2.0 (meta issue)
- Open