[SOLR-3671] DIH doesn't use its own interface + writerImpl has no information about the request

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.0-ALPHA, 4.0-BETA
• Fix Version/s: 4.9
• Component/s: contrib - DataImportHandler
• Assignee: James Dyer
• Reporter: Roman Chyla
• Created: 24/Jul/12 23:25
• Updated: 28/May/14 08:10
• Resolved: 05/May/14 17:49

Description

The use case: I would like to extend DIH by providing a new writer, I have tried everything but can't accomplish it without either a) duplicating whole DIHandler or b) java reflection tricks. Almost everything inside DIH is private and the mechanism to instantiate a new writer based on the 'writerImpl' mechanism seems lacking important functionality

It doesn't give the new class a chance to get information about the request, update processor. Also, the writer is instantiated twice (when 'writerImpl' is there), which is really unnecessary.

As a solution, the existing DIHandler.getSolrWriter() should instantiate the appropriate writer and send it to DocBuilder (it is already doing that for SolrWriter). And DocBuilder doesn't need to create a second (duplicate) writer

Issue Links

• relates to: LUCENE-4215 DataImportHandler not using its own interface
• relates to: SOLR-5981 Please change method visibility of getSolrWriter in DataImportHandler to public (or at least protected)