[SOLR-5981] Please change method visibility of getSolrWriter in DataImportHandler to public (or at least protected)

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Not A Problem
• Affects Version/s: 4.0
• Component/s: contrib - DataImportHandler

Environment

Linux 3.13.9-200.fc20.x86_64
Solr 4.6.0

• Assignee: James Dyer
• Reporter: Aaron LaBella
• Created: 11/Apr/14 20:19
• Updated: 05/May/14 18:15
• Resolved: 05/May/14 17:51

Description

I've been using the org.apache.solr.handler.dataimport.DataImportHandler for a bit and it's an excellent model and architecture. I'd like to extend the usage of it to plugin my own DIHWriter, but, the code doesn't allow for it. Please change ~line 227 in the DataImportHander class to be:

public SolrWriter getSolrWriter

instead of:

private SolrWriter getSolrWriter

or, at a minimum, protected, so that I can extend DataImportHandler and override this method.

Thank you sincerely in advance for the quick turn-around on this. If the change can be made in 4.6.0 and upstream, that'd be ideal.

Thanks!

Issue Links

• is related to: SOLR-3671 DIH doesn't use its own interface + writerImpl has no information about the request