Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-3671

DIH doesn't use its own interface + writerImpl has no information about the request

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 4.0-ALPHA, 4.0-BETA
    • Fix Version/s: 4.9
    • Labels:
      None

      Description

      The use case: I would like to extend DIH by providing a new writer, I have tried everything but can't accomplish it without either a) duplicating whole DIHandler or b) java reflection tricks. Almost everything inside DIH is private and the mechanism to instantiate a new writer based on the 'writerImpl' mechanism seems lacking important functionality

      It doesn't give the new class a chance to get information about the request, update processor. Also, the writer is instantiated twice (when 'writerImpl' is there), which is really unnecessary.

      As a solution, the existing DIHandler.getSolrWriter() should instantiate the appropriate writer and send it to DocBuilder (it is already doing that for SolrWriter). And DocBuilder doesn't need to create a second (duplicate) writer

        Attachments

        1. SOLR-3671.patch
          11 kB
          James Dyer
        2. SOLR-3671.patch
          12 kB
          Roman Chyla

          Issue Links

            Activity

              People

              • Assignee:
                jdyer James Dyer
                Reporter:
                rchyla Roman Chyla
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: