[SOLR-11946] Move bin/solr arg-parsing logic to Java

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Duplicate
• Affects Version/s: 8.0
• Fix Version/s: 8.1, 9.0
• Component/s: scripts and tools
• Assignee: Unassigned
• Reporter: Jason Gerlowski
• Created: 05/Feb/18 04:32
• Updated: 12/May/22 00:26
• Resolved: 18/Jan/22 09:24

Description

Currently, there is logic in three different places that parses arguments for the bin/solr scripts. There is logic in the scripts themselves (bin/solr, bin/solr.cmd), and there is logic in Java to parse the arguments sent by the scripts themselves (SolrCLI.java.

This creates maintenance burden. It makes it easy for inconsistencies/bugs to creep into the scripts (see SOLR-11840 and SOLR-11441, for a few examples). It adds work when adding/removing/modifying bin/solr script behavior. And it forces anyone hoping to improve the scripts to be conversant in both bash and Windows batch scripting.

It would be a big help if all the argument parsing was done on the Java side, and little or none was done in the scripts themselves. There are a few situations in which this is difficult, but in no cases is it impossible.

We should move this logic into Java-land.

Issue Links

• is a child of: SOLR-11206 Migrate logic from bin/solr scripts to SolrCLI
• is duplicated by: SOLR-15831 Refactor bin/solr and bin/solr.cmd to delegate args parsing and usage help to SolrCLI