Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-11206

Migrate logic from bin/solr scripts to SolrCLI

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 8.1, master (9.0)
    • Component/s: scripts and tools
    • Labels:
      None

      Description

      The bin/solr and bin/solr.cmd scripts have taken on a lot of logic that would be easier to maintain if it was instead written in Java code, for a handful of reasons

      • Any logic in the control scripts is duplicated in two places by definition.
      • Increasing test coverage of this logic would be much easier if it was written in Java.
      • Few developers are conversant in both bash and Windows-shell, making editing difficult.

      Some sections in these scripts make good candidates for migration to Java. This issue should examine any of these that are brought up. However the biggest and most obvious candidate for migration is the argument parsing, validation, usage/help text, etc. for the commands that don't directly start/stop Solr processes (i.e. the "create", "delete", "zk", "auth", "assert" commands).

        Attachments

        1. linux-initial-output.txt
          53 kB
          Jason Gerlowski
        2. ctrl-script-output-benchmark.sh
          18 kB
          Jason Gerlowski
        3. SOLR-11206.patch
          21 kB
          Jason Gerlowski
        4. ctrl-script-output-benchmark.cmd
          20 kB
          Jason Gerlowski
        5. windows-initial-output.txt
          38 kB
          Jason Gerlowski
        6. SOLR-11206.patch
          20 kB
          Jason Gerlowski

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                gerlowskija Jason Gerlowski
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated: