Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-10833

Numeric FooPointField classes inconsistent with TrieFooFields on malformed input: throw NumberFormatException

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.7, 7.0
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)

      Description

      Trie based Numeic fields deal with bad input by wrapping NumberFormatExceptions in w/BAD_REQUEST SolrExceptions – PointFields are just allowing the NumberFormatExceptions to be thrown as is, which means they propagate up and are eventually treated as a SERVER_ERROR when responding to clients.

      This is not only inconsistent from an end user perspective – but also breaks how these errors are handled in SolrCloud when the requests have been forwarded/proxied.

      We should ensure that the FooPointField classes behave consistently with the TrieFooField classes on bad input (both when adding a document, or query creating a field query)

        Attachments

        1. SOLR-10833.patch
          40 kB
          Tomás Fernández Löbbe
        2. SOLR-10833.patch
          31 kB
          Tomás Fernández Löbbe
        3. SOLR-10833.patch
          15 kB
          Tomás Fernández Löbbe
        4. SOLR-10833.patch
          0.8 kB
          Hoss Man

          Issue Links

            Activity

              People

              • Assignee:
                tomasflobbe Tomás Fernández Löbbe
                Reporter:
                hossman Hoss Man
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: