Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-10807

Randomize PointFields in all tests unless explicit reason not to

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Task
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.0, 7.1, 8.0
    • Component/s: None
    • Labels:
      None

      Description

      We need to seriously beef up our testing of PointFields to figure out what Solr features don't currently work with PointFields.

      The existing Trie/Point randomization logic in SolrTestCaseJ4 is a good start – but only a handful of schema files leverage it.


      Allthough a jira/SOLR-10807 branch was originally created with this goal, it was ultimately just used for initial experimentation, and has been abandoned. The "meat" of the work needed to improve how we randomize in Point fields was done in SOLR-10864, and other sub-tasks of this issue have been / are being used to track rolling out this randomization to more and more test schema files and validating the affected tests.

      This effort is now highly parallelizable – so here are some rough guidelines/suggestions for folks interested in contributing to this effort:

        Attachments

        Issue Links

        1.
        Add static (test only) boolean to PointField indicating 'precisionStep' should be ignored so we can simplify points randomization in our schemas Sub-task Resolved Chris M. Hostetter Actions
        2.
        SuppressPointFields should require a bugUrl Sub-task Resolved Chris M. Hostetter Actions
        3.
        Randomize PointFields in all solrj tests unless explicit reason not to Sub-task Resolved Chris M. Hostetter Actions
        4.
        Randomize PointFields in all contrib tests unless explicit reason not to Sub-task Resolved Chris M. Hostetter Actions
        5.
        Randomize PointFields in all tests using schema-*sort* files Sub-task Resolved Chris M. Hostetter Actions
        6.
        Randomize PointFields in CdcrBootstrapTest Sub-task Resolved Chris M. Hostetter Actions
        7.
        Randomize the usage of Points based numerics in schema15.xml and all impacted tests Sub-task Resolved Chris M. Hostetter Actions
        8.
        Randomize PointFields in schema-docValues\*.xml and all affected tests Sub-task Resolved Chris M. Hostetter Actions
        9.
        Randomize PointFields and general cleanup in schema files that have completley unused Trie fieldTYpes Sub-task Resolved Chris M. Hostetter Actions
        10.
        Randomize PointFields in schema-add-schema-fields-update-processor.xml in core/src/test-files/solr/collection1 Sub-task Closed Anshum Gupta Actions
        11.
        Randomize PointFields in schema-blockjoinfacetcomponent.xml and all related tests Sub-task Closed Anshum Gupta Actions
        12.
        Randomize PointFields in schema-custom-field.xml and all related tests Sub-task Closed Anshum Gupta Actions
        13.
        Randomize PointFields in cloud-dynamic configset and all related tests Sub-task Closed Anshum Gupta Actions
        14.
        Randomize PointFields in doc-expiry & exitable-directory test configsets and all affected tests Sub-task Closed Chris M. Hostetter Actions
        15.
        Randomize PointFields in _default test configset and all affected tests Sub-task Resolved Steven Rowe Actions
        16.
        Randomize PointFields in schema-id-and-version-fields-only.xml and all affected tests Sub-task Closed Chris M. Hostetter Actions
        17.
        Randomize PointFields in cloud-managed-preanalyzed &schema-preanalyzed.xml and all affected tests Sub-task Closed Chris M. Hostetter Actions
        18.
        Randomize PointFields in "cloud-dynamic" test configset and all affected tests Sub-task Resolved Steven Rowe Actions
        19.
        Randomize PointFields in "cloud-minimal" test configset and all affected tests Sub-task Closed Steven Rowe Actions
        20.
        Randomize PointFields in schema-rest.xml and all affected tests Sub-task Closed Chris M. Hostetter Actions
        21.
        Randomize PointFields in "cloud-hdfs" test configset and all affected tests Sub-task Closed Steven Rowe Actions
        22.
        Randomize PointFields in "cloud-minimal-jmx" and "cloud-minimal-inplace-updates" test configsets Sub-task Closed Steven Rowe Actions
        23.
        Randomize PointFields in "cloud-subdirs" and "configset-2" test configsets Sub-task Closed Steven Rowe Actions
        24.
        Randomize PointFields in "cloud-managed" and "cloud-managed-upgrade" test configsets Sub-task Closed Steven Rowe Actions
        25.
        Randomize PointFields in collection1/conf/: schemasurround.xml, schema-sql.xml, and schema-spatial.xml Sub-task Closed Steven Rowe Actions
        26.
        Randomize PointFields in schema-folding.xml and all affected tests Sub-task Closed Chris M. Hostetter Actions
        27.
        Randomize PointFields in analysis-err-schema.xml, schema-hash.xml, and all affected tests Sub-task Closed Chris M. Hostetter Actions
        28.
        Randomize PointFields in schema-customfield.xml and TestOverriddenPrefixQueryForCustomFieldType Sub-task Closed Chris M. Hostetter Actions
        29.
        Randomize PointFields in schema-psuedo-fields.xml, schema-multiword-synonyms.xml, and all affected tests Sub-task Closed Steven Rowe Actions
        30.
        Randomize PointFields in schema-numeric.xml and all related tests Sub-task Closed Steven Rowe Actions
        31.
        Randomize PointFields in schema-behavior.xml, schema-enums.xml, and all affected tests Sub-task Closed Steven Rowe Actions
        32.
        Randomize PointFields in schema-HighlighterMaxOffsetTest.xml, schema-luceneMatchVersion.xml, schema-minimal-atomic-stress.xml, and all affected tests Sub-task Closed Steven Rowe Actions
        33.
        Remove trie fieldTypes from schema-points.xml Sub-task Closed Chris M. Hostetter Actions
        34.
        Randomize PointFields in schema-trie.xml and TestTrie Sub-task Closed Chris M. Hostetter Actions
        35.
        Randomize PointFields in test classes that currently have usage of Trie field classes/names hardcoded Sub-task Closed Chris M. Hostetter Actions

          Activity

            People

            • Assignee:
              hossman Chris M. Hostetter
              Reporter:
              hossman Chris M. Hostetter

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment