[SOLR-10833] Numeric FooPointField classes inconsistent with TrieFooFields on malformed input: throw NumberFormatException

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 6.7, 7.0
• Labels: numeric-tries-to-points
• Assignee: Tomas Eduardo Fernandez Lobbe
• Reporter: Chris M. Hostetter
• Created: 07/Jun/17 00:24
• Updated: 02/Oct/19 17:30
• Resolved: 15/Jun/17 02:01

Description

Trie based Numeic fields deal with bad input by wrapping NumberFormatExceptions in w/BAD_REQUEST SolrExceptions – PointFields are just allowing the NumberFormatExceptions to be thrown as is, which means they propagate up and are eventually treated as a SERVER_ERROR when responding to clients.

This is not only inconsistent from an end user perspective – but also breaks how these errors are handled in SolrCloud when the requests have been forwarded/proxied.

We should ensure that the FooPointField classes behave consistently with the TrieFooField classes on bad input (both when adding a document, or query creating a field query)

Issue Links

• is duplicated by: SOLR-11018 Wrong status code in case of invalid requests
• relates to: SOLR-10830 Solr needs to enforce that _root_ field has the same fieldType as the uniqueKey field
• relates to: SOLR-10860 in-place updates currently throw NumberFormatException instead of a Bad Request SolrException for bad input
• relates to: SOLR-10807 Randomize PointFields in all tests unless explicit reason not to