Uploaded image for project: 'Sentry (Retired)'
  1. Sentry (Retired)
  2. SENTRY-1556

Simplify privilege cleaning

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 1.8.0, 2.0.0
    • 1.8.0, 2.0.0
    • Sentry
    • None

    Description

      The SentryStore class has a privCleaner that cleans up orphaned privileges. Currently cleaning is happening after 50 notification requests are sent and it uses locking to synchronize.

      I think the whole thing can be simplified:

      1) We should consider whether it is possible to clean up a privilege simply when we see that there are no roles associated with it. In this case we do not need this at all.

      2) We can simply run a periodic job to clean up orphaned privileges and groups (which are not cleaned up at all now).

      Attachments

        1. SENTRY-1556.002.patch
          30 kB
          Krishna Kalyan
        2. SENTRY-1556.003.patch
          49 kB
          Krishna Kalyan
        3. SENTRY-1556.004.patch
          41 kB
          Krishna Kalyan
        4. SENTRY-1556.005.patch
          40 kB
          Krishna Kalyan
        5. SENTRY-1556.006.patch
          41 kB
          Krishna Kalyan
        6. SENTRY-1556.007.patch
          42 kB
          Krishna Kalyan
        7. SENTRY-1556.008.patch
          42 kB
          Krishna Kalyan
        8. SENTRY-1556.001-sentry-ha-redesign.patch
          42 kB
          Krishna Kalyan
        9. SENTRY-1556.002-sentry-ha-redesign.patch
          42 kB
          Krishna Kalyan

        Issue Links

          breaks

          Bug - A problem which impairs or prevents the functions of the product. SENTRY-1788 Sentry Store may use JDO object after the associated data is removed in DB

          • Major - Major loss of function.
          • Resolved
          incorporates

          Bug - A problem which impairs or prevents the functions of the product. SENTRY-1654 Revoking privileges is creating state privileges in in persistent store

          • Major - Major loss of function.
          • Resolved
          is related to

          Bug - A problem which impairs or prevents the functions of the product. SENTRY-1545 Deleted users and groups remain in the DB forever

          • Major - Major loss of function.
          • Open
          relates to

          Bug - A problem which impairs or prevents the functions of the product. SENTRY-140 Orphaned privileges should be garbage collected

          • Major - Major loss of function.
          • Resolved
          links to

          Web Link Review board link

          Activity

            People

              kkalyan Krishna Kalyan
              akolb Alex Kolbasov
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: